GNU bug report logs - #27436
26.0.50; cc-defs requires cl instead of cl-lib in master

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alex <agrambot <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#27436: closed (26.0.50; cc-defs requires cl instead of cl-lib
 in master)
Date: Sun, 25 Jun 2017 19:53:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 25 Jun 2017 13:51:31 -0600
with message-id <87injjlubg.fsf <at> lylat>
and subject line Re: bug#27436: 26.0.50; cc-defs requires cl instead of cl-lib in master
has caused the debbugs.gnu.org bug report #27436,
regarding 26.0.50; cc-defs requires cl instead of cl-lib in master
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
27436: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27436
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex <agrambot <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; cc-defs requires cl instead of cl-lib in master
Date: Wed, 21 Jun 2017 00:04:12 -0600

cc-defs has this condition to check whether or not to include cl-lib:

======================================
(and (fboundp 'mapcan)
     (subrp (symbol-function 'mapcan)))
======================================

As of 466ee1b3ea, Emacs now has a built in mapcan, so the above returns
true.

Other code in cc-defs.el uses (featurep 'xemacs). Is there a reason why
it can't be used here?

[Message part 3 (message/rfc822, inline)]

From: Alex <agrambot <at> gmail.com>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 27436-done <at> debbugs.gnu.org
Subject: Re: bug#27436: 26.0.50;
 cc-defs requires cl instead of cl-lib in master
Date: Sun, 25 Jun 2017 13:51:31 -0600

Alan Mackenzie <acm <at> muc.de> writes:

> Hello, Alex.
>
> On Wed, Jun 21, 2017 at 00:04:12 -0600, Alex wrote:
>> cc-defs has this condition to check whether or not to include cl-lib:
>
>> ======================================
>> (and (fboundp 'mapcan)
>>      (subrp (symbol-function 'mapcan)))
>> ======================================
>
>> As of 466ee1b3ea, Emacs now has a built in mapcan, so the above returns
>> true.
>
> Yes.  Thanks for taking the trouble to report this bug.
>
> I've committed a fix to master.  I'd be grateful if you would confirm it
> fixes the problem properly, or tell me what's not quite right.
>
>> Other code in cc-defs.el uses (featurep 'xemacs). Is there a reason why
>> it can't be used here?
>
> CC Mode has always favoured testing features rather than version numbers
> and the the base (X)Emacs, so that if a tested feature becomes or ceases
> to be available, CC Mode should pick that up automatically.  That is
> illustrated by the current case, just that here the actual test used was
> suboptimal.  Hopefully it is now OK.

Hello, Alan.

Thanks for the explanation and fix; I can confirm that the problem is
fixed in master. I'll close this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.