GNU bug report logs - #27435
patch for dired-mouse-find-file-other-window

Previous Next

Full log

Message #20 received at 27435 <at> debbugs.gnu.org (full text, mbox):

From: Tak Kunihiro <tkk <at> misasa.okayama-u.ac.jp>
To: eliz <at> gnu.org
Cc: 27435 <at> debbugs.gnu.org, tkk <at> misasa.okayama-u.ac.jp
Subject: Re: bug#27435: patch for dired-mouse-find-file-other-window
Date: Sat, 26 Aug 2017 18:26:58 +0900 (JST)

Thank you for the response!

> Can you describe a use case where you need to customize the function
> used to visit a file from Dired?

On dired I use `RET', `o', and `C-o' on different occasions and I
prefer mouse click to work as `RET' instead of `C-o'.  This is
especially true when there are more than three windows in a frame.

The patch lets mouse click on dired visit a file or directory in
<this-window> not in <other-window> with following customization.

  (setq dired-mouse-find-file-func 'find-file)

> (Btw, we use "visit a file", not "open a file" in our terminology, so
> at least that aspect in the doc strings of your patch should be
> amended.)

I revised phrases from "open a file" to "visit a file".  I hope now
this patch is ready for consideration and applied.


# Change log

2017-08-26  Tak Kunihiro  <tkk <at> misasa.okayama-u.ac.jp>

        Let user specify function to visit a file or directory in dired using mouse-2

        * doc/emacs/dired.texi (Navigation): Document support of customizing functions to be used by mouse-2.
        * lisp/dired.el (dired-mouse-find-file-other-window): Visit a file or directory by `dired-mouse-find-file-func' or `dired-mouse-find-dir-func'.
    (dired-mouse-find-file-func): Specify function to visit a file on `dired-mouse-find-file-other-window'.
    (dired-mouse-find-dir-func): Specify function to visit a directory on `dired-mouse-find-file-other-window'.

# NEWS

** Use can specify function to visit a file or directory in dired using mouse click.
You can specify function to visit a file or directory by
'dired-mouse-find-file-func' and 'dired-mouse-find-dir-func'.

# Code

diff --git a/dired.252.el b/dired.el
index 39dc29e..8c21388 100644
--- a/dired.252.el
+++ b/dired.el
@@ -2117,8 +2117,20 @@ directory in another window."
 ;; Don't override the setting from .emacs.
 ;;;###autoload (put 'dired-find-alternate-file 'disabled t)

+(defcustom dired-mouse-find-file-func 'find-file-other-window
+  "Function to visit a file by `dired-mouse-find-file-other-window'."
+  :group 'mouse
+  :type 'function
+  :version "26.1")
+(defcustom dired-mouse-find-dir-func 'dired-other-window
+  "Function to visit a directory by `dired-mouse-find-file-other-window'."
+  :group 'mouse
+  :type 'function
+  :version "26.1")
 (defun dired-mouse-find-file-other-window (event)
-  "In Dired, visit the file or directory name you click on."
+  "In Dired, visit the file or directory name you click on.
+To visit the file or directory, this uses
+`dired-mouse-find-file-func' or `dired-mouse-find-dir-func'."
   (interactive "e")
   (let (window pos file)
     (save-excursion
@@ -2134,9 +2146,9 @@ directory in another window."
                 (dired-goto-subdir file))
            (progn
              (select-window window)
-             (dired-other-window file)))
+             (funcall dired-mouse-find-dir-func file)))
       (select-window window)
-      (find-file-other-window (file-name-sans-versions file t)))))
+      (funcall dired-mouse-find-file-func (file-name-sans-versions file t)))))

 (defun dired-view-file ()
   "In Dired, examine a file in view mode, returning to Dired when done.

# Info

diff --git a/dired.252.texi b/dired.texi
index 0e62a9e..323d350 100644
--- a/dired.252.texi
+++ b/dired.texi
@@ -358,7 +358,9 @@ another window, but do not select that window (@code{dired-display-file
 @findex dired-mouse-find-file-other-window
 Visit the file whose name you clicked on
 (@code{dired-mouse-find-file-other-window}).  This uses another window
-to display the file, like the @kbd{o} command.
+to display the file, like the @kbd{o} command.  You can change which
+window to display the file by customizing the variables
+@code{dired-mouse-find-file-func} and @code{dired-mouse-find-dir-func}.

 @item v
 @kindex v @r{(Dired)}

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.