GNU bug report logs - #27421
OpenTTD OpenGFX patches

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#27421: closed (OpenTTD OpenGFX patches)
Date: Wed, 21 Jun 2017 02:36:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 20 Jun 2017 19:51:19 -0400
with message-id <87injqp6a0.fsf <at> openmailbox.org>
and subject line Re: [bug#27421] [PATCH 5/5] gnu: openttd-engine: Add 'install-data' phase.
has caused the debbugs.gnu.org bug report #27421,
regarding OpenTTD OpenGFX patches
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
27421: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27421
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kei Kebreau <kei <at> openmailbox.org>
To: guix-patches <at> gnu.org
Subject: OpenTTD OpenGFX patches
Date: Sun, 18 Jun 2017 13:37:01 -0400

[Message part 3 (text/plain, inline)]

This patch series allows a user to have a playable OpenTTD game "out of
the box" by including the game's OpenGFX data.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Kei Kebreau <kei <at> openmailbox.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 27421-done <at> debbugs.gnu.org
Subject: Re: [bug#27421] [PATCH 5/5] gnu: openttd-engine: Add 'install-data'
 phase.
Date: Tue, 20 Jun 2017 19:51:19 -0400

[Message part 6 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Kei Kebreau <kei <at> openmailbox.org> writes:
>
>> Marius Bakke <mbakke <at> fastmail.com> writes:
>>
>>> Kei Kebreau <kei <at> openmailbox.org> writes:
>>>
>>>> * gnu/packages/games.scm (openttd-engine): Rename package to openttd.
>>>> [arguments]: Add it.
>>>> [native-inputs]: Add openttd-opengfx.
>>>
>>> This should also mention that the (openttd) variable is now gone.
>>> However, I would prefer keeping "openttd-engine" and only add these
>>> changes to the inherited "openttd" package. What do you think?
>>
>> That would be a more logical progression given the comment about adding
>> openttd-opengfx. I've attached the change you're talking about.
>
> LGTM, thanks!

All five patches pushed to master. Thanks for the review, Marius!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.