From unknown Sat Sep 20 13:34:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27407 <27407@debbugs.gnu.org> To: bug#27407 <27407@debbugs.gnu.org> Subject: Status: 25.2; SGR reset is ignored if it terminates Eshell's output Reply-To: bug#27407 <27407@debbugs.gnu.org> Date: Sat, 20 Sep 2025 20:34:34 +0000 retitle 27407 25.2; SGR reset is ignored if it terminates Eshell's output reassign 27407 emacs submitter 27407 Pierre Neidhardt severity 27407 minor tag 27407 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 17 07:31:20 2017 Received: (at submit) by debbugs.gnu.org; 17 Jun 2017 11:31:20 +0000 Received: from localhost ([127.0.0.1]:52159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMBwm-0007bH-DV for submit@debbugs.gnu.org; Sat, 17 Jun 2017 07:31:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMBwk-0007WI-Vq for submit@debbugs.gnu.org; Sat, 17 Jun 2017 07:31:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMBwe-00021U-Tp for submit@debbugs.gnu.org; Sat, 17 Jun 2017 07:31:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57825) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dMBwe-00021M-Q6 for submit@debbugs.gnu.org; Sat, 17 Jun 2017 07:31:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMBwd-0007ck-OF for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 07:31:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMBwY-0001y1-Mq for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 07:31:11 -0400 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:36092) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMBwY-0001xf-GB for bug-gnu-emacs@gnu.org; Sat, 17 Jun 2017 07:31:06 -0400 Received: by mail-wm0-x22f.google.com with SMTP id m125so44429321wmm.1 for ; Sat, 17 Jun 2017 04:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :content-transfer-encoding:user-agent; bh=d4XnawLBCLlaImua28EYmg2lGIE7RgwzB+eo2HrmPSU=; b=ecjpF4FqCjYTIJofIU9mwnyTKEn1vzuwzRlah5ABzvkqEO2fjy7MNqyf7QUj/yl1gJ krJIxnq5c+IML7bCD/azD2tWLzrJpfP6vXj7B657zbsxoPl4bYiiZYrvB2NgO1U5omIs iKFryTqbXOsh58DuAw2d7XKKjzOdK22z0EMcOKpz6cIw87ew5REIMzPAuzDK01yW3vJs Cf0WWh2QEEJgGpkTvh1IOKsKRF0P8bBgXPI3HE63+B6qu1y5mMji/xbQkB2emuBO6oly MSOrijKFxY4C/443HaDmH+GWEyhkK4u78W2vzbl4SDIGgiHbUy5ECf1vAgu+v1Zc9LIP 4h0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=d4XnawLBCLlaImua28EYmg2lGIE7RgwzB+eo2HrmPSU=; b=cuiX23dNGK4LItrBhr2bYWuxKL2qZhZz1oUHM1YBSESFu/evnYFYtK+rgR+rH6nBxm VSATZIMEVvT0+6Dp6OkPDr/ABQ9/UQnFgSbzutZ778AjDwOFDBsTIGrXK0vkUlPwiBIw 6owHtcjM2Df3KiHUmXLtBj0yu6s5DIdkPmLAHO/GopvPn1GnRfrCOpnqrdmInYGfN1Cs fJzxqkD+tlVCLCpDmzcmz0kEUZqngnb3f2bF4MZxOmBnIrKSFcdlbaUP2os5wzE6RDFs OjFlFFKQ64b8OA8Kfa/bCXB4IEvNpV9zN/grIlwbMj+cSJHbZ1M1pVekZViuv2RNxxHf 4Neg== X-Gm-Message-State: AKS2vOzSVDPaLssk52F+6NzmUPwQU8C54HOvPJfdAJz35M/bnquFBI7g ox6ERW5oV6qxvkub X-Received: by 10.80.205.94 with SMTP id d30mr10226671edj.74.1497699065179; Sat, 17 Jun 2017 04:31:05 -0700 (PDT) Received: from gmail.com ([196.203.31.130]) by smtp.gmail.com with ESMTPSA id o1sm3551975edc.22.2017.06.17.04.31.04 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Jun 2017 04:31:04 -0700 (PDT) Date: Sat, 17 Jun 2017 12:31:03 +0100 From: Pierre Neidhardt To: GNU Emacs bug Tracking System Subject: 25.2; SGR reset is ignored if it terminates Eshell's output Message-ID: <20170617113103.GB7315@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-Info: Simplicity is the ultimate sophistication. User-Agent: Mutt/1.8.3 (2017-05-23) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Steps to reproduce: - M-x eshell - Enter "=1B[33mhello=1B[0m" The new prompt becomes yellow. It does not happen if the SGR reset sequence is not last. This is fine for instance: - echo "=1B[33mhello=1B[0m"X - echo -n "=1B[33mhello=1B[0m" Maybe an off-by-one error in the `ansi-*' function? In GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.10) of 2017-04-22 built on juergen Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: Arch Linux Configured using: 'configure --prefix=3D/usr --sysconfdir=3D/etc --libexecdir=3D/usr/lib --localstatedir=3D/var --with-x-toolkit=3Dgtk3 --with-xft --with-modules 'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fstack-protector-strong' CPPFLAGS=3D-D_FORTIFY_SOURCE=3D2 LDFLAGS=3D-Wl,-O1,--sort-common,--as-needed,-z,relro' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 17 14:18:25 2017 Received: (at 27407) by debbugs.gnu.org; 17 Jun 2017 18:18:25 +0000 Received: from localhost ([127.0.0.1]:53636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMIIj-0002u8-CU for submit@debbugs.gnu.org; Sat, 17 Jun 2017 14:18:25 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:33422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMIIh-0002tk-K4; Sat, 17 Jun 2017 14:18:23 -0400 Received: by mail-io0-f179.google.com with SMTP id t87so45602455ioe.0; Sat, 17 Jun 2017 11:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YlIFJcaHDHaN5qk+ipALRrOl//QNqDShveB/+4Wn2zs=; b=DTQOW935x8CK1DlHyMs5K4ARQqgp2Fl8jBwNiCG1cbCYncAJ26q4AC+Gp3t1K+2Bxi 45fDZnIeO4d70xmWihUJMdjFR7MFTglGFAPhv+siwEiZPuH6ooUMwrU9wduOtnPwC7eS WlacdQ6AKo/g68TBXux77o27C7/MfTr7oE5PqSAydn4IS5E4J8H6RCXJ4TcI+FO9eghe lObySZNpfXcglud6TUYYWVwt6rAbvdoxiHuZkylPtsowqzglX6q5PIAMhrP8vnGNCkDn zQzMcXcdAnKtP4xhc8yrGsScm8TDNqAs8NeaduF/v+3v/KQrm3HoeZVGgrzA0WYyXl+T V7DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=YlIFJcaHDHaN5qk+ipALRrOl//QNqDShveB/+4Wn2zs=; b=OAQu6aH+1VBTo8H7V3AfUQR2GU2ejSp8Li0Ol0ma/qaLkwVv203grrhVC+72K74xiM JGFhBwHysM1CSrLckr3H/Vrii3fuAqnvDE2nroLIY0PPh/qD/4cEh5BpyiE/NV8GFHY+ Ep5zrOJxKgFu7sYdbESzS1VTH75Rg9iRu84b5jmJbpbejP0rSnwG5ua2AY+piVg53pV1 lnDniw03eO2LbZ1CPOf4a3PzHIce3pKMEBSbfpBbAzlOOVopGsIuG2vNCyJ9rlI/aPNC jkdPFKI0m9vDnPd2XjOdtiJ6hn85qpO7acrAmSk5U9HuIN98ZnaL0wK2EVLNAQ5HNK5H imRg== X-Gm-Message-State: AKS2vOxZorkTftzDWDuA9Z53YFHQLR9ioW4mt/x1aah0TrbYzcVlTN5D puESTvIyYyCevkNw X-Received: by 10.107.12.142 with SMTP id 14mr15887244iom.214.1497723497709; Sat, 17 Jun 2017 11:18:17 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id b62sm4032916itd.2.2017.06.17.11.18.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Jun 2017 11:18:16 -0700 (PDT) From: npostavs@users.sourceforge.net To: Pierre Neidhardt Subject: Re: bug#27407: 25.2; SGR reset is ignored if it terminates Eshell's output References: <20170617113103.GB7315@gmail.com> Date: Sat, 17 Jun 2017 14:19:54 -0400 In-Reply-To: <20170617113103.GB7315@gmail.com> (Pierre Neidhardt's message of "Sat, 17 Jun 2017 12:31:03 +0100") Message-ID: <87a856schh.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 27407 Cc: 27407@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 27407 + patch severity 27407 minor quit Pierre Neidhardt writes: > Steps to reproduce: > > - M-x eshell > - Enter "hello" > > The new prompt becomes yellow. You meant enter the text produced with (insert "echo \"\e[33mhello\e[0m\""). > It does not happen if the SGR reset sequence is not last. > This is fine for instance: > > - echo "hello"X > - echo -n "hello" > > Maybe an off-by-one error in the `ansi-*' function? The escape code is implemented by applying an overlay to the text following it (see `ansi-color-apply-on-region'). The problem seems to be that the reset sequence is translated to no face, so nothing is applied (see `ansi-color-apply-overlay-face'), and the yellow overlay gets extended despite the `ansi-color-freeze-overlay' modification-hook because `eshell-output-filter' (and `eshell-send-input') let-bind `inhibit-modification-hooks'. I'm not sure why `inhibit-modification-hooks' needs to be let-bound at all, but just binding it to nil around string insertion seems to be enough: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Let-ansi-color-overlay-hooks-work-in-eshell-Bug-2.patch Content-Description: patch >From 6e3892b8044fc918a5231a79963d0560adea2403 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 17 Jun 2017 12:06:37 -0400 Subject: [PATCH v1] Let ansi-color overlay hooks work in eshell (Bug#27407) * lisp/ansi-color.el (ansi-color-make-extent): Add `ansi-color-freeze-overlay' to `insert-behind-hooks' as well. * lisp/eshell/esh-mode.el (eshell-output-filter): Let-bind `inhibit-modification-hooks' to nil while inserting the string. --- lisp/ansi-color.el | 1 + lisp/eshell/esh-mode.el | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/ansi-color.el b/lisp/ansi-color.el index a1b4933175..72d70c2102 100644 --- a/lisp/ansi-color.el +++ b/lisp/ansi-color.el @@ -481,6 +481,7 @@ (defun ansi-color-make-extent (from to &optional object) ;; property to make sure it works. (let ((overlay (make-overlay from to object))) (overlay-put overlay 'modification-hooks '(ansi-color-freeze-overlay)) + (overlay-put overlay 'insert-behind-hooks '(ansi-color-freeze-overlay)) overlay))) (defun ansi-color-freeze-overlay (overlay is-after begin end &optional len) diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el index 0fd0c18301..0999f9c4a8 100644 --- a/lisp/eshell/esh-mode.el +++ b/lisp/eshell/esh-mode.el @@ -726,7 +726,9 @@ (defun eshell-output-filter (process string) (setq obeg (+ obeg nchars))) (if (<= (point) oend) (setq oend (+ oend nchars))) - (insert-before-markers string) + ;; Let the ansi-color overlay hooks run. + (let ((inhibit-modification-hooks nil)) + (insert-before-markers string)) (if (= (window-start) (point)) (set-window-start (selected-window) (- (point) nchars))) -- 2.11.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 18 02:49:27 2017 Received: (at 27407) by debbugs.gnu.org; 18 Jun 2017 06:49:27 +0000 Received: from localhost ([127.0.0.1]:53918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMU1X-0005It-CO for submit@debbugs.gnu.org; Sun, 18 Jun 2017 02:49:27 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMU1V-0005Ig-OK for 27407@debbugs.gnu.org; Sun, 18 Jun 2017 02:49:26 -0400 Received: by mail-wm0-f68.google.com with SMTP id d17so11628246wme.3 for <27407@debbugs.gnu.org>; Sat, 17 Jun 2017 23:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ho+KwBAxZN19qZke26mj3l+lV4y2CICZGOyTxeT0DMM=; b=RaEO8WBT9hMDrvnbZpzqy+/nXXXTA083/UrRkbfSkFfqEkDyb/t9CFR3mAPKinl6fA PGwJrQkHMeHqLPvyb+PO+OaJgUwVoNAgnka651TxhTSKluZv1SzfScV4ZTaQZBRURJIV 7+KHNF6IQCyGGfhSDRBr6wIO66cxie5Z4xxH+Kl3Zx/p4PaKFoAx9BfYOg7Ok1P5jZrp /CiCk1shgLqn72UjloSqkR/KYzOZOeYZLdizG9iZU7mIqq4FewXNdaq2o458o7q+B0ot 6JPOpyGiT59fVQ9RMdyOBLNEqmH47oYvAFOPJpP1srMYYV18T5/gGmAvQyFuXwGFXBKW +Hag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ho+KwBAxZN19qZke26mj3l+lV4y2CICZGOyTxeT0DMM=; b=WnGmqVPedyj8exG62fbC+vtv8wvAFakc5FzZ3oFIaKK895byv+N/E+VwEL08/hXtr0 4DFbcrB3ttecPjYOL8fcTfZz2ccMf9/DmYbQbsp5EXWL7za39PDTVf5wx3tGCw3Elo5C 8APnUPISfjAysZ6uKj5+OzIoDeLK3GzxSTsN9nufr5CTAmUYOn24lHODxD+CsWDoiv8o HWt1VuN8mDMlmi/t1AVpYf0BuEFNLFrD7rQeOW+63vB89jH2LkywFi781vEF5IHzH+6A 6gcAAcfdhXKjgmTpIRbSunsyPITE3nyVz/EbQQkfXptzax4/mRINxKawN1lBfnsF6Yap K/Dg== X-Gm-Message-State: AKS2vOzhLMtxaml3hkeNCfRgrE+HOdLZ4rkUHzgFMxuZ4yE0HcyAUmYq aN/QyAnoAh/gmg== X-Received: by 10.80.194.66 with SMTP id t2mr11371631edf.86.1497768560003; Sat, 17 Jun 2017 23:49:20 -0700 (PDT) Received: from gmail.com ([196.203.31.130]) by smtp.gmail.com with ESMTPSA id x9sm4176775edd.36.2017.06.17.23.49.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Jun 2017 23:49:19 -0700 (PDT) Date: Sun, 18 Jun 2017 07:49:17 +0100 From: Pierre Neidhardt To: npostavs@users.sourceforge.net Subject: Re: bug#27407: 25.2; SGR reset is ignored if it terminates Eshell's output Message-ID: <20170618064917.GB3761@gmail.com> References: <20170617113103.GB7315@gmail.com> <87a856schh.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a856schh.fsf@users.sourceforge.net> X-Info: Simplicity is the ultimate sophistication. User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 27407 Cc: 27407@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 17-06-17 14:19:54, npostavs@users.sourceforge.net wrote: > You meant enter the text produced with (insert "echo \"\e[33mhello\e[0m\""). Yes. I haven't tried your patch, but in the general case Eshell should not extend the ANSI coloring to the prompt, SGR reset or not. I.e. the following should not color the prompt: (insert "echo \"\e[33mhello") -- Pierre Neidhardt From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 18 13:48:53 2017 Received: (at 27407) by debbugs.gnu.org; 18 Jun 2017 17:48:53 +0000 Received: from localhost ([127.0.0.1]:55315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMeJg-0002GI-R4 for submit@debbugs.gnu.org; Sun, 18 Jun 2017 13:48:52 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:36367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMeJe-0002G3-IZ for 27407@debbugs.gnu.org; Sun, 18 Jun 2017 13:48:50 -0400 Received: by mail-io0-f182.google.com with SMTP id y77so52459878ioe.3 for <27407@debbugs.gnu.org>; Sun, 18 Jun 2017 10:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Y413IVIhK5JghfcWIDK2IGlEVP9LQR3rLKKFYJMV/Z0=; b=Jq9zyt7EAIWvqV6AncSHSYd60Sz6+MSlA/o59akFAnK0JOEeyt7op3CQ/NNLi8OYgl rYuCG8cL7/UGgTk5FG/y6fELZEOE7lr03Q7ln0nRs9lmBmmVjSh4AzvuliuiMEIWWyT4 d/6RIAvY0o6s89EyhtgQ3qXgpXQg4V96TVYLZB4VUoumG8mLlsJEFCHRz6I2/oUHZCaj 0UzfEn/xw6kt6ialfhyvspx//7vsLY0DLAeSolfwmEr7U13LVePbHcNLUZ+cdTTU0O1M +1xVxzKuZa0eLpToOobx/SVNHu99NTlBQn3wfpOSnduxyS5gY4LQ6iLCKUqbmvp1h1VL 5l4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Y413IVIhK5JghfcWIDK2IGlEVP9LQR3rLKKFYJMV/Z0=; b=eBiD9x422coxfL2uQYPTe+54TFaqxB9B9Mptf9Yd8mi5YQVGP/w87u549hNbbJdXru ea+AfnrlvqyIZODrKok6/+29kpgUdDD2SR8lZGsT89wNoKHWw3Wb2dazoUPrFCnOWDmX Kd//gPJ/khHqyj2SIo30WkFlHphbRQLcplYPD2KzFy5qiwJlgKbtd3Vu3+xJlpHS04Dq K5xQl3YMm3sT7EnkB+wNQsw26hiY6dgWEbRy201gnBw8xN0FRKqSNPtvsKsB6ygwm0rH 137QyjOPvHHBsNESJizC3923Rq7H6N+FgppkT//vhbZDsoG/5HG2vg5nUrvw8CFqWB4O 01SQ== X-Gm-Message-State: AKS2vOxr8NuLlAthebuX9/DgToYf3MYnyEDpgT4zNm3791LKlZzlF3ej 7rZX6jSS+RhO8jqV X-Received: by 10.107.137.166 with SMTP id t38mr18317965ioi.79.1497808124845; Sun, 18 Jun 2017 10:48:44 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id j62sm4467155iod.29.2017.06.18.10.48.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Jun 2017 10:48:43 -0700 (PDT) From: npostavs@users.sourceforge.net To: Pierre Neidhardt Subject: Re: bug#27407: 25.2; SGR reset is ignored if it terminates Eshell's output References: <20170617113103.GB7315@gmail.com> <87a856schh.fsf@users.sourceforge.net> <20170618064917.GB3761@gmail.com> Date: Sun, 18 Jun 2017 13:50:20 -0400 In-Reply-To: <20170618064917.GB3761@gmail.com> (Pierre Neidhardt's message of "Sun, 18 Jun 2017 07:49:17 +0100") Message-ID: <87poe1qj6r.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Pierre Neidhardt writes: > On 17-06-17 14:19:54, npostavs@users.sourceforge.net wrote: > > I haven't tried your patch, but in the general case Eshell should not extend the > ANSI coloring to the prompt, SGR reset or not. I.e. the following should not > color the prompt: > > (insert "echo \"\e[33mhello") [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.223.182 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.223.182 listed in wl.mailspike.net] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 27407 Cc: 27407@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Pierre Neidhardt writes: > On 17-06-17 14:19:54, npostavs@users.sourceforge.net wrote: > > I haven't tried your patch, but in the general case Eshell should not extend the > ANSI coloring to the prompt, SGR reset or not. I.e. the following should not > color the prompt: > > (insert "echo \"\e[33mhello") [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.223.182 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.223.182 listed in list.dnswl.org] 1.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different Pierre Neidhardt writes: > On 17-06-17 14:19:54, npostavs@users.sourceforge.net wrote: > > I haven't tried your patch, but in the general case Eshell should not extend the > ANSI coloring to the prompt, SGR reset or not. I.e. the following should not > color the prompt: > > (insert "echo \"\e[33mhello") My patch does not solve this scenario, but on the other hand, when I try this experiment in a terminal with bash, not putting a reset does give a coloured prompt, i.e., in the following the 2nd "~/src$" is in yellow: ~/src$ echo $'\e[33mhello' hello ~/src$ So should eshell really be any different? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 18 14:07:53 2017 Received: (at 27407) by debbugs.gnu.org; 18 Jun 2017 18:07:53 +0000 Received: from localhost ([127.0.0.1]:55343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMec5-0002nD-2x for submit@debbugs.gnu.org; Sun, 18 Jun 2017 14:07:53 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMec2-0002my-CO for 27407@debbugs.gnu.org; Sun, 18 Jun 2017 14:07:51 -0400 Received: by mail-wr0-f196.google.com with SMTP id 77so11053917wrb.3 for <27407@debbugs.gnu.org>; Sun, 18 Jun 2017 11:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OhJuPLxb7C9NKLIethhIRURsZVtRRmphQTenGu+agU0=; b=Lez0EyB5f9LvZ/Q6qiDSSe+c952uKhGPbQ7j9o9MZLg6Y5Tw9Ejlew0bG+7fWVbUiK hwfMMcF4sk18+TVfI2D+O9GNyN+EumMbuUbHV5SNM3zK8IZI2Kd9MTAQA1p0XsYTyH21 RN1DjnWKlefsfA1kI+DXvI4sGffcvKzXsjX7OqveF38j+iy/LSwZ8osCnVQM/ih9qmJA aYQ0tQ7wkrUimJnqFjtbjYmI2TBq0cKOFJqfUYwOC8jGrIL5cgTZ6vRXpKmV6t0/Zni1 7cGE1KGWxHvd+P/0J9te4IS2q7QQsBQMyLW6pu6/dLEhgR4kcq3vrXkuK2/AJc1pMeMb UpiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OhJuPLxb7C9NKLIethhIRURsZVtRRmphQTenGu+agU0=; b=n2JGeV4tZjYKLMW03QIp/y5G9GdZKvF971fzzf8UUZstggLcFyOq0AMdMw5lLWcrdy PD00mxYvG7KsySfh5kRDm1mj20vIC0uDkQQatCiyvWL09YLerp03iP9b2aubEUdzD3fv wKyZyF8F4GYqF4gXbZT1PMsVOx4Pz7yWHHICUyAWxNPr1aw2mHtvabSCaZYF7jCEbjmN vT7wyziOWYxjXUl/wBwf27ISjVIX/mui2bhGKaOtYkB0O4MhLMCY/kRQtRJSBzU8OBk3 UO2v7GWWEh/UYRE0spDA7GZTIH07Jz2y+pZle6+AFdWhtNXmkBGdEZOn8KvVK7TvUai/ jp2g== X-Gm-Message-State: AKS2vOz3m1HF0bE+CCm7CqtHzpBgKFZrrKYcLLo0h0NH+ADlUt5myKwT KxmV0gFap1r7/g== X-Received: by 10.223.165.1 with SMTP id i1mr14778558wrb.59.1497809264713; Sun, 18 Jun 2017 11:07:44 -0700 (PDT) Received: from gmail.com ([196.203.31.130]) by smtp.gmail.com with ESMTPSA id t8sm7277546wrc.28.2017.06.18.11.07.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Jun 2017 11:07:44 -0700 (PDT) Date: Sun, 18 Jun 2017 19:07:42 +0100 From: Pierre Neidhardt To: npostavs@users.sourceforge.net Subject: Re: bug#27407: 25.2; SGR reset is ignored if it terminates Eshell's output Message-ID: <20170618180742.GC2617@gmail.com> References: <20170617113103.GB7315@gmail.com> <87a856schh.fsf@users.sourceforge.net> <20170618064917.GB3761@gmail.com> <87poe1qj6r.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87poe1qj6r.fsf@users.sourceforge.net> X-Info: Simplicity is the ultimate sophistication. User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27407 Cc: 27407@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > My patch does not solve this scenario, but on the other hand, when I try > this experiment in a terminal with bash, not putting a reset does give a > coloured prompt, i.e., in the following the 2nd "~/src$" is in yellow: > > ~/src$ echo $'\e[33mhello' > hello > ~/src$ > > So should eshell really be any different? Yes. Definitely. Eshell _already_ is very different and that's why we use it. Bash is hardly a role model in the world of shells. In the case of bash, the issue probably stems back from historical limitations of VT* terminals. Something that does not make sense to emulate in modern computers. I don't see any use case for letting the SGR color the shell. If you want to change you shell from a command, Elisp is your friend... -- Pierre Neidhardt From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 18 15:32:43 2017 Received: (at 27407) by debbugs.gnu.org; 18 Jun 2017 19:32:43 +0000 Received: from localhost ([127.0.0.1]:55417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMfwA-0006tQ-V0 for submit@debbugs.gnu.org; Sun, 18 Jun 2017 15:32:43 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:32843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMfw9-0006tB-FP for 27407@debbugs.gnu.org; Sun, 18 Jun 2017 15:32:41 -0400 Received: by mail-io0-f169.google.com with SMTP id t87so53121722ioe.0 for <27407@debbugs.gnu.org>; Sun, 18 Jun 2017 12:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Y21dO8/y9voqb9co5E00dIBV3Srz7fK3ky9cPfHHCqU=; b=S43smYeGXNZi4e4UAs2PcjtFG06jJGjXJzSXp55moArsbhPFXccaIGm0kHADVNlsWG u3VfGG88q3WyEpRxEXChZLCkFnI9fsoCGD9k5gSzhigDtMtdBh+yLo2O8lIzxQi9jIpP 73NgivFCqgHZ4w8CnZlkxifVfJbkKR/C4std6+KQZxT9UP7fgH6FcwMqBziUOhM6vW7P 5SFcyJ70lZUrmCcM3n+FSDOBZmW+beWrWef7zKwg5xPJxWZts9vGaBMfcSt1NurES3w3 DZJ8EvYmFFIUK9x2aEBUcVvaIKyOgpu9/jVOAuROWxGRZ0h5mHAZMaR+h77Vo/mvgigz l2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Y21dO8/y9voqb9co5E00dIBV3Srz7fK3ky9cPfHHCqU=; b=FkOezXr3vUrNAun4erSRKwedUjDltIL2lHi1diLE5e+715s8HPG174yTzesb6nrFSN N+tcQnddcgaSLZ5o11CFbtt6fJv2zTtC/RA7dYMMpBsOqYWgG2sRcjK/gchU/sWPtTXq 4ioNdssxDx7mpoibX/mk7X6ggJl4ys7XAGEU2QNGhpJw8jtQwWOSBjkOzOao9Rn0pJGn elmLpKBw0pfHCFZvaAJdU0kJ64qmyNka4eXiMYkwGXI3bWeYfZow4MNu+hSJXTeA0Zsh tXaSbKxuur83j+l8Qbt+ngSQvYb72bRD2LKLhPeQG2/y48N6aaMBMfQ6l3kw4MTUqugz Dg7Q== X-Gm-Message-State: AKS2vOyjUIGfba4p2+NVVQr7o2QZNXztgJjFNMuJhfpE6uGKVfMOaEyV afvCvUl/s8+12mkO X-Received: by 10.107.170.99 with SMTP id t96mr19714313ioe.113.1497814355674; Sun, 18 Jun 2017 12:32:35 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 137sm5190895itw.14.2017.06.18.12.32.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Jun 2017 12:32:34 -0700 (PDT) From: npostavs@users.sourceforge.net To: Pierre Neidhardt Subject: Re: bug#27407: 25.2; SGR reset is ignored if it terminates Eshell's output References: <20170617113103.GB7315@gmail.com> <87a856schh.fsf@users.sourceforge.net> <20170618064917.GB3761@gmail.com> <87poe1qj6r.fsf@users.sourceforge.net> <20170618180742.GC2617@gmail.com> Date: Sun, 18 Jun 2017 15:34:11 -0400 In-Reply-To: <20170618180742.GC2617@gmail.com> (Pierre Neidhardt's message of "Sun, 18 Jun 2017 19:07:42 +0100") Message-ID: <87mv95qedo.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Pierre Neidhardt writes: >> My patch does not solve this scenario, but on the other hand, when I try >> this experiment in a terminal with bash, not putting a reset does give a >> coloured prompt, i.e., in the following the 2nd "~/src$" is in yellow: >> >> ~/src$ echo $'\e[33mhello' >> hello >> ~/src$ >> >> So should eshell really be any different? > > Yes. Definitely. Eshell _already_ is very different and that's why we use > it. Bash is hardly a role model in the world of shells. > > In the case of bash, the issue probably stems back from historical limitations > of VT* terminals. Something that does not make sense to emulate in modern > computers. > > I don't see any use case for letting the SGR color the shell. If you want to > change you shell from a command, Elisp is your friend... [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.223.169 listed in list.dnswl.org] -0.7 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.223.169 listed in wl.mailspike.net] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 27407 Cc: 27407@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Pierre Neidhardt writes: >> My patch does not solve this scenario, but on the other hand, when I try >> this experiment in a terminal with bash, not putting a reset does give a >> coloured prompt, i.e., in the following the 2nd "~/src$" is in yellow: >> >> ~/src$ echo $'\e[33mhello' >> hello >> ~/src$ >> >> So should eshell really be any different? > > Yes. Definitely. Eshell _already_ is very different and that's why we use > it. Bash is hardly a role model in the world of shells. > > In the case of bash, the issue probably stems back from historical limitations > of VT* terminals. Something that does not make sense to emulate in modern > computers. > > I don't see any use case for letting the SGR color the shell. If you want to > change you shell from a command, Elisp is your friend... [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.223.169 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.223.169 listed in list.dnswl.org] 1.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (npostavs[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different --=-=-= Content-Type: text/plain Pierre Neidhardt writes: >> My patch does not solve this scenario, but on the other hand, when I try >> this experiment in a terminal with bash, not putting a reset does give a >> coloured prompt, i.e., in the following the 2nd "~/src$" is in yellow: >> >> ~/src$ echo $'\e[33mhello' >> hello >> ~/src$ >> >> So should eshell really be any different? > > Yes. Definitely. Eshell _already_ is very different and that's why we use > it. Bash is hardly a role model in the world of shells. > > In the case of bash, the issue probably stems back from historical limitations > of VT* terminals. Something that does not make sense to emulate in modern > computers. > > I don't see any use case for letting the SGR color the shell. If you want to > change you shell from a command, Elisp is your friend... Hmm, seems easy enough to fix: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Reset-ansi-escape-context-before-printing-eshell-.patch Content-Description: patch >From 34f41c8573936285076b4e24c2e7ff4d34a48b8d Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 18 Jun 2017 15:29:55 -0400 Subject: [PATCH v1] Reset ansi escape context before printing eshell prompt (Bug#27407) * lisp/eshell/em-prompt.el (eshell-emit-prompt): Reset `ansi-color-context-region'. --- lisp/eshell/em-prompt.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/eshell/em-prompt.el b/lisp/eshell/em-prompt.el index 53a83e6a67..8c81b43b1f 100644 --- a/lisp/eshell/em-prompt.el +++ b/lisp/eshell/em-prompt.el @@ -117,6 +117,8 @@ (defun eshell-prompt-initialize () (defun eshell-emit-prompt () "Emit a prompt if eshell is being used interactively." + (when (boundp 'ansi-color-context-region) + (setq ansi-color-context-region nil)) (run-hooks 'eshell-before-prompt-hook) (if (not eshell-prompt-function) (set-marker eshell-last-output-end (point)) -- 2.11.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 03 10:10:58 2017 Received: (at 27407) by debbugs.gnu.org; 3 Jul 2017 14:10:58 +0000 Received: from localhost ([127.0.0.1]:50417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS242-0003zb-Gk for submit@debbugs.gnu.org; Mon, 03 Jul 2017 10:10:58 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:33775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS240-0003zE-93; Mon, 03 Jul 2017 10:10:56 -0400 Received: by mail-it0-f65.google.com with SMTP id 188so8950683itx.0; Mon, 03 Jul 2017 07:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ApOceA899xbPZNk5jq8oDU9MBCq2/DmcpLzwrPq1KUs=; b=I9lsypS8wEBoWmcq5Yl/VVblZwyj4sTBANcegYOLmm42vgetJWXFWo4CZivMQXaO2N KNdly+ZJ0qvlMgUG6Fdk+OEhJ4WXzIvVlJ9mBR/iwjjL647PXemsmCvQ9DrCVppanefr 2yA26s1gAvJkE9/yMPKmYoMn1tX5r4833aeKTlVjgJA6YNwor7ygVMidd9bcZGi7sS3C zIIBnx8Ugk7H/9imsozOQ2A9NEVFGnrfhgGeLP4su1ZXw8RkRJJFsmap+BQ+8/a03GXy 51nksKb+Lcy6O4+scFuD7ODkxOLHU0gnb+vrJOvhZo06szlAko3/5h1Ic5jj9uyP9mbm fOzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=ApOceA899xbPZNk5jq8oDU9MBCq2/DmcpLzwrPq1KUs=; b=UMrvejHQp2+I04QoE9UEuKYdPoMC4o8trTzMWFvFTTDaVoNHcnLnWUuU8NdQysrOi6 q1YZcJ1blPd+7PkD3p9SJmrqjziY2T/dbY7/yP1lCUIZLc/nqNY0IOuTAUTkWfmWOl3Q +mFB5bbrUWCNUU5EwM8tpnOuZo5AnDNIrWQRvD6L2PuKWuUXeYAonswlppu7nux842HK LiBmxHhtOoXHw+48FTxdmAJTxmnJbk4P2RQvu6H5dBeZpWzGAjOxFXVkdMl+1wgEYcrS 3LMsYCQlkU6mEz2RegeE8iuwUpJqb0DbTvjlCS/plaWKWZHx2GuSjg4z6KNawQwb2t1f uWpA== X-Gm-Message-State: AKS2vOydGuKfBWXL3hG628jf4jXFojpA0Rm0Mo6sYXj4RudtPnhhii9D ygm1q5fHgvfntnsC X-Received: by 10.36.33.202 with SMTP id e193mr30709011ita.92.1499091050738; Mon, 03 Jul 2017 07:10:50 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id g198sm6152559itb.3.2017.07.03.07.10.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jul 2017 07:10:50 -0700 (PDT) From: npostavs@users.sourceforge.net To: Pierre Neidhardt Subject: Re: bug#27407: 25.2; SGR reset is ignored if it terminates Eshell's output References: <20170617113103.GB7315@gmail.com> <87a856schh.fsf@users.sourceforge.net> <20170618064917.GB3761@gmail.com> <87poe1qj6r.fsf@users.sourceforge.net> <20170618180742.GC2617@gmail.com> <87mv95qedo.fsf@users.sourceforge.net> Date: Mon, 03 Jul 2017 10:12:26 -0400 In-Reply-To: <87mv95qedo.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sun, 18 Jun 2017 15:34:11 -0400") Message-ID: <878tk5k3sl.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 27407 Cc: 27407@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 27407 fixed close 27407 26.1 quit npostavs@users.sourceforge.net writes: >> >> I don't see any use case for letting the SGR color the shell. If you want to >> change you shell from a command, Elisp is your friend... > > Hmm, seems easy enough to fix: Pushed to master. [1: 4ebdcc46ab]: 2017-07-03 10:09:40 -0400 Let ansi-color overlay hooks work in eshell (Bug#27407) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4ebdcc46ab345849332332d580bd1e3c2c9adb1e [2: 37cdfec7c7]: 2017-07-03 10:09:41 -0400 Reset ansi escape context before printing eshell prompt (Bug#27407) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=37cdfec7c73205668498da9b27387f5f3ccfebee From unknown Sat Sep 20 13:34:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 01 Aug 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator