GNU bug report logs - #27405
25.2; Make eshell-next-prompt more reliable

Previous Next

Full log

Message #21 received at 27405 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: 27405 <at> debbugs.gnu.org
Subject: Re: bug#27405: 25.2; Make eshell-next-prompt more reliable
Date: Sun, 18 Jun 2017 15:19:59 +0100

On 17-06-18 09:52:13, npostavs <at> users.sourceforge.net wrote:
> Pierre Neidhardt <ambrevar <at> gmail.com> writes:
>
> >> > 	(defun eshell-previous-prompt (n)
> >> > 	  "Move to end of Nth previous prompt in the buffer.
> >> > 	See `eshell-prompt-regexp'."
> >> > 	  (interactive "p")
> >> > 	  (backward-char)
> >> > 	  (eshell-next-prompt (- n))))
> >>
> >> What's the backward-char for?
> >
> > That would have definitely deserved a comment...
> >
> > Without it, if point is right after the prompt, it won't move. That would be
> > disturbing for the user.
>
> Hmm, maybe beginning-of-line would make more sense?  If I have point on
> the same line of the prompt I can get to the beginning of the prompted
> line with C-a, so C-c C-p probably means I want to go farther back.

Agreed. Please make the change and add a comment.

--
Pierre Neidhardt

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.