GNU bug report logs - #27405
25.2; Make eshell-next-prompt more reliable

Previous Next

Package: emacs;

Reported by: Pierre Neidhardt <ambrevar <at> gmail.com>

Date: Sat, 17 Jun 2017 09:09:01 UTC

Severity: minor

Tags: confirmed, fixed, patch

Found in version 25.2

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: 27405 <at> debbugs.gnu.org
Subject: bug#27405: 25.2; Make eshell-next-prompt more reliable
Date: Sun, 18 Jun 2017 14:29:32 +0100

> > 	(defun eshell-previous-prompt (n)
> > 	  "Move to end of Nth previous prompt in the buffer.
> > 	See `eshell-prompt-regexp'."
> > 	  (interactive "p")
> > 	  (backward-char)
> > 	  (eshell-next-prompt (- n))))
>
> What's the backward-char for?

That would have definitely deserved a comment...

Without it, if point is right after the prompt, it won't move. That would be
disturbing for the user.

Detailed rules:

- If point is on the command line _after_ eshell-bol, then go back to eshell-bol.

- If point is between eshell-bol (included) and _after_ eshell-bol of the last
prompt (excluded), go to the last prompt.

--
Pierre Neidhardt
This bug report was last modified 8 years and 35 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.