GNU bug report logs - #27392
26.0.50; [css-mode] Completion fails after "grid" is typed out

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27392 in the body.
You can then email your comments to 27392 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; [css-mode] Completion fails after "grid" is typed out
Date: Fri, 16 Jun 2017 13:01:42 +0300

With these buffer contents (with point at |), press C-M-i:

html {
  gri|
}


It completes to "grid". Press C-M-i again: "No match".

Even though css-mode knows about various grid-** properties, it fails to 
suggest them in this situation.

It *does* offer them as completions after "gri" for `company-capf', however.

Same for "border", "animation" and probably others.

It's a problem for company-capf in particular because with 
company-require-match, after you `M-x company-capf', you're not allowed 
to type out the last letter of each respective word.

It's also a problem in discoverability.

Message #8 received at 27392 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 27392 <at> debbugs.gnu.org
Subject: Re: bug#27392: 26.0.50; [css-mode] Completion fails after "grid" is
 typed out
Date: Fri, 16 Jun 2017 20:23:29 +0200

[Message part 1 (text/plain, inline)]

It seems to be because 'css--complete-property-value' is a bit too 
eager.

Can you try with the following patch? If it's sufficent I'll install it
with some test cases.

-- Simen

[0001-WIP-Make-css-complete-property-value-less-eager.patch (text/x-patch, attachment)]

Message #11 received at 27392 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: 27392 <at> debbugs.gnu.org
Subject: Re: bug#27392: 26.0.50; [css-mode] Completion fails after "grid" is
 typed out
Date: Fri, 16 Jun 2017 23:33:02 +0300

On 6/16/17 9:23 PM, Simen Heggestøyl wrote:
> It seems to be because 'css--complete-property-value' is a bit too eager.
> 
> Can you try with the following patch? If it's sufficent I'll install it
> with some test cases.

Looks like it does fix the problem. Thanks!

Message #16 received at 27392-done <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 27392-done <at> debbugs.gnu.org
Subject: Re: bug#27392: 26.0.50; [css-mode] Completion fails after "grid" is
 typed out
Date: Sat, 17 Jun 2017 10:40:48 +0200

Installed a similar fix as 8960f6aa36000a8d6014e0c7371ee96ba148965a.

Thanks for reporting!

-- Simen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.