From unknown Sun Jun 22 17:11:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#2737 <2737@debbugs.gnu.org> To: bug#2737 <2737@debbugs.gnu.org> Subject: Status: [PATCH] Emacs CVS: (rcirc): Save call args to history variables Reply-To: bug#2737 <2737@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:11:46 +0000 retitle 2737 [PATCH] Emacs CVS: (rcirc): Save call args to history variables reassign 2737 emacs submitter 2737 Jari Aalto severity 2737 wishlist tag 2737 patch thanks From jari.aalto@cante.net Sat Mar 21 09:28:22 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 21 Mar 2009 16:28:22 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.0 required=4.0 tests=IMPRONONCABLE_2, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from emh03.mail.saunalahti.fi (emh03.mail.saunalahti.fi [62.142.5.109]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2LGSHCt020728 for ; Sat, 21 Mar 2009 09:28:19 -0700 Received: from saunalahti-vams (vs3-12.mail.saunalahti.fi [62.142.5.96]) by emh03-2.mail.saunalahti.fi (Postfix) with SMTP id 35595EBA3D for ; Sat, 21 Mar 2009 18:28:16 +0200 (EET) Received: from emh01.mail.saunalahti.fi ([62.142.5.107]) by vs3-12.mail.saunalahti.fi ([62.142.5.96]) with SMTP (gateway) id A017970FA0B; Sat, 21 Mar 2009 18:28:16 +0200 Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh01.mail.saunalahti.fi (Postfix) with ESMTP id 22F0D404E for ; Sat, 21 Mar 2009 18:28:15 +0200 (EET) Received: from [192.168.1.7] (helo=jondo.cante.net) by picasso.cante.net with esmtp (Exim 4.69) (envelope-from ) id 1Ll43R-0002SF-BN for submit@emacsbugs.donarmstrong.com; Sat, 21 Mar 2009 18:28:13 +0200 Received: from jaalto by jondo.cante.net with local (Exim 4.69) (envelope-from ) id 1Ll43S-0001TJ-Lp for submit@emacsbugs.donarmstrong.com; Sat, 21 Mar 2009 18:28:14 +0200 From: Jari Aalto To: Emacs bug BTS Subject: [PATCH] Emacs CVS: (rcirc): Save call args to history variables Date: Sat, 21 Mar 2009 18:28:14 +0200 Message-ID: <87fxh6on6p.fsf@jondo.cante.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SA-Exim-Connect-IP: 192.168.1.7 X-SA-Exim-Mail-From: jari.aalto@cante.net X-SA-Exim-Scanned: No (on picasso.cante.net); SAEximRunCond expanded to false X-Antivirus: VAMS --=-=-= Patch against CVS as of 2009-03-21 16:27 UTC 2009-03-21 Jari Aalto * net/rcirc.el (rcirc-history-server-name) (rcirc-history-server-port) (rcirc-history-nick-name): new variables. (rcirc): Use history variables. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-net-rcirc.el-rcirc-Save-call-args-to-histor.patch >From 02c1deb5855e78168aab74b1199a48b72eb9656b Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Sat, 21 Mar 2009 18:25:11 +0200 Subject: [PATCH] lisp/net/rcirc.el: (rcirc): Save call args to history variables --- lisp/net/rcirc.el | 18 +++++++++++++++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index f63237f..de4bdeb 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -359,6 +359,15 @@ and the cdr part is used for encoding." (defvar rcirc-startup-channels nil) +(defvar rcirc-history-server-name nil + "History variable for \\[rcirc] call.") + +(defvar rcirc-history-server-port nil + "History variable for \\[rcirc] call.") + +(defvar rcirc-history-nick-name nil + "History variable for \\[rcirc] call.") + ;;;###autoload (defun rcirc (arg) "Connect to all servers in `rcirc-server-alist'. @@ -371,15 +380,18 @@ If ARG is non-nil, instead prompt for connection parameters." (let* ((server (completing-read "IRC Server: " rcirc-server-alist nil nil - (caar rcirc-server-alist))) + (caar rcirc-server-alist) + 'rcirc-history-server-name)) (server-plist (cdr (assoc-string server rcirc-server-alist))) (port (read-string "IRC Port: " (number-to-string (or (plist-get server-plist 'port) - rcirc-default-port)))) + rcirc-default-port)) + 'rcirc-history-server-port)) (nick (read-string "IRC Nick: " (or (plist-get server-plist 'nick) - rcirc-default-nick))) + rcirc-default-nick) + 'rcirc-history-nick-name)) (channels (split-string (read-string "IRC Channels: " (mapconcat 'identity -- 1.6.1.3 --=-=-=-- From jari.aalto@cante.net Sat Mar 21 11:56:15 2009 Received: (at control) by emacsbugs.donarmstrong.com; 21 Mar 2009 18:56:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=MURPHY_DRUGS_REL8, VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from emh01.mail.saunalahti.fi (emh01.mail.saunalahti.fi [62.142.5.107]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2LIuBgX026547 for ; Sat, 21 Mar 2009 11:56:13 -0700 Received: from saunalahti-vams (vs3-12.mail.saunalahti.fi [62.142.5.96]) by emh01-2.mail.saunalahti.fi (Postfix) with SMTP id 69E618C487 for ; Sat, 21 Mar 2009 20:56:10 +0200 (EET) Received: from emh01.mail.saunalahti.fi ([62.142.5.107]) by vs3-12.mail.saunalahti.fi ([62.142.5.96]) with SMTP (gateway) id A003405F7DB; Sat, 21 Mar 2009 20:56:10 +0200 Received: from picasso.cante.net (a91-155-187-216.elisa-laajakaista.fi [91.155.187.216]) by emh01.mail.saunalahti.fi (Postfix) with ESMTP id 5EFFE402E for ; Sat, 21 Mar 2009 20:56:09 +0200 (EET) Received: from [192.168.1.7] (helo=jondo.cante.net) by picasso.cante.net with esmtp (Exim 4.69) (envelope-from ) id 1Ll6MZ-0003AA-8s for control@emacsbugs.donarmstrong.com; Sat, 21 Mar 2009 20:56:07 +0200 Received: from jaalto by jondo.cante.net with local (Exim 4.69) (envelope-from ) id 1Ll6Ma-0001py-Pk for control@emacsbugs.donarmstrong.com; Sat, 21 Mar 2009 20:56:08 +0200 From: Jari Aalto To: control@debbugs.gnu.org Subject: Bug#2737 change of tags / patch X-Bug-User-Agent: Emacs 23.0.91.2 and tinydebian.el 2009.0318.1913 Date: Sat, 21 Mar 2009 20:56:08 +0200 Message-ID: <87hc1m66yf.fsf@jondo.cante.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SA-Exim-Connect-IP: 192.168.1.7 X-SA-Exim-Mail-From: jari.aalto@cante.net X-SA-Exim-Scanned: No (on picasso.cante.net); SAEximRunCond expanded to false X-Antivirus: VAMS tags 2737 + patch thanks From rgm@gnu.org Mon Mar 23 17:43:35 2009 Received: (at control) by emacsbugs.donarmstrong.com; 24 Mar 2009 00:43:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2O0hWeG008557 for ; Mon, 23 Mar 2009 17:43:33 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Llujr-0001B2-SQ; Mon, 23 Mar 2009 20:43:32 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18888.11443.738154.918797@fencepost.gnu.org> Date: Mon, 23 Mar 2009 20:43:31 -0400 From: Glenn Morris To: control Subject: control message severity 2737 wishlist reassign 2753 emacs,ns tags 2753 moreinfo reassign 2754 emacs,ns reassign 2758 emacs,ns reassign 2759 spam severity 2746 minor From cyd@stupidchicken.com Sun Jul 12 12:01:00 2009 Received: (at 2737) by emacsbugs.donarmstrong.com; 12 Jul 2009 19:01:00 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.4 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po28.its.yale.edu (pantheon-po28.its.yale.edu [130.132.50.123]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6CJ0vkU014424 for <2737@emacsbugs.donarmstrong.com>; Sun, 12 Jul 2009 12:00:58 -0700 Received: from furry (c-71-192-161-14.hsd1.nh.comcast.net [71.192.161.14]) (authenticated bits=0) by pantheon-po28.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n6CJ0p1v026477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 12 Jul 2009 15:00:51 -0400 Received: by furry (Postfix, from userid 1000) id 922A2C09B; Sun, 12 Jul 2009 15:00:51 -0400 (EDT) From: Chong Yidong To: Ryan Yeske Cc: 2737@debbugs.gnu.org Subject: Re: [PATCH] Emacs CVS: (rcirc): Save call args to history variables Date: Sun, 12 Jul 2009 15:00:51 -0400 Message-ID: <87hbxhn2u4.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) Hi Ryan, Jari Aalto wrote a patch to rcirc.el for saving the arguments to `rcirc' to history. Could you review it? Thanks: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2737 From rcyeske@gmail.com Sun Jul 12 15:39:59 2009 Received: (at 2737) by emacsbugs.donarmstrong.com; 12 Jul 2009 22:39:59 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-pz0-f191.google.com (mail-pz0-f191.google.com [209.85.222.191]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6CMdp99020138 for <2737@emacsbugs.donarmstrong.com>; Sun, 12 Jul 2009 15:39:53 -0700 Received: by pzk29 with SMTP id 29so1442602pzk.19 for <2737@emacsbugs.donarmstrong.com>; Sun, 12 Jul 2009 15:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject :in-reply-to:references:date:message-id:mime-version:content-type; bh=LdPB9aF2TsZ82w/Kln0ykaYI3wIephLnP0jYFsxfkR8=; b=oyKMLG8EPN6oPmHvAeyN/IZP71Bb/LuxLt4keFxt5YNfPvRf7qcZriio068MJwpaOu 5pLPGQTVTJ8956Iq4M92iZgX4Lpw6+OqB5NtzVEwMXs1l24+GoNxsroDqynvLIHJMuXo dori6S5alTUAEOCX5Bau6e0DlbL1Dl0VPdvKo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; b=KCz767EuPXFEG2R04EH7YMQ4u9HoA0fq39bi4DPhSDHZE2RAjwQJwzITzxLIQp8y8u jgttYUyVoZwEQDZ+xe+TzN4pNP7uHJlHX0pE8BKAzap3ryeS/7aIFAM8LyBwQ2G5QKST 93gxpY2PBSEbobNr1nYVwwVCoYKazWQElA1bU= Received: by 10.115.92.8 with SMTP id u8mr7501952wal.152.1247438386446; Sun, 12 Jul 2009 15:39:46 -0700 (PDT) Received: from freegeek.hackery.lan (d154-20-143-140.bchsia.telus.net [154.20.143.140]) by mx.google.com with ESMTPS id n33sm6991072wag.21.2009.07.12.15.39.44 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 12 Jul 2009 15:39:45 -0700 (PDT) From: Ryan Yeske To: Chong Yidong Cc: 2737@debbugs.gnu.org Subject: Re: [PATCH] Emacs CVS: (rcirc): Save call args to history variables In-Reply-To: <87hbxhn2u4.fsf@stupidchicken.com> (message from Chong Yidong on Sun, 12 Jul 2009 15:00:51 -0400) References: <87hbxhn2u4.fsf@stupidchicken.com> Date: Sun, 12 Jul 2009 15:39:43 -0700 Message-ID: <87ws6da5lc.fsf@freegeek.hackery.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Chong Yidong writes: > Hi Ryan, > > Jari Aalto wrote a patch to rcirc.el for saving the arguments to `rcirc' > to history. Could you review it? Thanks: > > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2737 This is a useful change. I tested the patch here, and it looks fine to me. Go ahead and apply it. From cyd@stupidchicken.com Wed Jul 15 09:03:05 2009 Received: (at 2737-done) by emacsbugs.donarmstrong.com; 15 Jul 2009 16:03:06 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.4 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po44.its.yale.edu (pantheon-po44.its.yale.edu [130.132.50.78]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6FG30VH013641 for <2737-done@emacsbugs.donarmstrong.com>; Wed, 15 Jul 2009 09:03:01 -0700 Received: from furry (dhcp128036014244.central.yale.edu [128.36.14.244]) (authenticated bits=0) by pantheon-po44.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n6FG2ruc018052 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 15 Jul 2009 12:02:53 -0400 Received: by furry (Postfix, from userid 1000) id 009DCC0E1; Wed, 15 Jul 2009 11:08:46 -0400 (EDT) From: Chong Yidong To: Jari Aalto Cc: Ryan Yeske , 2737-done@debbugs.gnu.org Subject: Re: [PATCH] Emacs CVS: (rcirc): Save call args to history variables Date: Wed, 15 Jul 2009 11:08:46 -0400 Message-ID: <87eisiyoe9.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) I've checked this patch into the trunk. (I renamed your history variables from rcirc-history-* to rcirc-*-history, for conformity.) Thanks. From unknown Sun Jun 22 17:11:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Thu, 13 Aug 2009 14:24:19 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator