GNU bug report logs - #27368
Minor concern: Confusing tail warning

Previous Next

Full log

View this message in rfc822 format

From: Pádraig Brady <P <at> draigBrady.com>
To: 27368 <at> debbugs.gnu.org
Subject: bug#27368: Minor concern: Confusing tail warning
Date: Sat, 17 Jun 2017 14:30:29 -0700

On 17/06/17 07:35, Jim Meyering wrote:
> On Sat, Jun 17, 2017 at 1:32 AM, Pádraig Brady <P <at> draigbrady.com> wrote:
> ...
>> Two proposed patches for this are attached.
> 
> Nice fixes. Thank you!
> 
> In the NEWS addition:
> 
>    tail -f will now exit immediately if the output is piped
>    and the reader of the pipe terminates.
> 
> +  tail -f will no longer erroneously warn about being ineffective
> +  when following a single tty, as the simple blocking loop used
> +  is effective in this case.

> Please don't use "will" in [NEWS].
> I.e., use the present tense instead. Referencing the future makes
> sense only now, prior to the release.
> 
> ----------------------
> In this new function, please move the declaration of "i" into the for-loop:
> 
> +static bool
> +any_non_regular (const struct File_spec *f, size_t n_files)
> +{
> +  size_t i;
> +
> +  for (i = 0; i < n_files; i++)
> 

Cool.
Thanks for the review

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.