Subject: Re: [bug#27355] [PATCH 5/7] gnu: Add libsigrok.

From: Danny Milosavljevic <[email-masked]>
Date: Mon, 19 Jun 2017 22:35:09 +0200

Hi,

On Wed, 14 Jun 2017 12:58:11 +0300
Theodoros Foradis <[email-masked]> wrote:

> +     `(#:tests? #f ; tests need usb access

All of them?

> +         (add-after 'install 'install-udev-rules
...
> +         (add-after 'install-eudev-rules 'install-fw
                                ^ e?

> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let* ((fx2lafw (assoc-ref inputs "sigrok-firmware-fx2lafw"))
> +                    (out (assoc-ref outputs "out"))
> +                    (dir "/share/sigrok-firmware/")

Maybe "dir-suffix" ?  Not that important...

> +    (description "Libsigrok is a shared library written in C, which provides the basic hardware

                                                               ^ comma looks weird here

Also maybe @code{libsigrok} ?

Otherwise LGTM!