From unknown Wed Jun 25 00:21:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27346 <27346@debbugs.gnu.org> To: bug#27346 <27346@debbugs.gnu.org> Subject: Status: module tests fail to compile with gcc 4.8.5 Reply-To: bug#27346 <27346@debbugs.gnu.org> Date: Wed, 25 Jun 2025 07:21:42 +0000 retitle 27346 module tests fail to compile with gcc 4.8.5 reassign 27346 emacs submitter 27346 Glenn Morris severity 27346 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 13:37:26 2017 Received: (at submit) by debbugs.gnu.org; 12 Jun 2017 17:37:27 +0000 Received: from localhost ([127.0.0.1]:43956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKTHK-00051l-P7 for submit@debbugs.gnu.org; Mon, 12 Jun 2017 13:37:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKTHJ-00051Y-5a for submit@debbugs.gnu.org; Mon, 12 Jun 2017 13:37:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKTHD-0007Ze-5D for submit@debbugs.gnu.org; Mon, 12 Jun 2017 13:37:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKTHD-0007ZT-1h for submit@debbugs.gnu.org; Mon, 12 Jun 2017 13:37:19 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKTHC-0002OM-IN; Mon, 12 Jun 2017 13:37:18 -0400 From: Glenn Morris To: submit@debbugs.gnu.org Subject: module tests fail to compile with gcc 4.8.5 X-Spook: Bellcore fraud Croatian NORAD Plane USCODE Compsec Exxon X-Ran: UQ&))wau+5,4N4c"6yu\Re&]ok%jiQW@0\T4?ilJfI7Vn#^N4?tNDMW?)koC6w#1WK~$l} X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 12 Jun 2017 13:37:18 -0400 Message-ID: <99r2ypw1ip.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Package: emacs Version: 26.0.50 Current master on rhel7.3. gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11) After building with-modules: cd test/data/emacs-module make gcc -std=gnu11 -I../../../src -fPIC -g3 -O2 -c -o mod-test.o mod-test.c In file included from mod-test.c:23:0: ../../../src/emacs-module.h:38:47: error: missing binary operator before token "(" #if defined __has_attribute && __has_attribute(__nonnull__) ^ make: *** [mod-test.o] Error 1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 14:25:47 2017 Received: (at 27346) by debbugs.gnu.org; 12 Jun 2017 18:25:47 +0000 Received: from localhost ([127.0.0.1]:43977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKU27-000660-3M for submit@debbugs.gnu.org; Mon, 12 Jun 2017 14:25:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKU25-00065o-B1 for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 14:25:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKU1w-0005rf-T7 for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 14:25:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKU1w-0005rZ-Q2 for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 14:25:36 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3726 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dKU1v-0002jY-7V; Mon, 12 Jun 2017 14:25:36 -0400 Date: Mon, 12 Jun 2017 21:25:15 +0300 Message-Id: <83mv9d3vxw.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: <99r2ypw1ip.fsf@fencepost.gnu.org> (message from Glenn Morris on Mon, 12 Jun 2017 13:37:18 -0400) Subject: Re: bug#27346: module tests fail to compile with gcc 4.8.5 References: <99r2ypw1ip.fsf@fencepost.gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27346 Cc: 27346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Glenn Morris > Date: Mon, 12 Jun 2017 13:37:18 -0400 > > Current master on rhel7.3. > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-11) > > After building with-modules: > cd test/data/emacs-module > make > > gcc -std=gnu11 -I../../../src -fPIC -g3 -O2 -c -o mod-test.o mod-test.c > In file included from mod-test.c:23:0: > ../../../src/emacs-module.h:38:47: error: missing binary operator before token "(" > #if defined __has_attribute && __has_attribute(__nonnull__) I think the "if defined __has_attribute &&" part is not needed, since conf_post.h defines it fr compilers that lack it. Can you try that? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 16:29:04 2017 Received: (at 27346) by debbugs.gnu.org; 12 Jun 2017 20:29:04 +0000 Received: from localhost ([127.0.0.1]:44063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKVxQ-0000UC-Ha for submit@debbugs.gnu.org; Mon, 12 Jun 2017 16:29:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKVxO-0000Th-S5 for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 16:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKVxI-0006ZA-OH for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 16:28:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD, UNRESOLVED_TEMPLATE autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKVxI-0006Yw-KU for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 16:28:56 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKVxH-0006zS-Pj; Mon, 12 Jun 2017 16:28:55 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#27346: module tests fail to compile with gcc 4.8.5 References: <99r2ypw1ip.fsf@fencepost.gnu.org> <83mv9d3vxw.fsf@gnu.org> X-Spook: Drug war La Familia Metro Peking Shell Quarnantine X-Ran: =gHn{v}!_W%7SdzT+d<9QPev#HY[$"%JS/&4g%3}"L:O/BJfxF]Txxa11K^0@%scQIh~ (Eli Zaretskii's message of "Mon, 12 Jun 2017 21:25:15 +0300") Message-ID: <1fvao16jco.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 27346 Cc: 27346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Eli Zaretskii wrote: > I think the "if defined __has_attribute &&" part is not needed, since > conf_post.h defines it fr compilers that lack it. Can you try that? emacs-module.h does not include config.h, and I don't know if it should. (I see no src/*.h file includes config.h, except cygw32.h. Should it? It could easily be changed not to.) If not, then I guess something like the following is needed: --- a/src/emacs-module.h +++ b/src/emacs-module.h @@ -35,9 +35,12 @@ # define EMACS_NOEXCEPT #endif -#if defined __has_attribute && __has_attribute(__nonnull__) +#ifdef __has_attribute +#if __has_attribute(__nonnull__) # define EMACS_ATTRIBUTE_NONNULL(...) __attribute__((__nonnull__(__VA_ARGS__))) -#else +#endif +#endif +#ifndef EMACS_ATTRIBUTE_NONNULL # define EMACS_ATTRIBUTE_NONNULL(...) #endif (Even with this change or your suggestion, I then get "Module initialization failed" when running the tests, but that's probably a different issue.) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 17:34:07 2017 Received: (at 27346) by debbugs.gnu.org; 12 Jun 2017 21:34:07 +0000 Received: from localhost ([127.0.0.1]:44112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKWyM-0001yM-Sj for submit@debbugs.gnu.org; Mon, 12 Jun 2017 17:34:07 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:34112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKWyL-0001xs-4U for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 17:34:05 -0400 Received: by mail-oi0-f52.google.com with SMTP id b6so8362451oia.1 for <27346@debbugs.gnu.org>; Mon, 12 Jun 2017 14:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=It/fj9QSobiWCzqndJ1u1vubZGV/Xt/vPy4g5heK//0=; b=euCPAUthk5biNg/cxKlIXKkVmQdQZF3FSaYrQZm1pW+YYfBgZID205Cr7eQga4K528 Eky0DQQpA4A5s0BwoHEKBPoMjqhGLkF9IO1I0HwVqWqEnUSG85psRQGVdWenTkfYB4f8 UnazPHuQBp/VzbrPMgLJJBVh892OHTSmUosU+OGwG2Yb9NWJrWoYFnqjd/cYKS3JDapZ CAaRLjoufGft8MgQKIj1Z6bJcPb6oDTd2l0Buopjd8wVzE0wl3VW0S6k68MGqheDgsDg eaLuPoBlMTF79tO5fRSP9XX+LL4VOJovC/VLErrdGL1xxEmwIqTAi7klsG0KN67/ldM7 f1rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=It/fj9QSobiWCzqndJ1u1vubZGV/Xt/vPy4g5heK//0=; b=kybPA9S6kleRLQ0ILzN43307JhHhn+7/BmKl9T63smH7+GdEYCYlnjxx5RTFjF8K+s 8gxR98AznhFAAIALgd3ULfKNMDMyT360Tk6FWr8MGi+utSVr5Gy+lgdirQPBaJouIFNG Q5XGuHOniB9UGQeRI+VbZJwXnM9Peg1yvd7nyEcBi8woyJt+8VWo3dExYmymIDh15src rjewgXsuw3oC2PIzsPodkJWqPdrm70/UZrU/K4k+x8ZbtLetYgwFPbp94HptQIIjgJ0G fNfaRlPz4ytMf3uS9nfs0RBudRNlXWfxLr+JV/lyL3P6moZW9/ktuVZuw1dDRmBgIRIc MxcQ== X-Gm-Message-State: AODbwcCnUPMwmKAWimQsuJ/toUpy4tWmS0V5XN/uuvM/kmxj9elz5J5B KTqoNeBUfoqU26z8ZfnnJPfpWJONS0vd X-Received: by 10.202.6.131 with SMTP id 125mr26220074oig.114.1497303239481; Mon, 12 Jun 2017 14:33:59 -0700 (PDT) MIME-Version: 1.0 References: <99r2ypw1ip.fsf@fencepost.gnu.org> <83mv9d3vxw.fsf@gnu.org> <1fvao16jco.fsf@fencepost.gnu.org> In-Reply-To: <1fvao16jco.fsf@fencepost.gnu.org> From: Philipp Stephani Date: Mon, 12 Jun 2017 21:33:48 +0000 Message-ID: Subject: Re: bug#27346: module tests fail to compile with gcc 4.8.5 To: Glenn Morris , Eli Zaretskii Content-Type: multipart/alternative; boundary="94eb2c18d98cb5fe470551ca13a5" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 27346 Cc: 27346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --94eb2c18d98cb5fe470551ca13a5 Content-Type: text/plain; charset="UTF-8" Glenn Morris schrieb am Mo., 12. Juni 2017 um 22:30 Uhr: > Eli Zaretskii wrote: > > > I think the "if defined __has_attribute &&" part is not needed, since > > conf_post.h defines it fr compilers that lack it. Can you try that? > > emacs-module.h does not include config.h, and I don't know if it should. > > No, emacs-module.h cannot include any headers except standard C headers. > > If not, then I guess something like the following is needed: > > --- a/src/emacs-module.h > +++ b/src/emacs-module.h > @@ -35,9 +35,12 @@ > # define EMACS_NOEXCEPT > #endif > > -#if defined __has_attribute && __has_attribute(__nonnull__) > +#ifdef __has_attribute > +#if __has_attribute(__nonnull__) > # define EMACS_ATTRIBUTE_NONNULL(...) > __attribute__((__nonnull__(__VA_ARGS__))) > -#else > +#endif > +#endif > +#ifndef EMACS_ATTRIBUTE_NONNULL > # define EMACS_ATTRIBUTE_NONNULL(...) > #endif > > > Probably yes, thanks. (I don't know why the && expression doesn't work.) > (Even with this change or your suggestion, I then get "Module > initialization > failed" when running the tests, but that's probably a different issue.) > Do you get a more detailed error message? --94eb2c18d98cb5fe470551ca13a5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Mo= ., 12. Juni 2017 um 22:30=C2=A0Uhr:
Eli Zaretskii wrote:

> I think the "if defined __has_attribute &&" part is = not needed, since
> conf_post.h defines it fr compilers that lack it.=C2=A0 Can you try th= at?

emacs-module.h does not include config.h, and I don't know if it should= .


No, emacs-module.h cannot include any = headers except standard C headers.
=C2=A0

If not, then I guess something like the following is needed:

--- a/src/emacs-module.h
+++ b/src/emacs-module.h
@@ -35,9 +35,12 @@
=C2=A0# define EMACS_NOEXCEPT
=C2=A0#endif

-#if defined __has_attribute && __has_attribute(__nonnull__)
+#ifdef __has_attribute
+#if __has_attribute(__nonnull__)
=C2=A0# define EMACS_ATTRIBUTE_NONNULL(...)
=C2=A0__attribute__((__nonnull__(__VA_ARGS__)))
-#else
+#endif
+#endif
+#ifndef EMACS_ATTRIBUTE_NONNULL
=C2=A0# define EMACS_ATTRIBUTE_NONNULL(...)
=C2=A0#endif



Probably yes, thanks. (I don't kno= w why the && expression doesn't work.)
=C2=A0
(Even with this change or your suggestion, I then get "Module initiali= zation
failed" when running the tests, but that's probably a different is= sue.)

Do you get a more detailed error = message?=C2=A0
--94eb2c18d98cb5fe470551ca13a5-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 17:46:48 2017 Received: (at 27346) by debbugs.gnu.org; 12 Jun 2017 21:46:48 +0000 Received: from localhost ([127.0.0.1]:44127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKXAd-0002Gs-TL for submit@debbugs.gnu.org; Mon, 12 Jun 2017 17:46:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKXAc-0002Gf-2F for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 17:46:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKXAV-0007MP-NA for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 17:46:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKXAS-0007LZ-4a; Mon, 12 Jun 2017 17:46:36 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKXAR-0007V6-KD; Mon, 12 Jun 2017 17:46:35 -0400 From: Glenn Morris To: Philipp Stephani Subject: Re: bug#27346: module tests fail to compile with gcc 4.8.5 References: <99r2ypw1ip.fsf@fencepost.gnu.org> <83mv9d3vxw.fsf@gnu.org> <1fvao16jco.fsf@fencepost.gnu.org> X-Spook: Environmental terrorist Attorney General lynch Clinton X-Ran: t^W2]0,VF4?6v/fV=Lk*xU*cenOjA"hK^[]UTu_`ORQ8RKscUl!c{<`tKa>NVt$;%v (Philipp Stephani's message of "Mon, 12 Jun 2017 21:33:48 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27346 Cc: Eli Zaretskii , 27346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Philipp Stephani wrote: >> +#ifdef __has_attribute >> +#if __has_attribute(__nonnull__) >> # define EMACS_ATTRIBUTE_NONNULL(...) >> __attribute__((__nonnull__(__VA_ARGS__))) >> -#else >> +#endif >> +#endif >> +#ifndef EMACS_ATTRIBUTE_NONNULL >> # define EMACS_ATTRIBUTE_NONNULL(...) >> #endif Applied as 69899d4. > Probably yes, thanks. (I don't know why the && expression doesn't work.) I could not find a good reference, but see eg https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36453#c3 >> (Even with this change or your suggestion, I then get "Module >> initialization >> failed" when running the tests, but that's probably a different issue.) > > Do you get a more detailed error message? It was the off-by-one thing you just fixed. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 17:47:56 2017 Received: (at control) by debbugs.gnu.org; 12 Jun 2017 21:47:56 +0000 Received: from localhost ([127.0.0.1]:44131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKXBk-0002Ig-7M for submit@debbugs.gnu.org; Mon, 12 Jun 2017 17:47:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKXBi-0002IT-AA for control@debbugs.gnu.org; Mon, 12 Jun 2017 17:47:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKXBc-0007cB-Ih for control@debbugs.gnu.org; Mon, 12 Jun 2017 17:47:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKXBc-0007c7-Fc for control@debbugs.gnu.org; Mon, 12 Jun 2017 17:47:48 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKXBc-0007Zl-6E for control@debbugs.gnu.org; Mon, 12 Jun 2017 17:47:48 -0400 Subject: control message for bug 27346 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 12 Jun 2017 17:47:48 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) # 69899d4 close 27346 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 18:00:20 2017 Received: (at 27346) by debbugs.gnu.org; 12 Jun 2017 22:00:20 +0000 Received: from localhost ([127.0.0.1]:44140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKXNk-0002sC-DP for submit@debbugs.gnu.org; Mon, 12 Jun 2017 18:00:20 -0400 Received: from mail-ot0-f178.google.com ([74.125.82.178]:34776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKXNi-0002kn-3m for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 18:00:18 -0400 Received: by mail-ot0-f178.google.com with SMTP id t31so75404077ota.1 for <27346@debbugs.gnu.org>; Mon, 12 Jun 2017 15:00:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rcOxIFVIfXF6OWyozt9F9/RYbTaCDHz3PIb4lUNt4bI=; b=Nl6eRHKbP9aAsw3Dm8rUWEJ/AKEgViyFvafZeUxa/CQvj1j+/dFwpmWOwPI8gu7sY5 yxjNe1uW1Aw5iCGWucLn+e9mhOaLUDkf/AYAufbB8UkuNWUgiiIdq12otixop/laYxRf 26idgJFr+393qki2BD71cLo6weIrt+KMcQpS+ek7zfQyqgiUs0rpG3Z9GoDj/HSdFpWq bbQq+eIaPsWo+yrZsqaruC/SNuKfOZw/AZ8Lf5P0vV2v8jZtVWF5oz26FBeAczgzE/dD NEnygqqC8RLv+CkQHjQGzAfCM3GWKOID+dO26xElfeGL6eitOQQmeAgVQiY/3jzaghlQ b88Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rcOxIFVIfXF6OWyozt9F9/RYbTaCDHz3PIb4lUNt4bI=; b=q2+pS55tc2kA4brnA1dMlNFCHIZb925k9abHvy7FFvADz/NKBo2V+nYH2kMNF41hZJ zPcfSt4tI8flvVDi2Xk211Mwpt+3KT6MXJASX7nUm33/I/I78RThY/5Eh3f/FNhnA7Gx 6e6ky9jWmZXGj3ku9ShAQY0WJOfPAqKtyCOn2A5oRgaYitdR9prZJ8jhf9jBdYGSXv7O vg8pSBfI0bm3W45ussZyaD1YLejODRzh7mgW8rLGTyfZ94FWKOnbEpAnoyPg3oZx7Lry yVn+NPlXzyObnaOGEonghYir2hq76dyleETUO0KZYofa04ZBXbzeRudz3kQcf7Z7BDkL X7Vg== X-Gm-Message-State: AODbwcA0miWZO0rKd655/aulyl0HC/rgMfWmHHtx2iwJ44QNjW9YFWDw vqEpjL683LcroSYC0ROoFLx8vDdCow== X-Received: by 10.157.30.129 with SMTP id n1mr26483566otn.243.1497304812008; Mon, 12 Jun 2017 15:00:12 -0700 (PDT) MIME-Version: 1.0 References: <99r2ypw1ip.fsf@fencepost.gnu.org> <83mv9d3vxw.fsf@gnu.org> <1fvao16jco.fsf@fencepost.gnu.org> In-Reply-To: From: Philipp Stephani Date: Mon, 12 Jun 2017 22:00:01 +0000 Message-ID: Subject: Re: bug#27346: module tests fail to compile with gcc 4.8.5 To: Glenn Morris Content-Type: multipart/alternative; boundary="001a1136f5c870c0910551ca71be" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 27346 Cc: Eli Zaretskii , 27346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --001a1136f5c870c0910551ca71be Content-Type: text/plain; charset="UTF-8" Glenn Morris schrieb am Mo., 12. Juni 2017 um 23:46 Uhr: > Philipp Stephani wrote: > > >> (Even with this change or your suggestion, I then get "Module > >> initialization > >> failed" when running the tests, but that's probably a different issue.) > > > > Do you get a more detailed error message? > > It was the off-by-one thing you just fixed. > Thanks. I've now also added some more informational messages. Two smaller things: - After 5f25857f619f87c59e8e888fde5e66280a185123 dependency tracking doesn't seem to work correctly any more on my macOS system (i.e. mod-test.so isn't rebuilt if the module source has changed). `make' is GNU Make 3.81; maybe there was a bug that has been fixed in the meantime? If so, should we check for this in configure? - Regarding the core dumps, it would probably better to use `ulimit -c 0' to prevent them during tests where aborts are expected. Not sure how to do that portably though. --001a1136f5c870c0910551ca71be Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Mo= ., 12. Juni 2017 um 23:46=C2=A0Uhr:
Philipp Stephani wrote:

>> (Even with this change or your suggestion, I then get "Module=
>> initialization
>> failed" when running the tests, but that's probably a dif= ferent issue.)
>
> Do you get a more detailed error message?

It was the off-by-one thing you just fixed.

=
Thanks. I've now also added some more informational messages.
Two smaller things:
- After 5f25857f619f87c59e8e888fde5e662= 80a185123 dependency tracking doesn't seem to work correctly any more o= n my macOS system (i.e. mod-test.so isn't rebuilt if the module source = has changed). `make' is GNU Make 3.81; maybe there was a bug that has b= een fixed in the meantime? If so, should we check for this in configure?
- Regarding the core dumps, it would probably better to use `ulimit= -c 0' to prevent them during tests where aborts are expected. Not sure= how to do that portably though.=C2=A0
--001a1136f5c870c0910551ca71be-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 18:10:32 2017 Received: (at 27346) by debbugs.gnu.org; 12 Jun 2017 22:10:32 +0000 Received: from localhost ([127.0.0.1]:44146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKXXc-0004dM-I8 for submit@debbugs.gnu.org; Mon, 12 Jun 2017 18:10:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKXXb-0004dA-AF for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 18:10:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKXXU-0006gi-PH for 27346@debbugs.gnu.org; Mon, 12 Jun 2017 18:10:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKXXR-0006fW-8k; Mon, 12 Jun 2017 18:10:21 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKXXQ-0005OC-Ms; Mon, 12 Jun 2017 18:10:20 -0400 From: Glenn Morris To: Philipp Stephani Subject: Re: bug#27346: module tests fail to compile with gcc 4.8.5 References: <99r2ypw1ip.fsf@fencepost.gnu.org> <83mv9d3vxw.fsf@gnu.org> <1fvao16jco.fsf@fencepost.gnu.org> X-Spook: hackers Vince Foster corporate security underground Leak X-Ran: |;Bq!YnKvxAj!9~Q79b5S%@+7Hu9ph)cR.9IbMU_#u=V|6#_>Vv1c7S%3hd}OU081FF~*= X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 12 Jun 2017 18:10:20 -0400 In-Reply-To: (Philipp Stephani's message of "Mon, 12 Jun 2017 22:00:01 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27346 Cc: Eli Zaretskii , 27346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Philipp Stephani wrote: > - After 5f25857f619f87c59e8e888fde5e66280a185123 dependency tracking > doesn't seem to work correctly any more on my macOS system (i.e. > mod-test.so isn't rebuilt if the module source has changed). > `make' is GNU Make 3.81; maybe there was a bug that has been fixed in > the meantime? If so, should we check for this in configure? The previous version used "$srcdir", which wasn't defined in that Makefile, and would have been wrong even if it was, so I can't see how it could ever have worked for you. It works for me now with make 3.82 if either mod-test.c or emacs-module.h is changed. I don't see how this could be specific to some version of make. > - Regarding the core dumps, it would probably better to use `ulimit -c 0' > to prevent them during tests where aborts are expected. Not sure how to do > that portably though. Me neither. :) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 13 03:59:35 2017 Received: (at 27346) by debbugs.gnu.org; 13 Jun 2017 07:59:35 +0000 Received: from localhost ([127.0.0.1]:44313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKgjf-0004mq-2g for submit@debbugs.gnu.org; Tue, 13 Jun 2017 03:59:35 -0400 Received: from mail-ot0-f179.google.com ([74.125.82.179]:36026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKgjd-0004mb-RU for 27346@debbugs.gnu.org; Tue, 13 Jun 2017 03:59:34 -0400 Received: by mail-ot0-f179.google.com with SMTP id i31so82219649ota.3 for <27346@debbugs.gnu.org>; Tue, 13 Jun 2017 00:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EMIO3JNFGBrtPi5f7FHuiqyIV/X5mYGDL9KBftsoACU=; b=J4CZHzmYitsgxgrv2T9mDLmCNVkUhGDAIX6gPt4UkxtRU5ea2lyr8VS9/QfZCGqMLj DO6CgZGY53wX8NjLJczZV+EPGMHzQfL15jRHV5kXfR5or0jPAZzf0PNIddADElUGyknU dJeV9if6Vs6SOtIB0+VGDhZI+3zTF1pHjjn+sUvXPrEZu41VdLtkb2+O5kcXJPwqNSVN XV12S5/JkolR/tS65o16kXjebcJyt+i0i2mOJqgZyNplFXs5b7ggxHAdi9FGDJciXoUx ERu/Re3wzxf0fJvu1eiTBB3sIZ5UngUnZafN5KfzONtvNmdYXnGkr4xsMb619Y/l4e2l sY/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EMIO3JNFGBrtPi5f7FHuiqyIV/X5mYGDL9KBftsoACU=; b=uJjCwEiMEalyMSfocUw2/mEfMDzT0YvUqgRZf0m3MQHxQqWZZrkvLI13e7Ax+13rs3 41rcrAjaL5pqvaIgvhHrkfsbsT23+NNbp4tCT1yKW/iTDEJ/lPoTB1Kf0EmDOkmWx0lc HS7XNyQBNxdbZRslDwT/KaQM2oQmiNeUGA4EPlVK7mKN2F0/uNWaaLro95WYgRb4/NOS Mo/T6gF8VPFdez7wS7SkIp4Aj5znq6J78FAVm/jXYUx6DLvuieSscd4aAykk2D2pbNTB xrGNRKT24bGhx73WO5PmYiPew5sR9Z0S0XETkL7mbCAKZxav2EVn/nelN4eYacahJDIJ OmSg== X-Gm-Message-State: AKS2vOzxDLB6kq6iM2yx6BdMJGhS0/7QSkuZ/plakfY1Ldqbf2uR67mB o88j+VJIXl3NSl9ZIrj/o2ApqLvWUA== X-Received: by 10.157.68.228 with SMTP id p36mr34982694otg.19.1497340768023; Tue, 13 Jun 2017 00:59:28 -0700 (PDT) MIME-Version: 1.0 References: <99r2ypw1ip.fsf@fencepost.gnu.org> <83mv9d3vxw.fsf@gnu.org> <1fvao16jco.fsf@fencepost.gnu.org> In-Reply-To: From: Philipp Stephani Date: Tue, 13 Jun 2017 07:59:17 +0000 Message-ID: Subject: Re: bug#27346: module tests fail to compile with gcc 4.8.5 To: Glenn Morris Content-Type: multipart/alternative; boundary="f403043c4a589600a80551d2d0a2" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 27346 Cc: Eli Zaretskii , 27346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --f403043c4a589600a80551d2d0a2 Content-Type: text/plain; charset="UTF-8" Glenn Morris schrieb am Di., 13. Juni 2017 um 00:10 Uhr: > Philipp Stephani wrote: > > > - After 5f25857f619f87c59e8e888fde5e66280a185123 dependency tracking > > doesn't seem to work correctly any more on my macOS system (i.e. > > mod-test.so isn't rebuilt if the module source has changed). > > `make' is GNU Make 3.81; maybe there was a bug that has been fixed in > > the meantime? If so, should we check for this in configure? > > The previous version used "$srcdir", which wasn't defined in that > Makefile, and would have been wrong even if it was, so I can't see how > it could ever have worked for you. Indeed. I think what matters for 'make -C test src/emacs-module-tests' is the dependency declaration in test/Makefile.in. > It works for me now with make 3.82 if > either mod-test.c or emacs-module.h is changed. I don't see how this > could be specific to some version of make. > Does it also work if you run 'make src/emacs-module-tests' from 'test'? That's the case that apparently doesn't work any more for me (probably because of some unrelated change). --f403043c4a589600a80551d2d0a2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Di= ., 13. Juni 2017 um 00:10=C2=A0Uhr:
Philipp Stephani wrote:

> - After 5f25857f619f87c59e8e888fde5e66280a185123 dependency tracking > doesn't seem to work correctly any more on my macOS system (i.e. > mod-test.so isn't rebuilt if the module source has changed).
> `make' is GNU Make 3.81; maybe there was a bug that has been fixed= in
> the meantime? If so, should we check for this in configure?

The previous version used "$srcdir", which wasn't defined in = that
Makefile, and would have been wrong even if it was, so I can't see how<= br> it could ever have worked for you.

Indeed. = I think what matters for 'make -C test src/emacs-module-tests' is t= he dependency declaration in test/Makefile.in.
=C2=A0
It works for me now with make 3.82 if
either mod-test.c or emacs-module.h is changed. I don't see how this could be specific to some version of make.

<= div>Does it also work if you run 'make src/emacs-module-tests' from= 'test'? That's the case that apparently doesn't work any m= ore for me (probably because of some unrelated change).

--f403043c4a589600a80551d2d0a2-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 13 04:03:42 2017 Received: (at 27346) by debbugs.gnu.org; 13 Jun 2017 08:03:43 +0000 Received: from localhost ([127.0.0.1]:44320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKgne-0004uF-Lm for submit@debbugs.gnu.org; Tue, 13 Jun 2017 04:03:42 -0400 Received: from mail-ot0-f173.google.com ([74.125.82.173]:34766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKgnd-0004u2-6d for 27346@debbugs.gnu.org; Tue, 13 Jun 2017 04:03:41 -0400 Received: by mail-ot0-f173.google.com with SMTP id t31so82387142ota.1 for <27346@debbugs.gnu.org>; Tue, 13 Jun 2017 01:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6vr6A9CUW52a4pYBZjwnZIub7wRal0JyDq+39B42pqg=; b=ItOPl6cJn7SajRVTqOZWTQvuMawQdbDEhZxtiIPuwCDonJ1KFeAglZm2pA3dEuIhGY NDqyTfiylTJhAWkLi3eyBzyEN3gLhjmfpSuhy/tveGoV3yZhybkuePX3BGvZGlC648Tj l+amLn/XQlGXnjLOugLsiX66T8iPdh6lRnRDflQpJskxps7hBaMStClQOo9KHcy7CzkW Rcf3opCmNnsJpF17nnoGGcjNqJtQz8sS5Dxkb2wyZULeRILsE2KCTADcWdfif0fAO2YM +1bwu64jnrAHWkiPNupRnrkM2ux90qF1LdBgAuGAJlvK8Xce08MdaG+ah032u99RhCc0 8O7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6vr6A9CUW52a4pYBZjwnZIub7wRal0JyDq+39B42pqg=; b=WIjHFBiODLNOp60fa9ixyBKD39xJtRqlSn+5bzq9qRhfGazJTVURbioNTQ25lwQ5cI v85CJeVJLHrdB9Thz3R4x61cgOIG0i7UWzRWPmXYrhlwIaRYS7DJL8yHLkdMM7AFo6k8 eJZUWVvLeMH3UYfN0taq8JZj4+4mi/cOS04A+39KZ0Wt6HMLZjtpnJiOhXAuCO/kwIar P54pyRkC83ZvoXAMTkyQx28KZCFbAZvwpmrakaiEVnZ4ExyPPo1dKjhWi69TdYplkGtu GvClnwPffWtX6NwlPizjmK/5viBmtb7iyop4wpZmbw48dRj1gca8IsPQ5BAujlXnd30J gUcg== X-Gm-Message-State: AKS2vOxrQFkC0jWkv9FQ3QRDmefr8svI6nwaDqc+7a2ukE2CpAAnK98N wRedlzKpzpShOyAFB9oz13QWCZBCKaFa X-Received: by 10.157.37.244 with SMTP id q107mr1418193ota.44.1497341015789; Tue, 13 Jun 2017 01:03:35 -0700 (PDT) MIME-Version: 1.0 References: <99r2ypw1ip.fsf@fencepost.gnu.org> <83mv9d3vxw.fsf@gnu.org> <1fvao16jco.fsf@fencepost.gnu.org> In-Reply-To: From: Philipp Stephani Date: Tue, 13 Jun 2017 08:03:25 +0000 Message-ID: Subject: Re: bug#27346: module tests fail to compile with gcc 4.8.5 To: Glenn Morris Content-Type: multipart/alternative; boundary="001a113e40e05a98830551d2df4c" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 27346 Cc: Eli Zaretskii , 27346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --001a113e40e05a98830551d2df4c Content-Type: text/plain; charset="UTF-8" Glenn Morris schrieb am Mo., 12. Juni 2017 um 23:46 Uhr: > Philipp Stephani wrote: > > >> +#ifdef __has_attribute > >> +#if __has_attribute(__nonnull__) > >> # define EMACS_ATTRIBUTE_NONNULL(...) > >> __attribute__((__nonnull__(__VA_ARGS__))) > >> -#else > >> +#endif > >> +#endif > >> +#ifndef EMACS_ATTRIBUTE_NONNULL > >> # define EMACS_ATTRIBUTE_NONNULL(...) > >> #endif > > Applied as 69899d4. > Thanks! > > > Probably yes, thanks. (I don't know why the && expression doesn't work.) > > I could not find a good reference, but see eg > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36453#c3 > > I've looked it up in the (C++) standard, and the explanation makes sense. What happens is that the preprocessor first replaces the 'define' forms and expands macros, then replaces all leftover identifiers (including C keywords) with 0. So #if defined __has_attribute && __has_attribute ((__nonnull__)) first gets translated to #if 0 && 0 ((0)) which is then evaluated, but it's a syntax error, which fails even if the LHS of && is false. --001a113e40e05a98830551d2df4c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Mo= ., 12. Juni 2017 um 23:46=C2=A0Uhr:
Philipp Stephani wrote:

>> +#ifdef __has_attribute
>> +#if __has_attribute(__nonnull__)
>>=C2=A0 # define EMACS_ATTRIBUTE_NONNULL(...)
>>=C2=A0 __attribute__((__nonnull__(__VA_ARGS__)))
>> -#else
>> +#endif
>> +#endif
>> +#ifndef EMACS_ATTRIBUTE_NONNULL
>>=C2=A0 # define EMACS_ATTRIBUTE_NONNULL(...)
>>=C2=A0 #endif

Applied as 69899d4.

Thanks!
= =C2=A0

> Probably yes, thanks. (I don't know why the && expression = doesn't work.)

I could not find a good reference, but see eg
https://gcc.gnu.org/bugzilla/show_bug.cgi?id= =3D36453#c3


I've looked it up in the (C++) sta= ndard, and the explanation makes sense. What happens is that the preprocess= or first replaces the 'define' forms and expands macros, then repla= ces all leftover identifiers (including C keywords) with 0. So
#if defined __has_attribute && __has_attribute ((__non= null__))

first gets translated to

#if 0 && 0 ((0))

which is then ev= aluated, but it's a syntax error, which fails even if the LHS of &&= amp; is false.=C2=A0
--001a113e40e05a98830551d2df4c-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 13 13:04:36 2017 Received: (at 27346) by debbugs.gnu.org; 13 Jun 2017 17:04:37 +0000 Received: from localhost ([127.0.0.1]:46176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKpF5-0003Im-Ga for submit@debbugs.gnu.org; Tue, 13 Jun 2017 13:04:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKpF4-0003IZ-1k for 27346@debbugs.gnu.org; Tue, 13 Jun 2017 13:04:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKpEy-0003xH-5j for 27346@debbugs.gnu.org; Tue, 13 Jun 2017 13:04:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKpEu-0003w3-Gx; Tue, 13 Jun 2017 13:04:24 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKpEs-0008JX-4G; Tue, 13 Jun 2017 13:04:22 -0400 From: Glenn Morris To: Philipp Stephani Subject: Re: bug#27346: module tests fail to compile with gcc 4.8.5 References: <99r2ypw1ip.fsf@fencepost.gnu.org> <83mv9d3vxw.fsf@gnu.org> <1fvao16jco.fsf@fencepost.gnu.org> X-Spook: AIMSX Peking military Facility Delays White Water X-Ran: dBRd/nL%O5CD$|E`yk~-!CR'xvV9(,}brE-40W%/a'4MAQy@+G'|]=J/%h9_>@N-(;]H^h X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 13 Jun 2017 13:04:22 -0400 In-Reply-To: (Philipp Stephani's message of "Tue, 13 Jun 2017 07:59:17 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27346 Cc: Eli Zaretskii , 27346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Philipp Stephani wrote: > Does it also work if you run 'make src/emacs-module-tests' from 'test'? Yes, it does. Although I did change test/data/emacs-module/mod-test.o to not directly depend on src/emacs-module.c (only on .h), because it doesn't. Depending on the .c versions seems to me a bit like adding a depending on "src/emacs", which is strictly true, but would probably be annoying in practice. But put back the [ch] thing if that's the issue you mean. BTW, the relevant rules in test/Makefile are duplicating some of the logic of those in data/emacs-module/Makefile.in. Perhaps the latter could be removed. At least, test/Makefile should use FORCE to defer to data/emacs-module/Makefile as to whether things are up-to-date. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 13 14:50:40 2017 Received: (at 27346) by debbugs.gnu.org; 13 Jun 2017 18:50:41 +0000 Received: from localhost ([127.0.0.1]:46219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKqtk-0005hE-M3 for submit@debbugs.gnu.org; Tue, 13 Jun 2017 14:50:40 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:33920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKqti-0005h1-PF for 27346@debbugs.gnu.org; Tue, 13 Jun 2017 14:50:39 -0400 Received: by mail-oi0-f53.google.com with SMTP id b6so23888203oia.1 for <27346@debbugs.gnu.org>; Tue, 13 Jun 2017 11:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bvvIian/PxLOSf2wBgOkMI1Y0ueSujR4SAwNdJQwRMI=; b=llt2MjR1tgdplQU/3p3OFwj8m6MXYFJi6ZTNpD3N8MrLVuXfvBAxHh9OnvrMPUf1Lx QKaNKFzaQkoFUR3KsvtkSm6DTj+5bMtcpzqkBfsIBJiogGdXnKPSEjWrHPu10SOj3R6o VpMalND5p0wDNAzN3fEXBUC7XAJ/HOxKrgpAl9M92zhYhu2Z/6kVuVp/d/WSynNgYwBK 6BI037bmhSwUEw7EvZn4h7KwdSGNnL/6J0175TcBoJ0/DIrNk/daSKIv7840mDZh5TyG AKajJimkjxdWT7XfawW2maC7pWPQi1LIv/TD1tH86II3DDncRSTwD6OPvnrK7UNAUpZe vsew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bvvIian/PxLOSf2wBgOkMI1Y0ueSujR4SAwNdJQwRMI=; b=RioQPCCTc27uyHuudEy6mNSwk8pPvDT2ob0a9oRl7GNmAD89muDc6I7fRiFc1yGSHt KslaldQHm/4Nunx10kuqm4WiYYYlmB6WpNVuJ+7ECJ5qrvWAjqosGRSEABx1/s7l9D/j V2qWYH6e+YJWHtUiIepZZy65UP+H5g/BAZJnckls1+7XZE6dvJVBwJQLemVO5MAzi4pi B7TSSmn5zkhmNDccMfZfpLrt6foG+7DGJrHziv42/x1eU6HJD1rVduF7ScNyvNLEogHX DbkCF0FrtPsJeyWzVrdO8tkZ9qrJnV6Wa3lECmZuQt3y2PQdAZPprWfwHKefB6gHP0UD oN7w== X-Gm-Message-State: AKS2vOw4UHNKfL6zlZZ52dbwMkRBwI0M2KLKF7jyQmEnP+PPM5mXHTmN 05A2CFGFuvwtx005bja5+aca/aNPLQ== X-Received: by 10.202.6.131 with SMTP id 125mr944665oig.114.1497379832979; Tue, 13 Jun 2017 11:50:32 -0700 (PDT) MIME-Version: 1.0 References: <99r2ypw1ip.fsf@fencepost.gnu.org> <83mv9d3vxw.fsf@gnu.org> <1fvao16jco.fsf@fencepost.gnu.org> In-Reply-To: From: Philipp Stephani Date: Tue, 13 Jun 2017 18:50:22 +0000 Message-ID: Subject: Re: bug#27346: module tests fail to compile with gcc 4.8.5 To: Glenn Morris Content-Type: multipart/alternative; boundary="94eb2c18d98c0a067e0551dbe9d9" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 27346 Cc: Eli Zaretskii , 27346@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --94eb2c18d98c0a067e0551dbe9d9 Content-Type: text/plain; charset="UTF-8" Glenn Morris schrieb am Di., 13. Juni 2017 um 19:04 Uhr: > Philipp Stephani wrote: > > > Does it also work if you run 'make src/emacs-module-tests' from 'test'? > > Yes, it does. > > Although I did change test/data/emacs-module/mod-test.o to not directly > depend on src/emacs-module.c (only on .h), because it doesn't. Depending > on the .c versions seems to me a bit like adding a depending on > "src/emacs", which is strictly true, but would probably be annoying in > practice. But put back the [ch] thing if that's the issue you mean. > No, that dependency would indeed be bogus. I don't remember why I put it into test/Makefile.in in the first place. > > BTW, the relevant rules in test/Makefile are duplicating some of the > logic of those in data/emacs-module/Makefile.in. Perhaps the latter > could be removed. > Yes, I've done that now and at least for me the dependency tracking now works fine. --94eb2c18d98c0a067e0551dbe9d9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Di= ., 13. Juni 2017 um 19:04=C2=A0Uhr:
Philipp Stephani wrote:

> Does it also work if you run 'make src/emacs-module-tests' fro= m 'test'?

Yes, it does.

Although I did change test/data/emacs-module/mod-test.o to not directly
depend on src/emacs-module.c (only on .h), because it doesn't. Dependin= g
on the .c versions seems to me a bit like adding a depending on
"src/emacs", which is strictly true, but would probably be annoyi= ng in
practice. But put back the [ch] thing if that's the issue you mean.
=

No, that dependency would indeed be bogus.= I don't remember why I put it into test/Makefile.in in the first place= .
=C2=A0

BTW, the relevant rules in test/Makefile are duplicating some of the
logic of those in data/emacs-module/Makefile.in. Perhaps the latter
could be removed.

Yes, I've done th= at now and at least for me the dependency tracking now works fine.=C2=A0
--94eb2c18d98c0a067e0551dbe9d9-- From unknown Wed Jun 25 00:21:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 12 Jul 2017 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator