Subject: [bug#27344] [PATCH 08/12] gnu: Add ngspice.

From: Theodoros Foradis <[email-masked]>
Date: Fri, 16 Jun 2017 20:20:51 +0300

Danny Milosavljevic writes:

>> +                   (license:non-copyleft "file://COPYING") ; spice3 bsd-style
>
> This would mean the current directory of the current user on the remote host with name "COPYING".
>
> I think you meant file:///COPYING which refers to the file "COPYING" on localhost.
>

Right, fixed.

>> +           ((#:phases phases)
>> +            `(alist-cons-after 'install 'in-ng
>
> Please use modify-phases.
>
> Please name the phase so that one can know what it does...
>
>> +               (lambda* (#:key inputs outputs #:allow-other-keys)
>> +                 (map (lambda (lib)
>> +                        (copy-file
>> +                         (string-append (assoc-ref inputs "libngspice")
>> +                                        "/lib/" lib)
>> +                         (string-append (assoc-ref outputs "out")
>> +                                        "/lib/" lib)))
>> +                      '("libngspice.so.0" "libngspice.so"))
>
> Just use for-each...

It was in fact a mistake to have that phase there, now I just propagate
the shared library.

I am waiting for whatever other corrections before I submit a v2 for the
patch series with the suggested fixes.

-- 
Theodoros Foradis