GNU bug report logs - #27341
eww-search-words should prompt if region inactive

Previous Next

Full log

View this message in rfc822 format

From: npostavs <at> users.sourceforge.net
To: Alex Branham <branham <at> utexas.edu>
Cc: 27341 <at> debbugs.gnu.org
Subject: bug#27341: updated patch to fix docstring
Date: Sun, 02 Jul 2017 14:32:50 -0400

Alex Branham <branham <at> utexas.edu> writes:

> On Fri 30 Jun 2017 at 00:54, npostavs <at> users.sourceforge.net wrote:
>
>> Could you add a ChangeLog entry to the commit message as described in
>> CONTRIBUTE, please?
>
> Yes, I have done so. Let me know if it's not right.

Looks good, thanks.

>> Doc strings shouldn't be indented like that, and there should be a
>> double space between sentences.
>
> Fixed.

You missed the double spacing before the "Else,".

> Actually, we need to check (use-region-p) anyway in case the mark
> hasn't been activated yet in the buffer:

Hmm, I just tried this and it doesn't quite do the job.  I believe the
problem is that the (interactive "r") form throws an error when the mark
hasn't been activated yet.  To handle this case correctly you need to
replace the "r" with some lisp code that produces the argument list.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.