From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: eww-search-words should prompt if region inactive Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jun 2017 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 27341@debbugs.gnu.org X-Debbugs-Original-To: "" Received: via spool by submit@debbugs.gnu.org id=B.149726649819328 (code B ref -1); Mon, 12 Jun 2017 11:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Jun 2017 11:21:38 +0000 Received: from localhost ([127.0.0.1]:41901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKNPd-00051g-VE for submit@debbugs.gnu.org; Mon, 12 Jun 2017 07:21:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKNPb-00051S-Bw for submit@debbugs.gnu.org; Mon, 12 Jun 2017 07:21:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKNPV-0001wb-BL for submit@debbugs.gnu.org; Mon, 12 Jun 2017 07:21:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37541) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dKNPV-0001wW-7u for submit@debbugs.gnu.org; Mon, 12 Jun 2017 07:21:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKNPU-0004FG-7k for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2017 07:21:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKNPN-0001u0-J3 for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2017 07:21:26 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:34129) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dKNPN-0001tY-9p for bug-gnu-emacs@gnu.org; Mon, 12 Jun 2017 07:21:21 -0400 Received: by mail-lf0-x241.google.com with SMTP id o28so9247828lfk.1 for ; Mon, 12 Jun 2017 04:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=utexas-edu.20150623.gappssmtp.com; s=20150623; h=user-agent:from:to:subject:date:message-id:mime-version; bh=VViIX1EJhK326gaDQz7U7hwxTGMGuZDMZbaosW2Xm7w=; b=rZwde1MQId3H1NyIhSTEPAPkY36w9QaLnS3rem44mnZGP3uE5h2MeIBd/nV8hhaiKt w1ZzQbqgwXE68+GmD58mwbeLoAjf20zgDNV48H7/AV3rZ73BcbvvWhTaqYxqg115e+7x CkzhDkzrKlPJ4OFdoZaIxZIeZ2bzMIwMC4ioKCTDY3C5UVSEFi9oxD/OC6AoWNDDaZoC /71rn3X5sJxNq5h94e7kw0QFjpBXfH/Yicqysf5RdakK6RvbV7llf9DVFuwOGDXLUvMU UbH3sUf7e7+qU1Ng771AMRbkzaHdtXPgGlxMJ34zLinKe9S8CuSmvpqFKfEjc2FA3Cy0 jGdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=VViIX1EJhK326gaDQz7U7hwxTGMGuZDMZbaosW2Xm7w=; b=nWZiyEJSPOoiiWjfqEdhzUCevaa14mW3okentfmFueQsSCdefQRRv4CXxYBv+RLcak xLIe78zK2r5N02EAQVsiL0NLj+tRPQEXpAU2TvOGCsz60JmRT5zJ9CMfMgpFyeBqqNl0 8O0NYANI8htsB6gevBNE0lIbwtNdOi54ursF1/32PMehhMF9TWs7PeYFvgkvbzXonIkz poPWI8RWdOjqwoukiFtfdqOs2Er7ioMuZ2X6+9kV1k0zhrFSwmXU5Rf6VEobwiJq72aT E3TQiP9G5JswsX5I6xGyMCdNttVQgkgeDI/6LEfcQHqELUZP8VjO2UzC9q/q2la/Afn8 /vxw== X-Gm-Message-State: AODbwcBRarFK+ptdHzoc1is6AbMmGgdgVg0vwSZht9qsymJLRoCKgzj5 bNtNs1/LHU0t0DPIDbs= X-Received: by 10.46.32.42 with SMTP id g42mr10966656ljg.20.1497266477847; Mon, 12 Jun 2017 04:21:17 -0700 (PDT) Received: from mars (edu221103.eduroam.gu.se. [130.241.221.103]) by smtp.gmail.com with ESMTPSA id a2sm1185046lfg.51.2017.06.12.04.21.16 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Jun 2017 04:21:16 -0700 (PDT) User-agent: mu4e 0.9.18; emacs 25.2.1 From: Alex Branham Date: Mon, 12 Jun 2017 13:21:15 +0200 Message-ID: <8760g1xxhw.fsf@utexas.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain eww-search-words (M-S M-w) searches for the active region and doesn't do anything useful if the region isn't active. This patch has it prompt the user for a search string if the region isn't active. Alex --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-eww-earch-prefix-prompt-for-query-if-region-inactive.patch >From bf8cda29c442fa773ce59fe7bf7760887399c8fd Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Mon, 12 Jun 2017 13:10:27 +0200 Subject: [PATCH] eww-earch-prefix: prompt for query if region inactive --- lisp/net/eww.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fe31657914..dd64dc81eb 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -316,7 +316,9 @@ word(s) will be searched for via `eww-search-prefix'." "Search the web for the text between BEG and END. See the `eww-search-prefix' variable for the search engine used." (interactive "r") - (eww (buffer-substring beg end))) + (if (region-active-p) + (eww (buffer-substring beg end)) + (eww (read-string "Query: ")))) (defun eww-open-in-new-buffer () "Fetch link at point in a new EWW buffer." -- 2.13.1 --=-=-=-- From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring References: <8760g1xxhw.fsf@utexas.edu> In-Reply-To: <8760g1xxhw.fsf@utexas.edu> Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Jun 2017 09:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.149734588325956 (code B ref 27341); Tue, 13 Jun 2017 09:25:01 +0000 Received: (at 27341) by debbugs.gnu.org; 13 Jun 2017 09:24:43 +0000 Received: from localhost ([127.0.0.1]:44357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKi3z-0006kW-Oq for submit@debbugs.gnu.org; Tue, 13 Jun 2017 05:24:43 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:36295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKi3u-0006kG-7V for 27341@debbugs.gnu.org; Tue, 13 Jun 2017 05:24:38 -0400 Received: by mail-lf0-f50.google.com with SMTP id o83so65692734lff.3 for <27341@debbugs.gnu.org>; Tue, 13 Jun 2017 02:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=utexas-edu.20150623.gappssmtp.com; s=20150623; h=user-agent:from:to:subject:date:message-id:mime-version; bh=8IX2E6izvISK8VJrcYxu6bgdwKqp5roexEaEDiNTvs0=; b=bhG4LVJVnCKd5KdB16lR1hJC4jJWVbctbYL+cH9i4nB843CXZe6S+Nd5wL03xD3RFj TI/HstVvnFZEV/j6bXtWmtusw6ciyDWb/uWxA58SxSFfRHR1VrG0jMRGxb3od2TQPrBc xecOPHXWNhBIzI7uQVEB/1f8iDrzuZChOm1D95NVc4bO5FF7DPftMD7iVXSuqqg6aOKs oF6gTB3gAEeiR/hsJ40YsPcbjE80rY2nsHmnroYstLQvN+MaRUTS0L18pt0ektXSd4gQ YOodAAKvR8Sdwl+iWCtL3ioGSdZpfeEzvK9b655KfaOYonDnkldStXTQBhg4tX0VVcXR 57jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=8IX2E6izvISK8VJrcYxu6bgdwKqp5roexEaEDiNTvs0=; b=H+UHqeU0pTkRZ9IuhHR+y9NkPov+K3TWXmd4BImCPoXySzneIkUIHCmFEvzbT30JFt MRTPQLmce4LzZpQJlvSNiI0FGcIPXSgEOZJvZvwfs8wecD2nZ92LlqyjLQ0TDBfba2qn ApAuEShqydtqzFGH7dbEmnXpsN4y5YhH85LwoOCnJfML65JZ4c4VSt0rViTbmba9jIHO QTQcv5NtfhewSGh5MnS6i31B+zdbaD8D0KmbEb+kb/EjaUMBLIQ8X/DhuJ1WZetuPXVx 1RMkO8e6k/xpPdUsez+4Av+hfuRD2EsVSo3FCtVr8XdRU+DD1mJpXRPr2rQ/VVadynC7 keSg== X-Gm-Message-State: AKS2vOyZh+oMXOJhgvqzwrbMx96gM4LfRerQ4sVodzU8vSbdPflcfyvc +jmI/OAeoPC86+QFpvE= X-Received: by 10.46.97.18 with SMTP id v18mr1782213ljb.134.1497345867790; Tue, 13 Jun 2017 02:24:27 -0700 (PDT) Received: from mars (edu221103.eduroam.gu.se. [130.241.221.103]) by smtp.gmail.com with ESMTPSA id 184sm3263247ljf.8.2017.06.13.02.24.26 for <27341@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Jun 2017 02:24:26 -0700 (PDT) User-agent: mu4e 0.9.18; emacs 25.2.1 From: Alex Branham Date: Tue, 13 Jun 2017 11:24:25 +0200 Message-ID: <8737b4grzq.fsf@utexas.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Hi - I realized I forgot to update the docstring; this patch incorporates that change as well Alex >From 4545b2fb1d6f047b05cbb1e19a50fb09809d5a31 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 13 Jun 2017 11:21:35 +0200 Subject: [PATCH] eww-search-words prompts user for search if region inactive --- lisp/net/eww.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fe31657914..aa358dce0f 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -313,10 +313,13 @@ word(s) will be searched for via `eww-search-prefix'." ;;;###autoload (defun eww-search-words (&optional beg end) - "Search the web for the text between BEG and END. + "If region is active, search the web for the text between BEG and END. +Else, prompt the user for a search string. See the `eww-search-prefix' variable for the search engine used." (interactive "r") - (eww (buffer-substring beg end))) + (if (region-active-p) + (eww (buffer-substring beg end)) + (eww (read-string "Query: ")))) (defun eww-open-in-new-buffer () "Fetch link at point in a new EWW buffer." -- 2.13.1 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-eww-search-words-prompt-user-for-search-if-region.patch >From 4545b2fb1d6f047b05cbb1e19a50fb09809d5a31 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 13 Jun 2017 11:21:35 +0200 Subject: [PATCH] eww-search-words prompts user for search if region inactive --- lisp/net/eww.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fe31657914..aa358dce0f 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -313,10 +313,13 @@ word(s) will be searched for via `eww-search-prefix'." ;;;###autoload (defun eww-search-words (&optional beg end) - "Search the web for the text between BEG and END. + "If region is active, search the web for the text between BEG and END. +Else, prompt the user for a search string. See the `eww-search-prefix' variable for the search engine used." (interactive "r") - (eww (buffer-substring beg end))) + (if (region-active-p) + (eww (buffer-substring beg end)) + (eww (read-string "Query: ")))) (defun eww-open-in-new-buffer () "Fetch link at point in a new EWW buffer." -- 2.13.1 --=-=-=-- From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jun 2017 14:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.149840087327576 (code B ref 27341); Sun, 25 Jun 2017 14:28:02 +0000 Received: (at 27341) by debbugs.gnu.org; 25 Jun 2017 14:27:53 +0000 Received: from localhost ([127.0.0.1]:37405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dP8W1-0007Ah-GH for submit@debbugs.gnu.org; Sun, 25 Jun 2017 10:27:53 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:38365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dP8Vz-0007AU-Qy for 27341@debbugs.gnu.org; Sun, 25 Jun 2017 10:27:52 -0400 Received: by mail-it0-f51.google.com with SMTP id b205so28242587itg.1 for <27341@debbugs.gnu.org>; Sun, 25 Jun 2017 07:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xDb5DadomaLre4lW4RwpFVS2OtiimB3QgpRbqtW3G3s=; b=LVonwRC+3ihjdYe417U+K4+FKOfS5WIA8y56urG/ASkH5AJb0guBJwKNbTJt27QxDP 7ub5j+49+MZ6IqwDtiIYFbbygFrIIMQBcnbhGtfPQ1n+9fXnP/ex2ZQjIB9YUplhc9z5 ssYz0YRwjT7P5thUixzLjwCdqSB/jFFDNl5bs65j2xD8TGM6EKAhsce60SSatx4QESWM 0s47wknylnAqrJyD0D/w/7UrhN45jkNaU3wofvQNtIBRWrg1XNb2PFUj1hyCg4PZKfCP sKZ5SIWw90KzNx0H8ZIQh9x2Rp57FQ+EKPhPUunDtc9//bbaNlXFSfgIj2OfBnP2ES8D bZJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=xDb5DadomaLre4lW4RwpFVS2OtiimB3QgpRbqtW3G3s=; b=nOlldsw7KYJWglOeF8NoUErBCuofXbI3cWZr64butjJPgy0sPaAdyNAoW6TnUH/EGc T3G9Z6tIRnBqqZfF2r9Fpf2lxZeEK/rS5hwAnve9ShtD15HQZt/5Lone1WoABRcafIsK eEKnJ/ZYmYcQloOKKSAJTCfy2rmqwfoz/RtBZ2hjVUVKmUcCjwGN8gXOMadG9m++m6y7 CDqqlqvfX8ILMz9nB8oK+b/1qptsQ5PzRxksy5KqnlmfTZjYWkhOOXVqDha927AlYtWe 9oAm+kxQacuJYRFkGMEwh5YrAYcHQ6eUhwmScvetoKSKzMNOZ5hDqUGnaJt/BNMcFTqR G2bw== X-Gm-Message-State: AKS2vOxMfOQCILiLcQLGcTSxgXq97iK8PrdfnnyS6Nug5L2vKLYXpFYI hp7Qbi9BkvF1OEuf X-Received: by 10.36.211.69 with SMTP id n66mr17379460itg.36.1498400866073; Sun, 25 Jun 2017 07:27:46 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id u186sm6253473ita.3.2017.06.25.07.27.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Jun 2017 07:27:45 -0700 (PDT) From: npostavs@users.sourceforge.net References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> Date: Sun, 25 Jun 2017 10:29:22 -0400 In-Reply-To: <8737b4grzq.fsf@utexas.edu> (Alex Branham's message of "Tue, 13 Jun 2017 11:24:25 +0200") Message-ID: <8737aop2d9.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Alex Branham writes: > - (eww (buffer-substring beg end))) > + (if (region-active-p) If think we should use `use-region-p' instead. Or perhaps just check directly if region is empty? I guess searching for an empty string doesn't make much sense even if `use-empty-active-region' is t. From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Jun 2017 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.149848565728045 (code B ref 27341); Mon, 26 Jun 2017 14:01:02 +0000 Received: (at 27341) by debbugs.gnu.org; 26 Jun 2017 14:00:57 +0000 Received: from localhost ([127.0.0.1]:39211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPUZV-0007IH-FB for submit@debbugs.gnu.org; Mon, 26 Jun 2017 10:00:57 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:34417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPUZS-0007I1-K7 for 27341@debbugs.gnu.org; Mon, 26 Jun 2017 10:00:55 -0400 Received: by mail-lf0-f52.google.com with SMTP id l13so1310427lfl.1 for <27341@debbugs.gnu.org>; Mon, 26 Jun 2017 07:00:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=utexas-edu.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=6H0mnrFhoV9MHtO8CE1194SIaV/l95Ka5Wfa0CfjEzI=; b=WxzEUoC7fXL1b/ubIEuvPcfZ+uaHNljrTginQprLAX5bPH43zTgAIxzEQtm1xFqVxs eVILhdHnKXCqeTjfdL3aMk054Y+VXwzaK+vFVabrCHHOtLAJJ3zjGfrZa9x+jFOgktQc 6fl6wZdR5jX71+++RDQjBI8OSVSq01uHJS+EIX07lYFy1Cm6UbwRBGUXJSkElKtIF2HO HPf+C1u8riE5OgeGqrRHyQq54lNNWdfrXPDcUgWTc0dnLFOQrlbYoApwcdOo3dym3Bhn wI/coWLf2js/2lz1ql9PwEGN0hAOzPi2+e5Z2g49f68Np3A1goY+Pdy2/TYajagvsKbu RahA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=6H0mnrFhoV9MHtO8CE1194SIaV/l95Ka5Wfa0CfjEzI=; b=DdVjRSs6NaF7hcYqxnrtYM2Y7znohSWSN5YLXbfoNFxqu1aa3n2XvmMYuVjvCuoZCb iBkLbuCrgy98AFA3xDRE8p5NKTRfUiJYNjIVKjatdDbcYNtcl2pFJ7n29H7i/3SKN4P3 ebGlETo/4+FnyVbmZgpKVLmM47AylOIZPiNP3hlvd6Pv9Vpt2c9R9ON0BlxUF8uu6eth l9yqbYnRtU3H8Lm3nXWzrDcOPVhz2X/3uOlHE6U5xzDBX+m0qApc+D9cUo1UHnu3BLks NW7+OQ6L3tOOf1e9OB51D79+s1vDiA0I3zHn14rbteHesMTQlug2ofr4vKTHUUQOscwR KGTg== X-Gm-Message-State: AKS2vOyRzOqL3QKy0tQpYBqqzpmg49ZiMARy270645lPCdCZh7rtJM6j NyrbBfisW5QDwUM/pUc= X-Received: by 10.25.218.9 with SMTP id r9mr106448lfg.149.1498485647902; Mon, 26 Jun 2017 07:00:47 -0700 (PDT) Received: from mars (edu220107.eduroam.gu.se. [130.241.220.107]) by smtp.gmail.com with ESMTPSA id g39sm51145lfi.15.2017.06.26.07.00.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Jun 2017 07:00:46 -0700 (PDT) References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Alex Branham In-reply-to: <8737aop2d9.fsf@users.sourceforge.net> Date: Mon, 26 Jun 2017 16:00:46 +0200 Message-ID: <87lgoedf1t.fsf@utexas.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain Here's a new patch that checks the region directly, ignoring `use-empty-active-region'. >From c3babb73d8f29ff3f27aacbac99c7226ef4b32a0 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Mon, 26 Jun 2017 15:57:15 +0200 Subject: [PATCH] eww-search-words prompt user for query if region active and not empty --- lisp/net/eww.el | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fe31657914..cf46530d35 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -314,9 +314,15 @@ word(s) will be searched for via `eww-search-prefix'." ;;;###autoload (defun eww-search-words (&optional beg end) "Search the web for the text between BEG and END. -See the `eww-search-prefix' variable for the search engine used." + If region is active (and not whitespace), search the web for +the text between BEG and END. Else, prompt the user for a search +string. See the `eww-search-prefix' variable for the search +engine used." (interactive "r") - (eww (buffer-substring beg end))) + (let ((region-string (buffer-substring beg end))) + (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) + (eww region-string) + (eww (read-string "Query: "))))) (defun eww-open-in-new-buffer () "Fetch link at point in a new EWW buffer." -- 2.13.1 On Sun 25 Jun 2017 at 14:29, npostavs@users.sourceforge.net wrote: > Alex Branham writes: > >> - (eww (buffer-substring beg end))) >> + (if (region-active-p) > > If think we should use `use-region-p' instead. Or perhaps just check > directly if region is empty? I guess searching for an empty string > doesn't make much sense even if `use-empty-active-region' is t. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0003-eww-search-words-prompt-user-for-query-if-region-act.patch >From c3babb73d8f29ff3f27aacbac99c7226ef4b32a0 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Mon, 26 Jun 2017 15:57:15 +0200 Subject: [PATCH] eww-search-words prompt user for query if region active and not empty --- lisp/net/eww.el | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fe31657914..cf46530d35 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -314,9 +314,15 @@ word(s) will be searched for via `eww-search-prefix'." ;;;###autoload (defun eww-search-words (&optional beg end) "Search the web for the text between BEG and END. -See the `eww-search-prefix' variable for the search engine used." + If region is active (and not whitespace), search the web for +the text between BEG and END. Else, prompt the user for a search +string. See the `eww-search-prefix' variable for the search +engine used." (interactive "r") - (eww (buffer-substring beg end))) + (let ((region-string (buffer-substring beg end))) + (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) + (eww region-string) + (eww (read-string "Query: "))))) (defun eww-open-in-new-buffer () "Fetch link at point in a new EWW buffer." -- 2.13.1 --=-=-=-- From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Jun 2017 23:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.149852095729826 (code B ref 27341); Mon, 26 Jun 2017 23:50:02 +0000 Received: (at 27341) by debbugs.gnu.org; 26 Jun 2017 23:49:17 +0000 Received: from localhost ([127.0.0.1]:39700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPdkr-0007l0-5G for submit@debbugs.gnu.org; Mon, 26 Jun 2017 19:49:17 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:34672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPdkp-0007kl-IQ for 27341@debbugs.gnu.org; Mon, 26 Jun 2017 19:49:16 -0400 Received: by mail-io0-f171.google.com with SMTP id r36so9440994ioi.1 for <27341@debbugs.gnu.org>; Mon, 26 Jun 2017 16:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Qzt8gTSQJAKdqeFXhN/sDIMcpXV4uRz3cIgooC7aD8E=; b=kdAQGjruXU5qHIrhsPl6xgeP28PFNPUMthiBjwn9KIQlLBuc6CQ9m9Sjm9M8mYrnvz UUA4nVRcOjQrlhE1n85jTp6RSDORPwDmRDaXBWb8VP4zUMi+KOnV6gmZerqt4lG3rkdw RYSB9UNlSy35GNUWPc1I45VzuLSYTIoTXE0wPrZvC/N8bW0iZpLkidwjiCLwpFvYBJBL 7x2u5IBqQKFWDpp+kJXZ+zzZoxSjH4yp9w8vaRnSGvEUe/arrRQZCKjyQf1JxQ9Rq2Wr m8nvh9F+lltqSzGxfwpxQyliKpBC3yo77MlQInoVgqOlcXDJVB6XQdOo6dm9aL578h5Y onzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Qzt8gTSQJAKdqeFXhN/sDIMcpXV4uRz3cIgooC7aD8E=; b=hT90JoGW9IScteKwUB6a23Thlqxv65fkWH8+H15saklcIjjTIkZJqOn6OLT1sX1mP+ pz9EevMzpn+CAI6DNfQWImqNRwCMyG4Zm4OQtBLkaHfKDNwJj1baXHPXqK11YfuWjqql CnFKMjKCP0TjbD4ENQJvgyGh6UhzZs9qMQ4mVbP7jlz7XDwsYl19VzO/210QcmcvPL8r k5eRe0y5yCjy53KZUTKNmR5PkHBL8SaFfpJKKwJaD2XDl/T7DGrbrVxaZpD17dQnPSp+ 7Ge5K7u5mHrGIN1CSKHSJrhsEAQlNKuz/YwWb9CWiLKotRIw1/0/k0pRw+8lS++pT0OP y/CQ== X-Gm-Message-State: AKS2vOw0EJPK23ZBKFA6XAH3gIPNQ+GoAzXHnFi2Ke4i0jnbOzA0ocXz 5GIQzGto6T4VDUIF X-Received: by 10.107.164.207 with SMTP id d76mr4323910ioj.158.1498520949664; Mon, 26 Jun 2017 16:49:09 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id b17sm668036itd.0.2017.06.26.16.49.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Jun 2017 16:49:08 -0700 (PDT) From: npostavs@users.sourceforge.net References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> Date: Mon, 26 Jun 2017 19:50:45 -0400 In-Reply-To: <87lgoedf1t.fsf@utexas.edu> (Alex Branham's message of "Mon, 26 Jun 2017 16:00:46 +0200") Message-ID: <87efu6nwa2.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Alex Branham writes: > Here's a new patch that checks the region directly, ignoring `use-empty-active-region'. Looks good, I'll push in a few days. You haven't assigned copyright, have you? From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2017 05:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.149854153429330 (code B ref 27341); Tue, 27 Jun 2017 05:33:02 +0000 Received: (at 27341) by debbugs.gnu.org; 27 Jun 2017 05:32:14 +0000 Received: from localhost ([127.0.0.1]:39845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPj6k-0007d0-Gg for submit@debbugs.gnu.org; Tue, 27 Jun 2017 01:32:14 -0400 Received: from mail-qt0-f176.google.com ([209.85.216.176]:36259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPj6i-0007cj-Sb for 27341@debbugs.gnu.org; Tue, 27 Jun 2017 01:32:13 -0400 Received: by mail-qt0-f176.google.com with SMTP id i2so16877930qta.3 for <27341@debbugs.gnu.org>; Mon, 26 Jun 2017 22:32:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=utexas-edu.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2OINwY3gicjwxWaUvMjjpbWZ7RekJW1IFvEH/JhzqW4=; b=wKMPlXv+oZPFhkJ+UbvOmbnd/sVr8eqI0xxtR1oBaYI4XydUXT9CAMUD1o+RHAoHvg 5m1b8TH2s7i+bxN1/7NOBhQZc29OI1x4xvFg9TS7Kav37iaSnK0W/Xum55WW/rLhWozD YKWPQXu1Upgk9pI5/Tc5pZzxHntqPKSASh3tmlxbOq+HdypMohfl5xgInMDwyk2XC0Wy RwC1kH1HunXuc8lty9RZg6lqI7kR+DdYih+aU/+jZ66WmAaZ0iLULpk4pjIuBjhROdRE 6m7LkL0V51+smCau557IEc13a5xlIP3Kv99H5FgkLHRHQgvXeag/V8YDTsUNbvu3r75/ AqjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2OINwY3gicjwxWaUvMjjpbWZ7RekJW1IFvEH/JhzqW4=; b=Str50EA9JvC0bnEPCFaQpa2FHyNuRClxesYiknUC2wThs6tmQojzc+9cQ3I5h0zGqI ktO/Xagha7h3rSFcQE48tFgum+VIN9VyucunCcHE26UfEeGAf2P1QMyBimzpA0RYEh9D WvWApCvVqun8c/EG9zsWot7bJLgce6ZedPFmhfBPWzJh5WVqXDt1Ct+StzTqgsXj6aFQ 55x2dXMyTI6HAfDU7iGgxMSw0lEymaadcojZGdBtHVnXJdrZxNjJTLWxxIkKMqxog3aU hMwsTnFXkHdfegIpY4m2/yiJTHYwhoIwpRKqurVLFsCR10iP00hD73h/VECf0tMF/OFj fMFw== X-Gm-Message-State: AKS2vOzxymrWHK4RW58bhYHelI04G1tcqep91o0uibyQ9lJP250YLSbY g73tdUPtGIGxlnfnky0KHoKJ7fLds69O X-Received: by 10.237.41.225 with SMTP id o88mr364627qtd.27.1498541527121; Mon, 26 Jun 2017 22:32:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.32.101 with HTTP; Mon, 26 Jun 2017 22:32:06 -0700 (PDT) Received: by 10.237.32.101 with HTTP; Mon, 26 Jun 2017 22:32:06 -0700 (PDT) In-Reply-To: <87efu6nwa2.fsf@users.sourceforge.net> References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> From: Alex Branham Date: Tue, 27 Jun 2017 07:32:06 +0200 Message-ID: Content-Type: multipart/alternative; boundary="94eb2c12542a67d06b0552ea6342" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --94eb2c12542a67d06b0552ea6342 Content-Type: text/plain; charset="UTF-8" No, I haven't. Do I need to for something this small? Happy to do so if it's necessary. Alex On Jun 27, 2017 1:49 AM, wrote: > Alex Branham writes: > > > Here's a new patch that checks the region directly, ignoring > `use-empty-active-region'. > > Looks good, I'll push in a few days. You haven't assigned copyright, > have you? > --94eb2c12542a67d06b0552ea6342 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
No, I haven't. Do I need to for something this small?= Happy to do so if it's necessary.=C2=A0

Alex

On Jun 27, 2017 1:49 AM, <npostavs@users.sourceforge.net> wrote:
Alex Branham <branham@utexas.edu> writes:

> Here's a new patch that checks the region directly, ignoring `use-= empty-active-region'.

Looks good, I'll push in a few days.=C2=A0 You haven't assigned cop= yright,
have you?
--94eb2c12542a67d06b0552ea6342-- From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2017 13:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.149856981024869 (code B ref 27341); Tue, 27 Jun 2017 13:24:01 +0000 Received: (at 27341) by debbugs.gnu.org; 27 Jun 2017 13:23:30 +0000 Received: from localhost ([127.0.0.1]:40160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPqSn-0006T2-Kt for submit@debbugs.gnu.org; Tue, 27 Jun 2017 09:23:29 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:35259) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPqSl-0006Sp-Ie for 27341@debbugs.gnu.org; Tue, 27 Jun 2017 09:23:28 -0400 Received: by mail-lf0-f53.google.com with SMTP id b207so17084928lfg.2 for <27341@debbugs.gnu.org>; Tue, 27 Jun 2017 06:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=utexas-edu.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=fFBKVARbJLrwPK3Rc7T7SwnR0QfQTVv4k7QilLvLuKg=; b=WN9Bw74GHTjsbAwYOvLiRSMxfvIh68gU44hWfRG2sBjygmgE1jKOkQScitG4RsHu0x BFQcgqV0igFoxaQe1YatSbwaWJm2zMg3auI0M53IfGRLAnktiXVjIpiDempwR0alf/DL OjCWtkKWbkOA+8DB8ShX7KCIyWXUrzGP45OiJj5jOHc2YMRNClf+3xPTLpcrCKzIrv0Q eqLGjxr7BAisiRnHmGSPlO86vH+SY8tkTsp/ChSuGfZqJSBnqvskdxR5RqtnM1LegXXA Wqtfh6DtyS8Um8JGhIYowb29KLqC1Kp87OKbja1AVserTltp4Rfkn1dTtQIn93NbcyRh ZI5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=fFBKVARbJLrwPK3Rc7T7SwnR0QfQTVv4k7QilLvLuKg=; b=czPtn2D+BJ0+J8lLFGcbIa7DzhZoBP9PfWv2SylkynG3z5TrCTrAflLjh5oD4JYnMc g8IadH8/UblptK5zIBrgaTlPYFj0Ya8ooJQNyUHysizx05wzmYLCw86T6iX/APkT+UwK 6IT13LFGl9terGm/QYVLFYLFZODQ1yuY0LYjfsMihy/QdapCvqSLSBIFt0pD0h2DCG60 Wh7wbO54BinQnfg9NP0bt799gTuLteCEKGqdlzlxsv1R/79Nle0JA78yFUIr65mrgLyo 9/Unc4gV2pIQewUVvRRCNtW+V/ode+dBe3vNW1HRs0nMcolx4FKDVicCUYLmgtP8BhVN LloQ== X-Gm-Message-State: AKS2vOwKg+uh1k2625J+2XeISkx5SIyHvyE98VZlQ0jiZ+JEr64ccj/z 0RB+rhyF05qod5QmSBM= X-Received: by 10.46.74.1 with SMTP id x1mr1614248lja.27.1498569801096; Tue, 27 Jun 2017 06:23:21 -0700 (PDT) Received: from mars (edu220107.eduroam.gu.se. [130.241.220.107]) by smtp.gmail.com with ESMTPSA id v28sm650321ljd.17.2017.06.27.06.23.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Jun 2017 06:23:19 -0700 (PDT) References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Alex Branham In-reply-to: Date: Tue, 27 Jun 2017 15:23:17 +0200 Message-ID: <878tkdy37e.fsf@utexas.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain Actually, we need to check (use-region-p) anyway in case the mark hasn't been activated yet in the buffer: >From 685f3d0d2bfea7b3d6aad03d46a247fac25702d0 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 27 Jun 2017 15:20:27 +0200 Subject: [PATCH] eww-search-words prompt for query if region inactive or blank --- lisp/net/eww.el | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fe31657914..a90caa7fc4 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -314,9 +314,16 @@ word(s) will be searched for via `eww-search-prefix'." ;;;###autoload (defun eww-search-words (&optional beg end) "Search the web for the text between BEG and END. -See the `eww-search-prefix' variable for the search engine used." + If region is active (and not whitespace), search the web for + the text between BEG and END. Else, prompt the user for a search + string. See the `eww-search-prefix' variable for the search + engine used." (interactive "r") - (eww (buffer-substring beg end))) + (if (use-region-p) + (let ((region-string (buffer-substring beg end))) + (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) + (eww region-string))) + (eww (read-string "Query: ")))) (defun eww-open-in-new-buffer () "Fetch link at point in a new EWW buffer." -- 2.13.2 On Tue 27 Jun 2017 at 05:32, Alex Branham wrote: > No, I haven't. Do I need to for something this small? Happy to do so if > it's necessary. > > Alex > > On Jun 27, 2017 1:49 AM, wrote: > >> Alex Branham writes: >> >> > Here's a new patch that checks the region directly, ignoring >> `use-empty-active-region'. >> >> Looks good, I'll push in a few days. You haven't assigned copyright, >> have you? >> --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0004-eww-search-words-prompt-user-for-query-if-region-inactive.patch >From 685f3d0d2bfea7b3d6aad03d46a247fac25702d0 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Tue, 27 Jun 2017 15:20:27 +0200 Subject: [PATCH] eww-search-words prompt for query if region inactive or blank --- lisp/net/eww.el | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fe31657914..a90caa7fc4 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -314,9 +314,16 @@ word(s) will be searched for via `eww-search-prefix'." ;;;###autoload (defun eww-search-words (&optional beg end) "Search the web for the text between BEG and END. -See the `eww-search-prefix' variable for the search engine used." + If region is active (and not whitespace), search the web for + the text between BEG and END. Else, prompt the user for a search + string. See the `eww-search-prefix' variable for the search + engine used." (interactive "r") - (eww (buffer-substring beg end))) + (if (use-region-p) + (let ((region-string (buffer-substring beg end))) + (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) + (eww region-string))) + (eww (read-string "Query: ")))) (defun eww-open-in-new-buffer () "Fetch link at point in a new EWW buffer." -- 2.13.2 --=-=-=-- From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2017 14:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 27341@debbugs.gnu.org, npostavs@users.sourceforge.net Reply-To: Eli Zaretskii Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.149857447732724 (code B ref 27341); Tue, 27 Jun 2017 14:42:01 +0000 Received: (at 27341) by debbugs.gnu.org; 27 Jun 2017 14:41:17 +0000 Received: from localhost ([127.0.0.1]:40962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPrg5-0008Vk-7L for submit@debbugs.gnu.org; Tue, 27 Jun 2017 10:41:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPrg3-0008VV-MU for 27341@debbugs.gnu.org; Tue, 27 Jun 2017 10:41:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPrfv-0002d3-N7 for 27341@debbugs.gnu.org; Tue, 27 Jun 2017 10:41:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPrfv-0002cW-Jt; Tue, 27 Jun 2017 10:41:07 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4388 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dPrfu-0008D9-NI; Tue, 27 Jun 2017 10:41:07 -0400 Date: Tue, 27 Jun 2017 17:40:55 +0300 Message-Id: <838tkdsdc8.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Alex Branham on Tue, 27 Jun 2017 07:32:06 +0200) References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Alex Branham > Date: Tue, 27 Jun 2017 07:32:06 +0200 > Cc: 27341@debbugs.gnu.org > > No, I haven't. Do I need to for something this small? Happy to do so if it's necessary. No, you don't. But it's good to start the ball rolling anyway, so that we could accept your future contributions without limitations. Thanks. From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jun 2017 00:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.14987839542418 (code B ref 27341); Fri, 30 Jun 2017 00:53:01 +0000 Received: (at 27341) by debbugs.gnu.org; 30 Jun 2017 00:52:34 +0000 Received: from localhost ([127.0.0.1]:45204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQkAj-0000cv-NR for submit@debbugs.gnu.org; Thu, 29 Jun 2017 20:52:33 -0400 Received: from mail-io0-f171.google.com ([209.85.223.171]:36681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQkAh-0000cl-WF for 27341@debbugs.gnu.org; Thu, 29 Jun 2017 20:52:32 -0400 Received: by mail-io0-f171.google.com with SMTP id z62so16388258ioi.3 for <27341@debbugs.gnu.org>; Thu, 29 Jun 2017 17:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/hJYBDsfx5HVorA1edeV3SLuWOLDSrxfWGLYlIwlToo=; b=J0AZHOX8oxuEuaLfL8bdYol9RPFclBd6gUHzecvgXsYgm16Ilvox99UnV7aIbNmJMP IFlifqaoTrOze3qE8JLDay+/vPaDZ3cK1CH4FrMd0jqNTFsIkrPWqDIsnHW8fq57M56e Njm0pJifqy/1B7TUGQtEpI4STI9vLxghVIoq1ZiA0HQHtNDNVKIJ93ijxyR3CLFudLd9 PL4vYvjeRBfjv6wPMBDXxGrXxVNhc8ZRB0vhvJDM8J93+e0a36pWRHE58gz8EgHjDjRR Tvq7ELQJks2/ASi4loOlv1RE4Folg2my3h7UvvNkKPNTva4RWhcOAA6TwIv482QUu2Hc pOZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=/hJYBDsfx5HVorA1edeV3SLuWOLDSrxfWGLYlIwlToo=; b=t+5FKLXW8A45kD4s4cxdrWOjukVG7rmOAhLSApFjWbLZ1d1EYJNCcWmwJOz2rroYa7 w5cCFd0GSqXmnV5KN86/Asc0EIWTe6y1sgeDArJzAevI2xNKnm3c5KhSVs+kq69pJoSU 8f0ezHB4Em0Y6K+25JxRtO3jU6w8WWqiLYKmgi1dKGjaCtqxYNzv1w4a2CS47ff1kLit Q7wjd8dkjP7Oid2tm6WT3H+oC/Gm08yUu4p889pzcJ+hSPRev0nyESy0EzRvPMBjY7AT A5s2rfmirOSjyePLzwEEICqkFVvGHDXJCwmq3mGjVB6kIE2UMinMyaVAH/bEf+Ow9UnR jZOw== X-Gm-Message-State: AKS2vOw7PhBGOJk+FOudaQxn0Ct+3Uxr0xQ8ENCIsDZ5+uSfHqYWdBEZ Wp68hlqJms82/4NT X-Received: by 10.107.32.197 with SMTP id g188mr21704199iog.146.1498783946300; Thu, 29 Jun 2017 17:52:26 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 66sm1344391itj.1.2017.06.29.17.52.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Jun 2017 17:52:25 -0700 (PDT) From: npostavs@users.sourceforge.net References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> <878tkdy37e.fsf@utexas.edu> Date: Thu, 29 Jun 2017 20:54:02 -0400 In-Reply-To: <878tkdy37e.fsf@utexas.edu> (Alex Branham's message of "Tue, 27 Jun 2017 15:23:17 +0200") Message-ID: <874luymh1x.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Alex Branham writes: > Actually, we need to check (use-region-p) anyway in case the mark > hasn't been activated yet in the buffer: Oops, good catch, I hadn't thought of that. > Subject: [PATCH] eww-search-words prompt for query if region inactive or blank > > --- Could you add a ChangeLog entry to the commit message as described in CONTRIBUTE, please? > (defun eww-search-words (&optional beg end) > "Search the web for the text between BEG and END. > -See the `eww-search-prefix' variable for the search engine used." > + If region is active (and not whitespace), search the web for > + the text between BEG and END. Else, prompt the user for a search > + string. See the `eww-search-prefix' variable for the search > + engine used." Doc strings shouldn't be indented like that, and there should be a double space between sentences. > (interactive "r") > - (eww (buffer-substring beg end))) > + (if (use-region-p) > + (let ((region-string (buffer-substring beg end))) > + (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) > + (eww region-string))) > + (eww (read-string "Query: ")))) This silently does nothing if the region is active but just blanks, did you mean to fallback to querying in that case? From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jun 2017 06:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.149880396921784 (code B ref 27341); Fri, 30 Jun 2017 06:27:01 +0000 Received: (at 27341) by debbugs.gnu.org; 30 Jun 2017 06:26:09 +0000 Received: from localhost ([127.0.0.1]:45373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQpNY-0005fI-LA for submit@debbugs.gnu.org; Fri, 30 Jun 2017 02:26:08 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:35436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQpNX-0005f5-9B for 27341@debbugs.gnu.org; Fri, 30 Jun 2017 02:26:08 -0400 Received: by mail-lf0-f53.google.com with SMTP id b207so64441899lfg.2 for <27341@debbugs.gnu.org>; Thu, 29 Jun 2017 23:26:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=utexas-edu.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=fYdF7WEELhfxmrdiUqIQaTL36KIFJf9f9n7PcL0EyDo=; b=WWQhgyv9WqXiUFM4XqfCKu26i9sYNEbuT9JpgoteFSwe5EoGq/BtNFK+ps1kddtAs1 urQVnCIkD4O64o0tfsQObosXHTtgUq1JblXBSBAwx1hg9oSjOJd0z5sLm/id2sXPc/ps +HCjhobOWfjNXkB2+Urzt4k4lGbEGG1C5lgjTD4blfREoZE3TplEPkZY9awIwuptmW3u tUsB2W1nbk+aEH6q/iUpb/+AM/yGY2R6TshkAeTqaHHph+QIkEgn7jf6wlv/TLfrEYzP 99X4oyi7HR500LYjs1bGsU25hqsfJYwtJwPr8lpJJwLXHKWdKEasuIFMiqfLep+fN41p LuCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=fYdF7WEELhfxmrdiUqIQaTL36KIFJf9f9n7PcL0EyDo=; b=kHLBGAdUac9YPwRReGg9u8Y6vTEz1T83QPpXLN+4LghyVNMOkIBCwj8wt7Iv2jrBCN Ks2EnByd+Wr2P/YRV71wswiVjdcsntsXaKGnxV+UiFRtwNTjKEgvCaV8ggal/XLcE59P 1C/thuWZX0/70nHqSexMKiFx4SZkGZZ3Bx2jcCoQdZOZ6an3hLBXdLF9oLEducSjkdcr a4X/Kl4DYpgXw8DPAQPA8xycJaaIYn4i7QCssbfrnB00Ts6usPVBuBNFngr7VGwWqHEk d32lRHzu8tFRMO226rxQPHesquPQKTJF1cFt9KfPQI0+nSXHMQoCDNPEGM6gd4HkcYF6 D0Hg== X-Gm-Message-State: AIVw113NC9LhaqCl/gXbTg1ZkdxtYKJNjFgwQJfWwu2Alwz6Zj6dMejg 0MoZTQSeK0SD9XaOPlc= X-Received: by 10.25.216.82 with SMTP id p79mr70186lfg.35.1498803960997; Thu, 29 Jun 2017 23:26:00 -0700 (PDT) Received: from mars (edu220107.eduroam.gu.se. [130.241.220.107]) by smtp.gmail.com with ESMTPSA id j12sm816784lfh.23.2017.06.29.23.25.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Jun 2017 23:25:59 -0700 (PDT) References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> <878tkdy37e.fsf@utexas.edu> <874luymh1x.fsf@users.sourceforge.net> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Alex Branham In-reply-to: <874luymh1x.fsf@users.sourceforge.net> Date: Fri, 30 Jun 2017 08:25:58 +0200 Message-ID: <87bmp63sax.fsf@utexas.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain On Fri 30 Jun 2017 at 00:54, npostavs@users.sourceforge.net wrote: > Could you add a ChangeLog entry to the commit message as described in > CONTRIBUTE, please? Yes, I have done so. Let me know if it's not right. > >> (defun eww-search-words (&optional beg end) >> "Search the web for the text between BEG and END. >> -See the `eww-search-prefix' variable for the search engine used." >> + If region is active (and not whitespace), search the web for >> + the text between BEG and END. Else, prompt the user for a search >> + string. See the `eww-search-prefix' variable for the search >> + engine used." > > Doc strings shouldn't be indented like that, and there should be a > double space between sentences. Fixed. > >> (interactive "r") >> - (eww (buffer-substring beg end))) >> + (if (use-region-p) >> + (let ((region-string (buffer-substring beg end))) >> + (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) >> + (eww region-string))) >> + (eww (read-string "Query: ")))) > > This silently does nothing if the region is active but just blanks, did > you mean to fallback to querying in that case? Fixed, thanks --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0005-Make-eww-search-words-prompt-for-query-if-nothing-se.patch >From 1d036b16903dd18268c499c4617d430172b08ffe Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Fri, 30 Jun 2017 08:16:13 +0200 Subject: [PATCH] Make eww-search-words prompt for query if nothing selected * lisp/net/eww.el (eww-search-words): Make eww-search-words prompt the user for a search query if the region is inactive or if the region is just whitespace. Copyright-paperwork-exempt: yes --- lisp/net/eww.el | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fe31657914..757e738a18 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -314,9 +314,17 @@ word(s) will be searched for via `eww-search-prefix'." ;;;###autoload (defun eww-search-words (&optional beg end) "Search the web for the text between BEG and END. -See the `eww-search-prefix' variable for the search engine used." +If region is active (and not whitespace), search the web for +the text between BEG and END. Else, prompt the user for a search +string. See the `eww-search-prefix' variable for the search +engine used." (interactive "r") - (eww (buffer-substring beg end))) + (if (use-region-p) + (let ((region-string (buffer-substring beg end))) + (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) + (eww region-string) + (eww (read-string "Query: ")))) + (eww (read-string "Query: ")))) (defun eww-open-in-new-buffer () "Fetch link at point in a new EWW buffer." -- 2.13.2 --=-=-=-- From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2017 18:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.14990202825564 (code B ref 27341); Sun, 02 Jul 2017 18:32:01 +0000 Received: (at 27341) by debbugs.gnu.org; 2 Jul 2017 18:31:22 +0000 Received: from localhost ([127.0.0.1]:48995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRjeT-0001Rg-O9 for submit@debbugs.gnu.org; Sun, 02 Jul 2017 14:31:21 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:33359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRjeS-0001RR-9N for 27341@debbugs.gnu.org; Sun, 02 Jul 2017 14:31:20 -0400 Received: by mail-io0-f177.google.com with SMTP id h64so45089246iod.0 for <27341@debbugs.gnu.org>; Sun, 02 Jul 2017 11:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=sd1mfv0OT9qzynXn743DyvKMDSd6RmG7TOU9cEMU7go=; b=mZx+DnG1tVRmuUtLLk+KNkiqL2dyvOlTOXRU0t9WiC9IuOw7Pp/apMOBsIt+DxQuI4 xADPIr1dwRrv23Yp+dtbzFDItcksrIxOFVyoVsNkOdJOE4WEbpIDA1rY3XoUhMWCCJAs F5qLo7d9mOiyqnTF7ZCKZkr1IaLw+Sew1/U0wNO2qb5qATOfZ7g9YdpYEoR1/k7oBwrr WMtJaRSzvWSffoC4vY7jB0lPa9LbeSwhahphSnI/d5EIzwUNRVebV4e80tAK9R2Hjp7p y+6+R9df9HxZoagqQ1QhLdEzYX/1pDytKsa/i+1jhfW7SUVE+ih8h7UGb0WuKLOzUR5/ q9xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=sd1mfv0OT9qzynXn743DyvKMDSd6RmG7TOU9cEMU7go=; b=PphXf4/aG8NUNCPzXB9lzXWcRP5WrTIPAJ28XaPiQxZIczQ9Q+a5GFGRRKRfEzUMzh t7CY7R1hQuXK2T8FChAw4HL8Yqo1Ol6kba9ODlg7qpD6iH5TSYJhmXtOUKyfwEa5/c30 1dWstYt2Xlp5gFak1ygE6ANcYiCEZ7PsKHPtzDLNXGRj7bZLmGUB+KQePtNB+77bfWOk fsXj8FaTIZzyC43uUlikTkmugeSjF0f4WecjjTldLC/Q+s9xf+tpCA2WZHbvNMhA4mkt CbUc9TeODarMuT64nKuHk3Kl3ffpkjUeaVtb2DvemElTod039U+o+sCyg3WJCCSJZh3o 7jRQ== X-Gm-Message-State: AKS2vOw/3jIO43KcdZw/wmuMP6twoLBR5ZlqmXVGjPCf/o8vyN9LC724 VDAtIqUpzKn5gDfx X-Received: by 10.107.22.2 with SMTP id 2mr33895810iow.32.1499020274473; Sun, 02 Jul 2017 11:31:14 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id t5sm1652413ita.22.2017.07.02.11.31.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 Jul 2017 11:31:13 -0700 (PDT) From: npostavs@users.sourceforge.net References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> <878tkdy37e.fsf@utexas.edu> Date: Sun, 02 Jul 2017 14:32:50 -0400 In-Reply-To: <878tkdy37e.fsf@utexas.edu> (Alex Branham's message of "Tue, 27 Jun 2017 15:23:17 +0200") Message-ID: <87zicmk7u5.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Alex Branham writes: > On Fri 30 Jun 2017 at 00:54, npostavs@users.sourceforge.net wrote: > >> Could you add a ChangeLog entry to the commit message as described in >> CONTRIBUTE, please? > > Yes, I have done so. Let me know if it's not right. Looks good, thanks. >> Doc strings shouldn't be indented like that, and there should be a >> double space between sentences. > > Fixed. You missed the double spacing before the "Else,". > Actually, we need to check (use-region-p) anyway in case the mark > hasn't been activated yet in the buffer: Hmm, I just tried this and it doesn't quite do the job. I believe the problem is that the (interactive "r") form throws an error when the mark hasn't been activated yet. To handle this case correctly you need to replace the "r" with some lisp code that produces the argument list. From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2017 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.14990211606876 (code B ref 27341); Sun, 02 Jul 2017 18:46:02 +0000 Received: (at 27341) by debbugs.gnu.org; 2 Jul 2017 18:46:00 +0000 Received: from localhost ([127.0.0.1]:49005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRjse-0001mp-8i for submit@debbugs.gnu.org; Sun, 02 Jul 2017 14:46:00 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:35523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRjsc-0001mc-45 for 27341@debbugs.gnu.org; Sun, 02 Jul 2017 14:45:58 -0400 Received: by mail-lf0-f44.google.com with SMTP id b207so92100874lfg.2 for <27341@debbugs.gnu.org>; Sun, 02 Jul 2017 11:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=utexas-edu.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=SGPqo9wpVa34hw5p6ElGDV+31R3qJfkB5HZQ/HnjcTE=; b=L8A3LnSYuumBq3UX/zArp6KVXfz3kPNrt6QvjBvsBZ9e5cangS09Xyx1EU4JGLlvtJ uDYiKQPHcmVYKzDA+mQtAQRLxroACRgdNnZfjWBDELf2k2M3qUiza+U5yZCd5sEOfVr2 p9c4xng5b8C/iSJ0khCHCrl/1bCl2CLqUNjFTzFjr/thH/FJ5l7Rf/KLPMacPnCEKURr 2HqSVgelM74nlN2Ur/d7D5QxDjGiYGgc6wI8mHObLTEkDcTHvx8yvHR/lZerhhPvgiwf 9hzHTsd7W6l27YOGhbbrnAGnRbl7AKwkGypoA4w6ePwdTLNNP2I5WgNAOx3Ua+7MZo/1 1ZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=SGPqo9wpVa34hw5p6ElGDV+31R3qJfkB5HZQ/HnjcTE=; b=uHaxfDig3ADeSvfEo0Rvk66vJryAUISezFyF/BXoklmm3O5pGzzIIsoPKPVZkwwmMG c4QsMuXy9Fxe9bXyEzOeihtErPUdrD6C20ZQ3ThEyGt/AP34+b+zh9BVRLFRt0QY1aD+ TJhQ/8wTXo4daNB9zWHfq8wrEpFXkbSjGXlrU2kCcdTzzG/3N+E/a5waJGk3F7N9lZS2 iOnr30pUbMHHRqHd6Wsg7GkrIDSU3IGEsXoEOKkNMxF37ktaQHQzOJC/JNuGHOZ/CJlx yvazhF5xpjdsCUHeilME0Yg+/gVOuNWmaKPOniuwxDH3NjAI674nZmxxXY2NNBnHC5Ia r4cw== X-Gm-Message-State: AKS2vOwOFneSotNvpYb/et7laJg2JZlw+8X3FSN0s93QKi6AsulQpcNk GPrfQAg254cLGpGNF5A= X-Received: by 10.25.209.20 with SMTP id i20mr8747623lfg.41.1499021151608; Sun, 02 Jul 2017 11:45:51 -0700 (PDT) Received: from mars (edu220107.eduroam.gu.se. [130.241.220.107]) by smtp.gmail.com with ESMTPSA id h74sm2013281lfh.31.2017.07.02.11.45.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 Jul 2017 11:45:50 -0700 (PDT) References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> <878tkdy37e.fsf@utexas.edu> <87zicmk7u5.fsf@users.sourceforge.net> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Alex Branham In-reply-to: <87zicmk7u5.fsf@users.sourceforge.net> Date: Sun, 02 Jul 2017 20:45:49 +0200 Message-ID: <87tw2u7k4i.fsf@utexas.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain On Sun 02 Jul 2017 at 18:32, npostavs@users.sourceforge.net wrote: > Alex Branham writes: > >> On Fri 30 Jun 2017 at 00:54, npostavs@users.sourceforge.net wrote: > >>> Doc strings shouldn't be indented like that, and there should be a >>> double space between sentences. >> >> Fixed. > > You missed the double spacing before the "Else,". D'oh! Fixed this time, sorry! >> Actually, we need to check (use-region-p) anyway in case the mark >> hasn't been activated yet in the buffer: > > Hmm, I just tried this and it doesn't quite do the job. I believe the > problem is that the (interactive "r") form throws an error when the mark > hasn't been activated yet. To handle this case correctly you need to > replace the "r" with some lisp code that produces the argument list. Ok, now I don't use "r" and just get the region directly. I think that'll do the trick? Thanks, Alex --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0006-Make-eww-search-words-prompt-for-query-if-nothing-se.patch >From 9dc5deec743d827e6d099f0f46b257ab8e7142c1 Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Sun, 2 Jul 2017 20:43:12 +0200 Subject: [PATCH] Make eww-search-words prompt for query if nothing selected * lisp/net/eww.el (eww-search-words): Make eww-search-words prompt the user for a search query if the region is inactive or if the region is just whitespace. Copyright-paperwork-exempt: yes --- lisp/net/eww.el | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fe31657914..438f635c5e 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -314,9 +314,17 @@ word(s) will be searched for via `eww-search-prefix'." ;;;###autoload (defun eww-search-words (&optional beg end) "Search the web for the text between BEG and END. -See the `eww-search-prefix' variable for the search engine used." - (interactive "r") - (eww (buffer-substring beg end))) + If region is active (and not whitespace), search the web for + the text between BEG and END. Else, prompt the user for a search + string. See the `eww-search-prefix' variable for the search + engine used." + (interactive) + (if (use-region-p) + (let ((region-string (buffer-substring (region-beginning) (region-end)))) + (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) + (eww region-string) + (eww (read-string "Query: ")))) + (eww (read-string "Query: ")))) (defun eww-open-in-new-buffer () "Fetch link at point in a new EWW buffer." -- 2.13.2 --=-=-=-- From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2017 19:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.14990227229162 (code B ref 27341); Sun, 02 Jul 2017 19:13:01 +0000 Received: (at 27341) by debbugs.gnu.org; 2 Jul 2017 19:12:02 +0000 Received: from localhost ([127.0.0.1]:49009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRkHq-0002Nh-GI for submit@debbugs.gnu.org; Sun, 02 Jul 2017 15:12:02 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:35575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRkHo-0002NE-RJ for 27341@debbugs.gnu.org; Sun, 02 Jul 2017 15:12:01 -0400 Received: by mail-io0-f174.google.com with SMTP id h134so45396993iof.2 for <27341@debbugs.gnu.org>; Sun, 02 Jul 2017 12:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=3Sln+LkaV3QPL8QIw5Lvo6UOwBXuucKVbkJfRYcOR/0=; b=Jm7xoaFVceLCFL9Jp7Xb3qkLob9SRLxHOSmtXRHD1DmWeswGE7C6zNRdAkRdKYzmbA 4reafJ0vPnmRyyx1ZIEJ87YVKg+KUk1OZHFPuHmLHWs7CrLl8qErY8LWiZ3xiM7scN7r hCkGNkeR1X9DTmhtgkAf4NfadVKA70K7BcMW+dMT9Ep7j5T0266LtoxmLPZUsUNBVC1Y GjG7DmjZ0xrcEyt1xKYy0/rKuowi8KGtnP/uxMjwXcg02c8/7LNGqyqb5hFEegtQ40Gg gL+XODSyVQhcA7G4ZwKiO4P8WJxDXP3knG8SKlLs4OvPeOt7+dmWOimhwi/TeTrMVT32 hm0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=3Sln+LkaV3QPL8QIw5Lvo6UOwBXuucKVbkJfRYcOR/0=; b=FwqYCrECgs1phgGN6jta4iq/QwZZH7B8e7AhatGbIc4z2qEOAW8bRhjLueDbX6ZggX SeMbEe9VN5epTyyKvbqy8Yh346YU/+PNbNz+WYgz4+GduW3TOpJ7pUsPhgbwRJClXtTT 0nHFHC+etKk8nBTyyvm5x6zPe7IM3df/vBD9CnICYWFem7qWN9m5eTif2hlGXctinlaM wenD75OuUL1Q20xFdX9gmHg4SA8tWHTDxKbCo2EVHLaGJC8LmnxI9vy1b484Zj5tVYgQ q0vCtzUkpuR7i/rjUmpJHkRUWlM2r084m3wvNxBLD49iemgRvndjkP8MEdyIL/nNo2xv i7MQ== X-Gm-Message-State: AKS2vOw2uSEBbioKy2iamDNI+rxaEdRGOQNYVBTV+cXnsaOcMNaV8xwd l4vCYdvq7OuFlvcl X-Received: by 10.107.137.152 with SMTP id t24mr32875247ioi.218.1499022715022; Sun, 02 Jul 2017 12:11:55 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id s135sm9110376ita.2.2017.07.02.12.11.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 Jul 2017 12:11:54 -0700 (PDT) From: npostavs@users.sourceforge.net References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> <878tkdy37e.fsf@utexas.edu> <87zicmk7u5.fsf@users.sourceforge.net> <87tw2u7k4i.fsf@utexas.edu> Date: Sun, 02 Jul 2017 15:13:29 -0400 In-Reply-To: <87tw2u7k4i.fsf@utexas.edu> (Alex Branham's message of "Sun, 02 Jul 2017 20:45:49 +0200") Message-ID: <87wp7qk5ye.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Alex Branham writes: >> You missed the double spacing before the "Else,". > > D'oh! Fixed this time, sorry! Oh, the funny indentation came back, do you have some Emacs setting that's doing that? >>> Actually, we need to check (use-region-p) anyway in case the mark >>> hasn't been activated yet in the buffer: >> >> Hmm, I just tried this and it doesn't quite do the job. I believe the >> problem is that the (interactive "r") form throws an error when the mark >> hasn't been activated yet. To handle this case correctly you need to >> replace the "r" with some lisp code that produces the argument list. > > Ok, now I don't use "r" and just get the region directly. I think that'll= do the trick? Oh yeah, that works. We should try not to add compiler warnings though: ELC net/eww.elc In toplevel form: ../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument =E2=80=98end=E2=80=99 ../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument =E2=80=98beg=E2=80=99 I think we can just drop the arguments as well, lisp programs can always do (eww (buffer-substring BEG END)) instead. Do you think the prompt string should be a bit more detailed? "Query" seems a bit vague (e.g., consider if you hit M-s M-w by accident). Maybe we should just do (call-interactively 'eww) and then we'll get the prompt from there. From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2017 19:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.149902356610427 (code B ref 27341); Sun, 02 Jul 2017 19:27:02 +0000 Received: (at 27341) by debbugs.gnu.org; 2 Jul 2017 19:26:06 +0000 Received: from localhost ([127.0.0.1]:49022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRkVS-0002i7-9J for submit@debbugs.gnu.org; Sun, 02 Jul 2017 15:26:06 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:34497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRkVQ-0002hd-7M for 27341@debbugs.gnu.org; Sun, 02 Jul 2017 15:26:05 -0400 Received: by mail-lf0-f52.google.com with SMTP id l13so92470519lfl.1 for <27341@debbugs.gnu.org>; Sun, 02 Jul 2017 12:26:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=utexas-edu.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=A2iKWIxGNS85AfA4ecS/BKIx3THsAISDdCl05nV+yUM=; b=o3CRdGYn5+0nzVqRNKw7LACGvIf+PihbTPMF8K6R6/aUOK+ClAVLhZHvb1lxjKAiOw 0/oNQLWW8yftJJG4whYeYwoFRsWEoOLCb6bvveYwDDMeDCocyhPUWUayRLrp2IIPKPgW lE8W+L/viNgswkHj0DGHsULoHEadARfgrg3u1rmebf6Xc64XbOTjeXlSe2yYuFL68TsY rypjFHAhCvveiv91XK8j3JbovSJofpj8YmTkY5wl2vQhKK3MG59lMHtONBMeFK2pkemS 914Hli+osRVFhbFCroqqrXyOsV6pdewlSdTnSscqkM+EYW2im8Ht2WTkOYBR8bs7csVg a62A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=A2iKWIxGNS85AfA4ecS/BKIx3THsAISDdCl05nV+yUM=; b=ueSqzLdJQ7sTUlHKYbbltRlAiGctABtKmjaofYOVurbrOPCHfFl5ja0FW7p/XzqHjm VtW6fg/nSpljxSTbvQVnwi9KGBbUsNyEtYkrNTXFvI0dCz9H9rOsX8pQgY73hvIERTGh lC4iRiQRXvDo6xBms2SUSP4VIy3c1pX7QB2pv+9pGawdQDiqWIo/csIBbhyKS/tYNvbR PvdEz9yNGgzmYr0rYrDTpqgUOJ7xLfliihCrrBG+PKT5lTDYZK97/axTXUOBtCFwHo98 Vb4A83YfhRMAgeb5QSxhODNejdqybI4rfrL64htFJr8/tVVvcBQmqnCUIwVD7pK/kvmP UhAg== X-Gm-Message-State: AKS2vOyxl1vFCTeZjHAqg0q7FIU/q8fXRJkZlmldAj6u3uiUMSCUksLP +Qbp/rVUg7c+L5zbmmA= X-Received: by 10.46.92.137 with SMTP id q131mr9131110ljb.124.1499023557774; Sun, 02 Jul 2017 12:25:57 -0700 (PDT) Received: from mars (edu220107.eduroam.gu.se. [130.241.220.107]) by smtp.gmail.com with ESMTPSA id d203sm3051175lfg.59.2017.07.02.12.25.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 Jul 2017 12:25:56 -0700 (PDT) References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> <878tkdy37e.fsf@utexas.edu> <87zicmk7u5.fsf@users.sourceforge.net> <87tw2u7k4i.fsf@utexas.edu> <87wp7qk5ye.fsf@users.sourceforge.net> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Alex Branham In-reply-to: <87wp7qk5ye.fsf@users.sourceforge.net> Date: Sun, 02 Jul 2017 21:25:56 +0200 Message-ID: <87shie7i9n.fsf@utexas.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On Sun 02 Jul 2017 at 19:13, npostavs@users.sourceforge.net wrote: > Alex Branham writes: > >>> You missed the double spacing before the "Else,". >> >> D'oh! Fixed this time, sorry! > > Oh, the funny indentation came back, do you have some Emacs setting > that's doing that? Ugh. Fixed. I think it has to do with how I'm copy/pasting from my own init file. >> Ok, now I don't use "r" and just get the region directly. I think that'll do the trick? > > Oh yeah, that works. We should try not to add compiler warnings though: > > ELC net/eww.elc > > In toplevel form: > ../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument > ‘end’ > ../../emacs-master/lisp/net/eww.el:315:1:Warning: Unused lexical argument > ‘beg’ > > I think we can just drop the arguments as well, lisp programs can always > do (eww (buffer-substring BEG END)) instead. Dropped. > Do you think the prompt string should be a bit more detailed? "Query" > seems a bit vague (e.g., consider if you hit M-s M-w by accident). > Maybe we should just do (call-interactively 'eww) and then we'll get the > prompt from there. Yes, that's much better. Done, thanks. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0007-Make-eww-search-words-prompt-for-query-if-nothing-se.patch >From 71e4329943541325f59a224b494e5ca82f07fdef Mon Sep 17 00:00:00 2001 From: Alex Branham Date: Sun, 2 Jul 2017 21:18:47 +0200 Subject: [PATCH] Make eww-search-words prompt for query if nothing selected * lisp/net/eww.el (eww-search-words): Make eww-search-words prompt the user for a search query if the region is inactive or if the region is just whitespace. Copyright-paperwork-exempt: yes --- lisp/net/eww.el | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index fe31657914..2fc36e180e 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -312,11 +312,19 @@ word(s) will be searched for via `eww-search-prefix'." (expand-file-name file)))) ;;;###autoload -(defun eww-search-words (&optional beg end) +(defun eww-search-words () "Search the web for the text between BEG and END. -See the `eww-search-prefix' variable for the search engine used." - (interactive "r") - (eww (buffer-substring beg end))) +If region is active (and not whitespace), search the web for +the text between BEG and END. Else, prompt the user for a search +string. See the `eww-search-prefix' variable for the search +engine used." + (interactive) + (if (use-region-p) + (let ((region-string (buffer-substring (region-beginning) (region-end)))) + (if (not (string-match-p "\\`[ \n\t\r\v\f]*\\'" region-string)) + (eww region-string) + (call-interactively 'eww))) + (call-interactively 'eww))) (defun eww-open-in-new-buffer () "Fetch link at point in a new EWW buffer." -- 2.13.2 --=-=-=-- From unknown Fri Sep 05 11:01:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27341: updated patch to fix docstring Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2017 20:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Alex Branham Cc: 27341@debbugs.gnu.org Received: via spool by 27341-submit@debbugs.gnu.org id=B27341.149902693022500 (code B ref 27341); Sun, 02 Jul 2017 20:23:02 +0000 Received: (at 27341) by debbugs.gnu.org; 2 Jul 2017 20:22:10 +0000 Received: from localhost ([127.0.0.1]:49091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRlNi-0005qq-ES for submit@debbugs.gnu.org; Sun, 02 Jul 2017 16:22:10 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:36850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRlNf-0005qS-W5; Sun, 02 Jul 2017 16:22:08 -0400 Received: by mail-io0-f196.google.com with SMTP id h134so7254411iof.3; Sun, 02 Jul 2017 13:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=tENHHlyx9DjQULIc9r7OQJ44hiShM7V1BHYvI3BN6wo=; b=DFql9+ub+RQKSNojwqmhlTpaj5d2rR845o9lsVo0MTePmDnO2J73SojF8DJdjhlCjH w9JH2hfmJfkdprudMrNmQ+oSKdv7SH1ceSvXTLYX8Yso/DlkGoLYvrgy/K86I41zPfrk 2UxzAx1yb6ZXz3gBoU0YcNYB8pltwhWq9aNm3QjS5778j+5IJMOHgcb86nZTcWGOrTLj 2vEUZbQTA6eB5zL5v17RSy4ATe59p0rF3pTvouSLKjbgrLLJB2IVMnyW81Hwrs2qz4Qs kQTMDyeI5++xZ3Q37PBrQgQQIUtZe6M1dMbbnmILfNhTYjbVAYfx/Il9sn/1qFF2GIDJ bFFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=tENHHlyx9DjQULIc9r7OQJ44hiShM7V1BHYvI3BN6wo=; b=bMa3YkidjC6cMGeqdPgMNjuW0y6WdL8dNUv5F7VSq7idcASffq/+jcpt6O2zqfbsAl mxZGCgfWNCCjTO9EreV8DI52XsIj9mouMD2ZLdivynzkBioa93yiLZqKQUQMfiqFtrfR 1fRBj/0fzOGq3bqa0AiPw/NC1y33+8KrhTfYv4QGPc2JahfSZIHPYlXXzNVdRxUJ12Il bRV9GPCx68k2Q7uFkirP8+9ItcX8519YzMx/6Se1VCukGnUB9+USlmokFKqRgOgRCtcB sdhQ7TCZuDXNTqO2OxbB1e5rKYZ5a5EReuQ1qQAsCUXAuFB/obpRMXGQyMY7dA7VcC7M cIhA== X-Gm-Message-State: AIVw112WLwsRsu7csyusZnzqrpko7FoUozMk1M8v8GfiGspWK7L2lGTF bbiJo286qiCIUuIz X-Received: by 10.107.18.140 with SMTP id 12mr2700554ios.119.1499026922355; Sun, 02 Jul 2017 13:22:02 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id k79sm9072835itk.26.2017.07.02.13.22.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 Jul 2017 13:22:01 -0700 (PDT) From: npostavs@users.sourceforge.net References: <8760g1xxhw.fsf@utexas.edu> <8737b4grzq.fsf@utexas.edu> <8737aop2d9.fsf@users.sourceforge.net> <87lgoedf1t.fsf@utexas.edu> <87efu6nwa2.fsf@users.sourceforge.net> <878tkdy37e.fsf@utexas.edu> <87zicmk7u5.fsf@users.sourceforge.net> <87tw2u7k4i.fsf@utexas.edu> <87wp7qk5ye.fsf@users.sourceforge.net> <87shie7i9n.fsf@utexas.edu> Date: Sun, 02 Jul 2017 16:23:37 -0400 In-Reply-To: <87shie7i9n.fsf@utexas.edu> (Alex Branham's message of "Sun, 02 Jul 2017 21:25:56 +0200") Message-ID: <87podik2pi.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 27341 fixed close 27341 26.1 quit Alex Branham writes: > >> Do you think the prompt string should be a bit more detailed? "Query" >> seems a bit vague (e.g., consider if you hit M-s M-w by accident). >> Maybe we should just do (call-interactively 'eww) and then we'll get the >> prompt from there. > > Yes, that's much better. Done, thanks. Okay, pushed to master [1: 1fd6ca40fd], thanks for hanging in there! :) [1: 1fd6ca40fd]: 2017-07-02 16:19:57 -0400 Make eww-search-words prompt for query if nothing selected http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1fd6ca40fd50989b8f82b287c04a5079a051ed09