From unknown Mon Aug 18 02:34:13 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27333 <27333@debbugs.gnu.org> To: bug#27333 <27333@debbugs.gnu.org> Subject: Status: URL History can't handle records Reply-To: bug#27333 <27333@debbugs.gnu.org> Date: Mon, 18 Aug 2025 09:34:13 +0000 retitle 27333 URL History can't handle records reassign 27333 emacs submitter 27333 Ian Dunn severity 27333 normal tag 27333 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 11 16:02:51 2017 Received: (at submit) by debbugs.gnu.org; 11 Jun 2017 20:02:51 +0000 Received: from localhost ([127.0.0.1]:41426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dK94V-00081z-5S for submit@debbugs.gnu.org; Sun, 11 Jun 2017 16:02:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dK94T-00081m-0P for submit@debbugs.gnu.org; Sun, 11 Jun 2017 16:02:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dK94N-0007Oy-20 for submit@debbugs.gnu.org; Sun, 11 Jun 2017 16:02:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37173) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dK94M-0007Ou-Uo for submit@debbugs.gnu.org; Sun, 11 Jun 2017 16:02:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dK94L-0007tE-S0 for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 16:02:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dK94L-0007Oc-2J for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 16:02:41 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dK94K-0007OY-Uy for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 16:02:40 -0400 Received: from [2604:6000:1010:176:da4d:3352:bae5:f50e] (port=49958 helo=escafil) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dK94K-0000I9-EZ for bug-gnu-emacs@gnu.org; Sun, 11 Jun 2017 16:02:40 -0400 From: Ian Dunn To: bug-gnu-emacs@gnu.org Subject: URL History can't handle records Date: Sun, 11 Jun 2017 16:01:18 -0400 Message-ID: <87wp8iway9.fsf@escafil> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Since the change to records a few months ago, I've seen a bug with `url-his= tory-save-history'. When I try to run it, I see: Error running timer =E2=80=98url-history-save-history=E2=80=99: (wrong-type= -argument stringp #s(url "https" nil nil "duckduckgo.com" nil "/html/?q=3De= macs" nil nil t nil t)) A backtrace puts it at the `string-match' call in `url-history-save-history= '. I think the problem is that url-history is using a url struct instead o= f a string, which, according to `url-history-update-url', isn't supposed to= be happening. The following patch should fix this: --=-=-= Content-Type: text/x-diff Content-Disposition: inline diff --git a/lisp/url/url-history.el b/lisp/url/url-history.el index 1fa085400d..af52d5861e 100644 --- a/lisp/url/url-history.el +++ b/lisp/url/url-history.el @@ -106,7 +106,7 @@ to run the `url-history-setup-save-timer' function manually." (defun url-history-update-url (url time) (setq url-history-changed-since-last-save t) - (puthash (if (vectorp url) (url-recreate-url url) url) time + (puthash (if (recordp url) (url-recreate-url url) url) time url-history-hash-table)) (autoload 'url-make-private-file "url-util") --=-=-= Content-Type: text/plain -- Ian Dunn --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 11 20:52:46 2017 Received: (at control) by debbugs.gnu.org; 12 Jun 2017 00:52:46 +0000 Received: from localhost ([127.0.0.1]:41631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKDb4-0000FU-Eu for submit@debbugs.gnu.org; Sun, 11 Jun 2017 20:52:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKDb2-0000FH-J6 for control@debbugs.gnu.org; Sun, 11 Jun 2017 20:52:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKDaw-0002EO-Sl for control@debbugs.gnu.org; Sun, 11 Jun 2017 20:52:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKDaw-0002EK-PR for control@debbugs.gnu.org; Sun, 11 Jun 2017 20:52:38 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKDaw-00073K-FC for control@debbugs.gnu.org; Sun, 11 Jun 2017 20:52:38 -0400 Subject: control message for bug 24655 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sun, 11 Jun 2017 20:52:38 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 24655 by 27333 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 28 07:40:38 2017 Received: (at 27333) by debbugs.gnu.org; 28 Jun 2017 11:40:38 +0000 Received: from localhost ([127.0.0.1]:41736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQBKo-0005X8-5D for submit@debbugs.gnu.org; Wed, 28 Jun 2017 07:40:38 -0400 Received: from mail-it0-f68.google.com ([209.85.214.68]:36755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQBKl-0005Wm-Ay; Wed, 28 Jun 2017 07:40:35 -0400 Received: by mail-it0-f68.google.com with SMTP id 185so5094879itv.3; Wed, 28 Jun 2017 04:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=yXhCCQKuV0vN+yIbOCznbYcMYOugujXnRFHna7UDL8E=; b=Ie2GnMgni47Z7TcdEBphkzJOIY04hhyn9lxyq3qDGVwjcWAKVIWZIAy4tP+TJPW9TP K4lOAYFC1APMSBlM0Y9WldXJcz3vT5rzRxBKraWIjx7noCiwtcaLBT0XtwvtYKMF7uEc GCdr6TvFV8RorL7YzxlKNZGtqmJfmAXYGWh7eB2oQd73CjYEEjPQasoBGWblFqfxzinW uTuGxJNqyDAkpfYzOar+rdI5AbbplgeblxjRpgtP/wuoNMPISokui17/0i3EmQagYWqv 7tLhTVIdiovRQs1G/Hv5xH7sm0M+i1cLPKrNRCajL5rLBaqm7MFGLaOCCrifnz2CkszC OWQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=yXhCCQKuV0vN+yIbOCznbYcMYOugujXnRFHna7UDL8E=; b=QgOAffZiFsMM5CkZvgL1k1QsxFg4dzY6o9arHypeixozx88ZlIWabnqDnrDCLfsUY9 jdHa4vT2iDBvOh52iRJzVi0wHyF+KPKih7h3LuRDekHkBca6UfiWGlc9QtUPRruyM55i HbYwI3VqwRYRywR67pkk3qMKZiVdUZ84Ff75oh88ASPaHAmgw28cA9W7QwljIebAxGWB 8TNy35UMNPSs1wBulSzZsQolm6k6y3XHBYXPFe5fEs+w2FXpqcFjVkzx1MiSD3+yjkUd pVQO2xMsbASjR5Lj/P54txAyTKC7Eym4IhPmdE4kLB4DfZxoqJamMzd4E8DsxNs8zrk3 2FOQ== X-Gm-Message-State: AKS2vOw7UIHQIB5cMyJoKCh44mC5vFNoHLKF39IbuH7cr1K9eeaTygrm uy2fI6ezbrp1oScC X-Received: by 10.36.127.208 with SMTP id r199mr7711491itc.110.1498650028246; Wed, 28 Jun 2017 04:40:28 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id j87sm1026511ioo.23.2017.06.28.04.40.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Jun 2017 04:40:26 -0700 (PDT) From: npostavs@users.sourceforge.net To: Ian Dunn Subject: Re: bug#27333: URL History can't handle records References: <87wp8iway9.fsf@escafil> Date: Wed, 28 Jun 2017 07:42:02 -0400 In-Reply-To: <87wp8iway9.fsf@escafil> (Ian Dunn's message of "Sun, 11 Jun 2017 16:01:18 -0400") Message-ID: <87vangmj91.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 27333 Cc: 27333@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 27333 fixed close 27333 quit Ian Dunn writes: > Since the change to records a few months ago, I've seen a bug with `url-h= istory-save-history'. When I try to run it, I see: > > Error running timer =E2=80=98url-history-save-history=E2=80=99: (wrong-ty= pe-argument stringp #s(url "https" nil nil "duckduckgo.com" nil "/html/?q= =3Demacs" nil nil t nil t)) Fixed in [1: d3a208ea8e], I decided to be a bit more specific and use `url-= p' instead of `recordp'. [1: d3a208ea8e]: 2017-06-28 07:39:05 -0400 Don't assume url structs are vectors (Bug#27333) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Dd3a208ea8e2e3a28f= b7d0e30248c7d46e13fc160> From unknown Mon Aug 18 02:34:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 27 Jul 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator