From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 11 13:13:15 2017 Received: (at submit) by debbugs.gnu.org; 11 Jun 2017 17:13:16 +0000 Received: from localhost ([127.0.0.1]:41355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dK6QM-0004Ek-Ir for submit@debbugs.gnu.org; Sun, 11 Jun 2017 13:13:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dK6FG-0003yr-8K for submit@debbugs.gnu.org; Sun, 11 Jun 2017 13:01:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dK6FA-0007NI-6s for submit@debbugs.gnu.org; Sun, 11 Jun 2017 13:01:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44980) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dK6FA-0007NE-3H for submit@debbugs.gnu.org; Sun, 11 Jun 2017 13:01:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dK6F8-00058o-VM for guix-patches@gnu.org; Sun, 11 Jun 2017 13:01:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dK6F5-0007Mv-UL for guix-patches@gnu.org; Sun, 11 Jun 2017 13:01:39 -0400 Received: from mail2.vany.ca ([142.54.190.254]:58488) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dK6F5-0007Ml-Pj for guix-patches@gnu.org; Sun, 11 Jun 2017 13:01:35 -0400 Received: from adamvy-laptop (ktnron060mw-lp130-03-184-145-60-107.dsl.bell.ca [184.145.60.107]) by mail2.vany.ca (Postfix) with ESMTPSA id 4FA8FAC0021 for ; Sun, 11 Jun 2017 12:01:32 -0500 (CDT) From: Adam Van Ymeren To: guix-patches@gnu.org Subject: [PATCH] Handle EIO error in ENOENT-safe as well. User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Date: Sun, 11 Jun 2017 13:01:31 -0400 Message-ID: <87y3syqx04.fsf@vany.ca> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 11 Jun 2017 13:13:14 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Trying to boot GuixSD when an audio CD is in the drive will die with an "input/output error" when trying to read the superblock from the cd drive. This patch catches and warns in this case rather than dying. --- gnu/build/file-systems.scm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 08f7d478e..f9cc4088b 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -419,6 +419,10 @@ warning and #f as the result." #f) ((= ENOMEDIUM errno) ;for removable media #f) + ((= EIO errno) ;unreadable hardware like audio CDs + (format (current-error-port) + "warning: failed to read from device '~a'~%" device) + #f) (else (apply throw args)))))))) -- 2.13.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 11 17:11:28 2017 Received: (at 27331-done) by debbugs.gnu.org; 11 Jun 2017 21:11:28 +0000 Received: from localhost ([127.0.0.1]:41463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKA8u-00019l-6i for submit@debbugs.gnu.org; Sun, 11 Jun 2017 17:11:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKA8t-00019a-8H for 27331-done@debbugs.gnu.org; Sun, 11 Jun 2017 17:11:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKA8l-0003gL-6E for 27331-done@debbugs.gnu.org; Sun, 11 Jun 2017 17:11:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKA8l-0003gG-2p; Sun, 11 Jun 2017 17:11:19 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:33458 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dKA8k-0006Gt-FC; Sun, 11 Jun 2017 17:11:18 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Adam Van Ymeren Subject: Re: bug#27331: [PATCH] Handle EIO error in ENOENT-safe as well. References: <87y3syqx04.fsf@vany.ca> Date: Sun, 11 Jun 2017 23:11:16 +0200 In-Reply-To: <87y3syqx04.fsf@vany.ca> (Adam Van Ymeren's message of "Sun, 11 Jun 2017 13:01:31 -0400") Message-ID: <87a85ep6vf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27331-done Cc: 27331-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello, Adam Van Ymeren skribis: > Trying to boot GuixSD when an audio CD is in the drive will die with an > "input/output error" when trying to read the superblock from the cd > drive. > > This patch catches and warns in this case rather than dying. Good catch! I added a commit log following our conventions and committed. Thanks, Ludo=E2=80=99. From unknown Fri Sep 05 20:56:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 Jul 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator