GNU bug report logs - #27318
[PATCH 1/2] gnu: stellarium: Fix build with Qt 5.9.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27318 in the body.
You can then email your comments to 27318 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH 1/2] gnu: stellarium: Fix build with Qt 5.9.
Date: Sun, 11 Jun 2017 00:23:17 +0200

* gnu/packages/astronomy.scm (stellarium)[arguments]:
Add phase "patch-version-check".
---
 gnu/packages/astronomy.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index 2aa65d588..6c486469d 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -141,6 +141,14 @@ programs for the manipulation and analysis of astronomical data.")
     (arguments
       `(#:test-target "tests"
         #:phases (modify-phases %standard-phases
+                   (add-after 'unpack 'patch-version-check
+                     (lambda _
+                       ;; Previously-deprecated cmake variable vanished in
+                       ;; Qt 5.9.
+                       ;; See <https://bugreports.qt.io/browse/QTBUG-60936>.
+                       (substitute* "CMakeLists.txt"
+                         (("Qt5Core_VERSION_STRING") "Qt5Core_VERSION"))
+                       #t))
                    (add-before 'check 'set-offscreen-display
                      (lambda _
                        ;; make Qt render "offscreen", required for tests

Message #8 received at 27318 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 27318 <at> debbugs.gnu.org
Subject: Re: bug#27318: [PATCH 1/2] gnu: stellarium: Fix build with Qt 5.9.
Date: Sun, 11 Jun 2017 13:28:21 -0400

[Message part 1 (text/plain, inline)]

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> * gnu/packages/astronomy.scm (stellarium)[arguments]:
> Add phase "patch-version-check".
> ---
>  gnu/packages/astronomy.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
> index 2aa65d588..6c486469d 100644
> --- a/gnu/packages/astronomy.scm
> +++ b/gnu/packages/astronomy.scm
> @@ -141,6 +141,14 @@ programs for the manipulation and analysis of astronomical data.")
>      (arguments
>        `(#:test-target "tests"
>          #:phases (modify-phases %standard-phases
> +                   (add-after 'unpack 'patch-version-check
> +                     (lambda _
> +                       ;; Previously-deprecated cmake variable vanished in
> +                       ;; Qt 5.9.
> +                       ;; See <https://bugreports.qt.io/browse/QTBUG-60936>.
> +                       (substitute* "CMakeLists.txt"
> +                         (("Qt5Core_VERSION_STRING") "Qt5Core_VERSION"))
> +                       #t))
>                     (add-before 'check 'set-offscreen-display
>                       (lambda _
>                         ;; make Qt render "offscreen", required for tests

LGTM.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.