Subject: Re: bug#27311: Acknowledgement (Enlightenment: 'cpufreq binary needs suid or has to be owned by root')

From: Ricardo Wurmus <[email-masked]>
Date: Wed, 21 Jun 2017 10:00:14 +0200

ng0 <[email-masked]> writes:

> Nix solved this particular issue (cpufreq) with a hack.
> It's okay for me, but do some of you agree with applying this:
>
>   # this is a hack and without this cpufreq module is not working. does the following:
>   #   1. moves the "freqset" binary to "e_freqset",
>   #   2. linkes "e_freqset" to enlightenment/bin so that,
>   #   3. wrappers.setuid detects it and places wrappers in /run/wrappers/bin/e_freqset,
>   #   4. and finally, links /run/wrappers/bin/e_freqset to original destination where enlightenment wants it
>   postInstall = ''
>     export CPUFREQ_DIRPATH=`readlink -f $out/lib/enlightenment/modules/cpufreq/linux-gnu-*`;
>     mv $CPUFREQ_DIRPATH/freqset $CPUFREQ_DIRPATH/e_freqset
>     ln -sv $CPUFREQ_DIRPATH/e_freqset $out/bin/e_freqset
>     ln -sv /run/wrappers/bin/e_freqset $CPUFREQ_DIRPATH/freqset
>   '';

No, we shouldn’t apply this hack.  Setuid binaries are declared
separately in the operating system configuration.  See section 6.2.8
Setuid Programs in the manual.

Packages cannot declare setuid binaries.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net