GNU bug report logs - #27307
[PATCH] gnu: unshield: Remove incorrect '"'.

Previous Next

Full log

Message #16 received at 27307-done <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 27307-done <at> debbugs.gnu.org
Subject: Re: bug#27307: [PATCH] gnu: unshield: Remove incorrect '"'.
Date: Mon, 10 Jul 2017 17:18:51 +0300

Hey Marius

On 06/10/2017 06:59 PM, Marius Bakke wrote:
> manolis837 <at> gmail.com writes:
> 
>> * gnu/packages/compression.scm: Remove incorrect '"'.
> 
> Nit-pick: it should say "* gnu/packages/compression.scm (unshield): ..."
> 
> [...]
> 
>> -           (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\"
>> +           (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\
>>  unshield-avigomanager11b22.zip?dl=1"))
> 
> I guess you can also remove string-append here? Alternatively, quoting the
> next line and indenting it would look a little better IMO.

I went with your second suggestion, I liked it more as well :)
Pushed the updated patch to master.
> 
> Sorry for the review failure! :-)
> 

I should have been more careful :P Thank you for your time and help!

Manolis

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.