GNU bug report logs - #27307
[PATCH] gnu: unshield: Remove incorrect '"'.

Previous Next

Package: guix-patches;

Reported by: manolis837 <at> gmail.com

Date: Sat, 10 Jun 2017 13:25:02 UTC

Severity: normal

Tags: patch

Done: Manolis Ragkousis <manolis837 <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 27307 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: manolis837 <at> gmail.com, 27307 <at> debbugs.gnu.org
Subject: Re: bug#27307: [PATCH] gnu: unshield: Remove incorrect '"'.
Date: Sat, 10 Jun 2017 17:59:33 +0200

[Message part 1 (text/plain, inline)]
manolis837 <at> gmail.com writes:

> * gnu/packages/compression.scm: Remove incorrect '"'.

Nit-pick: it should say "* gnu/packages/compression.scm (unshield): ..."

[...]

> -           (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\"
> +           (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\
>  unshield-avigomanager11b22.zip?dl=1"))

I guess you can also remove string-append here? Alternatively, quoting the
next line and indenting it would look a little better IMO.

Sorry for the review failure! :-)

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 7 years and 315 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.