From unknown Wed Jun 18 00:25:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27307 <27307@debbugs.gnu.org> To: bug#27307 <27307@debbugs.gnu.org> Subject: Status: [PATCH] gnu: unshield: Remove incorrect '"'. Reply-To: bug#27307 <27307@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:25:26 +0000 retitle 27307 [PATCH] gnu: unshield: Remove incorrect '"'. reassign 27307 guix-patches submitter 27307 manolis837@gmail.com severity 27307 normal tag 27307 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 09:24:18 2017 Received: (at submit) by debbugs.gnu.org; 10 Jun 2017 13:24:18 +0000 Received: from localhost ([127.0.0.1]:37894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJgNF-0003gU-VK for submit@debbugs.gnu.org; Sat, 10 Jun 2017 09:24:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJgND-0003gF-FO for submit@debbugs.gnu.org; Sat, 10 Jun 2017 09:24:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJgN7-0001Rf-Dj for submit@debbugs.gnu.org; Sat, 10 Jun 2017 09:24:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40896) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dJgN7-0001RR-AX for submit@debbugs.gnu.org; Sat, 10 Jun 2017 09:24:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJgN6-0006GT-6K for guix-patches@gnu.org; Sat, 10 Jun 2017 09:24:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJgN3-0001N9-3D for guix-patches@gnu.org; Sat, 10 Jun 2017 09:24:08 -0400 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:34533) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dJgN2-0001Mr-T5 for guix-patches@gnu.org; Sat, 10 Jun 2017 09:24:05 -0400 Received: by mail-wr0-x244.google.com with SMTP id u101so12294173wrc.1 for ; Sat, 10 Jun 2017 06:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=XZIXabXgwC73rcaXyyoP7/g4tRCSmrelSbwtetphHqw=; b=J+f6gmqZvTp842ECVQLoMiqsPorDz1sIsNegktiFOjPe+aGv2XOa2wEEbX0dnd6HpP Bq213XmOfrtClAHhrpd5VfmmBu78knjD4UCEQirQ1H8+cARzX8btaGk7BAb3DkGMEK+a 2Dhlnk5lsbNblk4oDKirbq7tVTk50W/BgERQJp6571BnBorWbQ0JqGlLrBXl+zAc9hEu hlm60XkJOYuLWbrf9ZlzDpJaZHFloeTZM0Sln+nW20BYeRWq8BsLHzloC6qGWibX351q T6t3f35e3HIQq/BGhbidHjZkl3J0G8/48a9ilAOeOFQBCYTeSmVWn17qE66m+DqMcsgg xB8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XZIXabXgwC73rcaXyyoP7/g4tRCSmrelSbwtetphHqw=; b=MjuHbPNpUY5879xKGjFLXIEL0QfRTCcpjIFNVwJG3UZcTixKGUEQq8MtABaLREEngY pQzZN7u8N/K2jSSZa8IddOcO7Pm0tqiXup+LbyAGNi52dDOo6KIf4PZY3RsHl5n4dPXe 9/nDLs53fADEeJaaSXSZv0ambAMJZI15k8Xfpi+3xF5PoXBXr7e4cRLhT95FYQue5AIa 9U+XxCm7qq2Uyb5yC05Xd3UcflF31xlxgjfaVAB2/Pu/BgRT0+qilWh8bCYXxLPv8Ww0 WfGZJNGQZwJD1kNG8Se1GQWV2RuhCGmZ8bd4G79R+yNvvnzwIGHpCZzXQKlTjscXfylw gavw== X-Gm-Message-State: AKS2vOztyv1/uwd5SGBWfw/LMrQc1VEWHCxOQNuECya78W/Bk344jQCE EzrWAOtWMjzq9WRsoJc= X-Received: by 10.28.149.65 with SMTP id x62mr2897659wmd.35.1497101042005; Sat, 10 Jun 2017 06:24:02 -0700 (PDT) Received: from localhost.localdomain (athedsl-218187.home.otenet.gr. [85.74.171.233]) by smtp.gmail.com with ESMTPSA id r130sm3302885wmg.4.2017.06.10.06.24.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Jun 2017 06:24:01 -0700 (PDT) From: manolis837@gmail.com To: guix-patches@gnu.org Subject: [PATCH] gnu: unshield: Remove incorrect '"'. Date: Sat, 10 Jun 2017 16:23:51 +0300 Message-Id: <20170610132351.25681-1-manolis837@gmail.com> X-Mailer: git-send-email 2.13.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit Cc: Manolis Ragkousis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) From: Manolis Ragkousis * gnu/packages/compression.scm: Remove incorrect '"'. --- gnu/packages/compression.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index 3742ff586..8de297fbc 100644 --- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -1183,7 +1183,7 @@ or junctions, and always follows hard links.") ("unshield-avigomanager11b22.zip" ,(origin (method url-fetch) - (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\" + (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\ unshield-avigomanager11b22.zip?dl=1")) (sha256 (base32 "0fwq7lih04if68wpwpsk5wjqyvh32db76a41sq6gbx4dn1lc3ddn")) @@ -1191,7 +1191,7 @@ unshield-avigomanager11b22.zip?dl=1")) ("unshield-the-feeble-files-spanish.zip" ,(origin (method url-fetch) - (uri (string-append "https://www.dropbox.com/s/1ng0z9kfxc7eb1e/\" + (uri (string-append "https://www.dropbox.com/s/1ng0z9kfxc7eb1e/\ unshield-the-feeble-files-spanish.zip?dl=1")) (sha256 (base32 "1k5cw6vnpja8yjlnhx5124xrw9i8s1l539hfdqqrqz3l5gn0bnyd")) -- 2.13.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 10:26:53 2017 Received: (at 27307) by debbugs.gnu.org; 10 Jun 2017 14:26:53 +0000 Received: from localhost ([127.0.0.1]:39018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJhLp-0005Oj-7B for submit@debbugs.gnu.org; Sat, 10 Jun 2017 10:26:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJhLn-0005OV-FR for 27307@debbugs.gnu.org; Sat, 10 Jun 2017 10:26:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJhLe-0005fq-9g for 27307@debbugs.gnu.org; Sat, 10 Jun 2017 10:26:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJhLe-0005fh-6K; Sat, 10 Jun 2017 10:26:42 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:60570 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dJhLd-00052k-Gb; Sat, 10 Jun 2017 10:26:41 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: manolis837@gmail.com Subject: Re: bug#27307: [PATCH] gnu: unshield: Remove incorrect '"'. References: <20170610132351.25681-1-manolis837@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Prairial an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sat, 10 Jun 2017 16:26:39 +0200 In-Reply-To: <20170610132351.25681-1-manolis837@gmail.com> (manolis's message of "Sat, 10 Jun 2017 16:23:51 +0300") Message-ID: <87h8znyl40.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27307 Cc: 27307@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) manolis837@gmail.com skribis: > From: Manolis Ragkousis > > * gnu/packages/compression.scm: Remove incorrect '"'. OK! Ludo'. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 11:59:38 2017 Received: (at 27307) by debbugs.gnu.org; 10 Jun 2017 15:59:38 +0000 Received: from localhost ([127.0.0.1]:39089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJina-0000sY-BX for submit@debbugs.gnu.org; Sat, 10 Jun 2017 11:59:38 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJinY-0000sQ-1g for 27307@debbugs.gnu.org; Sat, 10 Jun 2017 11:59:37 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3906D2060A; Sat, 10 Jun 2017 11:59:35 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Sat, 10 Jun 2017 11:59:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=qqswsuzAtGugwNqevBX6SF2dy+X67wKtSgrNtfCT9 0E=; b=3C2nIX1pJ+iaiwJDRHwJNGglvdLJQV1mvkrSOUEsj1GcO21DHGyj8a05Y vYZ18RQWJBf7GU2Ua4UUpKISf10HOlCVuqOjpzOdYpNdrxtyvkYgqXhS4axcIxoL kDdSxL8YMKtbNTM8Std9TaAewuJWYZDVoji9sw0ABOQQ7JJiErh53nGeY/Pfi+Jd QNi0jV5Ko4xvvDYWjYirZCtkIJ+EIUI1xE/NXugFPj+RaPB9VIDGrDZYgeYhnQXU 32Y8GatCZgi6ejxaEz8nlUI/9eVy94WwgKGcbZ6tBk4zeDzZ2Vm9QT8HtgrqPZKG qJ42ltIAK0jh454uc+RkmyO/c2z7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=qqswsuzAtGugwNqevB X6SF2dy+X67wKtSgrNtfCT90E=; b=dqGSQu3USJBHFxh5oxXnRYztRCyYMoViJt OBkiZt/4krJ5GUB+L9FiNgVQmqjZFSZzEvc5j1oEfR2tBo0IvPtN/UmY++ay4dcr BjeEzL8XtoXiu3oAPAgm9SXq9c6g/hiDEc+9GVMxY2GyfGEqAPy9nhRmHSt3IJSG Nncj1BvFTkDkHRzwu02+jtUdU5GKwSRDhTCR4efd3NsyOkIbKZwXh+JvJ7ZKdv/0 +C3RiHcY8lmZgWhP/LpjLrNoO9d/VVsYEvSfiV0+h9UcNuX81U97FkKIXAXohxOU 0RF4prCnIQRvBa/qYKUSmGAYnKQBlXmX6Ev4FwKWjqQN4FHlR3qg== X-ME-Sender: X-Sasl-enc: Wfx1XZPbqqP0InujvjPIAsjNAfKqgTlGe/kG9EUHkCgQ 1497110374 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id B68EC248B0; Sat, 10 Jun 2017 11:59:34 -0400 (EDT) From: Marius Bakke To: manolis837@gmail.com, 27307@debbugs.gnu.org Subject: Re: bug#27307: [PATCH] gnu: unshield: Remove incorrect '"'. In-Reply-To: <20170610132351.25681-1-manolis837@gmail.com> References: <20170610132351.25681-1-manolis837@gmail.com> User-Agent: Notmuch/0.24.2 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Sat, 10 Jun 2017 17:59:33 +0200 Message-ID: <87shj7ltp6.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27307 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain manolis837@gmail.com writes: > * gnu/packages/compression.scm: Remove incorrect '"'. Nit-pick: it should say "* gnu/packages/compression.scm (unshield): ..." [...] > - (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\" > + (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\ > unshield-avigomanager11b22.zip?dl=1")) I guess you can also remove string-append here? Alternatively, quoting the next line and indenting it would look a little better IMO. Sorry for the review failure! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlk8F2UACgkQoqBt8qM6 VPo4mQgAzwfbek6mOvQSFnINMhkmvmdgadqjTtAE5qxDRH8o+wqtawh9Snh8erQq WCp7H5TBACMptUmMU7i8ZM/x26i3/HedhZvE5/kK2oMRFv2ObBLG0L9itP640kYw XO4XaNNaMgQW4m7tYu0LUUQ/Pd9sn6582+Irnz2imAuE7SW4UNak6saX/GmOwSIV qmH5+7Bqq/TDoAZ/9IE2jV3HFu4k5Qvfkp2P3dRgKcYBZv8eC2ZCwUyg+dtH1UQv WR0tI6AiIA+cVS4loEC4Yp4+fShm42SM637q4BIVSYxs5OiifOm5uDEUl0NQlyfF z2MlIFRWPshRxQqX5mTuEc6LsSsYhA== =ksuA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 10 10:19:03 2017 Received: (at 27307-done) by debbugs.gnu.org; 10 Jul 2017 14:19:03 +0000 Received: from localhost ([127.0.0.1]:60963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUZWg-00017F-Qv for submit@debbugs.gnu.org; Mon, 10 Jul 2017 10:19:03 -0400 Received: from mail-wr0-f180.google.com ([209.85.128.180]:33440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUZWe-00016l-ES for 27307-done@debbugs.gnu.org; Mon, 10 Jul 2017 10:19:01 -0400 Received: by mail-wr0-f180.google.com with SMTP id r103so140959926wrb.0 for <27307-done@debbugs.gnu.org>; Mon, 10 Jul 2017 07:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=14WL2cOo6NF+82u7qQTj0rBibcQRLkO3JT66wU+iW4M=; b=f4XIJ3D1hZv8tFTr9LwkTLY7RIaoZO0VsS0hcJ/wO5FlD/yEIPhA0HLg6EambhwQ3z mJqcO0z8dnQK/biPct+OrWzMRYXCh90g8M0m21wQ0oGa8Exgla5ZmnJAfHwbWzYWmWTK U9//58c7tIw3MlaxDkX2fK7xRA+qLp6qJG1UyjkBbIwL//GuO8zyjDEQthL13wWdlrhD se5PI6J2W/ULuTkU6Nb1dPVYc8cGQ90mZiWRdqwajItB1W1NMxQEGX6c/lLgq2FI0CdO tzoURR3Acbcm9TVvu5MIm5z5FJU1t9RAW4F3nPgcUNBZbxKa+DlQ6vVhtpCxESWx4gjg YpfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=14WL2cOo6NF+82u7qQTj0rBibcQRLkO3JT66wU+iW4M=; b=fjbhG5/Ldc9vrD1kWqv7QFAuU1aiY3OVkPOef2wX7Z/v4O8eed8KgtswK/RhjcfxwG oL9NY1xe2FlnjDwt1NOy1BHacgn4U/cCLf0UC7INFC/pUN8Pd8+zc8Fk9pJ4kvDuMLOJ yF45QoG3Iciyx8sHv/rtwgOfPUlmy0qroIClH7pR6IAO50PwDovjymXWU8U76GeVED7z 7PZSQ4uT/kP9X4SKTjXyZYEMM+pztQ4P0vIW+gusPaw1/L5sFYCj+uH2U7z85VxrDNjt hUwqUasYsvqWyk0zQkh8Lew2hOL0Znm3ZC1ep8AqZi7tPM9UUttz7+9vSjk/UPjynHqD +Acw== X-Gm-Message-State: AIVw111i/ZHxYOgCn80Dy7eoslE+VNDjyQsG463Vxfbp7ZluobSRgcQt hNuu72jUPor3FcUo450= X-Received: by 10.223.165.146 with SMTP id g18mr7104967wrc.167.1499696334319; Mon, 10 Jul 2017 07:18:54 -0700 (PDT) Received: from [192.168.2.110] (ppp-94-66-212-18.home.otenet.gr. [94.66.212.18]) by smtp.gmail.com with ESMTPSA id 2sm6847676wrn.24.2017.07.10.07.18.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jul 2017 07:18:53 -0700 (PDT) Subject: Re: bug#27307: [PATCH] gnu: unshield: Remove incorrect '"'. To: Marius Bakke References: <20170610132351.25681-1-manolis837@gmail.com> <87shj7ltp6.fsf@fastmail.com> From: Manolis Ragkousis Message-ID: Date: Mon, 10 Jul 2017 17:18:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <87shj7ltp6.fsf@fastmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 27307-done Cc: 27307-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Hey Marius On 06/10/2017 06:59 PM, Marius Bakke wrote: > manolis837@gmail.com writes: > >> * gnu/packages/compression.scm: Remove incorrect '"'. > > Nit-pick: it should say "* gnu/packages/compression.scm (unshield): ..." > > [...] > >> - (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\" >> + (uri (string-append "https://www.dropbox.com/s/8r4b6752swe3nhu/\ >> unshield-avigomanager11b22.zip?dl=1")) > > I guess you can also remove string-append here? Alternatively, quoting the > next line and indenting it would look a little better IMO. I went with your second suggestion, I liked it more as well :) Pushed the updated patch to master. > > Sorry for the review failure! :-) > I should have been more careful :P Thank you for your time and help! Manolis From unknown Wed Jun 18 00:25:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 08 Aug 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator