Subject: bug#27302: closed (Re: emacs-dired-hacks-utils in one patch with github origin)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 24 Jun 2017 19:06:02 +0000

Your bug report

#27302: [PATCH 1/2] gnu: Add emacs-dired-hacks-utils.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
27302: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27302
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: emacs-dired-hacks-utils in one patch with github origin
From: Alex Kost <[email-masked]>
To: Oleg Pykhalov <[email-masked]>
Cc: Ludovic Courtès <[email-masked]>, [email-masked]
Date: Sat, 24 Jun 2017 22:04:55 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Oleg Pykhalov (2017-06-24 08:41 +0300) wrote:

> Hi Alex,
>
> Alex Kost <[email-masked]> writes:
>
>> Unfortunately, we can't use sources from MELPA.  The problem is: when a
>> repository get a new commit, the old tarball is *REPLACED* with the new
>> one on MELPA, so the package could never be built anymore, since the
>> source disappeared.  That's why we use tarballs directly from source.
>
> OK.  I saw some melpa packages in emacs.scm though.  Will they be
> removed in future?

I see the only package that uses MELPA source ("emacs-keyfreq"), and it
was definitely done so by mistake.  It will not be removed, instead it
should be adjusted to use a source directly from the upstream which is:

  https://github.com/dacap/keyfreq/archive/1.8.tar.gz

>> I see that this "dired-hacks" repository is split into multiple packages
>> on MELPA, and you follow this path, however I think it would be much
>> easier for us just to have a single "emacs-dired-hacks" package.
>> Otherwise, we'll have to pick single files for all these "dired-open",
>> "dired-avfs" and other packages, which is not convenient.
>>
>> What do you think?  Are there any objections on making a single
>> "dired-hacks" package?
>
> I'm not sure if splitting is worth.  I use only dired-open from this
> project.  So, I cannot be sure about other addons.  For example, I have
> some warnings and errors while building full addons collection but
> dired-open works though.

Oh, most of those warnings (like "function is not known to be defined"
or "reference to free variable") are the usual warnings that should be
fixed by the maintainer.  These warnings are harmless, most maintainers
don't even bother to fix them.  And the errors come from missing
libraries: "emacs-s" and "emacs-f" are needed for some files.

As for splitting this package into multiple ones, I think it may be done
in future, if someone will have a wish to do it :-)

[...]
> From 1a22aef22f0eec6c9dd8dc9a20964e11700834d7 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <[email-masked]>
> Date: Sat, 10 Jun 2017 02:59:25 +0300
> Subject: [PATCH] gnu: Add emacs-dired-hacks-utils.

Thank you, I added a copyright line for you, adjusted the package recipe
a bit, and committed:

  http://git.savannah.gnu.org/cgit/guix.git/commit/?id=730c0790fc5b3285cd0f1983804e2d76c37cb542

Thanks for contributing!

-- 
Alex

Subject: [PATCH 1/2] gnu: Add emacs-dired-hacks-utils.
From: Oleg Pykhalov <[email-masked]>
To: [email-masked]
Cc: Oleg Pykhalov <[email-masked]>
Date: Sat, 10 Jun 2017 04:05:31 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a4cb4a0b3..e3f5b926c 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4873,3 +4873,26 @@ running a customisable handler command (@code{ignore} by default). ")
 from within Emacs.  Restclient runs queries from a plan-text query sheet,
 displays results pretty-printed in XML or JSON with @code{restclient-mode}")
       (license license:public-domain))))
+
+(define-public dired-hacks-utils
+  (package
+    (name "emacs-dired-hacks-utils")
+    (version "20160527.1436")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/Fuco1/dired-hacks/archive/master"
+             ".tar.gz"))
+       (sha256
+        (base32
+         "180qfjjps3mg26zxwczj174qvbwivgn2h7haz1i8js9h1srl183r"))))
+    (build-system emacs-build-system)
+    (propagated-inputs `(("emacs-dash" ,emacs-dash)))
+    (home-page "https://github.com/Fuco1/dired-hacks")
+    (synopsis
+     "Utilities and helpers for dired-hacks collection")
+    (description
+     "Provides shared functionality and helpers for dired-hacks-utils
+collection.")
+    (license license:gpl3+)))
-- 
2.13.1