GNU bug report logs - #27302
[PATCH 1/2] gnu: Add emacs-dired-hacks-utils.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27302 in the body.
You can then email your comments to 27302 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH 1/2] gnu: Add emacs-dired-hacks-utils.
Date: Sat, 10 Jun 2017 04:05:31 +0300

---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a4cb4a0b3..e3f5b926c 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4873,3 +4873,26 @@ running a customisable handler command (@code{ignore} by default). ")
 from within Emacs.  Restclient runs queries from a plan-text query sheet,
 displays results pretty-printed in XML or JSON with @code{restclient-mode}")
       (license license:public-domain))))
+
+(define-public dired-hacks-utils
+  (package
+    (name "emacs-dired-hacks-utils")
+    (version "20160527.1436")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/Fuco1/dired-hacks/archive/master"
+             ".tar.gz"))
+       (sha256
+        (base32
+         "180qfjjps3mg26zxwczj174qvbwivgn2h7haz1i8js9h1srl183r"))))
+    (build-system emacs-build-system)
+    (propagated-inputs `(("emacs-dash" ,emacs-dash)))
+    (home-page "https://github.com/Fuco1/dired-hacks")
+    (synopsis
+     "Utilities and helpers for dired-hacks collection")
+    (description
+     "Provides shared functionality and helpers for dired-hacks-utils
+collection.")
+    (license license:gpl3+)))
-- 
2.13.1

Message #8 received at 27302 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 27302 <at> debbugs.gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH 1/3] gnu: emacs-dired-hacks-utils: Change origin to melpa
Date: Sat, 10 Jun 2017 05:02:23 +0300

---
 gnu/packages/emacs.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 5f00a7ad5..d2b1056b6 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4882,11 +4882,12 @@ displays results pretty-printed in XML or JSON with @code{restclient-mode}")
      (origin
        (method url-fetch)
        (uri (string-append
-             "https://github.com/Fuco1/dired-hacks/archive/master"
-             ".tar.gz"))
+             "http://melpa.org/packages/dired-hacks-utils-"
+             version
+             ".el"))
        (sha256
         (base32
-         "180qfjjps3mg26zxwczj174qvbwivgn2h7haz1i8js9h1srl183r"))))
+         "1378prbbvvdfi83ln1pwxanawynif6jmb3i5xd16igkjy6ads5qp"))))
     (build-system emacs-build-system)
     (propagated-inputs `(("emacs-dash" ,emacs-dash)))
     (home-page "https://github.com/Fuco1/dired-hacks")
-- 
2.13.1

Message #11 received at 27302 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 27302 <at> debbugs.gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH 2/3] gnu: emacs-dired-hacks-utils: Rename define-public
Date: Sat, 10 Jun 2017 05:02:24 +0300

---
 gnu/packages/emacs.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index d2b1056b6..8625f1ee4 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4874,7 +4874,7 @@ from within Emacs.  Restclient runs queries from a plan-text query sheet,
 displays results pretty-printed in XML or JSON with @code{restclient-mode}")
       (license license:public-domain))))
 
-(define-public dired-hacks-utils
+(define-public emacs-dired-hacks-utils
   (package
     (name "emacs-dired-hacks-utils")
     (version "20160527.1436")
@@ -4916,7 +4916,7 @@ collection.")
     (propagated-inputs
      `(("emacs-dash" ,emacs-dash)
        ("emacs-dired-hacks-utils"
-        ,dired-hacks-utils)))
+        ,emacs-dired-hacks-utils)))
     (home-page "https://github.com/Fuco1/dired-hacks")
     (synopsis
      "Open files from dired using using custom actions")
-- 
2.13.1

Message #14 received at 27302 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 27302 <at> debbugs.gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH 3/3] gnu: emacs-dired-open: Rename define-public
Date: Sat, 10 Jun 2017 05:02:25 +0300

---
 gnu/packages/emacs.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 8625f1ee4..7b61a539f 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4898,7 +4898,7 @@ displays results pretty-printed in XML or JSON with @code{restclient-mode}")
 collection.")
     (license license:gpl3+)))
 
-(define-public dired-open
+(define-public emacs-dired-open
   (package
     (name "emacs-dired-open")
     (version "20160205.1213")
-- 
2.13.1

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH 2/2] gnu: Add emacs-dired-open.
Date: Sat, 10 Jun 2017 04:05:32 +0300

---
 gnu/packages/emacs.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index e3f5b926c..5f00a7ad5 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4896,3 +4896,31 @@ displays results pretty-printed in XML or JSON with @code{restclient-mode}")
      "Provides shared functionality and helpers for dired-hacks-utils
 collection.")
     (license license:gpl3+)))
+
+(define-public dired-open
+  (package
+    (name "emacs-dired-open")
+    (version "20160205.1213")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://melpa.org/packages/dired-open-"
+             version
+             ".el"))
+       (sha256
+        (base32
+         "1fifc0k222l25f8jpqllhzq411dcvhbgzlr27mx1rnbnnabxya38"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-dired-hacks-utils"
+        ,dired-hacks-utils)))
+    (home-page "https://github.com/Fuco1/dired-hacks")
+    (synopsis
+     "Open files from dired using using custom actions")
+    (description
+     "Adds a mechanism to add hooks to dired-find-file that will run before
+emacs tries its own mechanisms to open the file, thus enabling you to launch
+other application or code and suspend the default behaviour.")
+    (license license:gpl3+)))
-- 
2.13.1

Message #20 received at 27302 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 27302 <at> debbugs.gnu.org
Subject: Re: bug#27302: [PATCH 1/2] gnu: Add emacs-dired-hacks-utils.
Date: Fri, 16 Jun 2017 15:38:39 +0300

Hello, thanks for the patches and sorry for the delay!

I see that this "dired-hacks" repository is split into multiple packages
on MELPA, and you follow this path, however I think it would be much
easier for us just to have a single "emacs-dired-hacks" package.
Otherwise, we'll have to pick single files for all these "dired-open",
"dired-avfs" and other packages, which is not convenient.

What do you think?  Are there any objections on making a single
"dired-hacks" package?

If you think a single package is appropriate, could you make a patch for
it?

Since "dired-hacks" has no releases, we have to use 'git-fetch' instead
of 'url-fetch' for source.  It should look something like this:

(define-public emacs-dired-hacks
  (let ((commit "eda68006ce73bbf6b9b995bfd70d08bec8cade36")
        (revision "1"))
    (package
      (name "emacs-dired-hacks")
      (version (string-append "0.0.0-" revision "."
                              (string-take commit 7)))
      (source (origin
                (method git-fetch)
                (uri (git-reference
                      (url "https://github.com/Fuco1/dired-hacks.git")
                      (commit commit)))
                (file-name (string-append name "-" version "-checkout"))
                (sha256
                 (base32
                  "some-letters-and-numbers-here"))))
      ...)))


BTW we already have a single "emacs-ivy" package (instead of "ivy",
"swiper" and "counsel" as it is split on MELPA).

-- 
Alex

Message #23 received at 27302 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 27302 <at> debbugs.gnu.org
Subject: Re: bug#27302: [PATCH 1/3] gnu: emacs-dired-hacks-utils: Change
 origin to melpa
Date: Fri, 16 Jun 2017 15:38:51 +0300

Oleg Pykhalov (2017-06-10 05:02 +0300) wrote:

> ---
>  gnu/packages/emacs.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 5f00a7ad5..d2b1056b6 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -4882,11 +4882,12 @@ displays results pretty-printed in XML or JSON with @code{restclient-mode}")
>       (origin
>         (method url-fetch)
>         (uri (string-append
> -             "https://github.com/Fuco1/dired-hacks/archive/master"
> -             ".tar.gz"))
> +             "http://melpa.org/packages/dired-hacks-utils-"
> +             version
> +             ".el"))

Unfortunately, we can't use sources from MELPA.  The problem is: when a
repository get a new commit, the old tarball is *REPLACED* with the new
one on MELPA, so the package could never be built anymore, since the
source disappeared.  That's why we use tarballs directly from source.

>         (sha256
>          (base32
> -         "180qfjjps3mg26zxwczj174qvbwivgn2h7haz1i8js9h1srl183r"))))
> +         "1378prbbvvdfi83ln1pwxanawynif6jmb3i5xd16igkjy6ads5qp"))))
>      (build-system emacs-build-system)
>      (propagated-inputs `(("emacs-dash" ,emacs-dash)))
>      (home-page "https://github.com/Fuco1/dired-hacks")

-- 
Alex

Message #26 received at 27302 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Kost <alezost <at> gmail.com>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 27302 <at> debbugs.gnu.org
Subject: Re: [bug#27302] [PATCH 1/2] gnu: Add emacs-dired-hacks-utils.
Date: Thu, 22 Jun 2017 22:02:58 +0200

Hi!

Alex Kost <alezost <at> gmail.com> skribis:

> Hello, thanks for the patches and sorry for the delay!
>
> I see that this "dired-hacks" repository is split into multiple packages
> on MELPA, and you follow this path, however I think it would be much
> easier for us just to have a single "emacs-dired-hacks" package.
> Otherwise, we'll have to pick single files for all these "dired-open",
> "dired-avfs" and other packages, which is not convenient.
>
> What do you think?  Are there any objections on making a single
> "dired-hacks" package?

I think Oleg’s lack of response might suggest that we should apply the
patch as-is.  :-)  WDYT, Alex?  Having separate packages may be better
than nothing at all.

Ludo’.

Message #29 received at 27302 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 27302 <at> debbugs.gnu.org
Subject: Re: [bug#27302] [PATCH 1/2] gnu: Add emacs-dired-hacks-utils.
Date: Fri, 23 Jun 2017 21:55:31 +0300

Ludovic Courtès (2017-06-22 22:02 +0200) wrote:

> Hi!
>
> Alex Kost <alezost <at> gmail.com> skribis:
>
>> Hello, thanks for the patches and sorry for the delay!
>>
>> I see that this "dired-hacks" repository is split into multiple packages
>> on MELPA, and you follow this path, however I think it would be much
>> easier for us just to have a single "emacs-dired-hacks" package.
>> Otherwise, we'll have to pick single files for all these "dired-open",
>> "dired-avfs" and other packages, which is not convenient.
>>
>> What do you think?  Are there any objections on making a single
>> "dired-hacks" package?
>
> I think Oleg’s lack of response might suggest that we should apply the
> patch as-is.  :-)  WDYT, Alex?  Having separate packages may be better
> than nothing at all.

Right, the problem however is that MELPA sources are used to get these
packages.  I can make a single "dired-hacks" package if it's reasonable.
OTOH if multiple packages are somehow "better", then we have to make
multiple recipes.

-- 
Alex

Message #32 received at 27302 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 27302 <at> debbugs.gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, Alex Kost <alezost <at> gmail.com>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: emacs-dired-hacks-utils in one patch with github origin
Date: Sat, 24 Jun 2017 08:41:06 +0300

[Message part 1 (text/plain, inline)]

Hi Alex,

Alex Kost <alezost <at> gmail.com> writes:

> Unfortunately, we can't use sources from MELPA.  The problem is: when a
> repository get a new commit, the old tarball is *REPLACED* with the new
> one on MELPA, so the package could never be built anymore, since the
> source disappeared.  That's why we use tarballs directly from source.

OK.  I saw some melpa packages in emacs.scm though.  Will they be
removed in future?

> I see that this "dired-hacks" repository is split into multiple packages
> on MELPA, and you follow this path, however I think it would be much
> easier for us just to have a single "emacs-dired-hacks" package.
> Otherwise, we'll have to pick single files for all these "dired-open",
> "dired-avfs" and other packages, which is not convenient.
>
> What do you think?  Are there any objections on making a single
> "dired-hacks" package?

I'm not sure if splitting is worth.  I use only dired-open from this
project.  So, I cannot be sure about other addons.  For example, I have
some warnings and errors while building full addons collection but
dired-open works though.

[Message part 2 (text/plain, inline)]

natsu <at> magnolia ~/src/guix$ guix build -K emacs-dired-hacks-utils
substitute: updating list of substitutes from 'https://mirror.hydra.gnu.org'... 100.0%
substitute: updating list of substitutes from 'https://mirror.hydra.gnu.org'... 100.0%
substitute: updating list of substitutes from 'https://mirror.hydra.gnu.org'... 100.0%
substitute: updating list of substitutes from 'https://mirror.hydra.gnu.org'... 100.0%
@ build-started /gnu/store/pxfjlm6w511s84nhzslpdpxpygc5r307-git-checkout.drv - x86_64-linux /var/log/guix/drvs/px//fjlm6w511s84nhzslpdpxpygc5r307-git-checkout.drv.bz2
Cloning into '/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout'...
Note: checking out 'eda68006ce73bbf6b9b995bfd70d08bec8cade36'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at eda6800... [rainbow] Add debug forms #72
environment variable `PATH' unset
@ build-succeeded /gnu/store/pxfjlm6w511s84nhzslpdpxpygc5r307-git-checkout.drv -
@ build-started /gnu/store/2zsdi38cfkj4d8dfzsdn97dayg8gv6m4-emacs-dired-hacks-utils-20160527.1436.drv - x86_64-linux /var/log/guix/drvs/2z//sdi38cfkj4d8dfzsdn97dayg8gv6m4-emacs-dired-hacks-utils-20160527.1436.drv.bz2
starting phase `set-SOURCE-DATE-EPOCH'
phase `set-SOURCE-DATE-EPOCH' succeeded after 0.0 seconds
starting phase `set-paths'
environment variable `PATH' set to `/gnu/store/a1b9nl9fwzr51fsrg4aji1s4dafakpzv-emacs-minimal-25.2/bin:/gnu/store/mfx9ib0cy6mvjfmszplnlh0dvdb0513v-tar-1.29/bin:/gnu/store/8wmanahsh0mk1n5xw6i7wpwih95yqzaq-gzip-1.8/bin:/gnu/store/8nkj1w5whm5gwrhsmqvm1w6im27vz02g-bzip2-1.0.6/bin:/gnu/store/c140q16b1n4x0j2i7wv1awc1c39ipzrr-xz-5.2.2/bin:/gnu/store/0xm7szwymsv87z7y4bi2lgvx2jhniqms-file-5.28/bin:/gnu/store/kbs0012il9z63kp0nlq0h66m6zjp4f21-diffutils-3.5/bin:/gnu/store/qbngj80kmydl4jsba2cdgwq2y51xlfv0-patch-2.7.5/bin:/gnu/store/z763jk8lkragpz2qr2wbrz946lgalx2h-sed-4.4/bin:/gnu/store/gdgrzf1y15scqwk1yzm51dc40g29vad9-findutils-4.6.0/bin:/gnu/store/55r4yg5iw9zh2j3zvzc6272k5xn4yxg4-gawk-4.1.4/bin:/gnu/store/87sj03j9kwzhl9zr76gs2i8ill86ki95-grep-3.0/bin:/gnu/store/6908gy3pws0ccys49ni98idwnicchlr2-coreutils-8.26/bin:/gnu/store/alg6ani0nnwrxyz15d1j5d0k6qs2m5sk-make-4.2.1/bin:/gnu/store/k7029k5va68lkapbzcycdzj7m5bjb4b8-bash-4.4.12/bin:/gnu/store/ri56wnmzkgzrajdyl5ydc55lrwy1164k-ld-wrapper-0/bin:/gnu/store/zq65kpvwwxgc3qqbf9apic8gyss2l0zq-binutils-2.27/bin:/gnu/store/4iw4r2majarqlm19adaikqw126jxqf2p-gcc-5.4.0/bin:/gnu/store/rmjlycdgiq8pfy5hfi42qhw3k7p6kdav-glibc-2.25/bin:/gnu/store/rmjlycdgiq8pfy5hfi42qhw3k7p6kdav-glibc-2.25/sbin'
environment variable `INFOPATH' set to `/gnu/store/a1b9nl9fwzr51fsrg4aji1s4dafakpzv-emacs-minimal-25.2/share/info:/gnu/store/4ci68akj0ay6jcddh4mhxk0f40c00drw-emacs-dash-2.13.0/share/info:/gnu/store/mfx9ib0cy6mvjfmszplnlh0dvdb0513v-tar-1.29/share/info:/gnu/store/8wmanahsh0mk1n5xw6i7wpwih95yqzaq-gzip-1.8/share/info:/gnu/store/kbs0012il9z63kp0nlq0h66m6zjp4f21-diffutils-3.5/share/info:/gnu/store/z763jk8lkragpz2qr2wbrz946lgalx2h-sed-4.4/share/info:/gnu/store/gdgrzf1y15scqwk1yzm51dc40g29vad9-findutils-4.6.0/share/info:/gnu/store/55r4yg5iw9zh2j3zvzc6272k5xn4yxg4-gawk-4.1.4/share/info:/gnu/store/87sj03j9kwzhl9zr76gs2i8ill86ki95-grep-3.0/share/info:/gnu/store/6908gy3pws0ccys49ni98idwnicchlr2-coreutils-8.26/share/info:/gnu/store/alg6ani0nnwrxyz15d1j5d0k6qs2m5sk-make-4.2.1/share/info:/gnu/store/k7029k5va68lkapbzcycdzj7m5bjb4b8-bash-4.4.12/share/info:/gnu/store/zq65kpvwwxgc3qqbf9apic8gyss2l0zq-binutils-2.27/share/info:/gnu/store/4iw4r2majarqlm19adaikqw126jxqf2p-gcc-5.4.0/share/info:/gnu/store/rmjlycdgiq8pfy5hfi42qhw3k7p6kdav-glibc-2.25/share/info'
environment variable `BASH_LOADABLES_PATH' set to `/gnu/store/k7029k5va68lkapbzcycdzj7m5bjb4b8-bash-4.4.12/lib/bash'
environment variable `C_INCLUDE_PATH' set to `/gnu/store/8nkj1w5whm5gwrhsmqvm1w6im27vz02g-bzip2-1.0.6/include:/gnu/store/c140q16b1n4x0j2i7wv1awc1c39ipzrr-xz-5.2.2/include:/gnu/store/0xm7szwymsv87z7y4bi2lgvx2jhniqms-file-5.28/include:/gnu/store/55r4yg5iw9zh2j3zvzc6272k5xn4yxg4-gawk-4.1.4/include:/gnu/store/alg6ani0nnwrxyz15d1j5d0k6qs2m5sk-make-4.2.1/include:/gnu/store/zq65kpvwwxgc3qqbf9apic8gyss2l0zq-binutils-2.27/include:/gnu/store/4iw4r2majarqlm19adaikqw126jxqf2p-gcc-5.4.0/include:/gnu/store/rmjlycdgiq8pfy5hfi42qhw3k7p6kdav-glibc-2.25/include:/gnu/store/5bh7p754d09wcp64ckxlvwz7lgyk0h59-linux-libre-headers-4.4.47/include'
environment variable `CPLUS_INCLUDE_PATH' set to `/gnu/store/8nkj1w5whm5gwrhsmqvm1w6im27vz02g-bzip2-1.0.6/include:/gnu/store/c140q16b1n4x0j2i7wv1awc1c39ipzrr-xz-5.2.2/include:/gnu/store/0xm7szwymsv87z7y4bi2lgvx2jhniqms-file-5.28/include:/gnu/store/55r4yg5iw9zh2j3zvzc6272k5xn4yxg4-gawk-4.1.4/include:/gnu/store/alg6ani0nnwrxyz15d1j5d0k6qs2m5sk-make-4.2.1/include:/gnu/store/zq65kpvwwxgc3qqbf9apic8gyss2l0zq-binutils-2.27/include:/gnu/store/4iw4r2majarqlm19adaikqw126jxqf2p-gcc-5.4.0/include:/gnu/store/rmjlycdgiq8pfy5hfi42qhw3k7p6kdav-glibc-2.25/include:/gnu/store/5bh7p754d09wcp64ckxlvwz7lgyk0h59-linux-libre-headers-4.4.47/include'
environment variable `LIBRARY_PATH' set to `/gnu/store/8nkj1w5whm5gwrhsmqvm1w6im27vz02g-bzip2-1.0.6/lib:/gnu/store/c140q16b1n4x0j2i7wv1awc1c39ipzrr-xz-5.2.2/lib:/gnu/store/0xm7szwymsv87z7y4bi2lgvx2jhniqms-file-5.28/lib:/gnu/store/55r4yg5iw9zh2j3zvzc6272k5xn4yxg4-gawk-4.1.4/lib:/gnu/store/k7029k5va68lkapbzcycdzj7m5bjb4b8-bash-4.4.12/lib:/gnu/store/zq65kpvwwxgc3qqbf9apic8gyss2l0zq-binutils-2.27/lib:/gnu/store/rmjlycdgiq8pfy5hfi42qhw3k7p6kdav-glibc-2.25/lib:/gnu/store/1h0p1lgl5i1dmwa0rzxflv664zwwm6am-glibc-utf8-locales-2.25/lib'
environment variable `GUIX_LOCPATH' set to `/gnu/store/1h0p1lgl5i1dmwa0rzxflv664zwwm6am-glibc-utf8-locales-2.25/lib/locale'
phase `set-paths' succeeded after 0.0 seconds
starting phase `install-locale'
using 'en_US.utf8' locale for category "LC_ALL"
phase `install-locale' succeeded after 0.0 seconds
starting phase `unpack'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/Cask' -> `./Cask'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-ranger.el' -> `./dired-ranger.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-narrow.el' -> `./dired-narrow.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-columns.el' -> `./dired-columns.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-images.el' -> `./dired-images.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-avfs.el' -> `./dired-avfs.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-filter.el' -> `./dired-filter.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-tagsistant.el' -> `./dired-tagsistant.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-hacks-utils.el' -> `./dired-hacks-utils.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-subtree.el' -> `./dired-subtree.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-rainbow.el' -> `./dired-rainbow.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/.travis.yml' -> `./.travis.yml'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-list.el' -> `./dired-list.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/.gitignore' -> `./.gitignore'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/README.md' -> `./README.md'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/dired-open.el' -> `./dired-open.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/tests/test-dired-filter.el' -> `./tests/test-dired-filter.el'
`/gnu/store/f4w8789pvpzhma8zx3cls5cnpbn6yq57-git-checkout/tests/test-dired-utils.el' -> `./tests/test-dired-utils.el'
phase `unpack' succeeded after 0.0 seconds
starting phase `patch-usr-bin-file'
phase `patch-usr-bin-file' succeeded after 0.0 seconds
starting phase `patch-source-shebangs'
phase `patch-source-shebangs' succeeded after 0.0 seconds
starting phase `patch-generated-file-shebangs'
phase `patch-generated-file-shebangs' succeeded after 0.0 seconds
starting phase `install'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-avfs.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-avfs.el'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-columns.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-columns.el'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-filter.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-filter.el'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-hacks-utils.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-hacks-utils.el'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-images.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-images.el'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-list.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-list.el'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-narrow.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-narrow.el'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-open.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-open.el'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-rainbow.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-rainbow.el'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-ranger.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-ranger.el'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-subtree.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-subtree.el'
`/tmp/guix-build-emacs-dired-hacks-utils-20160527.1436.drv-0/source/dired-tagsistant.el' -> `/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-tagsistant.el'
phase `install' succeeded after 0.0 seconds
starting phase `make-autoloads'
phase `make-autoloads' succeeded after 0.0 seconds
starting phase `move-doc'
phase `move-doc' succeeded after 0.0 seconds
starting phase `patch-el-files'
phase `patch-el-files' succeeded after 0.0 seconds
starting phase `build'
Checking /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/...
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-avfs.el...
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-columns.el...

In toplevel form:
dired-columns.el:1:1:Error: Cannot open load file: No such file or directory, s
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-filter.el...

In toplevel form:
dired-filter.el:231:1:Error: Cannot open load file: No such file or directory, f
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-hacks-utils-autoloads.el...
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-hacks-utils.el...
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-images.el...

In toplevel form:
dired-images.el:4:1:Error: Cannot open load file: No such file or directory, eimp
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-list.el...

In dired-list--get-ignored-stuff:
dired-list.el:273:56:Warning: reference to free variable ‘dir’
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-narrow.el...
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-open.el...
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-rainbow.el...
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-ranger.el...
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-subtree.el...

In dired-subtree--readin:
dired-subtree.el:477:21:Warning: looking-back called with 1 argument, but
    requires 2-3

In dired-subtree-apply-filter:
dired-subtree.el:716:33:Warning: reference to free variable ‘dired-filter-map’

In end of data:
dired-subtree.el:781:1:Warning: the following functions are not known to be
    defined: dired-details-delete-overlays, dired-details-activate,
    tramp-tramp-file-p, tramp-sh-handle-file-directory-p,
    tramp-handle-insert-directory, dired-filter--describe-filters,
    dired-filter--expunge
Compiling /gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436/share/emacs/site-lisp/guix.d/dired-hacks-utils-20160527.1436/dired-tagsistant.el...

In toplevel form:
dired-tagsistant.el:33:1:Error: Cannot open load file: No such file or directory, f
Done (Total of 8 files compiled, 4 failed, 1 skipped)
phase `build' succeeded after 0.2 seconds
starting phase `patch-shebangs'
phase `patch-shebangs' succeeded after 0.0 seconds
starting phase `strip'
phase `strip' succeeded after 0.0 seconds
starting phase `validate-runpath'
phase `validate-runpath' succeeded after 0.0 seconds
starting phase `validate-documentation-location'
phase `validate-documentation-location' succeeded after 0.0 seconds
starting phase `delete-info-dir-file'
phase `delete-info-dir-file' succeeded after 0.0 seconds
starting phase `patch-dot-desktop-files'
phase `patch-dot-desktop-files' succeeded after 0.0 seconds
starting phase `reset-gzip-timestamps'
phase `reset-gzip-timestamps' succeeded after 0.0 seconds
starting phase `compress-documentation'
phase `compress-documentation' succeeded after 0.0 seconds
@ build-succeeded /gnu/store/2zsdi38cfkj4d8dfzsdn97dayg8gv6m4-emacs-dired-hacks-utils-20160527.1436.drv -
/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436
natsu <at> magnolia ~/src/guix$ guix package -i emacs-dired-hacks-utils
The following package will be installed:
   emacs-dired-hacks-utils	20160527.1436	/gnu/store/v60m1k4mr11gmqyn33m94n34575yf4q4-emacs-dired-hacks-utils-20160527.1436

114 packages in profile
natsu <at> magnolia ~/src/guix$ 

[Message part 3 (text/plain, inline)]

> If you think a single package is appropriate, could you make a patch for
> it?
>
> Since "dired-hacks" has no releases, we have to use 'git-fetch' instead
> of 'url-fetch' for source.  It should look something like this:
>
> (define-public emacs-dired-hacks
>   (let ((commit "eda68006ce73bbf6b9b995bfd70d08bec8cade36")
>         (revision "1"))
>     (package
>       (name "emacs-dired-hacks")
>       (version (string-append "0.0.0-" revision "."
>                               (string-take commit 7)))
>       (source (origin
>                 (method git-fetch)
>                 (uri (git-reference
>                       (url "https://github.com/Fuco1/dired-hacks.git")
>                       (commit commit)))
>                 (file-name (string-append name "-" version "-checkout"))
>                 (sha256
>                  (base32
>                   "some-letters-and-numbers-here"))))
>       ...)))
>
>
> BTW we already have a single "emacs-ivy" package (instead of "ivy",
> "swiper" and "counsel" as it is split on MELPA).

Thanks, I prepared all this in one patch.

[0001-gnu-Add-emacs-dired-hacks-utils.patch (text/x-patch, inline)]

From 1a22aef22f0eec6c9dd8dc9a20964e11700834d7 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Sat, 10 Jun 2017 02:59:25 +0300
Subject: [PATCH] gnu: Add emacs-dired-hacks-utils.

---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 4d8a230b1..80548a514 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4896,3 +4896,26 @@ running a customisable handler command (@code{ignore} by default). ")
 from within Emacs.  Restclient runs queries from a plan-text query sheet,
 displays results pretty-printed in XML or JSON with @code{restclient-mode}")
       (license license:public-domain))))
+
+(define-public emacs-dired-hacks-utils
+  (package
+    (name "emacs-dired-hacks-utils")
+    (version "20160527.1436")
+    (source (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Fuco1/dired-hacks.git")
+             (commit "eda68006ce73bbf6b9b995bfd70d08bec8cade36")))
+       (sha256
+        (base32
+         "1w7ssl9zssn5rcha6apf4h8drkd02k4xgvs203bdbqyqp9wz9brx"))))
+    (build-system emacs-build-system)
+    (propagated-inputs `(("emacs-dash" ,emacs-dash)))
+    (home-page "https://github.com/Fuco1/dired-hacks")
+    (synopsis
+     "Collection of useful dired additions")
+    (description
+     "Collection of Emacs dired mode additions dired-avfs dired-columns
+dired-filter dired-hacks-utils dired-images dired-list dired-narrow dired-open
+dired-rainbow dired-ranger dired-subtree dired-tagsistant.")
+    (license license:gpl3+)))
-- 
2.13.1

[Message part 5 (text/plain, inline)]

Hi Ludovic,

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hi!
>
> I think Oleg’s lack of response might suggest that we should apply the
> patch as-is.  :-)  WDYT, Alex?  Having separate packages may be better
> than nothing at all.
>
> Ludo’.

Sorry for delay.  I had some issues with health and cannot follow this
thread.

Message #37 received at 27302-done <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 27302-done <at> debbugs.gnu.org
Subject: Re: emacs-dired-hacks-utils in one patch with github origin
Date: Sat, 24 Jun 2017 22:04:55 +0300

Oleg Pykhalov (2017-06-24 08:41 +0300) wrote:

> Hi Alex,
>
> Alex Kost <alezost <at> gmail.com> writes:
>
>> Unfortunately, we can't use sources from MELPA.  The problem is: when a
>> repository get a new commit, the old tarball is *REPLACED* with the new
>> one on MELPA, so the package could never be built anymore, since the
>> source disappeared.  That's why we use tarballs directly from source.
>
> OK.  I saw some melpa packages in emacs.scm though.  Will they be
> removed in future?

I see the only package that uses MELPA source ("emacs-keyfreq"), and it
was definitely done so by mistake.  It will not be removed, instead it
should be adjusted to use a source directly from the upstream which is:

  https://github.com/dacap/keyfreq/archive/1.8.tar.gz

>> I see that this "dired-hacks" repository is split into multiple packages
>> on MELPA, and you follow this path, however I think it would be much
>> easier for us just to have a single "emacs-dired-hacks" package.
>> Otherwise, we'll have to pick single files for all these "dired-open",
>> "dired-avfs" and other packages, which is not convenient.
>>
>> What do you think?  Are there any objections on making a single
>> "dired-hacks" package?
>
> I'm not sure if splitting is worth.  I use only dired-open from this
> project.  So, I cannot be sure about other addons.  For example, I have
> some warnings and errors while building full addons collection but
> dired-open works though.

Oh, most of those warnings (like "function is not known to be defined"
or "reference to free variable") are the usual warnings that should be
fixed by the maintainer.  These warnings are harmless, most maintainers
don't even bother to fix them.  And the errors come from missing
libraries: "emacs-s" and "emacs-f" are needed for some files.

As for splitting this package into multiple ones, I think it may be done
in future, if someone will have a wish to do it :-)

[...]
> From 1a22aef22f0eec6c9dd8dc9a20964e11700834d7 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Sat, 10 Jun 2017 02:59:25 +0300
> Subject: [PATCH] gnu: Add emacs-dired-hacks-utils.

Thank you, I added a copyright line for you, adjusted the package recipe
a bit, and committed:

  http://git.savannah.gnu.org/cgit/guix.git/commit/?id=730c0790fc5b3285cd0f1983804e2d76c37cb542

Thanks for contributing!

-- 
Alex

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.