From unknown Tue Aug 19 09:31:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27291: [PATCH 0/2] Provide a Schemey interface to the Rottlog service Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Jun 2017 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27291 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 27291@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.149695392112483 (code B ref -1); Thu, 08 Jun 2017 20:32:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jun 2017 20:32:01 +0000 Received: from localhost ([127.0.0.1]:35517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJ464-0003FH-PQ for submit@debbugs.gnu.org; Thu, 08 Jun 2017 16:32:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJ463-0003F4-C2 for submit@debbugs.gnu.org; Thu, 08 Jun 2017 16:31:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJ45x-0005b4-EC for submit@debbugs.gnu.org; Thu, 08 Jun 2017 16:31:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42484) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dJ45x-0005az-BM for submit@debbugs.gnu.org; Thu, 08 Jun 2017 16:31:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJ45w-0001bc-CW for guix-patches@gnu.org; Thu, 08 Jun 2017 16:31:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJ45v-0005aj-Ji for guix-patches@gnu.org; Thu, 08 Jun 2017 16:31:52 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJ45q-0005a1-I5; Thu, 08 Jun 2017 16:31:46 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:50320 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dJ45p-0001Dk-Md; Thu, 08 Jun 2017 16:31:46 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Thu, 8 Jun 2017 22:31:34 +0200 Message-Id: <20170608203134.20079-1-ludo@gnu.org> X-Mailer: git-send-email 2.13.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello! This patch series changes the interface to the rottlog service, providing a more Schemey interface. It changes the API in an incompatible way though, so I’m posting here for review. If there are no objections, I’d like to commit it within a couple of days. Ludo’. Ludovic Courtès (2): services: rottlog: Define objects. services: rottlog: Make extensible. doc/guix.texi | 61 ++++++++++++++++++-------- gnu/services/admin.scm | 116 ++++++++++++++++++++++++++++++++++++------------- 2 files changed, 127 insertions(+), 50 deletions(-) -- 2.13.0 From unknown Tue Aug 19 09:31:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27291: [PATCH 1/2] services: rottlog: Define objects. References: <20170608203134.20079-1-ludo@gnu.org> In-Reply-To: <20170608203134.20079-1-ludo@gnu.org> Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Jun 2017 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27291 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 27291@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 27291-submit@debbugs.gnu.org id=B27291.149695525614825 (code B ref 27291); Thu, 08 Jun 2017 20:55:02 +0000 Received: (at 27291) by debbugs.gnu.org; 8 Jun 2017 20:54:16 +0000 Received: from localhost ([127.0.0.1]:35547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJ4Rc-0003r3-1D for submit@debbugs.gnu.org; Thu, 08 Jun 2017 16:54:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJ4RY-0003qc-Qg for 27291@debbugs.gnu.org; Thu, 08 Jun 2017 16:54:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJ4RS-0006dP-GH for 27291@debbugs.gnu.org; Thu, 08 Jun 2017 16:54:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJ4RO-0006c5-L8; Thu, 08 Jun 2017 16:54:02 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:50334 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dJ4RN-0000Sl-Ai; Thu, 08 Jun 2017 16:54:02 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Thu, 8 Jun 2017 22:53:51 +0200 Message-Id: <20170608205352.21398-1-ludo@gnu.org> X-Mailer: git-send-email 2.13.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/services/admin.scm (): New record type. (syslog-rotation-config, simple-rotation-config): Remove. (%default-rotations): Define as a list of objects. (log-rotation->config, log-rotations->/etc-entries): New procedures. ()[periodic-rotations]: Remove. [rotations]: New field. (rottlog-etc): Use 'log-rotations->/etc-entries'. * doc/guix.texi (Log Rotation): Update accordingly. --- doc/guix.texi | 58 +++++++++++++++++--------- gnu/services/admin.scm | 110 +++++++++++++++++++++++++++++++++++-------------- 2 files changed, 118 insertions(+), 50 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index f69c84dea..597fb9812 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -9542,7 +9542,7 @@ services admin)} module provides an interface to GNU@tie{}Rot[t]log, a log rotation tool (@pxref{Top,,, rottlog, GNU Rot[t]log Manual}). The example below defines an operating system that provides log rotation -with the default settings. +with the default settings, for commonly encountered log files. @lisp (use-modules (guix) (gnu)) @@ -9575,23 +9575,8 @@ The Rottlog package to use. The Rottlog configuration file to use (@pxref{Mandatory RC Variables,,, rottlog, GNU Rot[t]log Manual}). -@item @code{periodic-rotations} (default: @code{`(("weekly" %default-rotations))}) -A list of Rottlog period-name/period-config tuples. - -For example, taking an example from the Rottlog manual (@pxref{Period -Related File Examples,,, rottlog, GNU Rot[t]log Manual}), a valid tuple -might be: - -@example -("daily" ,(plain-file "daily" - "\ - /var/log/apache/* @{ - storedir apache-archives - rotate 6 - notifempty - nocompress - @}")) -@end example +@item @code{rotations} (default: @code{%default-rotations}) +A list of @code{log-rotation} objects as defined below. @item @code{jobs} This is a list of gexps where each gexp corresponds to an mcron job @@ -9599,9 +9584,44 @@ specification (@pxref{Scheduled Job Execution}). @end table @end deftp +@deftp {Data Type} log-rotation +Data type representing the rotation of a group of log files. + +Taking an example from the Rottlog manual (@pxref{Period Related File +Examples,,, rottlog, GNU Rot[t]log Manual}), a log rotation might be +defined like this: + +@example +(log-rotation + (frequency 'daily) + (files '("/var/log/apache/*")) + (options '("storedir apache-archives" + "rotate 6" + "notifempty" + "nocompress"))) +@end example + +The list of fields is as follows: + +@table @asis +@item @code{frequency} (default: @code{'weekly}) +The log rotation frequency, a symbol. + +@item @code{files} +The list of files or file glob patterns to rotate. + +@item @code{options} (default: @code{'()}) +The list of rottlog options for this rotation (@pxref{Configuration +parameters,,, rottlog, GNU Rot[t]lg Manual}). + +@item @code{post-rotate} (default: @code{#f}) +Either @code{#f} or a gexp to execute once the rotation has completed. +@end table +@end deftp + @defvr {Scheme Variable} %default-rotations Specifies weekly rotation of @var{%rotated-files} and -@code{"/var/log/shepherd.log"}. +a couple of other files. @end defvr @defvr {Scheme Variable} %rotated-files diff --git a/gnu/services/admin.scm b/gnu/services/admin.scm index 6ac24e32b..99f3b1da1 100644 --- a/gnu/services/admin.scm +++ b/gnu/services/admin.scm @@ -27,8 +27,17 @@ #:use-module (guix packages) #:use-module (guix records) #:use-module (srfi srfi-1) + #:use-module (ice-9 vlist) #:export (%default-rotations %rotated-files + + log-rotation + log-rotation? + log-rotation-frequency + log-rotation-files + log-rotation-options + log-rotation-post-rotate + rottlog-configuration rottlog-configuration? rottlog-service @@ -40,41 +49,78 @@ ;;; /etc/rottlog/{rc,hourly|daily|weekly}. Example usage ;;; ;;; (mcron-service) -;;; (service rottlog-service-type (rottlog-configuration)) +;;; (service rottlog-service-type) ;;; ;;; Code: +(define-record-type* log-rotation make-log-rotation + log-rotation? + (files log-rotation-files) ;list of strings + (frequency log-rotation-frequency ;symbol + (default 'weekly)) + (post-rotate log-rotation-post-rotate ;#f | gexp + (default #f)) + (options log-rotation-options ;list of strings + (default '()))) + (define %rotated-files ;; Syslog files subject to rotation. '("/var/log/messages" "/var/log/secure" "/var/log/maillog")) -(define (syslog-rotation-config files) - #~(string-append #$(string-join files ",") - " { - sharedscripts - postrotate - " #$coreutils "/bin/kill -HUP $(cat /var/run/syslog.pid) 2> /dev/null - endscript -} -")) - -(define (simple-rotation-config files) - #~(string-append #$(string-join files ",") " { - sharedscripts -} -")) - (define %default-rotations - `(("weekly" - ,(computed-file "rottlog.weekly" - #~(call-with-output-file #$output - (lambda (port) - (display #$(syslog-rotation-config %rotated-files) - port) - (display #$(simple-rotation-config - '("/var/log/shepherd.log" - "/var/log/guix-daemon.log")) - port))))))) + (list (log-rotation ;syslog files + (files %rotated-files) + + ;; Restart syslogd after rotation. + (options '("sharedscripts")) + (post-rotate #~(let ((pid (call-with-input-file "/var/run/syslog.pid" + read))) + (kill pid SIGHUP)))) + (log-rotation + (files '("/var/log/shepherd.log" "/var/log/guix-daemon.log"))))) + +(define (log-rotation->config rotation) + "Return a string-valued gexp representing the rottlog configuration snippet +for ROTATION." + (define post-rotate + (let ((post (log-rotation-post-rotate rotation))) + (and post + (program-file "rottlog-post-rotate.scm" post)))) + + #~(let ((post #$post-rotate)) + (string-append (string-join '#$(log-rotation-files rotation) ",") + " {" + #$(string-join (log-rotation-options rotation) + "\n " 'prefix) + (if post + (string-append "\n postrotate\n " post + "\n endscript\n") + "") + "\n}\n"))) + +(define (log-rotations->/etc-entries rotations) + "Return the list of /etc entries for ROTATIONS, a list of ." + (define (frequency-file frequency rotations) + (computed-file (string-append "rottlog." (symbol->string frequency)) + #~(call-with-output-file #$output + (lambda (port) + (for-each (lambda (str) + (display str port)) + (list #$@(map log-rotation->config + rotations))))))) + + (let* ((frequencies (delete-duplicates + (map log-rotation-frequency rotations))) + (table (fold (lambda (rotation table) + (vhash-consq (log-rotation-frequency rotation) + rotation table)) + vlist-null + rotations))) + (map (lambda (frequency) + `(,(symbol->string frequency) + ,(frequency-file frequency + (vhash-foldq* cons '() frequency table)))) + frequencies))) (define (default-jobs rottlog) (list #~(job '(next-hour '(0)) ;midnight @@ -91,15 +137,17 @@ (default rottlog)) (rc-file rottlog-rc-file ;file-like (default (file-append rottlog "/etc/rc"))) - (periodic-rotations rottlog-periodic-rotations ;list of (name file) tuples + (rotations rottlog-rotations ;list of (default %default-rotations)) (jobs rottlog-jobs ;list of (default #f))) (define (rottlog-etc config) - `(("rottlog" ,(file-union "rottlog" - (cons `("rc" ,(rottlog-rc-file config)) - (rottlog-periodic-rotations config)))))) + `(("rottlog" + ,(file-union "rottlog" + (cons `("rc" ,(rottlog-rc-file config)) + (log-rotations->/etc-entries + (rottlog-rotations config))))))) (define (rottlog-jobs-or-default config) (or (rottlog-jobs config) -- 2.13.0 From unknown Tue Aug 19 09:31:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27291: [PATCH 2/2] services: rottlog: Make extensible. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Jun 2017 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27291 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 27291@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 27291-submit@debbugs.gnu.org id=B27291.149695525714833 (code B ref 27291); Thu, 08 Jun 2017 20:55:02 +0000 Received: (at 27291) by debbugs.gnu.org; 8 Jun 2017 20:54:17 +0000 Received: from localhost ([127.0.0.1]:35549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJ4Rd-0003rB-Dd for submit@debbugs.gnu.org; Thu, 08 Jun 2017 16:54:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJ4RZ-0003qf-Pc for 27291@debbugs.gnu.org; Thu, 08 Jun 2017 16:54:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJ4RT-0006dr-Rb for 27291@debbugs.gnu.org; Thu, 08 Jun 2017 16:54:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJ4RR-0006d0-RE; Thu, 08 Jun 2017 16:54:05 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:50334 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dJ4RR-0000Sl-0E; Thu, 08 Jun 2017 16:54:05 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Thu, 8 Jun 2017 22:53:52 +0200 Message-Id: <20170608205352.21398-2-ludo@gnu.org> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170608205352.21398-1-ludo@gnu.org> References: <20170608205352.21398-1-ludo@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/services/admin.scm (rottlog-service-type)[compose, extend]: New fields. * doc/guix.texi (Log Rotation): Mention extension. --- doc/guix.texi | 3 +++ gnu/services/admin.scm | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index 597fb9812..8a08fd9f7 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -9560,6 +9560,9 @@ with the default settings, for commonly encountered log files. This is the type of the Rottlog service, whose value is a @code{rottlog-configuration} object. +Other services can extend this one with new @code{log-rotation} objects +(see below), thereby augmenting the set of files to be rotated. + This service type can define mcron jobs (@pxref{Scheduled Job Execution}) to run the rottlog service. @end defvr diff --git a/gnu/services/admin.scm b/gnu/services/admin.scm index 99f3b1da1..b9e3fa70a 100644 --- a/gnu/services/admin.scm +++ b/gnu/services/admin.scm @@ -164,6 +164,12 @@ for ROTATION." ;; the documentation. (service-extension profile-service-type (compose list rottlog-rottlog)))) + (compose concatenate) + (extend (lambda (config rotations) + (rottlog-configuration + (inherit config) + (rotations (append (rottlog-rotations config) + rotations))))) (default-value (rottlog-configuration)))) ;;; admin.scm ends here -- 2.13.0 From unknown Tue Aug 19 09:31:44 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#27291: closed (Re: bug#27291: [PATCH 0/2] Provide a Schemey interface to the Rottlog service) Message-ID: References: <87a85c51qe.fsf@gnu.org> <20170608203134.20079-1-ludo@gnu.org> X-Gnu-PR-Message: they-closed 27291 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 27291@debbugs.gnu.org Date: Mon, 12 Jun 2017 21:35:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1497303303-7712-1" This is a multi-part message in MIME format... ------------=_1497303303-7712-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #27291: [PATCH 0/2] Provide a Schemey interface to the Rottlog service which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 27291@debbugs.gnu.org. --=20 27291: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27291 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1497303303-7712-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 27291-done) by debbugs.gnu.org; 12 Jun 2017 21:35:03 +0000 Received: from localhost ([127.0.0.1]:44119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKWzG-000208-Jd for submit@debbugs.gnu.org; Mon, 12 Jun 2017 17:35:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKWzE-0001zM-RR for 27291-done@debbugs.gnu.org; Mon, 12 Jun 2017 17:35:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKWz6-0003d1-NC for 27291-done@debbugs.gnu.org; Mon, 12 Jun 2017 17:34:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKWz6-0003cv-LB for 27291-done@debbugs.gnu.org; Mon, 12 Jun 2017 17:34:52 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:33452 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dKWz5-0004IN-V1 for 27291-done@debbugs.gnu.org; Mon, 12 Jun 2017 17:34:52 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: 27291-done@debbugs.gnu.org Subject: Re: bug#27291: [PATCH 0/2] Provide a Schemey interface to the Rottlog service References: <20170608203134.20079-1-ludo@gnu.org> Date: Mon, 12 Jun 2017 23:34:49 +0200 In-Reply-To: <20170608203134.20079-1-ludo@gnu.org> ("Ludovic \=\?utf-8\?Q\?Cou\?\= \=\?utf-8\?Q\?rt\=C3\=A8s\=22's\?\= message of "Thu, 8 Jun 2017 22:31:34 +0200") Message-ID: <87a85c51qe.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27291-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ludovic Court=C3=A8s skribis: > This patch series changes the interface to the rottlog service, > providing a more Schemey interface. It changes the API in an > incompatible way though, so I=E2=80=99m posting here for review. > > If there are no objections, I=E2=80=99d like to commit it within a couple= of > days. Done! Ludo'. ------------=_1497303303-7712-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Jun 2017 20:32:01 +0000 Received: from localhost ([127.0.0.1]:35517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJ464-0003FH-PQ for submit@debbugs.gnu.org; Thu, 08 Jun 2017 16:32:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJ463-0003F4-C2 for submit@debbugs.gnu.org; Thu, 08 Jun 2017 16:31:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJ45x-0005b4-EC for submit@debbugs.gnu.org; Thu, 08 Jun 2017 16:31:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42484) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dJ45x-0005az-BM for submit@debbugs.gnu.org; Thu, 08 Jun 2017 16:31:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJ45w-0001bc-CW for guix-patches@gnu.org; Thu, 08 Jun 2017 16:31:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJ45v-0005aj-Ji for guix-patches@gnu.org; Thu, 08 Jun 2017 16:31:52 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJ45q-0005a1-I5; Thu, 08 Jun 2017 16:31:46 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:50320 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dJ45p-0001Dk-Md; Thu, 08 Jun 2017 16:31:46 -0400 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= To: guix-patches@gnu.org Subject: [PATCH 0/2] Provide a Schemey interface to the Rottlog service Date: Thu, 8 Jun 2017 22:31:34 +0200 Message-Id: <20170608203134.20079-1-ludo@gnu.org> X-Mailer: git-send-email 2.13.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: =?UTF-8?q?Ludovic=20Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello! This patch series changes the interface to the rottlog service, providing a more Schemey interface. It changes the API in an incompatible way though, so I’m posting here for review. If there are no objections, I’d like to commit it within a couple of days. Ludo’. Ludovic Courtès (2): services: rottlog: Define objects. services: rottlog: Make extensible. doc/guix.texi | 61 ++++++++++++++++++-------- gnu/services/admin.scm | 116 ++++++++++++++++++++++++++++++++++++------------- 2 files changed, 127 insertions(+), 50 deletions(-) -- 2.13.0 ------------=_1497303303-7712-1--