GNU bug report logs - #27279
[PATCH] gnu: Add tmuxifier.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27279 in the body.
You can then email your comments to 27279 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add tmuxifier.
Date: Wed, 07 Jun 2017 22:53:44 +0200

[0001-gnu-Add-tmuxifier.patch (text/x-diff, inline)]

From 042aa8603b9d42d189f23cfd8bfb64da3b9eccd0 Mon Sep 17 00:00:00 2001
From: Stefan Reichoer <stefan <at> xsteve.at>
Date: Wed, 7 Jun 2017 22:51:19 +0200
Subject: [PATCH] gnu: Add tmuxifier.

* gnu/packages/tmux.scm (tmuxifier): New variable.
---
 gnu/packages/tmux.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/tmux.scm b/gnu/packages/tmux.scm
index 5b92df8..41be237 100644
--- a/gnu/packages/tmux.scm
+++ b/gnu/packages/tmux.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2016 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2016 Matthew Jordan <matthewjordandevops <at> yandex.com>
 ;;; Copyright © 2017 Vasile Dumitrascu <va511e <at> yahoo.com>
+;;; Copyright © 2017 Stefan Reichör <stefan <at> xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -89,3 +90,47 @@ continue running in the background, then later reattached.")
       (description "A collection of various themes for Tmux.")
       (license
        (non-copyleft "http://www.wtfpl.net/txt/copying/")))))
+
+(define-public tmuxifier
+  (package
+    (name "tmuxifier")
+    (version "0.13.0")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append
+                    "https://github.com/jimeh/tmuxifier/archive/v"
+                    version ".tar.gz"))
+             (sha256
+              (base32
+               "1j9fj6zg0j3sdn7svpybzsqh7876rv81zi437976kj7hxnyjkcz7"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure)
+                  (delete 'build)
+                  (replace 'install
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out    (assoc-ref %outputs "out"))
+                             (bindir (string-append out "/bin"))
+                             (share  (string-append out "/share/" ,name)))
+                        (install-file "bin/tmuxifier" bindir)
+                        (substitute* (string-append bindir "/tmuxifier")
+                          (("set -e")
+                           (string-append "TMUXIFIER=" share "\nset -e")))
+                        (for-each (lambda (init-script)
+                                    (install-file init-script (string-append
+                                                               share "/init")))
+                                  '("init.sh" "init.tcsh" "init.fish"))
+                        (for-each (lambda (dir)
+                                    (copy-recursively dir (string-append
+                                                           share "/" dir)))
+                                  '("completion" "lib" "libexec"
+                                    "templates"))))))))
+    (home-page "https://github.com/jimeh/tmuxifier")
+    (synopsis "Powerful session, window & pane management for Tmux")
+    (description "Tmuxifier allows you to easily create, edit, and load
+'layout' files, which are simple shell scripts where you use the tmux command
+and helper commands provided by tmuxifier to manage Tmux sessions and
+windows.")
+    (license expat)))
-- 
2.7.4

Message #8 received at 27279 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: Stefan Reichör <stefan <at> xsteve.at>
Cc: 27279 <at> debbugs.gnu.org
Subject: Re: bug#27279: [PATCH] gnu: Add tmuxifier.
Date: Fri, 16 Jun 2017 15:32:54 +0200

Stefan Reichör <stefan <at> xsteve.at> writes:

> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                    "https://github.com/jimeh/tmuxifier/archive/v"
> +                    version ".tar.gz"))
> +             (sha256
> +              (base32
> +               "1j9fj6zg0j3sdn7svpybzsqh7876rv81zi437976kj7hxnyjkcz7"))))

guix lint asks to add

     (file-name (string-append name "-" version ".tar.gz"))

to the source, so the downloaded tarball in the store is easily
recognizable.  Other than that, it looks good to me, so I can push with
that change, assuming it works (not a tmux user myself :) ).

cheers,

Thomas

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Reichör <stefan <at> xsteve.at>
To: guix-patches <at> gnu.org
Subject: Re: bug#27279: [PATCH] gnu: Add tmuxifier.
Date: Fri, 16 Jun 2017 21:33:46 +0200

[Message part 1 (text/plain, inline)]

Thomas Danckaert <post <at> thomasdanckaert.be> writes:

> Stefan Reichör <stefan <at> xsteve.at> writes:
>
>> +    (source (origin
>> +             (method url-fetch)
>> +             (uri (string-append
>> +                    "https://github.com/jimeh/tmuxifier/archive/v"
>> +                    version ".tar.gz"))
>> +             (sha256
>> +              (base32
>> +               "1j9fj6zg0j3sdn7svpybzsqh7876rv81zi437976kj7hxnyjkcz7"))))
>
> guix lint asks to add
>
>      (file-name (string-append name "-" version ".tar.gz"))
>
> to the source, so the downloaded tarball in the store is easily
> recognizable.  Other than that, it looks good to me, so I can push with
> that change, assuming it works (not a tmux user myself :) ).
>
> cheers,
>
> Thomas

Thanks for your review. I have added the file-name hint. guix lint asked
me to change '...' to @code{...}. So I changed this as well.


Stefan.

[0001-gnu-Add-tmuxifier.patch (text/x-diff, inline)]

From 85de44861bed37fb213aaf5dd9af331c7042fe18 Mon Sep 17 00:00:00 2001
From: Stefan Reichoer <stefan <at> xsteve.at>
Date: Fri, 16 Jun 2017 21:30:24 +0200
Subject: [PATCH] gnu: Add tmuxifier.

* gnu/packages/tmux.scm (tmuxifier): New variable.
---
 gnu/packages/tmux.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/tmux.scm b/gnu/packages/tmux.scm
index 5b92df8..0ffc3b9 100644
--- a/gnu/packages/tmux.scm
+++ b/gnu/packages/tmux.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2016 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2016 Matthew Jordan <matthewjordandevops <at> yandex.com>
 ;;; Copyright © 2017 Vasile Dumitrascu <va511e <at> yahoo.com>
+;;; Copyright © 2017 Stefan Reichör <stefan <at> xsteve.at>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -89,3 +90,48 @@ continue running in the background, then later reattached.")
       (description "A collection of various themes for Tmux.")
       (license
        (non-copyleft "http://www.wtfpl.net/txt/copying/")))))
+
+(define-public tmuxifier
+  (package
+    (name "tmuxifier")
+    (version "0.13.0")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append
+                    "https://github.com/jimeh/tmuxifier/archive/v"
+                    version ".tar.gz"))
+             (file-name (string-append name "-" version ".tar.gz"))
+             (sha256
+              (base32
+               "1j9fj6zg0j3sdn7svpybzsqh7876rv81zi437976kj7hxnyjkcz7"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure)
+                  (delete 'build)
+                  (replace 'install
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out    (assoc-ref %outputs "out"))
+                             (bindir (string-append out "/bin"))
+                             (share  (string-append out "/share/" ,name)))
+                        (install-file "bin/tmuxifier" bindir)
+                        (substitute* (string-append bindir "/tmuxifier")
+                          (("set -e")
+                           (string-append "TMUXIFIER=" share "\nset -e")))
+                        (for-each (lambda (init-script)
+                                    (install-file init-script (string-append
+                                                               share "/init")))
+                                  '("init.sh" "init.tcsh" "init.fish"))
+                        (for-each (lambda (dir)
+                                    (copy-recursively dir (string-append
+                                                           share "/" dir)))
+                                  '("completion" "lib" "libexec"
+                                    "templates"))))))))
+    (home-page "https://github.com/jimeh/tmuxifier")
+    (synopsis "Powerful session, window & pane management for Tmux")
+    (description "Tmuxifier allows you to easily create, edit, and load
+@code{layout} files, which are simple shell scripts where you use the tmux
+command and helper commands provided by tmuxifier to manage Tmux sessions and
+windows.")
+    (license expat)))
-- 
2.7.4

Message #16 received at 27279-close <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: Stefan Reichör <stefan <at> xsteve.at>,
 27279-close <at> debbugs.gnu.org
Subject: Re: [bug#27279] [PATCH] gnu: Add tmuxifier.
Date: Sat, 17 Jun 2017 22:10:02 +0200

Stefan Reichör <stefan <at> xsteve.at> writes:

> Thanks for your review. I have added the file-name hint. guix lint asked
> me to change '...' to @code{...}. So I changed this as well.

Pushed as commit 6c8b802f9c8ef3beb41d468eec8d2a2948efdb9c, closing.

cheers,

Thomas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.