GNU bug report logs - #27272
25.2; [patch] Fix positional args among keyword args in eldoc.

Previous Next

Package: emacs;

Reported by: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>

Date: Wed, 7 Jun 2017 09:32:01 UTC

Severity: normal

Tags: fixed, patch

Found in version 25.2

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log


Message #41 received at 27272 <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: 27272 <at> debbugs.gnu.org, Johan Bockgård <bojohan <at> gnu.org>
Subject: Re: bug#27272: 25.2;
 [patch] Fix positional args among keyword args in eldoc.
Date: Fri, 30 Jun 2017 08:36:52 +0200
npostavs <at> users.sourceforge.net writes:

> Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
>
>> npostavs <at> users.sourceforge.net writes:
>>
>>> Do you mean you have an updated patch that fixes this as well (which you
>>> seem to have forgotten to post)?
>>
>> It is here.
>
> I get a compile warning
>
> In elisp--highlight-function-argument:
> ../../emacs-master/lisp/progmodes/elisp-mode.el:1404:44:Warning: reference to
>     free variable ‘args-lst’
>
> and then at run-time eldoc is non-functional, it just prints
>
> eldoc error: (void-variable args-lst)

This patch is an adaptation of what I use in my .emacs.el, originally
the patch was correct, I have then deleted it (because the patch was
refused) and then created it again on your request, forgetting to merge
one line; Use let* instead of let.

Don't expect me to send another patch for such trivial change and more
generally to collaborate anymore on any emacs bugs.

--
Thierry
Gpg Key fingerprint = 6CEC 7081 AB33 E251 4AB8  5FC2 28D1 7F53 59F2 9997




This bug report was last modified 8 years and 1 day ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.