From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 06 04:50:58 2017 Received: (at submit) by debbugs.gnu.org; 6 Jun 2017 08:50:58 +0000 Received: from localhost ([127.0.0.1]:58474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIACY-0001qm-2x for submit@debbugs.gnu.org; Tue, 06 Jun 2017 04:50:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIACW-0001qa-QD for submit@debbugs.gnu.org; Tue, 06 Jun 2017 04:50:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIACQ-0002jY-J1 for submit@debbugs.gnu.org; Tue, 06 Jun 2017 04:50:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41673) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIACQ-0002j9-DE for submit@debbugs.gnu.org; Tue, 06 Jun 2017 04:50:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIACP-0004Wl-6L for guix-patches@gnu.org; Tue, 06 Jun 2017 04:50:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIACM-0002eG-3C for guix-patches@gnu.org; Tue, 06 Jun 2017 04:50:49 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:40134) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIACL-0002d6-TU for guix-patches@gnu.org; Tue, 06 Jun 2017 04:50:46 -0400 Received: from dayas.3.home (77.118.242.17.wireless.dyn.drei.com [77.118.242.17]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 00F7C1CA0425; Tue, 6 Jun 2017 10:50:41 +0200 (CEST) From: Danny Milosavljevic To: guix-patches@gnu.org Subject: [PATCH] file-systems: Use creation time if modification time is unset for ISO9660. Date: Tue, 6 Jun 2017 10:50:37 +0200 Message-Id: <20170606085037.28353-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.12.1 Tags: patch X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) * gnu/build/file-systems.scm (iso9660-superblock-uuid): Modify. --- gnu/build/file-systems.scm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 10be0dc83..7737de3d0 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -268,12 +268,18 @@ as a bytevector, or #f if DEVICE does not contain an iso9660 file system." (define (iso9660-superblock-uuid sblock) "Return the modification time of an iso9660 primary volume descriptor -SBLOCK as a bytevector." +SBLOCK as a bytevector. If that's not set, returns the creation time." ;; Drops GMT offset for compatibility with Grub, blkid and /dev/disk/by-uuid. ;; Compare Grub: "2014-12-02-19-30-23-00". ;; Compare blkid result: "2014-12-02-19-30-23-00". ;; Compare /dev/disk/by-uuid entry: "2014-12-02-19-30-23-00". - (sub-bytevector sblock 830 16)) + (let* ((creation-time (sub-bytevector sblock 813 17)) + (modification-time (sub-bytevector sblock 830 17)) + (unset-time (make-bytevector 17 0)) + (time (if (bytevector=? unset-time modification-time) + creation-time + modification-time))) + (sub-bytevector time 0 16))) ; strips GMT offset. (define (iso9660-uuid->string uuid) "Given an UUID bytevector, return its timestamp string." From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 06 19:19:52 2017 Received: (at 27265) by debbugs.gnu.org; 6 Jun 2017 23:19:52 +0000 Received: from localhost ([127.0.0.1]:60046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dINlQ-0003UG-JI for submit@debbugs.gnu.org; Tue, 06 Jun 2017 19:19:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dINlO-0003U2-Ju for 27265@debbugs.gnu.org; Tue, 06 Jun 2017 19:19:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dINlG-00060L-EJ for 27265@debbugs.gnu.org; Tue, 06 Jun 2017 19:19:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dINlG-00060C-As; Tue, 06 Jun 2017 19:19:42 -0400 Received: from astlambert-651-1-208-19.w92-151.abo.wanadoo.fr ([92.151.64.19]:37578 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dINlF-00088J-No; Tue, 06 Jun 2017 19:19:42 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: bug#27265: [PATCH] file-systems: Use creation time if modification time is unset for ISO9660. References: <20170606085037.28353-1-dannym@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 Prairial an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Wed, 07 Jun 2017 01:19:34 +0200 In-Reply-To: <20170606085037.28353-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Tue, 6 Jun 2017 10:50:37 +0200") Message-ID: <87o9u066wp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27265 Cc: 27265@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Danny Milosavljevic skribis: > * gnu/build/file-systems.scm (iso9660-superblock-uuid): Modify. > --- > gnu/build/file-systems.scm | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm > index 10be0dc83..7737de3d0 100644 > --- a/gnu/build/file-systems.scm > +++ b/gnu/build/file-systems.scm > @@ -268,12 +268,18 @@ as a bytevector, or #f if DEVICE does not contain a= n iso9660 file system." >=20=20 > (define (iso9660-superblock-uuid sblock) > "Return the modification time of an iso9660 primary volume descriptor > -SBLOCK as a bytevector." > +SBLOCK as a bytevector. If that's not set, returns the creation time." > ;; Drops GMT offset for compatibility with Grub, blkid and /dev/disk/b= y-uuid. > ;; Compare Grub: "2014-12-02-19-30-23-00". > ;; Compare blkid result: "2014-12-02-19-30-23-00". > ;; Compare /dev/disk/by-uuid entry: "2014-12-02-19-30-23-00". > - (sub-bytevector sblock 830 16)) > + (let* ((creation-time (sub-bytevector sblock 813 17)) > + (modification-time (sub-bytevector sblock 830 17)) > + (unset-time (make-bytevector 17 0)) > + (time (if (bytevector=3D? unset-time modification-time) > + creation-time > + modification-time))) > + (sub-bytevector time 0 16))) ; strips GMT offset. LGTM. I suppose this makes those UUIDs a bit more unique, right? Thank you, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 07 02:35:37 2017 Received: (at 27265-done) by debbugs.gnu.org; 7 Jun 2017 06:35:37 +0000 Received: from localhost ([127.0.0.1]:60241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIUZ7-00073W-9b for submit@debbugs.gnu.org; Wed, 07 Jun 2017 02:35:37 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:40864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIUZ6-00073O-EH for 27265-done@debbugs.gnu.org; Wed, 07 Jun 2017 02:35:36 -0400 Received: from localhost (178.113.246.10.wireless.dyn.drei.com [178.113.246.10]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 815251CA016E; Wed, 7 Jun 2017 08:35:34 +0200 (CEST) Date: Wed, 7 Jun 2017 08:35:34 +0200 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: bug#27265: [PATCH] file-systems: Use creation time if modification time is unset for ISO9660. Message-ID: <20170607083534.0444685a@scratchpost.org> In-Reply-To: <87o9u066wp.fsf@gnu.org> References: <20170606085037.28353-1-dannym@scratchpost.org> <87o9u066wp.fsf@gnu.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27265-done Cc: 27265-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ludo, On Wed, 07 Jun 2017 01:19:34 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > LGTM. >=20 > I suppose this makes those UUIDs a bit more unique, right? Yes, and it also aligns with what util-linux libblkid is doing (the same; s= ee probe_iso9660 in util-linux-2.29.2/libblkid/src/superblocks/iso9660.c). Pushed as c6aee77e297ee9c96412825127a921dbd1d10e92 to master. From unknown Fri Sep 12 20:17:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 05 Jul 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator