GNU bug report logs - #27256
[PATCH] gnu: postgresql: Enable contributed extensions.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27256 in the body.
You can then email your comments to 27256 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] gnu: postgresql: Enable contributed extensions.
Date: Mon,  5 Jun 2017 18:18:06 +0200

* gnu/packages/databases.scm (postgresql)[arguments]: Add "build-contrib",
"install-contrib" phases.  Add configure-flags.
[inputs]: Add libuuid.
---
 gnu/packages/databases.scm | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index c46e917b8..963d209a4 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -459,7 +459,8 @@ as a drop-in replacement of MySQL.")
                 "1imrjp4vfslxj5rrvphcrrk21zv8kqw3gacmwradixh1d5rv6i8n"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:phases
+     `(#:configure-flags '("--with-uuid=e2fs")
+       #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'patch-/bin/sh
                      (lambda _
@@ -467,9 +468,16 @@ as a drop-in replacement of MySQL.")
                        (substitute* '("src/bin/pg_ctl/pg_ctl.c"
                                       "src/bin/psql/command.c")
                          (("/bin/sh") (which "sh")))
-                       #t)))))
+                       #t))
+         (add-after 'build 'build-contrib
+           (lambda _
+             (zero? (system* "make" "-C" "contrib"))))
+         (add-after 'install 'install-contrib
+           (lambda _
+             (zero? (system* "make" "-C" "contrib" "install")))))))
     (inputs
      `(("readline" ,readline)
+       ("libuuid" ,util-linux)
        ("zlib" ,zlib)))
     (home-page "https://www.postgresql.org/")
     (synopsis "Powerful object-relational database system")

Message #8 received at 27256 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 27256 <at> debbugs.gnu.org
Subject: Re: bug#27256: [PATCH] gnu: postgresql: Enable contributed extensions.
Date: Tue, 06 Jun 2017 00:42:30 +0200

Danny Milosavljevic writes:

> * gnu/packages/databases.scm (postgresql)[arguments]: Add "build-contrib",
> "install-contrib" phases.  Add configure-flags.
> [inputs]: Add libuuid.
> ---
>  gnu/packages/databases.scm | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index c46e917b8..963d209a4 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -459,7 +459,8 @@ as a drop-in replacement of MySQL.")
>                  "1imrjp4vfslxj5rrvphcrrk21zv8kqw3gacmwradixh1d5rv6i8n"))))
>      (build-system gnu-build-system)
>      (arguments
> -     `(#:phases
> +     `(#:configure-flags '("--with-uuid=e2fs")
> +       #:phases
>         (modify-phases %standard-phases
>           (add-before 'configure 'patch-/bin/sh
>                       (lambda _
> @@ -467,9 +468,16 @@ as a drop-in replacement of MySQL.")
>                         (substitute* '("src/bin/pg_ctl/pg_ctl.c"
>                                        "src/bin/psql/command.c")
>                           (("/bin/sh") (which "sh")))
> -                       #t)))))
> +                       #t))
> +         (add-after 'build 'build-contrib
> +           (lambda _
> +             (zero? (system* "make" "-C" "contrib"))))
> +         (add-after 'install 'install-contrib
> +           (lambda _
> +             (zero? (system* "make" "-C" "contrib" "install")))))))
>      (inputs
>       `(("readline" ,readline)
> +       ("libuuid" ,util-linux)
>         ("zlib" ,zlib)))
>      (home-page "https://www.postgresql.org/")
>      (synopsis "Powerful object-relational database system")

LGTM!

Kind regards,
Roel Janssen

Message #11 received at 27256 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>, 27256 <at> debbugs.gnu.org
Subject: Re: bug#27256: [PATCH] gnu: postgresql: Enable contributed extensions.
Date: Thu, 20 Jul 2017 11:26:59 +0200

Roel Janssen <roel <at> gnu.org> skribis:

> Danny Milosavljevic writes:
>
>> * gnu/packages/databases.scm (postgresql)[arguments]: Add "build-contrib",
>> "install-contrib" phases.  Add configure-flags.
>> [inputs]: Add libuuid.
>> ---
>>  gnu/packages/databases.scm | 12 ++++++++++--
>>  1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
>> index c46e917b8..963d209a4 100644
>> --- a/gnu/packages/databases.scm
>> +++ b/gnu/packages/databases.scm
>> @@ -459,7 +459,8 @@ as a drop-in replacement of MySQL.")
>>                  "1imrjp4vfslxj5rrvphcrrk21zv8kqw3gacmwradixh1d5rv6i8n"))))
>>      (build-system gnu-build-system)
>>      (arguments
>> -     `(#:phases
>> +     `(#:configure-flags '("--with-uuid=e2fs")
>> +       #:phases
>>         (modify-phases %standard-phases
>>           (add-before 'configure 'patch-/bin/sh
>>                       (lambda _
>> @@ -467,9 +468,16 @@ as a drop-in replacement of MySQL.")
>>                         (substitute* '("src/bin/pg_ctl/pg_ctl.c"
>>                                        "src/bin/psql/command.c")
>>                           (("/bin/sh") (which "sh")))
>> -                       #t)))))
>> +                       #t))
>> +         (add-after 'build 'build-contrib
>> +           (lambda _
>> +             (zero? (system* "make" "-C" "contrib"))))
>> +         (add-after 'install 'install-contrib
>> +           (lambda _
>> +             (zero? (system* "make" "-C" "contrib" "install")))))))
>>      (inputs
>>       `(("readline" ,readline)
>> +       ("libuuid" ,util-linux)
>>         ("zlib" ,zlib)))
>>      (home-page "https://www.postgresql.org/")
>>      (synopsis "Powerful object-relational database system")
>
> LGTM!

Danny, don’t forget to commit.  :-)

Ludo’.

Message #16 received at 27256-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 27256-done <at> debbugs.gnu.org, Roel Janssen <roel <at> gnu.org>
Subject: Re: bug#27256: [PATCH] gnu: postgresql: Enable contributed extensions.
Date: Thu, 20 Jul 2017 13:11:57 +0200

Hi Ludo,

I think I did.  Does it show up for you?

commit b7aa3f5d2e04800b60ece895c88dd753d2c3dfcc
Author: Danny Milosavljevic <dannym <at> scratchpost.org>
Date:   Mon Jun 5 18:18:06 2017 +0200

    gnu: postgresql: Enable contributed extensions.
    
    * gnu/packages/databases.scm (postgresql)[arguments]: Add "build-contrib",
    "install-contrib" phases.  Add configure-flags.
    [inputs]: Add libuuid.

Message #19 received at 27256-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 27256-done <at> debbugs.gnu.org, Roel Janssen <roel <at> gnu.org>
Subject: Re: bug#27256: [PATCH] gnu: postgresql: Enable contributed extensions.
Date: Thu, 20 Jul 2017 15:51:43 +0200

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> I think I did.  Does it show up for you?
>
> commit b7aa3f5d2e04800b60ece895c88dd753d2c3dfcc
> Author: Danny Milosavljevic <dannym <at> scratchpost.org>
> Date:   Mon Jun 5 18:18:06 2017 +0200
>
>     gnu: postgresql: Enable contributed extensions.

It does, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.