GNU bug report logs - #27250
[PATCH] gnu: crawl: Update to 0.20.0.

Previous Next

Package: guix-patches;

Reported by: nee <nee <at> cock.li>

Date: Mon, 5 Jun 2017 11:33:01 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

Full log


Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org, Arun Isaac <arunisaac <at> systemreboot.net>,
 nee <nee <at> cock.li>
Cc: 27250 <at> debbugs.gnu.org
Subject: Re: bug#27250: [PATCH] gnu: crawl: Update to 0.20.0.
Date: Mon, 05 Jun 2017 11:54:07 -0400
Generally, I think it's fine if the patches we include contain whitespace issues.


-------- Original Message --------
From: Arun Isaac <arunisaac <at> systemreboot.net>
Sent: June 5, 2017 10:14:18 AM EDT
To: nee <nee <at> cock.li>
Cc: 27250 <at> debbugs.gnu.org
Subject: bug#27250: [PATCH] gnu: crawl: Update to 0.20.0.


Thanks! LGTM. Only one problem: crawl-upgrade-saves.patch seems to have
trailing whitespace, and git is complaining about that. Use `git diff
--check' on your commit to see what I mean. Could you fix this and send
a new patch?

gnu/packages/patches/crawl-upgrade-saves.patch:17: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:32: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:40: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:55: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:63: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:68: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:75: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:81: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:84: trailing whitespace.
++ 
gnu/packages/patches/crawl-upgrade-saves.patch:92: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:100: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:111: trailing whitespace.
++ 
gnu/packages/patches/crawl-upgrade-saves.patch:115: trailing whitespace.
+  







This bug report was last modified 8 years and 37 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.