GNU bug report logs - #27249
[PATCH] gnu: gnome: Add deja-dup.

Previous Next

Full log

Message #22 received at 27249 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 27249 <at> debbugs.gnu.org
Subject: Re: bug#27249: [PATCH] gnu: gnome: Add deja-dup.
Date: Sat, 22 Jul 2017 10:33:51 +0100

[Message part 1 (text/plain, inline)]

On Thu, 20 Jul 2017 11:28:11 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Heya Christopher,
> 
> Christopher Baines <mail <at> cbaines.net> skribis:
> 
> > On 07/06/17 14:01, Ludovic Courtès wrote:  
> >> Christopher Baines <mail <at> cbaines.net> skribis:
> >>   
> >>> * gnu/packages/gnome.scm (deja-dup): New variable.  
> >> 
> >> There’s a couple of lint warnings fixed by the patch below:  
> 
> [...]
> 
> >> Regarding propagated inputs:
> >>   
> >>> +    (propagated-inputs
> >>> +     `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> >>> +       ("gobject-introspection" ,gobject-introspection)
> >>> +       ("duplicity" ,duplicity)
> >>> +       ("python" ,python2-minimal)
> >>> +       ("python-pygobject" ,python2-pygobject)))  
> >> 
> >> Could you add a comment explaining why all this needs to be
> >> propagated? If there’s a way to avoid it, it’s even better (for
> >> instance, if deja-dup execs duplicity, we could hard-code the
> >> absolute file name of duplicity.)  
> >
> > Thanks for your review Ludo, hopefully I can get around to looking
> > at deja-dup again at the weekend :)  
> 
> It’s been a long week-end.  ;-)  Could you take a look again so we can
> save this patch from bitrot?

Yep, its so long ago, I forget what I ended up doing that weekend!

I've sent another patch now. I think vala and dbus may have moved in
the mean time, so this one includes a patch from upstream to fix
compilation issues with vala 0.36, and the check stage had to be
disabled, as the tests no longer pass due to an issue with DBus.

As for the propagated-inputs, I made them all inputs, and tested the
application, and I couldn't see any problems.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.