Subject: Re: bug#27249: [PATCH] gnu: gnome: Add deja-dup.

From: [email-masked] (Ludovic Courtès)
Date: Wed, 07 Jun 2017 15:01:20 +0200

Christopher Baines <[email-masked]> skribis:

> * gnu/packages/gnome.scm (deja-dup): New variable.

There’s a couple of lint warnings fixed by the patch below:

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ab0c57d31..cd78e6015 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -252,19 +252,19 @@ features to enable users to create their discs easily and quickly.")
        ("libnotify" ,libnotify)
        ("libpeas" ,libpeas)
        ("libsecret" ,libsecret)
-       ("itstool" ,itstool)
        ("packagekit" ,packagekit)))
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("vala" ,vala)
        ("gettext" ,gettext-minimal)
+       ("itstool" ,itstool)
        ("intltool" ,intltool)
        ("cmake", cmake)))
     (home-page "https://launchpad.net/deja-dup")
     (synopsis "Simple backup tool, for regular encrypted backups")
     (description
-     "Déjà Dup is a simple backup tool, for regular encrypted backups. It uses
-duplicity as the backend, which supports incremental backups and storage
+     "Déjà Dup is a simple backup tool, for regular encrypted backups.  It
+uses duplicity as the backend, which supports incremental backups and storage
 either on a local, or remote machine via a number of methods.")
     (license license:gpl3+)))

Regarding propagated inputs:

> +    (propagated-inputs
> +     `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("duplicity" ,duplicity)
> +       ("python" ,python2-minimal)
> +       ("python-pygobject" ,python2-pygobject)))

Could you add a comment explaining why all this needs to be propagated?
If there’s a way to avoid it, it’s even better (for instance, if
deja-dup execs duplicity, we could hard-code the absolute file name of
duplicity.)

TIA!

Ludo’.