From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 05 01:43:52 2017 Received: (at submit) by debbugs.gnu.org; 5 Jun 2017 05:43:52 +0000 Received: from localhost ([127.0.0.1]:56397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHknv-0008Fw-QH for submit@debbugs.gnu.org; Mon, 05 Jun 2017 01:43:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHknt-0008Fk-SZ for submit@debbugs.gnu.org; Mon, 05 Jun 2017 01:43:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHknn-0002X9-RS for submit@debbugs.gnu.org; Mon, 05 Jun 2017 01:43:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55205) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dHknn-0002We-PL for submit@debbugs.gnu.org; Mon, 05 Jun 2017 01:43:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHknm-0004Bq-Mq for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 01:43:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHknj-0002Ss-Jb for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 01:43:42 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:37650) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dHknj-0002SA-A3 for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2017 01:43:39 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v555havm000598 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 5 Jun 2017 05:43:37 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v555habT012791 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 5 Jun 2017 05:43:36 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v555hZ2L013064 for ; Mon, 5 Jun 2017 05:43:36 GMT MIME-Version: 1.0 Message-ID: Date: Sun, 4 Jun 2017 22:43:34 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.5; doc of `face-spec-set' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6767.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. The doc string and (elisp ) `Defining Faces' do not agree about argument SPEC-TYPE when its value is not one of the special values documented. The doc string says: Any other value means not to set any spec, but to run the function for its other effects. Huh? What "other effects"? Not clear, but we can guess (and looking at the code confirms) that what is hinted at is perhaps this: This function also defines FACE as a valid face name if it is not already one, and (re)calculates its attributes on existing frames. But the Elisp manual says instead: Any other value of SPEC-TYPE is reserved for internal use. IOW, the doc string tells us to use another SPEC-TYPE value to get the effect of defining a face and (re)calculating its attributes on existing frames. But the Elisp manual tells us NOT to use any other SPEC-TYPE value, because other values are reserved for internal use. 2. I also find this part unclear: Doc string: nil or `face-override-spec' means the override spec (which is usually what you want if calling this function outside of Custom code); Manual: If [SPEC-TYPE] is nil or `face-override-spec', this function sets the "override spec", which overrides over all other face specs on FACE. "if calling this function outside of Custom code"? What does that mean for users? Anyway, both of those descriptions are unclear to me. ("other face specs on FACE"? Does that mean the default (`defface') spec plus the customized spec plus the saved custom spec? And it's not clear here what those are, either.) In GNU Emacs 24.5.1 (i686-pc-mingw32) of 2015-04-11 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D3D/c/usr --host=3D3Di686-pc-mingw32' From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 05:19:17 2017 Received: (at 27246-done) by debbugs.gnu.org; 10 Jun 2017 09:19:17 +0000 Received: from localhost ([127.0.0.1]:37803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJcY9-0002vO-2q for submit@debbugs.gnu.org; Sat, 10 Jun 2017 05:19:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJcY7-0002vC-PO for 27246-done@debbugs.gnu.org; Sat, 10 Jun 2017 05:19:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJcXx-0004el-PN for 27246-done@debbugs.gnu.org; Sat, 10 Jun 2017 05:19:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJcXx-0004eh-L5; Sat, 10 Jun 2017 05:19:05 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4253 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dJcXx-0003oO-1Q; Sat, 10 Jun 2017 05:19:05 -0400 Date: Sat, 10 Jun 2017 12:18:49 +0300 Message-Id: <838tl06w06.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-reply-to: (message from Drew Adams on Sun, 4 Jun 2017 22:43:34 -0700 (PDT)) Subject: Re: bug#27246: 24.5; doc of `face-spec-set' References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27246-done Cc: 27246-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sun, 4 Jun 2017 22:43:34 -0700 (PDT) > From: Drew Adams > > 1. The doc string and (elisp ) `Defining Faces' do not agree about > argument SPEC-TYPE when its value is not one of the special values > documented. > > The doc string says: > > Any other value means not to set any spec, but to run the > function for its other effects. > > Huh? What "other effects"? Not clear, but we can guess (and looking at > the code confirms) that what is hinted at is perhaps this: > > This function also defines FACE as a valid face name if it is not > already one, and (re)calculates its attributes on existing frames. > > But the Elisp manual says instead: > > Any other value of SPEC-TYPE is reserved for internal use. I've now clarified what "other effects" means (your guess is correct). > IOW, the doc string tells us to use another SPEC-TYPE value to get the > effect of defining a face and (re)calculating its attributes on existing > frames. But the Elisp manual tells us NOT to use any other SPEC-TYPE > value, because other values are reserved for internal use. I've clarified in the manual that FACE's definition and recalculation of its attributes are done for any other value of SPEC-TYPE. As for the rest, I think it's quite allright for the manual to say "reserved", while the doc string describes the current behavior (and will presumably be changed if that behavior ever changes). I don't see how this is a request NOT to use other values, just to keep in mind that their effect might change in the future. And the sources are really there to tell the full story. > 2. I also find this part unclear: > > Doc string: > > nil or `face-override-spec' means the override spec (which is usually > what you want if calling this function outside of Custom code); > > Manual: > > If [SPEC-TYPE] is nil or `face-override-spec', this function sets > the "override spec", which overrides over all other face specs on > FACE. > > "if calling this function outside of Custom code"? What does that > mean for users? It means nothing for users. For Lisp programmers, it means what it says: when this function is called from Lisp outside Custom, use this value of SPEC-TYPE. (I've made both places be more consistent.) > ("other face specs on FACE"? Does that mean the default (`defface') > spec plus the customized spec plus the saved custom spec? Yes. I've made the text more explicit about this. > And it's not clear here what those are, either.) They are described right there, so I don't see what could be unclear about them, if you write code that sets face attributes. Thanks. From unknown Sun Jun 22 17:17:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 08 Jul 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator