GNU bug report logs - #27243
dired-auto-revert-buffer jumps point to beginning of buffer

Previous Next

Full log

View this message in rfc822 format

From: Antoine Levitt <antoine.levitt <at> gmail.com>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 27243 <at> debbugs.gnu.org
Subject: bug#27243: closed (Re: bug#27243: dired-auto-revert-buffer jumps point to beginning of buffer)
Date: Sun, 09 Jul 2017 19:37:53 +0200

Works for me, feel free to merge!

Best,
Antoine

17 June 2017 15:32 +02, Stephen Berman <stephen.berman <at> gmx.net>:
> On Sat, 17 Jun 2017 14:16:01 +0200 Antoine Levitt <antoine.levitt <at> gmail.com> wrote:
>
>> I just noticed this is not yet completely fixed: starting from emacs -Q,
>> (setq dired-auto-revert-buffer t), open dired, open any file in that
>> directory, C-x d RET to run dired again, the point jumps back to the
>> beginning of the buffer.
>
> I suppose the command `dired' should not use switch-to-buffer.  With the
> following patch, executing the above recipe does not move point.
>
> diff --git a/lisp/dired.el b/lisp/dired.el
> index 8396652d50..aa59f01af9 100644
> --- a/lisp/dired.el
> +++ b/lisp/dired.el
> @@ -786,7 +786,8 @@ dired
>  If DIRNAME is already in a Dired buffer, that buffer is used without refresh."
>    ;; Cannot use (interactive "D") because of wildcards.
>    (interactive (dired-read-dir-and-switches ""))
> -  (switch-to-buffer (dired-noselect dirname switches)))
> +  (set-window-buffer (selected-window)
> +                     (set-buffer (dired-noselect dirname switches))))
>  
>  ;;;###autoload (define-key ctl-x-4-map "d" 'dired-other-window)
>  ;;;###autoload
>
> Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.