Subject: bug#27238: 24.5; Rename `face-spec-set-2' and give it a better doc string

From: Eli Zaretskii <[email-masked]>
Date: Mon, 05 Jun 2017 05:27:30 +0300

> Date: Sun, 4 Jun 2017 12:38:10 -0700 (PDT)
> From: Drew Adams <[email-masked]>
> Cc: [email-masked]
> 
> (That reasoning would apply also to `face-spec-recalc', `face-spec-set',
> `face-set-after-frame-default', `custom-face-set', `custom-face-save',
> `custom-face-mark-to-save', `custom-face-reset-saved',
> `custom-face-mark-to-reset-standard', `custom-declare-face',
> `custom-theme-set-faces', `custom-reset-faces', `woman-default-faces',
> ...)

They all call face-spec-recalc.

> Unless you essentially repeat its body, it is the only way
> to do what it does.  Here's one use case:
> 
> (face-spec-set-2 TARGET-FACE
>                  FRAME
>                  (face-spec-choose
>                    (get SOURCE-FACE 'face-defface-spec)
>                    FRAME))

Why can't you do this by calling a higher-level function?