GNU bug report logs - #27225
[PATCH] artwork: Use a descriptive name for the source directory.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27225 in the body.
You can then email your comments to 27225 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] artwork: Use a descriptive name for the source directory.
Date: Sat,  3 Jun 2017 19:54:01 -0400

* gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
use the full commit hash when fetching.
---
 gnu/artwork.scm | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/gnu/artwork.scm b/gnu/artwork.scm
index 94c89143a..204845bd6 100644
--- a/gnu/artwork.scm
+++ b/gnu/artwork.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014, 2015 Ludovic Courtès <ludo <at> gnu.org>
+;;; Copyright © 2017 Leo Famulari <leo <at> famulari.name>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -28,13 +29,15 @@
 ;;; Code:
 
 (define %artwork-repository
-  (origin
-    (method git-fetch)
-    (uri (git-reference
-          (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
-          (commit "6998d30")))
-    (sha256
-     (base32
-      "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j"))))
+  (let ((commit "6998d30425289b087c64f63e7415df2241e591db"))
+    (origin
+      (method git-fetch)
+      (uri (git-reference
+             (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
+             (commit commit)))
+      (file-name (string-append "guix-artwork-" (string-take commit 7) "-checkout"))
+      (sha256
+       (base32
+        "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j")))))
 
 ;;; artwork.scm ends here
-- 
2.13.0

Message #8 received at 27225 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 27225 <at> debbugs.gnu.org
Subject: Re: bug#27225: [PATCH] artwork: Use a descriptive name for the source
 directory.
Date: Wed, 07 Jun 2017 01:12:25 +0200

Leo Famulari <leo <at> famulari.name> skribis:

> * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> use the full commit hash when fetching.

Good idea, thank you!

Ludo’.

Message #11 received at 27225 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 27225 <at> debbugs.gnu.org
Subject: Re: bug#27225: [PATCH] artwork: Use a descriptive name for the source
 directory.
Date: Wed, 07 Jun 2017 12:56:56 +0300

Leo Famulari (2017-06-03 19:54 -0400) wrote:

> * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> use the full commit hash when fetching.
> ---
>  gnu/artwork.scm | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/artwork.scm b/gnu/artwork.scm
> index 94c89143a..204845bd6 100644
> --- a/gnu/artwork.scm
> +++ b/gnu/artwork.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2014, 2015 Ludovic Courtès <ludo <at> gnu.org>
> +;;; Copyright © 2017 Leo Famulari <leo <at> famulari.name>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -28,13 +29,15 @@
>  ;;; Code:
>  
>  (define %artwork-repository
> -  (origin
> -    (method git-fetch)
> -    (uri (git-reference
> -          (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> -          (commit "6998d30")))
> -    (sha256
> -     (base32
> -      "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j"))))
> +  (let ((commit "6998d30425289b087c64f63e7415df2241e591db"))
> +    (origin
> +      (method git-fetch)
> +      (uri (git-reference
> +             (url "git://git.savannah.gnu.org/guix/guix-artwork.git")
> +             (commit commit)))
> +      (file-name (string-append "guix-artwork-" (string-take commit 7) "-checkout"))

As for me, this line is too long, I would make it:

       (file-name (string-append "guix-artwork-" (string-take commit 7)
                                 "-checkout"))

> +      (sha256
> +       (base32
> +        "0k7j3pj9s3zqiqmfkapypssvzx3f12yr0cc2rbzxqfii0b4clp1j")))))
>  
>  ;;; artwork.scm ends here

-- 
Alex

Message #16 received at 27225-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Alex Kost <alezost <at> gmail.com>
Cc: 27225-done <at> debbugs.gnu.org
Subject: Re: bug#27225: [PATCH] artwork: Use a descriptive name for the
 source directory.
Date: Wed, 7 Jun 2017 15:59:40 -0400

[Message part 1 (text/plain, inline)]

On Wed, Jun 07, 2017 at 12:56:56PM +0300, Alex Kost wrote:
> Leo Famulari (2017-06-03 19:54 -0400) wrote:
> > * gnu/artwork.scm (%artwork-repository): Set a descriptive file-name and
> > use the full commit hash when fetching.

> > +      (file-name (string-append "guix-artwork-" (string-take commit 7) "-checkout"))
> 
> As for me, this line is too long, I would make it:
> 
>        (file-name (string-append "guix-artwork-" (string-take commit 7)
>                                  "-checkout"))

Oops! Fixed before pushing as 94db92f78ec9c849f9c8da05d4d35356909f9fbe.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.