From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 12:53:50 2017 Received: (at submit) by debbugs.gnu.org; 3 Jun 2017 16:53:50 +0000 Received: from localhost ([127.0.0.1]:54035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHCJC-0007Uf-FR for submit@debbugs.gnu.org; Sat, 03 Jun 2017 12:53:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHCJ8-0007UR-Lf for submit@debbugs.gnu.org; Sat, 03 Jun 2017 12:53:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHCJ2-0001fF-LN for submit@debbugs.gnu.org; Sat, 03 Jun 2017 12:53:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40154) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dHCJ2-0001er-IA for submit@debbugs.gnu.org; Sat, 03 Jun 2017 12:53:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHCJ1-0004v9-8q for bug-guix@gnu.org; Sat, 03 Jun 2017 12:53:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHCIy-0001cg-9O for bug-guix@gnu.org; Sat, 03 Jun 2017 12:53:39 -0400 Received: from aibo.runbox.com ([91.220.196.211]:36086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHCIy-0001ZU-23 for bug-guix@gnu.org; Sat, 03 Jun 2017 12:53:36 -0400 Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1dHCIt-0000kt-LQ for bug-guix@gnu.org; Sat, 03 Jun 2017 18:53:31 +0200 Received: from [109.236.90.209] (helo=localhost) by mailfront10.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1dHCIn-0000KU-OT for bug-guix@gnu.org; Sat, 03 Jun 2017 18:53:26 +0200 Date: Sat, 3 Jun 2017 16:53:21 +0000 From: ng0 To: bug-guix@gnu.org Subject: 203a9455c4695152fc5d0085bffeead9ce3216c2 broke system boot Message-ID: <20170603165321.iocqorc25mmvjhjf@abyayala> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Otherwise perfectly working systems I have *all* break after https://git.savannah.gnu.org/cgit/guix.git/commit/?id=203a9455c4695152fc5d0085bffeead9ce3216c2 and the last thing they display before guile repl is the message in that commit. Yes, I use labels. No, I don't use complicated setups. Please test such changes before applying them in the wild.. I just hope this happened here and the break is a mistake. -- ng0 OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 13:01:15 2017 Received: (at 27212) by debbugs.gnu.org; 3 Jun 2017 17:01:15 +0000 Received: from localhost ([127.0.0.1]:54042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHCQN-0007go-8s for submit@debbugs.gnu.org; Sat, 03 Jun 2017 13:01:15 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHCQL-0007gf-9a for 27212@debbugs.gnu.org; Sat, 03 Jun 2017 13:01:13 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 781B320783; Sat, 3 Jun 2017 13:01:12 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Sat, 03 Jun 2017 13:01:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=8VeNhHTGJGtFPwdYD/guk+RU6VkS/ZfmZp+aarj7M 2c=; b=v60z2bwewma/24QkX5JTMYoEVJZCA8t4mB2TzVVM62jpIw0caPWPIl4EY UTVymcVMK8MJqCByCD/LUDbF8Q/4wTrtZkpk4wEMxCYO+t1KrfDsQsoSLZnIfSRn LAgRTiYxSPvbDwotmONjF1BWSPwYAxT/rkgcmkjZw0Xm+CUau1Bnapo1kQ0SV4kQ og106fgFN8L45x6WDoebPQiT5AXf65wzDs2lOZCWE7BI+4Hb6b4jwsFtJZRKVth2 TWq4PPyxTvkcClN8DHBt0Agl5i1ivlQvXUK6fO31l7OdzA5JmJrt0Olji9lyc2DA xLaFboMIvCcYcRjY+oLndXj7jpnSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=8VeNhHTGJGtFPwdYD/ guk+RU6VkS/ZfmZp+aarj7M2c=; b=bA/f/E0TudywqrGkCA0SVCpeyQLwu9qihp rj3bSRx6e3VntnC58OzvX4+TR/QCRxEJTwCIHswusVnNtkBkSbcWeJtO4KyvYuDT IO8ZodcttQj35kn/DOop6JQ124gfozyBWusPWIQlFliFub+2XzCv0bMo5y1UgVhF Oe+0OUvqJ4HFEjOOTPg7p6bmq0hFwEFmLcdCdIo10q6G89CpM5sSC4BgVpCiciEU niZHPbgbueTr4UwYIRm1kDk1lKUz45UFptj46mmI/a8lIthVtzTKzHmOkjcmn7S5 AZeRncqVyls/Y7VqyM8ncWlBhkJIVyPvowz+yHopw1X+JufxkB0Q== X-ME-Sender: X-Sasl-enc: UFWIuQqi2Fqh82kUXpm3Cy0eqawpBRkskSw5Pzh3CCoP 1496509272 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 0BEDA247DD; Sat, 3 Jun 2017 13:01:11 -0400 (EDT) From: Marius Bakke To: ng0 , 27212@debbugs.gnu.org Subject: Re: bug#27212: 203a9455c4695152fc5d0085bffeead9ce3216c2 broke system boot In-Reply-To: <20170603165321.iocqorc25mmvjhjf@abyayala> References: <20170603165321.iocqorc25mmvjhjf@abyayala> User-Agent: Notmuch/0.24.2 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Sat, 03 Jun 2017 19:01:10 +0200 Message-ID: <8737bh0zvt.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27212 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain ng0 writes: > Otherwise perfectly working systems I have *all* break after > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=203a9455c4695152fc5d0085bffeead9ce3216c2 > > and the last thing they display before guile repl is the > message in that commit. > > Yes, I use labels. No, I don't use complicated setups. > Please test such changes before applying them in the wild.. > I just hope this happened here and the break is a mistake. I *just* noticed the same thing. I also tried reverting this commit, but that just entered a (re)boot loop. Not sure what's up, but two of my GuixSD systems are affected. On my way out now, but will investigate more tomorrow. CC Danny in case of insight (which report by Chris did this address?). Older generations are fine. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlky61YACgkQoqBt8qM6 VPqx3Qf+ILevHDAGFd5dHhHp2igI7UEs7nfX+9sB2RrAnPomg0S/EPyFdH5vjmy7 ZHfLh+G1zDZj0IOYjZr1nKLpW+n6kqE1mWzo+W35cjIE3u/8bc1w6oj8UINrRDs6 Yq9UnwISuQY8kfO1op5/gseTsbLxsA8LzgNu1WsrlN9vddOPjZ7G6DfTBZ0VzfVJ WUslomc0Haqhz57pBC8R1t4KvHlxk7FP5VPc6dQwsLLcNAnXyByoeNa61rePv2ou YsTYUypeyOg0ZVai4+nil+LFwmc4kFD5yrbVsxXWd8r8nhVBTaHTZ2oG6xIpeQv7 FSw3XyT+0f6U77HPW6iuBhuvXgWqvg== =dpqn -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 13:31:11 2017 Received: (at 27212) by debbugs.gnu.org; 3 Jun 2017 17:31:11 +0000 Received: from localhost ([127.0.0.1]:54070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHCtJ-0008Nb-Td for submit@debbugs.gnu.org; Sat, 03 Jun 2017 13:31:11 -0400 Received: from aibo.runbox.com ([91.220.196.211]:37014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHCtH-0008NS-Nb for 27212@debbugs.gnu.org; Sat, 03 Jun 2017 13:31:08 -0400 Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1dHCtF-0003ht-N4; Sat, 03 Jun 2017 19:31:05 +0200 Received: from tor3.digineo.de ([185.117.215.9] helo=localhost) by mailfront10.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1dHCt8-00075S-95; Sat, 03 Jun 2017 19:30:58 +0200 Date: Sat, 3 Jun 2017 17:30:56 +0000 From: ng0 To: Marius Bakke Subject: Re: bug#27212: 203a9455c4695152fc5d0085bffeead9ce3216c2 broke system boot Message-ID: <20170603173056.7622qgvocdbn3gpi@abyayala> Mail-Followup-To: Marius Bakke , 27212@debbugs.gnu.org, Danny Milosavljevic References: <20170603165321.iocqorc25mmvjhjf@abyayala> <8737bh0zvt.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gnifaadafqpfa4ks" Content-Disposition: inline In-Reply-To: <8737bh0zvt.fsf@fastmail.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27212 Cc: Danny Milosavljevic , 27212@debbugs.gnu.org, ng0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --gnifaadafqpfa4ks Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Marius Bakke transcribed 1.4K bytes: > ng0 writes: >=20 > > Otherwise perfectly working systems I have *all* break after > > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D203a9455c469515= 2fc5d0085bffeead9ce3216c2 > > > > and the last thing they display before guile repl is the > > message in that commit. > > > > Yes, I use labels. No, I don't use complicated setups. > > Please test such changes before applying them in the wild.. > > I just hope this happened here and the break is a mistake. >=20 > I *just* noticed the same thing. I also tried reverting this commit, but > that just entered a (re)boot loop. Not sure what's up, but two of my > GuixSD systems are affected. >=20 > On my way out now, but will investigate more tomorrow. CC Danny in case > of insight (which report by Chris did this address?). >=20 > Older generations are fine. Thanks. Results like this should be avoided. As long as this happens there is a reason for the 'beta' label. It might be usable in all kinds of environments, but we have to have rules and guidelines when something can be applied just like this after QA or when a certain set of people have to aprove the change as they did test the change and it worked. I consider file-system one of these cases. If the commit touches the way towards boot, approval is the way to go. --=20 ng0 OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 --gnifaadafqpfa4ks Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEqIyK3RKYKNfqwC5S4i+bv+40hYgFAlky8ksACgkQ4i+bv+40 hYgcMg//ZVlqt1nwh/9sUFmxAxCdlOUtnFiasHyi1OeMni+I1y1ZIhZTJxndesm1 pSzefRDSuqHFu8JIdEOrAK3i+wirlnpWwPEHNINe6D9iGIgWVmerrNEdIp6skcsf /zLS5GOSjh3UZ1Om8V208x7+RbodWmAU+hv7eLeYUQJPNk/FNP6HmaSmRepLPczD FWF9bSqbulw0N7rwhNK/Fwhk3zTyw4gnDQU9d7lbak2kiPgzXrWfVt5M5VpYWH0P yMI8Qf9cstm3S2OjGjvwgspd77IDxmqz9G2C92BiWfEv53jutzg2lGfbrpQ28reY +QbAk8NhtOaT40VgmAljQVHpnKyBikaJnNmavtmh5H8r3rsjm4aikcNPxSpl5eQy 3lR+x0QR/YH52SFMgI3PtVgvanQwOEJOLTjDV4WzGRbwtIZXjLhDwVWc5bXjWafZ FUjn09+DRqrvE06OZC9+2NPtm0Air/e7U5QrkHFmruG1slPqLR9Gwji9StkZwUZH l/JGPCLtzfpFZ/EZenbC2oJjC5t/qVPvYNOqngHLhY9Gtu99wLefyux9zA4ncGtZ NyvOTKm4JgGqm8acUvMUf30bdLteYLg5uF7iANN0Z35XHsGdxN0wIrOSGatGtnOR nItQAoVX2PB5apfQI54pJpahY/peHP1nwyZKbDhe19W7bWtNwtg= =uNX/ -----END PGP SIGNATURE----- --gnifaadafqpfa4ks-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 14:01:11 2017 Received: (at 27212) by debbugs.gnu.org; 3 Jun 2017 18:01:11 +0000 Received: from localhost ([127.0.0.1]:54092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHDMM-0002R6-Pv for submit@debbugs.gnu.org; Sat, 03 Jun 2017 14:01:10 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:37178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHDML-0002Qz-Qo for 27212@debbugs.gnu.org; Sat, 03 Jun 2017 14:01:10 -0400 Received: from dayas.3.home (178.113.233.108.wireless.dyn.drei.com [178.113.233.108]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 3E0541CA0026; Sat, 3 Jun 2017 20:01:07 +0200 (CEST) From: Danny Milosavljevic To: 27212@debbugs.gnu.org Subject: [PATCH] file-systems: Improve error handling in the iso9660 case - fixes boot problem. Date: Sat, 3 Jun 2017 20:00:13 +0200 Message-Id: <20170603180013.15853-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.12.1 In-Reply-To: <8737bh0zvt.fsf@fastmail.com> References: <8737bh0zvt.fsf@fastmail.com> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27212 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/build/file-systems.scm (read-iso9660-superblock): Modify. --- gnu/build/file-systems.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 3e0873377..740c37124 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -260,7 +260,11 @@ volume descriptor from ~s" "Return the raw contents of DEVICE's iso9660 primary volume descriptor as a bytevector, or #f if DEVICE does not contain an iso9660 file system." ;; Start reading at sector 16. - (read-iso9660-primary-volume-descriptor device (* 2048 16))) + ;; Since we are not sure that the device contains an ISO9660 filesystem, + ;; we have to find that out first. + (if (read-superblock device (* 2048 16) 2048 iso9660-superblock?) + (read-iso9660-primary-volume-descriptor device (* 2048 16)) + #f)) ; Device does not contain an iso9660 filesystem. (define (iso9660-superblock-uuid sblock) "Return the modification time of an iso9660 primary volume descriptor From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 14:25:05 2017 Received: (at 27212) by debbugs.gnu.org; 3 Jun 2017 18:25:05 +0000 Received: from localhost ([127.0.0.1]:54107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHDjV-0002y4-Bk for submit@debbugs.gnu.org; Sat, 03 Jun 2017 14:25:05 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:39232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHDjT-0002xw-2V for 27212@debbugs.gnu.org; Sat, 03 Jun 2017 14:25:03 -0400 Received: from localhost (178.113.233.108.wireless.dyn.drei.com [178.113.233.108]) by dd1012.kasserver.com (Postfix) with ESMTPSA id EC72C1CA0026; Sat, 3 Jun 2017 20:25:01 +0200 (CEST) Date: Sat, 3 Jun 2017 20:25:00 +0200 From: Danny Milosavljevic To: 27212@debbugs.gnu.org, ng0 , Marius Bakke Subject: Re: [PATCH] file-systems: Improve error handling in the iso9660 case - fixes boot problem. Message-ID: <20170603202500.547f3d47@scratchpost.org> In-Reply-To: <20170603180013.15853-1-dannym@scratchpost.org> References: <8737bh0zvt.fsf@fastmail.com> <20170603180013.15853-1-dannym@scratchpost.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27212 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi, sorry for the slip-up. The error handling in 203a9455c4695152fc5d0085bffeead9ce3216c2 was improved for the case when there's no iso9660 primary volume descriptor anywhere and no terminator either. In that case the CD is broken. But if there's no iso9660 volume descriptor AT ALL (primary or not) it's not a fatal error for guix gnu/build/file-systems.scm - it just means we picked the wrong filesystem type and should try the next one. This case was not handled correctly and this patch addresses this. I'd like help with testing this patch. If someone with a fast computer could apply this patch, then run make check-system, and then, if everything worked, run guix system reconfigure /etc/config.scm , that would be great (my computer is building guix master for the last 3 days and probably needs 4 more - so no idea whether the patch works). @Marius: I don't understand why reverting 203a9455c4695152fc5d0085bffeead9ce3216c2 didn't fix it. It should have. (I can't try it myself because I'm in forced-system-update purgatory - argh). From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 15:46:17 2017 Received: (at 27212) by debbugs.gnu.org; 3 Jun 2017 19:46:17 +0000 Received: from localhost ([127.0.0.1]:54163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHF05-0004pO-8N for submit@debbugs.gnu.org; Sat, 03 Jun 2017 15:46:17 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHEzm-0004oV-Dk for 27212@debbugs.gnu.org; Sat, 03 Jun 2017 15:46:16 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B726820A32; Sat, 3 Jun 2017 15:45:57 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Sat, 03 Jun 2017 15:45:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=f/551c6yOnJVin7IcGLZvSo3dswhjYJLxMNuWA XLbMs=; b=jX02G7qC1tqAjKVNRdlEfECBrGiP9IlZlMzmfbDpz5zA69SdVmxsto uu7SrESxs5fbReWcXCdbOWR3z1Eut6p4iX4+JC1CfZvudBlOIw1K6HM1dKVDnPqC g1IPIAEgf/g3hc5Sc6sOiHW2xxegyVJUY/ArjdBT2Z8o740PjNuR4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=f/551c6yOnJVin7IcG LZvSo3dswhjYJLxMNuWAXLbMs=; b=hUdQvCTFSN2PgCxGY1lS0JuQJ5ZKYq7yox cr6Nc+I9gT+mouJpMwJAahR1glahIIE/JvIvSIaWS4y2+QGgQi89CMStov3JSBaw EDJAwKQTPJHxqcBxDQI5x834KzCztWXA145nhfpA5FC8VEptLOEzXxLE9jyU2wU1 VoNx3IwJhd+jhc7UwPwChGE4PqnaunoqyYbKanaY1NwU2IH41DFloKBSRu2ACAGt ukJT6DpFxBS0LH7UG7dnZOch6nG73qBxOuNfKoSmVHOUBX0t+faKn0/eLTTwE0+6 oeIK2Q5SdisrAJDh+TXFw07pMNd/Gbm+ql6EFqCs7xp5ZuthG6fQ== X-ME-Sender: X-Sasl-enc: LTpsmCYzvRnnIrq0aHfA5V/VmALtGSVBJM71obkIv9uA 1496519157 Received: from localhost (unknown [73.81.113.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 5EFEA7E84B; Sat, 3 Jun 2017 15:45:57 -0400 (EDT) Date: Sat, 3 Jun 2017 15:45:55 -0400 From: Leo Famulari To: Danny Milosavljevic Subject: Re: bug#27212: [PATCH] file-systems: Improve error handling in the iso9660 case - fixes boot problem. Message-ID: <20170603194555.GA23491@jasmine> References: <8737bh0zvt.fsf@fastmail.com> <20170603180013.15853-1-dannym@scratchpost.org> <20170603202500.547f3d47@scratchpost.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Content-Disposition: inline In-Reply-To: <20170603202500.547f3d47@scratchpost.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 27212 Cc: Marius Bakke , 27212@debbugs.gnu.org, ng0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 03, 2017 at 08:25:00PM +0200, Danny Milosavljevic wrote: > Hi, >=20 > sorry for the slip-up. >=20 > The error handling in 203a9455c4695152fc5d0085bffeead9ce3216c2 was improv= ed > for the case when there's no iso9660 primary volume descriptor anywhere a= nd no > terminator either. In that case the CD is broken. >=20 > But if there's no iso9660 volume descriptor AT ALL (primary or not) it's = not a > fatal error for guix gnu/build/file-systems.scm - it just means we picked= the > wrong filesystem type and should try the next one. This case was not han= dled > correctly and this patch addresses this. >=20 > I'd like help with testing this patch. If someone with a fast computer c= ould > apply this patch, then run make check-system, and then, if everything wor= ked, > run guix system reconfigure /etc/config.scm , that would be great (my com= puter > is building guix master for the last 3 days and probably needs 4 more - s= o no > idea whether the patch works). I don't have access to a fast GuixSD system today. How about reverting the original change now, so that we can reduce the numb= er of people who hit the bug. Then we can test the revised commit afterwards. --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlkzEfMACgkQJkb6MLrK fwhvNQ//UF78ea6o8qrWU8fP8CQSzlRLws0/PPnDzdb1ZO2PXyy+4BuZFZjSflih 754HGQ81nYXyCg4RwAPONUsQ0Z9mJgtKC44nnCRaTtGJWObedas3bZbf0iSTCWxk d7nDQIUi6xy+yIN//sWcNEqAXPe+gEFBP6n2SPOmI7lLmeS1pAz3GISewxqcYvrg rJonm9CrfND6iYEmzRqU432nNUNDUXrk3hxPt2fg7B8IcOmDEuuUUNey5s2X0L1r LHLYp/ysVaGZpPpzZ3mFyNw+du5RmUYEXHEQzg1+Dt1Hqg045KDRjOR2B9u8fdP0 tVwL3i09s9t4VuzTjORejM61ALLI9TYxuxkf8zsCVP/C/iYu6QFy4JZcfpUxB3W8 mN5LYF6uqMidoq/pofMcjEoJKu9nP63r9osQK6kLJkRJFThmQH9g+5ARNCACSoZn J7oG18tH4tOCJcUDe+Mvzg3J6fA89Mz0Ru3+vbUY63lL4wfIzNXbc5bq5ZSCk5as XskJFfdtGRTtsM0t8dsPTksiq8qDxj68E83HbV2C2xgUsV5rimDWvNOX9o2diyE+ kF9t9IH7qEccD3FhzHd0v4/SWrdIEr4eRjNpvZcVI6aDsAi99A/5SGbZTm0fznWG v2nX9POByPWlrxnL5IQ3DXAvvBRcwI5NZwoOjOLZbJA4GYR328c= =gYNL -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 15:57:52 2017 Received: (at 27212) by debbugs.gnu.org; 3 Jun 2017 19:57:52 +0000 Received: from localhost ([127.0.0.1]:54180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHFBI-00055W-5y for submit@debbugs.gnu.org; Sat, 03 Jun 2017 15:57:52 -0400 Received: from mail.fsfe.org ([217.69.89.162]:49472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHFBD-00055F-VL for 27212@debbugs.gnu.org; Sat, 03 Jun 2017 15:57:51 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.fsfe.org (Postfix) with ESMTP id 5FF6D63BEFC for <27212@debbugs.gnu.org>; Sat, 3 Jun 2017 21:57:41 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.fsfe.org Received: from mail.fsfe.org ([127.0.0.1]) by localhost (cavendish.fsfeurope.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZF1ChGqNQy3c for <27212@debbugs.gnu.org>; Sat, 3 Jun 2017 21:57:41 +0200 (CEST) Received: by mail-it0-f52.google.com with SMTP id m62so33064385itc.0 for <27212@debbugs.gnu.org>; Sat, 03 Jun 2017 12:57:40 -0700 (PDT) X-Gm-Message-State: AODbwcD2yALejEmHnNim95zeCVpgzB2I3x1HSMvL/qdgBFrtwjWQKZPc dem2KRkYv6QzOOmPHLNMcPfPHEWbsQ== X-Received: by 10.107.18.166 with SMTP id 38mr9122195ios.227.1496519857363; Sat, 03 Jun 2017 12:57:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.9.150 with HTTP; Sat, 3 Jun 2017 12:57:36 -0700 (PDT) In-Reply-To: <20170603194555.GA23491@jasmine> References: <8737bh0zvt.fsf@fastmail.com> <20170603180013.15853-1-dannym@scratchpost.org> <20170603202500.547f3d47@scratchpost.org> <20170603194555.GA23491@jasmine> From: Jelle Licht Date: Sat, 3 Jun 2017 21:57:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#27212: [PATCH] file-systems: Improve error handling in the iso9660 case - fixes boot problem. To: Leo Famulari Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27212 Cc: Danny Milosavljevic , 27212@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Leo Famulari writes: > On Sat, Jun 03, 2017 at 08:25:00PM +0200, Danny Milosavljevic wrote: >> Hi, >> >> sorry for the slip-up. >> >> The error handling in 203a9455c4695152fc5d0085bffeead9ce3216c2 was improved >> for the case when there's no iso9660 primary volume descriptor anywhere and no >> terminator either. In that case the CD is broken. >> >> But if there's no iso9660 volume descriptor AT ALL (primary or not) it's not a >> fatal error for guix gnu/build/file-systems.scm - it just means we picked the >> wrong filesystem type and should try the next one. This case was not handled >> correctly and this patch addresses this. >> >> I'd like help with testing this patch. If someone with a fast computer could >> apply this patch, then run make check-system, and then, if everything worked, >> run guix system reconfigure /etc/config.scm , that would be great (my computer >> is building guix master for the last 3 days and probably needs 4 more - so no >> idea whether the patch works). > > I don't have access to a fast GuixSD system today. > > How about reverting the original change now, so that we can reduce the number of > people who hit the bug. Then we can test the revised commit afterwards. Good news! My system boots again after applying your patch and reconfiguring. The make check-system fails a network related test, but only because of an unrelated problem, as this already happened before any of these problems started. - Jelle From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 15:59:37 2017 Received: (at 27212) by debbugs.gnu.org; 3 Jun 2017 19:59:37 +0000 Received: from localhost ([127.0.0.1]:54183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHFCz-000589-Ge for submit@debbugs.gnu.org; Sat, 03 Jun 2017 15:59:37 -0400 Received: from avasout04.plus.net ([212.159.14.19]:40497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHEsx-0004eR-Q2 for 27212@debbugs.gnu.org; Sat, 03 Jun 2017 15:38:56 -0400 Received: from 212.159.95.115 ([212.159.95.115]) by avasout04 with smtp id UKen1v0032VMKdw01KepP7; Sat, 03 Jun 2017 20:38:49 +0100 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.2 cv=cL2QihWN c=1 sm=1 tr=0 a=IqWQtzj2xuRxUPEYs27Alw==:117 a=IqWQtzj2xuRxUPEYs27Alw==:17 a=IkcTkHD0fZMA:10 a=31774qUxAAAA:8 a=cQjp7QjMpsZhDSS5PegA:9 a=QEXdDO2ut3YA:10 a=JWeP9RHU5fVL6vWNRoOp:22 X-AUTH: zadkiel+jah@:2500 To: 27212@debbugs.gnu.org From: jah Subject: Re: bug#27212: 203a9455c4695152fc5d0085bffeead9ce3216c2 broke system boot Message-ID: <59331045.9020408@jahboite.co.uk> Date: Sat, 3 Jun 2017 20:38:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The same issue affects a GuixSD installed on a GPT partitioned Qemu image. This was after doing guix pull and guix system reconfigure to a fresh install of 0.13.0.x86_64-linux. The following is a screenshot of the backtrace:- [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [212.159.14.19 listed in list.dnswl.org] 0.9 RCVD_NUMERIC_HELO Received: contains an IP address used for HELO 1.5 FSL_HELO_BARE_IP_2 No description available. X-Debbugs-Envelope-To: 27212 X-Mailman-Approved-At: Sat, 03 Jun 2017 15:59:36 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jah@jahboite.co.uk Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) The same issue affects a GuixSD installed on a GPT partitioned Qemu image. This was after doing guix pull and guix system reconfigure to a fresh install of 0.13.0.x86_64-linux. The following is a screenshot of the backtrace:- https://jahboite.co.uk/files/bab/backtrace_file-systems-scm.png jah From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 16:11:09 2017 Received: (at 27212) by debbugs.gnu.org; 3 Jun 2017 20:11:09 +0000 Received: from localhost ([127.0.0.1]:54202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHFO8-0005Ph-PP for submit@debbugs.gnu.org; Sat, 03 Jun 2017 16:11:08 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:47890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHFO6-0005PY-Mf for 27212@debbugs.gnu.org; Sat, 03 Jun 2017 16:11:07 -0400 Received: from localhost (178.113.233.108.wireless.dyn.drei.com [178.113.233.108]) by dd1012.kasserver.com (Postfix) with ESMTPSA id CCC781CA039D; Sat, 3 Jun 2017 22:11:04 +0200 (CEST) Date: Sat, 3 Jun 2017 22:11:01 +0200 From: Danny Milosavljevic To: Jelle Licht Subject: Re: bug#27212: [PATCH] file-systems: Improve error handling in the iso9660 case - fixes boot problem. Message-ID: <20170603221101.63486150@scratchpost.org> In-Reply-To: References: <8737bh0zvt.fsf@fastmail.com> <20170603180013.15853-1-dannym@scratchpost.org> <20170603202500.547f3d47@scratchpost.org> <20170603194555.GA23491@jasmine> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27212 Cc: 27212@debbugs.gnu.org, Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Pushed as fb03f44bb117226e7d67a85401ffbb54ad8858ed. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 03 16:13:09 2017 Received: (at 27212) by debbugs.gnu.org; 3 Jun 2017 20:13:09 +0000 Received: from localhost ([127.0.0.1]:54206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHFQ5-0005SY-75 for submit@debbugs.gnu.org; Sat, 03 Jun 2017 16:13:09 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:48052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHFPy-0005SD-C4 for 27212@debbugs.gnu.org; Sat, 03 Jun 2017 16:13:07 -0400 Received: from localhost (178.113.233.108.wireless.dyn.drei.com [178.113.233.108]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 4915B1CA039D; Sat, 3 Jun 2017 22:13:01 +0200 (CEST) Date: Sat, 3 Jun 2017 22:12:57 +0200 From: Danny Milosavljevic To: Leo Famulari Subject: Re: bug#27212: [PATCH] file-systems: Improve error handling in the iso9660 case - fixes boot problem. Message-ID: <20170603221257.0de70ad7@scratchpost.org> In-Reply-To: <20170603194555.GA23491@jasmine> References: <8737bh0zvt.fsf@fastmail.com> <20170603180013.15853-1-dannym@scratchpost.org> <20170603202500.547f3d47@scratchpost.org> <20170603194555.GA23491@jasmine> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27212 Cc: Marius Bakke , 27212@debbugs.gnu.org, ng0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Leo, On Sat, 3 Jun 2017 15:45:55 -0400 Leo Famulari wrote: > How about reverting the original change now According to Marius that doesn't work either so it wouldn't help. So I've applied the new patch to master after Jelle's successful test. Should be fixed now. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 04 07:15:04 2017 Received: (at 27212-done) by debbugs.gnu.org; 4 Jun 2017 11:15:04 +0000 Received: from localhost ([127.0.0.1]:54653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHTUu-0007rO-0B for submit@debbugs.gnu.org; Sun, 04 Jun 2017 07:15:04 -0400 Received: from aibo.runbox.com ([91.220.196.211]:42330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHTUs-0007qw-4V for 27212-done@debbugs.gnu.org; Sun, 04 Jun 2017 07:15:02 -0400 Received: from [10.9.9.210] (helo=mailfront10.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1dHTUq-0004Ym-7G for 27212-done@debbugs.gnu.org; Sun, 04 Jun 2017 13:15:00 +0200 Received: from ori.enn.lu ([85.248.227.163] helo=localhost) by mailfront10.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1dHTUb-00012Q-As for 27212-done@debbugs.gnu.org; Sun, 04 Jun 2017 13:14:46 +0200 Date: Sun, 4 Jun 2017 11:14:37 +0000 From: ng0 To: 27212-done@debbugs.gnu.org Subject: Re: bug#27212: 203a9455c4695152fc5d0085bffeead9ce3216c2 broke system boot Message-ID: <20170604111437.paxpslozbik75r4m@abyayala> Mail-Followup-To: 27212-done@debbugs.gnu.org References: <20170603165321.iocqorc25mmvjhjf@abyayala> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170603165321.iocqorc25mmvjhjf@abyayala> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27212-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) ng0 transcribed 0.5K bytes: > Otherwise perfectly working systems I have *all* break after > https://git.savannah.gnu.org/cgit/guix.git/commit/?id=203a9455c4695152fc5d0085bffeead9ce3216c2 > > and the last thing they display before guile repl is the > message in that commit. > > Yes, I use labels. No, I don't use complicated setups. > Please test such changes before applying them in the wild.. > I just hope this happened here and the break is a mistake. > -- > ng0 > OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 Okay, this has been fixed. Thanks! I just booted into a functional generation. I'm closing this bug, in the future let's come up with ideas how to prevent this. It is not good PR to collectively send everyone into the guile repl. I started discussing about solutions to this offline already and in other channels. Thanks! -- ng0 OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588 From unknown Fri Aug 15 20:50:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Jul 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator