Subject: bug#27210: 25.2; Recovering loaddefs.el with desktop-mode hangs when linum is on

From: [email-masked]
Date: Sat, 03 Jun 2017 15:52:10 -0400

Eli Zaretskii <[email-masked]> writes:

> Or maybe we should do the below?
>
> diff --git a/lisp/linum.el b/lisp/linum.el
> index 8baa263..06165f2 100644
> --- a/lisp/linum.el
> +++ b/lisp/linum.el
> @@ -112,7 +112,8 @@ linum-mode
>  (define-globalized-minor-mode global-linum-mode linum-mode linum-on)
>  
>  (defun linum-on ()
> -  (unless (minibufferp)
> +  (unless (or (minibufferp)
> +              (and (daemonp) (null (frame-parameter nil 'client))))
>      (linum-mode 1)))

It feels like the proper solution should be

modified   src/frame.c
@@ -903,7 +903,7 @@ make_initial_frame (void)
   tty_frame_count = 1;
   fset_name (f, build_pure_c_string ("F1"));
 
-  SET_FRAME_VISIBLE (f, 1);
+  SET_FRAME_VISIBLE (f, 0);
 
   f->output_method = terminal->type;
   f->terminal = terminal;

Because the hidden "F1" frame clearly isn't actually visible (and we
don't need to show line numbers on it).  But that just triggers
Bug#26912 "desktop-clear with emacs as daemon results in error on C-x 5
0" even without desktop-clear, so it's not an acceptable solution by
itself at least.