GNU bug report logs - #27193
25.2; tmm should use completing-read-default

Previous Next

Package: emacs;

Reported by: Ryan <rct <at> thompsonclan.org>

Date: Fri, 2 Jun 2017 04:52:01 UTC

Severity: minor

Tags: patch

Found in version 25.2

Fixed in version 26.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #20 received at 27193 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Drew Adams <drew.adams <at> oracle.com>, Ryan Thompson <rct <at> thompsonclan.org>, 
 27193 <at> debbugs.gnu.org
Subject: Re: bug#27193: 25.2; tmm should use completing-read-default
Date: Sat, 3 Jun 2017 00:37:00 +0300
On 6/3/17 12:25 AM, Drew Adams wrote:

> The case that needs to be made for your proposal is really (IMO) that 
> there are /NO/ values of `completing-read-function', apart from 
> `completing-read-default', which would be compatible with the tmm code.

That would be too strong.

> I don't think you can make that case. I sense you are extrapolating from 
> your own particular use of `completing-read-function' (and similar uses).

This is ridiculous. If there are functions that adhere to the contract 
of completing-read-function, and tmm can't work with them, tmm should 
use completing-read-default, and that's that.

I'll install the submitted patch in a few days if someone doesn't beat 
me to it.

> The result is not even recognizable as completing-read.
> 
> I don't think so. Certainly no more unrecognizable than Ido...

You are mixing up concepts right and left. E.g. APIs with their callers.




This bug report was last modified 7 years and 353 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.