From unknown Mon Aug 11 19:06:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27186: check-TESTS has dependency on check_PROGRAMS etc Resent-From: Nick Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 01 Jun 2017 14:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27186 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 27186@debbugs.gnu.org X-Debbugs-Original-To: "bug-automake@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.149632563119867 (code B ref -1); Thu, 01 Jun 2017 14:01:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Jun 2017 14:00:31 +0000 Received: from localhost ([127.0.0.1]:49785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGQeN-0005AM-5X for submit@debbugs.gnu.org; Thu, 01 Jun 2017 10:00:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGQeK-0005A7-3K for submit@debbugs.gnu.org; Thu, 01 Jun 2017 10:00:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGQeE-0008Bg-2n for submit@debbugs.gnu.org; Thu, 01 Jun 2017 10:00:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60231) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dGQeD-0008Bc-W3 for submit@debbugs.gnu.org; Thu, 01 Jun 2017 10:00:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58681) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGQe9-000081-3v for bug-automake@gnu.org; Thu, 01 Jun 2017 10:00:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGQe5-0008AB-89 for bug-automake@gnu.org; Thu, 01 Jun 2017 10:00:17 -0400 Received: from mx0a-000f0801.pphosted.com ([2620:100:9001:7a::1]:52095) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dGQe5-00089E-05 for bug-automake@gnu.org; Thu, 01 Jun 2017 10:00:13 -0400 Received: from pps.filterd (m0000542.ppops.net [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v51Dd2GZ031784 for ; Thu, 1 Jun 2017 06:39:20 -0700 Received: from brmwp-exmb11.corp.brocade.com ([208.47.132.227]) by mx0a-000f0801.pphosted.com with ESMTP id 2aq8uw1r07-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 01 Jun 2017 06:39:20 -0700 Received: from EMEAWP-EXMB11.corp.brocade.com (172.29.11.85) by BRMWP-EXMB11.corp.brocade.com (172.16.59.77) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 1 Jun 2017 07:39:18 -0600 Received: from EMEAWP-EXMB12.corp.brocade.com (172.29.11.86) by EMEAWP-EXMB11.corp.brocade.com (172.29.11.85) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 1 Jun 2017 15:39:16 +0200 Received: from EMEAWP-EXMB12.corp.brocade.com ([fe80::44d8:98be:88a6:417a]) by EMEAWP-EXMB12.corp.brocade.com ([fe80::44d8:98be:88a6:417a%23]) with mapi id 15.00.1210.000; Thu, 1 Jun 2017 15:39:16 +0200 From: Nick Brown Thread-Topic: check-TESTS has dependency on check_PROGRAMS etc Thread-Index: AQHS2tx2Hlo2Gccr3EmDSg5iBwKgfQ== Date: Thu, 1 Jun 2017 13:39:16 +0000 Message-ID: <1496324356.8761.24.camel@brocade.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [172.27.212.149] Content-Type: text/plain; charset="utf-8" Content-ID: <30DAC3D0EEEF254A889E022A5AB53772@brocade.local> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-06-01_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706010249 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) U29tZXRoaW5nIGxpa2U6wqANCsKgwqDCoC4vYXV0b2dlbi5zaMKgDQrCoMKgwqAuL2NvbmZpZ3Vy ZcKgDQrCoMKgwqBtYWtlIGNoZWNrLVRFU1RTwqANCndpbGwgZmFpbCwgdW5sZXNzICdtYWtlIGNo ZWNrJyBpcyBydW4gYmVmb3JlICdtYWtlIGNoZWNrLVRFU1RTJyBmb3LCoA0KTWFrZWZpbGUuYW0g c25pcHBldCBsaWtlOsKgDQoNCmNoZWNrX1BST0dSQU1TID0gZm9vwqANCmNoZWNrX1NDUklQVFMg PSBydW5fZm9vX3dyYXBwZXIuc2jCoA0KVEVTVFMgPSAkKGNoZWNrX1NDUklQVFMpwqANCi0tLcKg DQrCoGxpYi9hbS9jaGVjay5hbSB8IDMgKystwqANCsKgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0 aW9ucygrKSwgMSBkZWxldGlvbigtKcKgDQoNCmRpZmYgLS1naXQgYS9saWIvYW0vY2hlY2suYW0g Yi9saWIvYW0vY2hlY2suYW3CoA0KaW5kZXggN2JjZmZkNTNmYWE4Li4xNWNmYzdjNjQ1OTggMTAw NjQ0wqANCi0tLSBhL2xpYi9hbS9jaGVjay5hbcKgDQorKysgYi9saWIvYW0vY2hlY2suYW3CoA0K QEAgLTQwMSw3ICs0MDEsOCBAQCBSRUNIRUNLX0xPR1MgPSAkKFRFU1RfTE9HUynCoA0KwqAjIyBS dW5uaW5nIGFsbCB0ZXN0cywgb3IgcmVjaGVja2luZyBmYWlsdXJlcy4gIyPCoA0KwqAjIyAtLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0gIyPCoA0KwqDCoA0KLWNoZWNr LVRFU1RTOsKgDQorIyMgUnVubmluZyB0ZXN0cyBkZXBlbmQgb24gJChjaGVja19TQ1JJUFRTKSwg JChjaGVja19QUk9HUkFNUyksIGV0Yy7CoA0KK2NoZWNrLVRFU1RTOiAlQ0hFQ0tfREVQUyXCoA0K wqAJQGxpc3Q9JyQoUkVDSEVDS19MT0dTKSc7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoHRlc3QgLXog IiQkbGlzdCIgfHwgcm0gLWYgJCRsaXN0wqANCsKgCUBsaXN0PSckKFJFQ0hFQ0tfTE9HUzoubG9n PS50cnMpJzsgdGVzdCAteiAiJCRsaXN0IiB8fCBybSAtZiAkJGxpc3TCoA0KwqAjIyBXZSBhbHdh eXMgaGF2ZSB0byByZW1vdmUgJChURVNUX1NVSVRFX0xPRyksIHRvIGVuc3VyZSBpdHMgcnVsZSBp cyBydW7CoA0KLS3CoA0K From unknown Mon Aug 11 19:06:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27186: check-TESTS has dependency on check_PROGRAMS etc Resent-From: Mathieu Lirzin Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Sun, 04 Jun 2017 22:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27186 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Nick Brown Cc: 27186@debbugs.gnu.org Received: via spool by 27186-submit@debbugs.gnu.org id=B27186.149661633319327 (code B ref 27186); Sun, 04 Jun 2017 22:46:02 +0000 Received: (at 27186) by debbugs.gnu.org; 4 Jun 2017 22:45:33 +0000 Received: from localhost ([127.0.0.1]:56241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHeH6-00051e-Kg for submit@debbugs.gnu.org; Sun, 04 Jun 2017 18:45:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHeH5-00051S-Ex for 27186@debbugs.gnu.org; Sun, 04 Jun 2017 18:45:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHeGz-0004f7-9W for 27186@debbugs.gnu.org; Sun, 04 Jun 2017 18:45:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHeGz-0004f3-75; Sun, 04 Jun 2017 18:45:25 -0400 Received: from [2a01:e35:2ec2:e580:491c:541:7a4a:37d9] (port=33052 helo=localhost.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dHeGy-0007af-N5; Sun, 04 Jun 2017 18:45:24 -0400 From: Mathieu Lirzin References: <1496324356.8761.24.camel@brocade.com> Date: Mon, 05 Jun 2017 00:45:22 +0200 In-Reply-To: <1496324356.8761.24.camel@brocade.com> (Nick Brown's message of "Thu, 1 Jun 2017 13:39:16 +0000") Message-ID: <87zidnwewt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Hello Nick, Nick Brown writes: > Something like:=C2=A0 > =C2=A0=C2=A0=C2=A0./autogen.sh=C2=A0 > =C2=A0=C2=A0=C2=A0./configure=C2=A0 > =C2=A0=C2=A0=C2=A0make check-TESTS=C2=A0 > will fail, unless 'make check' is run before 'make check-TESTS' for=C2=A0 > Makefile.am snippet like:=C2=A0 > > check_PROGRAMS =3D foo=C2=A0 > check_SCRIPTS =3D run_foo_wrapper.sh=C2=A0 > TESTS =3D $(check_SCRIPTS)=C2=A0 > ---=C2=A0 > =C2=A0lib/am/check.am | 3 ++-=C2=A0 > =C2=A01 file changed, 2 insertions(+), 1 deletion(-)=C2=A0 > > diff --git a/lib/am/check.am b/lib/am/check.am=C2=A0 > index 7bcffd53faa8..15cfc7c64598 100644=C2=A0 > --- a/lib/am/check.am=C2=A0 > +++ b/lib/am/check.am=C2=A0 > @@ -401,7 +401,8 @@ RECHECK_LOGS =3D $(TEST_LOGS)=C2=A0 > =C2=A0## Running all tests, or rechecking failures. ##=C2=A0 > =C2=A0## ------------------------------------------ ##=C2=A0 > =C2=A0=C2=A0 > -check-TESTS:=C2=A0 > +## Running tests depend on $(check_SCRIPTS), $(check_PROGRAMS), etc.=C2= =A0 > +check-TESTS: %CHECK_DEPS%=C2=A0 > =C2=A0 @list=3D'$(RECHECK_LOGS)';=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0test -z "$$list" || rm -f $$list=C2=A0 > =C2=A0 @list=3D'$(RECHECK_LOGS:.log=3D.trs)'; test -z "$$list" || rm -f $= $list=C2=A0 > =C2=A0## We always have to remove $(TEST_SUITE_LOG), to ensure its rule i= s run=C2=A0 > --=C2=A0 I must confess I have never used the 'check-TESTS' target myself. In fact Automake current manual doesn't even mention it. So it is not clear to me how it is expected to work, and what its role compare to the 'check' and 'recheck' target. Since you seems to use it, maybe you can give me more background on that target? Thanks for your patch. --=20 Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 From unknown Mon Aug 11 19:06:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27186: check-TESTS has dependency on check_PROGRAMS etc Resent-From: Nick Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 05 Jun 2017 10:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27186 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: "mthl@gnu.org" Cc: "27186@debbugs.gnu.org" <27186@debbugs.gnu.org> Received: via spool by 27186-submit@debbugs.gnu.org id=B27186.149665860524306 (code B ref 27186); Mon, 05 Jun 2017 10:31:02 +0000 Received: (at 27186) by debbugs.gnu.org; 5 Jun 2017 10:30:05 +0000 Received: from localhost ([127.0.0.1]:56529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHpGt-0006Ja-6n for submit@debbugs.gnu.org; Mon, 05 Jun 2017 06:30:05 -0400 Received: from mx0b-000f0801.pphosted.com ([67.231.152.113]:59260 helo=mx0a-000f0801.pphosted.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dHpGr-0006Io-89 for 27186@debbugs.gnu.org; Mon, 05 Jun 2017 06:30:01 -0400 Received: from pps.filterd (m0000700.ppops.net [127.0.0.1]) by mx0b-000f0801.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v55AOC3n016262; Mon, 5 Jun 2017 03:30:00 -0700 Received: from brmwp-exmb12.corp.brocade.com ([208.47.132.227]) by mx0b-000f0801.pphosted.com with ESMTP id 2autr1w06r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 05 Jun 2017 03:30:00 -0700 Received: from EMEAWP-EXMB12.corp.brocade.com (172.29.11.86) by BRMWP-EXMB12.corp.brocade.com (172.16.59.130) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 5 Jun 2017 04:29:58 -0600 Received: from EMEAWP-EXMB12.corp.brocade.com (172.29.11.86) by EMEAWP-EXMB12.corp.brocade.com (172.29.11.86) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 5 Jun 2017 12:29:56 +0200 Received: from EMEAWP-EXMB12.corp.brocade.com ([fe80::44d8:98be:88a6:417a]) by EMEAWP-EXMB12.corp.brocade.com ([fe80::44d8:98be:88a6:417a%23]) with mapi id 15.00.1210.000; Mon, 5 Jun 2017 12:29:56 +0200 From: Nick Brown Thread-Topic: bug#27186: check-TESTS has dependency on check_PROGRAMS etc Thread-Index: AQHS2tx2Hlo2Gccr3EmDSg5iBwKgfaIVUtlhgACjP4A= Date: Mon, 5 Jun 2017 10:29:55 +0000 Message-ID: <1496658595.8761.31.camel@brocade.com> References: <1496324356.8761.24.camel@brocade.com> <87zidnwewt.fsf@gnu.org> In-Reply-To: <87zidnwewt.fsf@gnu.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [172.27.212.149] Content-Type: text/plain; charset="utf-8" Content-ID: <4BDA796CDEA90B45B534A5F52A16B5A8@brocade.local> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-06-05_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706050186 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) T24gTW9uLCAyMDE3LTA2LTA1IGF0IDAwOjQ1ICswMjAwLCBNYXRoaWV1IExpcnppbiB3cm90ZToN Cj4gSGVsbG8gTmljaywNCj4gDQo+IE5pY2sgQnJvd24gPGJyb3dubkBCcm9jYWRlLmNvbT4gd3Jp dGVzOg0KPiANCj4gPiBTb21ldGhpbmcgbGlrZTrCoA0KPiA+IMKgwqDCoC4vYXV0b2dlbi5zaMKg DQo+ID4gwqDCoMKgLi9jb25maWd1cmXCoA0KPiA+IMKgwqDCoG1ha2UgY2hlY2stVEVTVFPCoA0K PiA+IHdpbGwgZmFpbCwgdW5sZXNzICdtYWtlIGNoZWNrJyBpcyBydW4gYmVmb3JlICdtYWtlIGNo ZWNrLVRFU1RTJw0KPiA+IGZvcsKgDQo+ID4gTWFrZWZpbGUuYW0gc25pcHBldCBsaWtlOsKgDQo+ ID4gDQo+ID4gY2hlY2tfUFJPR1JBTVMgPSBmb2/CoA0KPiA+IGNoZWNrX1NDUklQVFMgPSBydW5f Zm9vX3dyYXBwZXIuc2jCoA0KPiA+IFRFU1RTID0gJChjaGVja19TQ1JJUFRTKcKgDQo+ID4gLS0t wqANCj4gPiDCoGxpYi9hbS9jaGVjay5hbSB8IDMgKystwqANCj4gPiDCoDEgZmlsZSBjaGFuZ2Vk LCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSnCoA0KPiA+IA0KPiA+IGRpZmYgLS1naXQg YS9saWIvYW0vY2hlY2suYW0gYi9saWIvYW0vY2hlY2suYW3CoA0KPiA+IGluZGV4IDdiY2ZmZDUz ZmFhOC4uMTVjZmM3YzY0NTk4IDEwMDY0NMKgDQo+ID4gLS0tIGEvbGliL2FtL2NoZWNrLmFtwqAN Cj4gPiArKysgYi9saWIvYW0vY2hlY2suYW3CoA0KPiA+IEBAIC00MDEsNyArNDAxLDggQEAgUkVD SEVDS19MT0dTID0gJChURVNUX0xPR1MpwqANCj4gPiDCoCMjIFJ1bm5pbmcgYWxsIHRlc3RzLCBv ciByZWNoZWNraW5nIGZhaWx1cmVzLiAjI8KgDQo+ID4gwqAjIyAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0gIyPCoA0KPiA+IMKgwqANCj4gPiAtY2hlY2stVEVTVFM6 wqANCj4gPiArIyMgUnVubmluZyB0ZXN0cyBkZXBlbmQgb24gJChjaGVja19TQ1JJUFRTKSwgJChj aGVja19QUk9HUkFNUyksDQo+ID4gZXRjLsKgDQo+ID4gK2NoZWNrLVRFU1RTOiAlQ0hFQ0tfREVQ UyXCoA0KPiA+IMKgCUBsaXN0PSckKFJFQ0hFQ0tfTE9HUyknO8KgwqDCoMKgwqDCoMKgwqDCoMKg wqB0ZXN0IC16ICIkJGxpc3QiIHx8IHJtDQo+ID4gLWYgJCRsaXN0wqANCj4gPiDCoAlAbGlzdD0n JChSRUNIRUNLX0xPR1M6LmxvZz0udHJzKSc7IHRlc3QgLXogIiQkbGlzdCIgfHwgcm0NCj4gPiAt ZiAkJGxpc3TCoA0KPiA+IMKgIyMgV2UgYWx3YXlzIGhhdmUgdG8gcmVtb3ZlICQoVEVTVF9TVUlU RV9MT0cpLCB0byBlbnN1cmUgaXRzIHJ1bGUNCj4gPiBpcyBydW7CoA0KPiA+IC0twqANCj4gDQo+ IEkgbXVzdCBjb25mZXNzIEkgaGF2ZSBuZXZlciB1c2VkIHRoZSAnY2hlY2stVEVTVFMnIHRhcmdl dCBteXNlbGYuwqDCoEluDQo+IGZhY3QgQXV0b21ha2UgY3VycmVudCBtYW51YWwgZG9lc24ndCBl dmVuIG1lbnRpb24gaXQuwqDCoFNvIGl0IGlzIG5vdA0KPiBjbGVhciB0byBtZSBob3cgaXQgaXMg ZXhwZWN0ZWQgdG8gd29yaywgYW5kIHdoYXQgaXRzIHJvbGUgY29tcGFyZSB0bw0KPiB0aGUNCj4g J2NoZWNrJyBhbmQgJ3JlY2hlY2snIHRhcmdldC7CoMKgU2luY2UgeW91IHNlZW1zIHRvIHVzZSBp dCwgbWF5YmUgeW91DQo+IGNhbg0KPiBnaXZlIG1lIG1vcmUgYmFja2dyb3VuZCBvbiB0aGF0IHRh cmdldD8NCg0KQXMgZmFyIGFzIEkndmUgYmVlbiBhYmxlIHRvIGRldGVybWluZSBpdCdzIHB1cnBv c2UgaXMgdG8gYWN0dWFsbHkNCmV4ZWN1dGUgdGhlIHRoZSB0ZXN0IHNjcmlwdHMsIGFuZCBpcyB1 c2VkIGJ5IHRoZSAnY2hlY2snIHRhcmdldCBmb3INCnRoaXMuDQpJIGRvbid0IHVzZSBpdCBteXNl bGYgZGlyZWN0bHksIGJ1dCBidW1wZWQgaW50byB0aGlzIGlzc3VlIHdoZW4gdXNpbmcNCnRoZSB0 aGUgQVhfVkFMR1JJTkQgYXV0b21ha2UgbWFjcm8gdGhhdCB1c2VzIHRoaXMgdGFyZ2V0Og0KaHR0 cHM6Ly93d3cuZ251Lm9yZy9zb2Z0d2FyZS9hdXRvY29uZi1hcmNoaXZlL2F4X3ZhbGdyaW5kX2No ZWNrLmh0bWwNCg0KDQo+IA0KPiBUaGFua3MgZm9yIHlvdXIgcGF0Y2guDQo+IA== From unknown Mon Aug 11 19:06:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27186: check-TESTS has dependency on check_PROGRAMS etc Resent-From: Mathieu Lirzin Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 15 Jul 2017 22:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27186 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Nick Brown Cc: 27186@debbugs.gnu.org Received: via spool by 27186-submit@debbugs.gnu.org id=B27186.150015946916908 (code B ref 27186); Sat, 15 Jul 2017 22:58:01 +0000 Received: (at 27186) by debbugs.gnu.org; 15 Jul 2017 22:57:49 +0000 Received: from localhost ([127.0.0.1]:40795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWW0S-0004Od-Va for submit@debbugs.gnu.org; Sat, 15 Jul 2017 18:57:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWW0R-0004OS-JB for 27186@debbugs.gnu.org; Sat, 15 Jul 2017 18:57:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWW0J-0007ll-Du for 27186@debbugs.gnu.org; Sat, 15 Jul 2017 18:57:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWW0J-0007la-Aq; Sat, 15 Jul 2017 18:57:39 -0400 Received: from arennes-653-1-267-199.w109-218.abo.wanadoo.fr ([109.218.42.199]:51106 helo=pc10.home) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dWW0I-0000PX-Rw; Sat, 15 Jul 2017 18:57:39 -0400 From: Mathieu Lirzin References: <1496324356.8761.24.camel@brocade.com> <87zidnwewt.fsf@gnu.org> <1496658595.8761.31.camel@brocade.com> Date: Sun, 16 Jul 2017 00:57:36 +0200 In-Reply-To: <1496658595.8761.31.camel@brocade.com> (Nick Brown's message of "Mon, 5 Jun 2017 10:29:55 +0000") Message-ID: <87k239e2an.fsf@pc10.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Hello, Nick Brown writes: > On Mon, 2017-06-05 at 00:45 +0200, Mathieu Lirzin wrote: >>=20 >> Nick Brown writes: >>=20 >> > Something like:=C2=A0 >> > =C2=A0=C2=A0=C2=A0./autogen.sh=C2=A0 >> > =C2=A0=C2=A0=C2=A0./configure=C2=A0 >> > =C2=A0=C2=A0=C2=A0make check-TESTS=C2=A0 >> > will fail, unless 'make check' is run before 'make check-TESTS' >> > for=C2=A0 >> > Makefile.am snippet like:=C2=A0 >> >=20 >> > check_PROGRAMS =3D foo=C2=A0 >> > check_SCRIPTS =3D run_foo_wrapper.sh=C2=A0 >> > TESTS =3D $(check_SCRIPTS)=C2=A0 >> > ---=C2=A0 >> > =C2=A0lib/am/check.am | 3 ++-=C2=A0 >> > =C2=A01 file changed, 2 insertions(+), 1 deletion(-)=C2=A0 >> >=20 >> > diff --git a/lib/am/check.am b/lib/am/check.am=C2=A0 >> > index 7bcffd53faa8..15cfc7c64598 100644=C2=A0 >> > --- a/lib/am/check.am=C2=A0 >> > +++ b/lib/am/check.am=C2=A0 >> > @@ -401,7 +401,8 @@ RECHECK_LOGS =3D $(TEST_LOGS)=C2=A0 >> > =C2=A0## Running all tests, or rechecking failures. ##=C2=A0 >> > =C2=A0## ------------------------------------------ ##=C2=A0 >> > =C2=A0=C2=A0 >> > -check-TESTS:=C2=A0 >> > +## Running tests depend on $(check_SCRIPTS), $(check_PROGRAMS), >> > etc.=C2=A0 >> > +check-TESTS: %CHECK_DEPS%=C2=A0 >> > =C2=A0 @list=3D'$(RECHECK_LOGS)';=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0test -z "$$list" || rm >> > -f $$list=C2=A0 >> > =C2=A0 @list=3D'$(RECHECK_LOGS:.log=3D.trs)'; test -z "$$list" || rm >> > -f $$list=C2=A0 >> > =C2=A0## We always have to remove $(TEST_SUITE_LOG), to ensure its rule >> > is run=C2=A0 >> > --=C2=A0 >>=20 >> I must confess I have never used the 'check-TESTS' target myself.=C2=A0= =C2=A0In >> fact Automake current manual doesn't even mention it.=C2=A0=C2=A0So it i= s not >> clear to me how it is expected to work, and what its role compare to >> the >> 'check' and 'recheck' target.=C2=A0=C2=A0Since you seems to use it, mayb= e you >> can >> give me more background on that target? > > As far as I've been able to determine it's purpose is to actually > execute the the test scripts, and is used by the 'check' target for > this. > I don't use it myself directly, but bumped into this issue when using > the the AX_VALGRIND automake macro that uses this target: > https://www.gnu.org/software/autoconf-archive/ax_valgrind_check.html > while I think nobody should rely on 'check-TESTS' target which is an implementation detail. I think it is fine to make it depends on check_PROGRAMS and check_SCRIPTS. This is fixes by commit 8555e7b81d0d68e1e8105d072d69b94788953e15. Thank you. --=20 Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 18:58:57 2017 Received: (at control) by debbugs.gnu.org; 15 Jul 2017 22:58:57 +0000 Received: from localhost ([127.0.0.1]:40799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWW1Z-0004Qd-Bz for submit@debbugs.gnu.org; Sat, 15 Jul 2017 18:58:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWW1Y-0004QM-96 for control@debbugs.gnu.org; Sat, 15 Jul 2017 18:58:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWW1P-0008K8-VF for control@debbugs.gnu.org; Sat, 15 Jul 2017 18:58:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWW1P-0008K3-Rg for control@debbugs.gnu.org; Sat, 15 Jul 2017 18:58:47 -0400 Received: from arennes-653-1-267-199.w109-218.abo.wanadoo.fr ([109.218.42.199]:51120 helo=pc10.home) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dWW1P-0002QC-9q for control@debbugs.gnu.org; Sat, 15 Jul 2017 18:58:47 -0400 Date: Sun, 16 Jul 2017 00:58:45 +0200 Message-Id: <87fudxe28q.fsf@pc10.home> To: control@debbugs.gnu.org From: Mathieu Lirzin Subject: control message for bug #27186 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) tags 27186 fixed close 27186