GNU bug report logs - #27181
[PATCH] gnu: Add kaiju.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27181 in the body.
You can then email your comments to 27181 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-devel <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add kaiju.
Date: Thu, 01 Jun 2017 15:19:41 +0200

[Message part 1 (text/plain, inline)]

Dear Guix,

Here's a patch for kaiju.  A C++ program without any dependencies, plus
some additional scripts that need perl.

Kind regards,
Roel Janssen

[0001-gnu-Add-kaiju.patch (text/x-diff, attachment)]

Message #8 received at 27181 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 27181 <at> debbugs.gnu.org
Subject: Re: bug#27181: [PATCH] gnu: Add kaiju.
Date: Thu, 01 Jun 2017 17:23:01 +0200

Hi Roel!

Roel Janssen <roel <at> gnu.org> skribis:

> From ed45f47f7514faf10710b41a7d5e9cdaa8217c70 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel <at> gnu.org>
> Date: Thu, 1 Jun 2017 15:01:51 +0200
> Subject: [PATCH] gnu: Add kaiju.
>
> * gnu/packages/bioinformatics (kaiju): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (add-before 'build 'move-to-src-dir
> +           (lambda _ (chdir "src") #t))
> +         (replace 'install
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> +               (mkdir-p bin)
> +               (chdir "..")
> +               (copy-recursively "bin" bin)
> +               (copy-recursively "util" bin)))))))

Make sure to return #t at the end of the phase.  Otherwise LGTM!

Thanks,
Ludo’.

Message #13 received at 27181-done <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 27181-done <at> debbugs.gnu.org
Subject: Re: bug#27181: [PATCH] gnu: Add kaiju.
Date: Fri, 02 Jun 2017 13:42:22 +0200

Ludovic Courtès writes:

> Hi Roel!
>
> Roel Janssen <roel <at> gnu.org> skribis:
>
>> From ed45f47f7514faf10710b41a7d5e9cdaa8217c70 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel <at> gnu.org>
>> Date: Thu, 1 Jun 2017 15:01:51 +0200
>> Subject: [PATCH] gnu: Add kaiju.
>>
>> * gnu/packages/bioinformatics (kaiju): New variable.
>
> [...]
>
>> +       (modify-phases %standard-phases
>> +         (delete 'configure)
>> +         (add-before 'build 'move-to-src-dir
>> +           (lambda _ (chdir "src") #t))
>> +         (replace 'install
>> +           (lambda* (#:key inputs outputs #:allow-other-keys)
>> +             (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
>> +               (mkdir-p bin)
>> +               (chdir "..")
>> +               (copy-recursively "bin" bin)
>> +               (copy-recursively "util" bin)))))))
>
> Make sure to return #t at the end of the phase.  Otherwise LGTM!

I added the #t to the end of the phase.

Thanks Ludo’! Pushed in b9a601d9db3aa1bdb877c0ac5e7f53077ee56185.

Kind regards,
Roel Janssen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.