GNU bug report logs - #27178
libxml-parse-*-region functions discard-comments argument only applies to top level comments

Previous Next

Full log

Message #23 received at 27178 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 27178 <at> debbugs.gnu.org, eefacm <at> gmail.com, npostavs <at> users.sourceforge.net
Subject: Re: bug#27178: 26.0.50;
 libxml-parse-*-region functions ignore discard-comments argument
Date: Sat, 14 Apr 2018 15:11:44 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> Why not update the docs, as Noam suggested last June?

Well, it would be nice if we could just get this to work, and it just
occurred to me that supporting this option shouldn't be that difficult:
We can just pre-treat the XML before parsing it.

That is, if discard-comments is mentioned, we can just go through the
buffer and delete all the comments before we point libxml towards it.

On the other hand, we could deprecate that option (since it's rather
nonsensical the way it is now), and just provide a Lisp convenience
function to delete the comments if you don't want comments?  I think
that sounds cleaner and much easier to implement.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.