From unknown Sat Sep 06 21:08:07 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27178 <27178@debbugs.gnu.org> To: bug#27178 <27178@debbugs.gnu.org> Subject: Status: libxml-parse-*-region functions discard-comments argument only applies to top level comments Reply-To: bug#27178 <27178@debbugs.gnu.org> Date: Sun, 07 Sep 2025 04:08:07 +0000 retitle 27178 libxml-parse-*-region functions discard-comments argument onl= y applies to top level comments reassign 27178 emacs submitter 27178 Sean McAfee severity 27178 normal tag 27178 confirmed fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed May 31 20:07:22 2017 Received: (at submit) by debbugs.gnu.org; 1 Jun 2017 00:07:22 +0000 Received: from localhost ([127.0.0.1]:48145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGDe5-0001kJ-IB for submit@debbugs.gnu.org; Wed, 31 May 2017 20:07:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGDe2-0001k2-Mx for submit@debbugs.gnu.org; Wed, 31 May 2017 20:07:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGDdu-0002uX-Vz for submit@debbugs.gnu.org; Wed, 31 May 2017 20:07:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dGDdu-0002uL-Sd for submit@debbugs.gnu.org; Wed, 31 May 2017 20:07:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGDds-00011F-Fj for bug-gnu-emacs@gnu.org; Wed, 31 May 2017 20:07:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGDdq-0002sS-B4 for bug-gnu-emacs@gnu.org; Wed, 31 May 2017 20:07:08 -0400 Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]:33990) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dGDdq-0002s7-3w for bug-gnu-emacs@gnu.org; Wed, 31 May 2017 20:07:06 -0400 Received: by mail-qt0-x22c.google.com with SMTP id c13so25047371qtc.1 for ; Wed, 31 May 2017 17:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=W2NtIM6yXQac3a+IjyZAtNEtpm7F5MB6WBIOGGoeXKs=; b=SNat0L6Nur3IsM5F+8afGYtzMhywUI8ivnRDRYsln+RRJShm9a9Knp2PW9WtwoIUiH YOKDt1e/P4xExIY9cwJrN9wwXcB2fJWm3oWADhR95eOxqhuem/+UAKFm0F+lBEFDvSml rJDb5rWVSg0beNIlkwEhibtqfb+QEDfjdMBgBZaSEmMpIw7vTh7A4av2ElmKizPPUvcw 5zehX0vSISQZebYtPIO/nr/AH1qmzVk7362ZEQzgz1TO47KMxrCxlo5FX8KTx989F0pb usN8cNTEgqtVTepdb58nrmqd6hNP9//blA8j0LeYNHWe8CAFVBGt0yV7JouHwxxe8M8s mClg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=W2NtIM6yXQac3a+IjyZAtNEtpm7F5MB6WBIOGGoeXKs=; b=QARRa+kC63MVF7OkOSqPycl/HgpcyIReRSHFlXh4pjwKxHpmtKjJrq2HmIJZjO9cR2 Mzzo/ryV1e3EIF0aSJzP3f+gJvdIaNXQxlIGg4hRReL5CVeGwkArG9hsNha0Ox3Y9aXp /3BLd4euY3fHqT+RVbWq1UfHVErrh8sK2S+J2Wbe6KQYKuuq6rIO5CxqVW6qHfK6vCm/ h5abhH2BCojUV2kaTkOejLi47Rh6DuiA2NQczx9slOLe4uIdfZOMESIgfdukkh4OEPST qPjLwF0LHPu5Jzs7Z6wUSlRg+NYja/3EXI0/ZBOkWjiKeuFHk8cNtgZKVwesmb8t/C5k h7cA== X-Gm-Message-State: AODbwcBxgGvdqXfL4OuPQ98wp2s7Yag+EWdwqQ1F6j48Z1tQFbiEPTF9 BL9kX39Qpzj/uZ0ZRi+Wf1gFIiGkMnNHjk0= X-Received: by 10.200.36.87 with SMTP id d23mr32585300qtd.196.1496275623517; Wed, 31 May 2017 17:07:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.180.85 with HTTP; Wed, 31 May 2017 17:07:03 -0700 (PDT) From: Sean McAfee Date: Wed, 31 May 2017 17:07:03 -0700 Message-ID: Subject: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="001a113fed2006a4be0550dad17b" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a113fed2006a4be0550dad17b Content-Type: text/plain; charset="UTF-8" The libxml-parse-html-region and libxml-parse-xml-region functions both appear to ignore their discard-comments parameters. When I enter the following text in a buffer and mark it:

This that

Then the result of evaluating the expression (libxml-parse-html-region (mark) (point) nil t) is (html nil (body nil (p nil "This " (comment nil " and ") " that"))) and the result of evaluating the expression (libxml-parse-xml-region (mark) (point) nil t) is (p nil "This " (comment nil " and ") " that") In both cases, I would expect that passing t as the fourth argument would cause the comments to be dropped, but they are not. Incidentally, I notice that the documentation for libxml-parse-xml-region includes the following sentence: If DISCARD-COMMENTS is non-nil, all HTML comments are discarded. I imagine this ought to refer to "XML comments" rather than "HTML comments." In GNU Emacs 26.0.50 (build 1, x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911)) of 2017-05-15 built on builder10-9.local Windowing system distributor 'Apple', version 10.3.1504 Recent messages: (html nil (body nil (p nil "this " (comment nil " and ") " that"))) [2 times] Auto-saving... funcall-interactively: Beginning of buffer (html nil (body nil (p nil "this " (comment nil " and ") " that"))) [2 times] Quit [4 times] Mark activated (p nil "this " (comment nil " and ") " that") uncompressing dom.el.gz...done Note: standard-indent adjusted to 2 Quit [3 times] Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: recentf-mode: t global-anzu-mode: t anzu-mode: t volatile-highlights-mode: t dtrt-indent-mode: t projectile-mode: t elisp-slime-nav-mode: t diff-auto-refine-mode: t magit-auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t google-this-mode: t global-flycheck-mode: t flycheck-mode: t minibuffer-depth-indicate-mode: t ido-everywhere: t global-undo-tree-mode: t undo-tree-mode: t paredit-mode: t override-global-mode: t show-paren-mode: t electric-pair-mode: t savehist-mode: t desktop-save-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t global-prettify-symbols-mode: t prettify-symbols-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail apropos ruby-end autoload lisp-mnt skeleton perl6-mode perl6-indent perl6-font-lock cus-edit cus-start cus-load warnings pcmpl-gnu mc-edit-lines edbi sql view epc ctable concurrent deferred cperl-mode-expansions cperl-mode tabify iso-transl bookmark woman man tmm pcmpl-unix vc-annotate vc vc-dispatcher pulse mm-archive rvm pp cl-print ag vc-svn find-dired wdired misearch multi-isearch dired-aux debug eieio-opt speedbar sb-image ezimage dframe define-word help-fns radix-tree network-stream starttls url-cache recentf tree-widget markdown-mode rng-xsd xsd-regexp rng-cmpct nxml-mode-expansions rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-enc xmltok sh-script executable conf-mode js-mode-expansions js tagedit s html-mode-expansions sgml-mode dom imenu cc-mode-expansions cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view image-mode org-bibtex bibtex org-bbdb org-w3m the-org-mode-expansions org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs gnus-dired restclient perl6-detect anzu vc-git robe url-http tls gnutls url-auth url-gw nsm inf-ruby ruby-mode-expansions ruby-mode smie yasnippet term disp-table ehelp volatile-highlights iedit iedit-lib multiple-cursors-core rect dtrt-indent projectile grep ibuf-ext ibuffer ibuffer-loaddefs elisp-slime-nav etags xref project magit-obsolete magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-branch magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode diff-mode magit-core magit-autorevert autorevert filenotify magit-process magit-margin magit-mode magit-git magit-section magit-popup git-commit magit-utils crm log-edit message puny rfc822 mml mml-sec epa epg mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp async tramp-sh tramp tramp-compat tramp-loaddefs trampver shell pcomplete parse-time format-spec google-this url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap flycheck derived json map find-func subr-x dash jka-compr compile let-alist gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr wid-edit autoinsert misc mb-depth ido dired-details+ dired dired-loaddefs dired-details change-inner expand-region text-mode-expansions er-basic-expansions expand-region-core advice expand-region-custom org-bullets undo-tree diff paredit edmacro kmacro cl-extra help-mode use-package pcase diminish bind-key easy-mmode finder-inf rx info package easymenu epg-config url-handlers url-parse auth-source eieio eieio-core eieio-loaddefs password-cache url-vars seq byte-opt bytecomp byte-compile cconv paren elec-pair savehist desktop frameset server hippie-exp comint ansi-color ring thingatpt cl-seq perl-mode cl-macs cl gv cl-loaddefs cl-lib time-date tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 1962060 148065) (symbols 48 60774 13) (miscs 40 9578 7951) (strings 32 245948 52334) (string-bytes 1 7136436) (vectors 16 106836) (vector-slots 8 2489273 298510) (floats 8 419 1325) (intervals 56 216342 2447) (buffers 976 204)) --001a113fed2006a4be0550dad17b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

The libxml-parse-html-region and libxml-parse-xml-regi= on functions both
appear to ignore their discard-comments parameters.
When I enter the following text in a buffer and mark it:

=C2=A0= <p>This <!-- and --> that</p>

Then the result of = evaluating the expression

=C2=A0 (libxml-parse-html-region (mark) (p= oint) nil t)

is

=C2=A0 (html nil (body nil (p nil "This = " (comment nil " and ") " that")))

and the = result of evaluating the expression

=C2=A0 (libxml-parse-xml-region = (mark) (point) nil t)

is

=C2=A0 (p nil "This " (com= ment nil " and ") " that")

In both cases, I woul= d expect that passing t as the fourth argument
would cause the comments = to be dropped, but they are not.

Incidentally, I notice that the doc= umentation for
libxml-parse-xml-region includes the following sentence:<= br>
=C2=A0 If DISCARD-COMMENTS is non-nil, all HTML comments are discard= ed.

I imagine this ought to refer to "XML comments" rather= than "HTML
comments."


In GNU Emacs 26.0.50 (build = 1, x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F19= 11))
=C2=A0of 2017-05-15 built on builder10-9.local
Windowing system = distributor 'Apple', version 10.3.1504
Recent messages:
(html= nil (body nil (p nil "this " (comment nil " and ") &qu= ot; that"))) [2 times]
Auto-saving...
funcall-interactively: Beg= inning of buffer
(html nil (body nil (p nil "this " (comment n= il " and ") " that"))) [2 times]
Quit [4 times]
M= ark activated
(p nil "this " (comment nil " and ") &= quot; that")
uncompressing dom.el.gz...done
Note: standard-inden= t adjusted to 2
Quit [3 times]

Configured using:
=C2=A0'co= nfigure --with-ns '--enable-locallisppath=3D/Library/Application
=C2= =A0Support/Emacs/${version}/site-lisp:/Library/Application
=C2=A0Support= /Emacs/site-lisp' --with-modules'

Configured features:
NO= TIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES

Importan= t settings:
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 locale-coding-s= ystem: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effec= t:
=C2=A0 recentf-mode: t
=C2=A0 global-anzu-mode: t
=C2=A0 anzu-m= ode: t
=C2=A0 volatile-highlights-mode: t
=C2=A0 dtrt-indent-mode: t<= br>=C2=A0 projectile-mode: t
=C2=A0 elisp-slime-nav-mode: t
=C2=A0 di= ff-auto-refine-mode: t
=C2=A0 magit-auto-revert-mode: t
=C2=A0 global= -git-commit-mode: t
=C2=A0 async-bytecomp-package-mode: t
=C2=A0 shel= l-dirtrack-mode: t
=C2=A0 google-this-mode: t
=C2=A0 global-flycheck-= mode: t
=C2=A0 flycheck-mode: t
=C2=A0 minibuffer-depth-indicate-mode= : t
=C2=A0 ido-everywhere: t
=C2=A0 global-undo-tree-mode: t
=C2= =A0 undo-tree-mode: t
=C2=A0 paredit-mode: t
=C2=A0 override-global-m= ode: t
=C2=A0 show-paren-mode: t
=C2=A0 electric-pair-mode: t
=C2= =A0 savehist-mode: t
=C2=A0 desktop-save-mode: t
=C2=A0 tooltip-mode:= t
=C2=A0 global-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2= =A0 mouse-wheel-mode: t
=C2=A0 global-prettify-symbols-mode: t
=C2=A0= prettify-symbols-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0 file-name-sh= adow-mode: t
=C2=A0 global-font-lock-mode: t
=C2=A0 font-lock-mode: t=
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-composition-mode: t
=C2= =A0 auto-encryption-mode: t
=C2=A0 auto-compression-mode: t
=C2=A0 li= ne-number-mode: t
=C2=A0 transient-mark-mode: t

Load-path shadows= :
None found.

Features:
(shadow sort mail-extr emacsbug sendma= il apropos ruby-end autoload
lisp-mnt skeleton perl6-mode perl6-indent p= erl6-font-lock cus-edit
cus-start cus-load warnings pcmpl-gnu mc-edit-li= nes edbi sql view epc
ctable concurrent deferred cperl-mode-expansions c= perl-mode tabify
iso-transl bookmark woman man tmm pcmpl-unix vc-annotat= e vc
vc-dispatcher pulse mm-archive rvm pp cl-print ag vc-svn find-dired=
wdired misearch multi-isearch dired-aux debug eieio-opt speedbar
sb-= image ezimage dframe define-word help-fns radix-tree network-stream
star= ttls url-cache recentf tree-widget markdown-mode rng-xsd xsd-regexp
rng-= cmpct nxml-mode-expansions rng-nxml rng-valid rng-loc rng-uri
rng-parse = nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns
nxml-mode nxml-ou= tln nxml-rap nxml-util nxml-enc xmltok sh-script
executable conf-mode js= -mode-expansions js tagedit s
html-mode-expansions sgml-mode dom imenu c= c-mode-expansions cc-mode
cc-fonts cc-guess cc-menus cc-cmds cc-styles c= c-align cc-engine cc-vars
cc-defs org-element org-rmail org-mhe org-irc = org-info org-gnus
org-docview doc-view image-mode org-bibtex bibtex org-= bbdb org-w3m
the-org-mode-expansions org org-macro org-footnote org-pcom= plete
org-list org-faces org-entities noutline outline org-version
ob= -emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys
o= b-comint ob-core ob-eval org-compat org-macs org-loaddefs cal-menu
calen= dar cal-loaddefs gnus-dired restclient perl6-detect anzu vc-git
robe url= -http tls gnutls url-auth url-gw nsm inf-ruby
ruby-mode-expansions ruby-= mode smie yasnippet term disp-table ehelp
volatile-highlights iedit iedi= t-lib multiple-cursors-core rect
dtrt-indent projectile grep ibuf-ext ib= uffer ibuffer-loaddefs
elisp-slime-nav etags xref project magit-obsolete= magit-blame
magit-stash magit-bisect magit-remote magit-commit magit-se= quence
magit-notes magit-worktree magit-branch magit-files magit-refsmagit-status magit magit-repos magit-apply magit-wip magit-log
magit-di= ff smerge-mode diff-mode magit-core magit-autorevert autorevert
filenoti= fy magit-process magit-margin magit-mode magit-git magit-section
magit-p= opup git-commit magit-utils crm log-edit message puny rfc822 mml
mml-sec= epa epg mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm= -utils mailheader pcvs-util add-log with-editor
async-bytecomp async tra= mp-sh tramp tramp-compat tramp-loaddefs trampver
shell pcomplete parse-t= ime format-spec google-this url url-proxy
url-privacy url-expand url-met= hods url-history url-cookie url-domsuf
url-util mailcap flycheck derived= json map find-func subr-x dash
jka-compr compile let-alist gnus nnheade= r gnus-util rmail rmail-loaddefs
rfc2047 rfc2045 ietf-drums mail-utils m= m-util mail-prsvr wid-edit
autoinsert misc mb-depth ido dired-details+ d= ired dired-loaddefs
dired-details change-inner expand-region text-mode-e= xpansions
er-basic-expansions expand-region-core advice expand-region-cu= stom
org-bullets undo-tree diff paredit edmacro kmacro cl-extra help-mod= e
use-package pcase diminish bind-key easy-mmode finder-inf rx info
p= ackage easymenu epg-config url-handlers url-parse auth-source eieio
eiei= o-core eieio-loaddefs password-cache url-vars seq byte-opt bytecomp
byte= -compile cconv paren elec-pair savehist desktop frameset server
hippie-e= xp comint ansi-color ring thingatpt cl-seq perl-mode cl-macs cl
gv cl-lo= addefs cl-lib time-date tooltip eldoc electric uniquify
ediff-hook vc-ho= oks lisp-float-type mwheel term/ns-win ns-win
ucs-normalize mule-util te= rm/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-lis= t replace newcomment text-mode elisp-mode
lisp-mode prog-mode register p= age menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock = font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cha= m georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao kor= ean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech europea= n ethiopic indian cyrillic
chinese composite charscript charprop case-ta= ble epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-prel= oaded nadvice loaddefs
button faces cus-face macroexp files text-propert= ies overlay sha1 md5
base64 format env code-pages mule custom widget has= htable-print-readable
backquote kqueue cocoa ns multi-tty make-network-p= rocess emacs)

Memory information:
((conses 16 1962060 148065)
= =C2=A0(symbols 48 60774 13)
=C2=A0(miscs 40 9578 7951)
=C2=A0(strings= 32 245948 52334)
=C2=A0(string-bytes 1 7136436)
=C2=A0(vectors 16 10= 6836)
=C2=A0(vector-slots 8 2489273 298510)
=C2=A0(floats 8 419 1325)=
=C2=A0(intervals 56 216342 2447)
=C2=A0(buffers 976 204))

--001a113fed2006a4be0550dad17b-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 10 11:48:35 2017 Received: (at 27178) by debbugs.gnu.org; 10 Jun 2017 15:48:35 +0000 Received: from localhost ([127.0.0.1]:39078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJict-0000dO-7T for submit@debbugs.gnu.org; Sat, 10 Jun 2017 11:48:35 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:34845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJicr-0000d5-5d; Sat, 10 Jun 2017 11:48:33 -0400 Received: by mail-it0-f66.google.com with SMTP id 67so8326054itx.2; Sat, 10 Jun 2017 08:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4RBC/htvVbjlChyHBWmpqQvayQmO11pHj0RSAc6ogEU=; b=ETSvBlGqS6HCR4UwiVtgoeukerOa/I1PtcLDRo6l/ujWn3nAP9/6FfG8bXjUgMScHR bo2ozSo8ERk3GJQrWgENfasrWgy8yT/tFVUtg+QkPoID5wnUDFWgmDaP1NBTLYpV/E8u nn/O0twDglsxzI1j1w2juiyKp3i6Hc01s6EVy7KHprOcqz2q8vjDbVtX+SmpHjEP0wsg 9pxSwV2tBTbtd0QYBcWyhIoYBU5ARgXbzdB/V4Aw6wtmaK5wrQjIDVsR5254pqCwdBes NkU1qVykOZzAESV8zj15/PBkRpbHF8lEtQoC1QudDbGduycDWnTuwU9HmNGHr4674Kwx AZ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=4RBC/htvVbjlChyHBWmpqQvayQmO11pHj0RSAc6ogEU=; b=Y0NP1VDoYeC0j45/b7m/0OYs2srUeRg2o3ZYd7JdkaVo+aiQSA3NzWe4hBYWNfBKkc 98hYOSq3kWSOnz0md8sFzLxGO0NdvQNi5yXxdkCuQep3M5lywbuExY26JZzTURojlupi K3CkWKhLQ0CCXw+a0y073Gr3g/QT+U6eA+eiIwwBlgBDmwnI9QA94HFXktCXPxuiDyqZ MTLB3XIvH/pHJJ5vL/SP+wdvM3qfeXEMzCqaW6KwUvPNpkuCIHeIlpF3GkwwY8lsoI3v FP1Hcf08NNutixZPj5uZQUQxD0HNHDtO752CH0xGneRSL2VeL5jSeJJuQgHyhQURsKhp o+EQ== X-Gm-Message-State: AODbwcDLNst9V7XqxhKwG3wnDNj6sOjXIc3BxiMURhiruoSHFGcmmjXQ S2RdPRzEhxe6Qtpm X-Received: by 10.36.44.201 with SMTP id i192mr4812161iti.21.1497109707354; Sat, 10 Jun 2017 08:48:27 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id g188sm1989610iof.6.2017.06.10.08.48.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 10 Jun 2017 08:48:26 -0700 (PDT) From: npostavs@users.sourceforge.net To: Sean McAfee Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: Date: Sat, 10 Jun 2017 11:50:06 -0400 In-Reply-To: (Sean McAfee's message of "Wed, 31 May 2017 17:07:03 -0700") Message-ID: <877f0jx2oh.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 27178 Cc: 27178@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) retitle 27178 libxml-parse-*-region functions discard-comments argument only applies to top level comments found 27178 25.2 tags 27178 confirmed quit Sean McAfee writes: > The libxml-parse-html-region and libxml-parse-xml-region functions both > appear to ignore their discard-comments parameters. > > When I enter the following text in a buffer and mark it: > >

This that

> > Then the result of evaluating the expression > > (libxml-parse-html-region (mark) (point) nil t) > > is > > (html nil (body nil (p nil "This " (comment nil " and ") " that"))) > > and the result of evaluating the expression > > (libxml-parse-xml-region (mark) (point) nil t) > > is > > (p nil "This " (comment nil " and ") " that") > > In both cases, I would expect that passing t as the fourth argument > would cause the comments to be dropped, but they are not. It doesn't quite ignore that argument, but it only applies to top level comments. I think it's the implementation level leaking through. See in xml.c: static Lisp_Object parse_region (Lisp_Object start, Lisp_Object end, Lisp_Object base_url, Lisp_Object discard_comments, bool htmlp) { ... /* The document doesn't have toplevel comments or we discarded them. Get the tree the proper way. */ xmlNode *node = xmlDocGetRootElement (doc); Apparently the "proper" way already discards top level comments, so the DISCARD-COMMENTS parameter was added to be able to control this. Maybe we should just update the docs to match the code though, not sure. > Incidentally, I notice that the documentation for > libxml-parse-xml-region includes the following sentence: > > If DISCARD-COMMENTS is non-nil, all HTML comments are discarded. > > I imagine this ought to refer to "XML comments" rather than "HTML > comments." Yeah, looks like copy-pasta from libxml-parse-html-region. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 13 18:54:22 2018 Received: (at 27178) by debbugs.gnu.org; 13 Apr 2018 22:54:22 +0000 Received: from localhost ([127.0.0.1]:51081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f77aH-0002EC-W5 for submit@debbugs.gnu.org; Fri, 13 Apr 2018 18:54:22 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:47096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f77aG-0002E2-1b for 27178@debbugs.gnu.org; Fri, 13 Apr 2018 18:54:20 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f77aA-00082K-VB; Sat, 14 Apr 2018 00:54:17 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f77a5-0003lS-F5; Sat, 14 Apr 2018 00:54:09 +0200 From: Lars Ingebrigtsen To: npostavs@users.sourceforge.net Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> Date: Sat, 14 Apr 2018 00:54:09 +0200 In-Reply-To: <877f0jx2oh.fsf@users.sourceforge.net> (npostavs's message of "Sat, 10 Jun 2017 11:50:06 -0400") Message-ID: <87bmemn2em.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27178 Cc: 27178@debbugs.gnu.org, Sean McAfee X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I tried the following, but it's not correct, since it resulted in (html nil (body nil (p nil "This " nil " that"))) But what should the result be here? (html nil (body nil (p nil "This that"))) or (html nil (body nil (p nil "This " " that"))) ? I think the former... Which means that you'd have to do some major doctoring of the structures, I think? diff --git a/src/xml.c b/src/xml.c index 42059d7713..bf416407da 100644 --- a/src/xml.c +++ b/src/xml.c @@ -119,7 +119,7 @@ init_libxml2_functions (void) } static Lisp_Object -make_dom (xmlNode *node) +make_dom (xmlNode *node, bool discard_comments) { if (node->type == XML_ELEMENT_NODE) { @@ -148,7 +148,7 @@ make_dom (xmlNode *node) child = node->children; while (child != NULL) { - result = Fcons (make_dom (child), result); + result = Fcons (make_dom (child, discard_comments), result); child = child->next; } @@ -163,7 +163,7 @@ make_dom (xmlNode *node) } else if (node->type == XML_COMMENT_NODE) { - if (node->content) + if (node->content && ! discard_comments) return list3 (intern ("comment"), Qnil, build_string ((char *) node->content)); else @@ -239,7 +239,7 @@ parse_region (Lisp_Object start, Lisp_Object end, Lisp_Object base_url, while (n) { if (!NILP (r)) result = Fcons (r, result); - r = make_dom (n); + r = make_dom (n, false); n = n->next; } } @@ -249,7 +249,7 @@ parse_region (Lisp_Object start, Lisp_Object end, Lisp_Object base_url, them. Get the tree the proper way. */ xmlNode *node = xmlDocGetRootElement (doc); if (node != NULL) - result = make_dom (node); + result = make_dom (node, !NILP(discard_comments)); } else result = Fcons (Qtop, Fcons (Qnil, Fnreverse (Fcons (r, result)))); -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 02:49:40 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 06:49:40 +0000 Received: from localhost ([127.0.0.1]:51291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7F0D-0004UF-0t for submit@debbugs.gnu.org; Sat, 14 Apr 2018 02:49:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7F08-0004Tz-OC for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 02:49:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7Ezz-0005gV-Dk for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 02:49:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7Ezt-0005eo-Qg; Sat, 14 Apr 2018 02:49:17 -0400 Received: from [176.228.60.248] (port=3688 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f7Ezt-0004td-63; Sat, 14 Apr 2018 02:49:17 -0400 Date: Sat, 14 Apr 2018 09:49:16 +0300 Message-Id: <83r2ni470z.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87bmemn2em.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Sat, 14 Apr 2018 00:54:09 +0200) Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27178 Cc: 27178@debbugs.gnu.org, eefacm@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lars Ingebrigtsen > Date: Sat, 14 Apr 2018 00:54:09 +0200 > Cc: 27178@debbugs.gnu.org, Sean McAfee > > I tried the following, but it's not correct, since it resulted in > > (html nil (body nil (p nil "This " nil " that"))) > > But what should the result be here? > > (html nil (body nil (p nil "This that"))) > > or > > (html nil (body nil (p nil "This " " that"))) > > ? > > I think the former... Which means that you'd have to do some major > doctoring of the structures, I think? Why not update the docs, as Noam suggested last June? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 09:11:56 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 13:11:56 +0000 Received: from localhost ([127.0.0.1]:51394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7KyC-0000Rw-Ji for submit@debbugs.gnu.org; Sat, 14 Apr 2018 09:11:56 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:53260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7KyB-0000Rp-3J for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 09:11:55 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f7Ky6-0006gv-Tt; Sat, 14 Apr 2018 15:11:53 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f7Ky1-0004ha-9d; Sat, 14 Apr 2018 15:11:45 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> <83r2ni470z.fsf@gnu.org> Date: Sat, 14 Apr 2018 15:11:44 +0200 In-Reply-To: <83r2ni470z.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Apr 2018 09:49:16 +0300") Message-ID: <87lgdqj5kf.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27178 Cc: 27178@debbugs.gnu.org, eefacm@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Why not update the docs, as Noam suggested last June? Well, it would be nice if we could just get this to work, and it just occurred to me that supporting this option shouldn't be that difficult: We can just pre-treat the XML before parsing it. That is, if discard-comments is mentioned, we can just go through the buffer and delete all the comments before we point libxml towards it. On the other hand, we could deprecate that option (since it's rather nonsensical the way it is now), and just provide a Lisp convenience function to delete the comments if you don't want comments? I think that sounds cleaner and much easier to implement. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 09:29:12 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 13:29:13 +0000 Received: from localhost ([127.0.0.1]:51415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7LEr-0000qB-8r for submit@debbugs.gnu.org; Sat, 14 Apr 2018 09:29:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7LEm-0000pZ-9Y for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 09:29:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7LEd-0003ks-29 for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 09:28:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7LEY-0003hj-BS; Sat, 14 Apr 2018 09:28:50 -0400 Received: from [176.228.60.248] (port=1470 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f7LEX-0006ix-P3; Sat, 14 Apr 2018 09:28:50 -0400 Date: Sat, 14 Apr 2018 16:28:50 +0300 Message-Id: <83k1t9533h.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87lgdqj5kf.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Sat, 14 Apr 2018 15:11:44 +0200) Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> <83r2ni470z.fsf@gnu.org> <87lgdqj5kf.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27178 Cc: 27178@debbugs.gnu.org, eefacm@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lars Ingebrigtsen > Cc: npostavs@users.sourceforge.net, 27178@debbugs.gnu.org, eefacm@gmail.com > Date: Sat, 14 Apr 2018 15:11:44 +0200 > > On the other hand, we could deprecate that option (since it's rather > nonsensical the way it is now), and just provide a Lisp convenience > function to delete the comments if you don't want comments? I think > that sounds cleaner and much easier to implement. That is also fine with me, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 09:54:17 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 13:54:17 +0000 Received: from localhost ([127.0.0.1]:51453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7LdB-0003R7-I2 for submit@debbugs.gnu.org; Sat, 14 Apr 2018 09:54:17 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:53578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7LdA-0003Qz-0E for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 09:54:16 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f7Ld5-0005pl-Rx; Sat, 14 Apr 2018 15:54:14 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f7Ld0-0004zs-7N; Sat, 14 Apr 2018 15:54:06 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> <83r2ni470z.fsf@gnu.org> <87lgdqj5kf.fsf@mouse.gnus.org> <83k1t9533h.fsf@gnu.org> Date: Sat, 14 Apr 2018 15:54:05 +0200 In-Reply-To: <83k1t9533h.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Apr 2018 16:28:50 +0300") Message-ID: <87r2nhj3lu.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27178 Cc: 27178@debbugs.gnu.org, eefacm@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> On the other hand, we could deprecate that option (since it's rather >> nonsensical the way it is now), and just provide a Lisp convenience >> function to delete the comments if you don't want comments? I think >> that sounds cleaner and much easier to implement. > > That is also fine with me, thanks. Hm... do we have a mechanism to mark parameters as obsolete, or should I just mention it in the doc string? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 11:00:48 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 15:00:48 +0000 Received: from localhost ([127.0.0.1]:52482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7MfU-0007As-32 for submit@debbugs.gnu.org; Sat, 14 Apr 2018 11:00:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7MfP-0007Ac-3l for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 11:00:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7MfF-0004wg-SX for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 11:00:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7Mf9-0004tN-KB; Sat, 14 Apr 2018 11:00:23 -0400 Received: from [176.228.60.248] (port=1578 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f7Mf9-0008Km-0S; Sat, 14 Apr 2018 11:00:23 -0400 Date: Sat, 14 Apr 2018 18:00:23 +0300 Message-Id: <83in8t4yuw.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87r2nhj3lu.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Sat, 14 Apr 2018 15:54:05 +0200) Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> <83r2ni470z.fsf@gnu.org> <87lgdqj5kf.fsf@mouse.gnus.org> <83k1t9533h.fsf@gnu.org> <87r2nhj3lu.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27178 Cc: 27178@debbugs.gnu.org, eefacm@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lars Ingebrigtsen > Cc: npostavs@users.sourceforge.net, 27178@debbugs.gnu.org, eefacm@gmail.com > Date: Sat, 14 Apr 2018 15:54:05 +0200 > > Eli Zaretskii writes: > > >> On the other hand, we could deprecate that option (since it's rather > >> nonsensical the way it is now), and just provide a Lisp convenience > >> function to delete the comments if you don't want comments? I think > >> that sounds cleaner and much easier to implement. > > > > That is also fine with me, thanks. > > Hm... do we have a mechanism to mark parameters as obsolete I don't believe so, but maybe others will have me corrected. > or should I just mention it in the doc string? If that's the only way, yes, please. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 11:15:06 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 15:15:06 +0000 Received: from localhost ([127.0.0.1]:52494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7MtN-0007Ui-NG for submit@debbugs.gnu.org; Sat, 14 Apr 2018 11:15:05 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:54147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7MtI-0007Tm-AG for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 11:15:02 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f7MtE-0000Cm-GG; Sat, 14 Apr 2018 17:14:58 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f7Mt8-0005JR-Hs; Sat, 14 Apr 2018 17:14:50 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> <83r2ni470z.fsf@gnu.org> <87lgdqj5kf.fsf@mouse.gnus.org> <83k1t9533h.fsf@gnu.org> <87r2nhj3lu.fsf@mouse.gnus.org> <83in8t4yuw.fsf@gnu.org> Date: Sat, 14 Apr 2018 17:14:50 +0200 In-Reply-To: <83in8t4yuw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Apr 2018 18:00:23 +0300") Message-ID: <877ep9izv9.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27178 Cc: 27178@debbugs.gnu.org, eefacm@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Hm... do we have a mechanism to mark parameters as obsolete > > I don't believe so, but maybe others will have me corrected. > >> or should I just mention it in the doc string? > > If that's the only way, yes, please. I've now done this. If it should turn out that there's a way to mark parameters as obsolete, I can change that later. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 11:15:05 2018 Received: (at control) by debbugs.gnu.org; 14 Apr 2018 15:15:05 +0000 Received: from localhost ([127.0.0.1]:52492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7MtL-0007Uc-Sg for submit@debbugs.gnu.org; Sat, 14 Apr 2018 11:15:05 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:54151) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7MtI-0007To-AF for control@debbugs.gnu.org; Sat, 14 Apr 2018 11:15:02 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f7MtF-0000I6-Pm for control@debbugs.gnu.org; Sat, 14 Apr 2018 17:14:59 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f7MtA-0005JU-6U for control@debbugs.gnu.org; Sat, 14 Apr 2018 17:14:52 +0200 To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #27178 Message-Id: Date: Sat, 14 Apr 2018 17:14:52 +0200 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 27178 fixed close 27178 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 11:18:04 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 15:18:04 +0000 Received: from localhost ([127.0.0.1]:52501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7MwG-0007Ze-78 for submit@debbugs.gnu.org; Sat, 14 Apr 2018 11:18:04 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:44032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7MwE-0007ZA-F8 for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 11:18:02 -0400 Received: by mail-io0-f169.google.com with SMTP id d7so13365368ioc.11 for <27178@debbugs.gnu.org>; Sat, 14 Apr 2018 08:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=D8bPR5gdl6wWSPOb5K7Zo6mEtC8OEFbBqyBC8Vc7Uhg=; b=VOTpNv5rXEGg8fa8+VMPc3wpGKZAmdr5DGt5WNaGp9DSaK6CUMwcAoR4KdTWl5aq4U J9Ywe3c3t9m6FVllewDipFYBhFF/TSXcN+y5gkSwqsQ+R3zyZtE9q+aeDonjXZjjm/iA myh7mE41DrMdyr7P9vCptFXMTKf3CRidkRcIDlU28bTDNEz9HraL+Tql/mig5p03YP5q BNfUEFwDlDxfePq1Bo5OSr5ilVrdnLMEOc7U4S8iXKTFqGK42LyaqI44g6M9qGplHR8s SJw5BcK7Wn3zPeWuJAqDzibRYQonaou8Y7jvlHxfXxuKYRY29SNNJeVZqBDZZ/95xbE+ B6xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=D8bPR5gdl6wWSPOb5K7Zo6mEtC8OEFbBqyBC8Vc7Uhg=; b=jGoYCn39hVsgQKvZZARxwMBvuxhuDekQEkAbSHpLFp5BUGL11k3fUG/ka8hcngznBd t9ie5ql2p86nfTy/RQR3cd7bkX1H0vmwBH7NYA2Su7oLm5BUNXQAm+XcFaRIKOC/gFHn xwPkHar4EBNeUIAfdt8SmMHbZGy5Ct7NOIVIs81PDtIVBrRhPMfMDPl73QSkFTZLLiyT e7xtcOkCZQGQc37UfYZn4d5KK7uzg0VQGl1LMU5s+ztDC4kxXIAxWcPqiFY0mSRj/yoq ZbrvaeVkMtg8hA913Sn8F4kzNA4zFfsbcDoIGAzyQB0B4f6hURa8rhLSAp8SeMNujVd8 7WOw== X-Gm-Message-State: ALQs6tAbjGRGvHf/oc+FMYc/vbu+nF/VC2d9v86ferZ1NwmLwK8B1yVt ThkKNLg++gK/KweWBjyGiK4= X-Google-Smtp-Source: AIpwx48stmKgbveIszOI80F1R6X0/Szdfm3npIqCtH0UyMnWBF5mwZbnTum/ePlDEPKDCkovosRYWg== X-Received: by 10.107.46.30 with SMTP id i30mr17839129ioo.288.1523719077115; Sat, 14 Apr 2018 08:17:57 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v194-v6sm2345178itb.17.2018.04.14.08.17.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Apr 2018 08:17:56 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> <83r2ni470z.fsf@gnu.org> <87lgdqj5kf.fsf@mouse.gnus.org> <83k1t9533h.fsf@gnu.org> <87r2nhj3lu.fsf@mouse.gnus.org> <83in8t4yuw.fsf@gnu.org> Date: Sat, 14 Apr 2018 11:17:55 -0400 In-Reply-To: <83in8t4yuw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Apr 2018 18:00:23 +0300") Message-ID: <87in8tkeak.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27178 Cc: Lars Ingebrigtsen , 27178@debbugs.gnu.org, eefacm@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Hm... do we have a mechanism to mark parameters as obsolete > > I don't believe so, but maybe others will have me corrected. I think we have advertised-calling-convention for this: `(advertised-calling-convention SIGNATURE WHEN)' This acts like a call to `set-advertised-calling-convention' (*note Obsolete Functions::); SIGNATURE specifies the correct argument list for calling the function or macro, and WHEN should be a string indicating when the old argument list was first made obsolete. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 11:22:06 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 15:22:07 +0000 Received: from localhost ([127.0.0.1]:52506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7N0A-0007fa-PI for submit@debbugs.gnu.org; Sat, 14 Apr 2018 11:22:06 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:54274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7N08-0007fS-Uo for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 11:22:05 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f7N06-0002eP-0K; Sat, 14 Apr 2018 17:22:04 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f7N00-0005Lp-4C; Sat, 14 Apr 2018 17:21:56 +0200 From: Lars Ingebrigtsen To: Noam Postavsky Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> <83r2ni470z.fsf@gnu.org> <87lgdqj5kf.fsf@mouse.gnus.org> <83k1t9533h.fsf@gnu.org> <87r2nhj3lu.fsf@mouse.gnus.org> <83in8t4yuw.fsf@gnu.org> <87in8tkeak.fsf@gmail.com> Date: Sat, 14 Apr 2018 17:21:55 +0200 In-Reply-To: <87in8tkeak.fsf@gmail.com> (Noam Postavsky's message of "Sat, 14 Apr 2018 11:17:55 -0400") Message-ID: <8736zxizjg.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27178 Cc: Eli Zaretskii , 27178@debbugs.gnu.org, eefacm@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > I think we have advertised-calling-convention for this: > > `(advertised-calling-convention SIGNATURE WHEN)' > This acts like a call to `set-advertised-calling-convention' > (*note Obsolete Functions::); SIGNATURE specifies the correct > argument list for calling the function or macro, and WHEN > should be a string indicating when the old argument list was > first made obsolete. Ah, thanks. That's as a declaration in the defun? How would we do this for a built-in C function, then? Hm... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 11:35:19 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 15:35:19 +0000 Received: from localhost ([127.0.0.1]:52513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7NCv-0001Ua-V9 for submit@debbugs.gnu.org; Sat, 14 Apr 2018 11:35:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7NCr-0001UL-9R for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 11:35:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7NCk-00017m-Aa for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 11:35:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7NCf-00015T-L7; Sat, 14 Apr 2018 11:35:01 -0400 Received: from [176.228.60.248] (port=1641 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f7NCe-0000Yj-UH; Sat, 14 Apr 2018 11:35:01 -0400 Date: Sat, 14 Apr 2018 18:35:01 +0300 Message-Id: <83h8od4x96.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <8736zxizjg.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Sat, 14 Apr 2018 17:21:55 +0200) Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> <83r2ni470z.fsf@gnu.org> <87lgdqj5kf.fsf@mouse.gnus.org> <83k1t9533h.fsf@gnu.org> <87r2nhj3lu.fsf@mouse.gnus.org> <83in8t4yuw.fsf@gnu.org> <87in8tkeak.fsf@gmail.com> <8736zxizjg.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27178 Cc: 27178@debbugs.gnu.org, npostavs@gmail.com, eefacm@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lars Ingebrigtsen > Cc: Eli Zaretskii , 27178@debbugs.gnu.org, eefacm@gmail.com > Date: Sat, 14 Apr 2018 17:21:55 +0200 > > Noam Postavsky writes: > > > I think we have advertised-calling-convention for this: > > > > `(advertised-calling-convention SIGNATURE WHEN)' > > This acts like a call to `set-advertised-calling-convention' > > (*note Obsolete Functions::); SIGNATURE specifies the correct > > argument list for calling the function or macro, and WHEN > > should be a string indicating when the old argument list was > > first made obsolete. > > Ah, thanks. > > That's as a declaration in the defun? How would we do this for a > built-in C function, then? Hm... Doesn't set-advertised-calling-convention work on primitives? There's also the "usage:" thingie. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 11:36:06 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 15:36:06 +0000 Received: from localhost ([127.0.0.1]:52517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7NDi-0001W2-IL for submit@debbugs.gnu.org; Sat, 14 Apr 2018 11:36:06 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:35463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7NDg-0001VT-ER for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 11:36:05 -0400 Received: by mail-io0-f175.google.com with SMTP id k8so2590446ioc.2 for <27178@debbugs.gnu.org>; Sat, 14 Apr 2018 08:36:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/WG8kbmTvRie95mzDZt/q5gAs2BykMX2+tnQBWkvjfY=; b=N3W1nXVSyurp6KWjHd7bXsFqJWhiUCvoAK0Q2VM8GglwgPK+95Dnie23BAlsv+bbWR wYAnjndX6YTUNdL6N1H53ifG3mlVV3V1GyNxe2+MAT+Nk7cQC07Yihf4xytXIDmiyLbh V6z63ZATn0/mvLL2W8gEb4txz0G+u6BDiNoUP4GwUN25STqrygaed0vLsZJS8oaUeiAv 64xWYm1v+497c1rQuDUVI42mWNfHb6/ZIzuIPwGGoxgVrVFCaajx2444OXnmJkVdX6s5 yz6LO7DjCPdy0YJejyDw9GZYZLxHuyUUgLtf46iMLVmc7HIQ0yzK9A9eCHzFdinMgHA2 SIUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/WG8kbmTvRie95mzDZt/q5gAs2BykMX2+tnQBWkvjfY=; b=fOOCidO5OIG1hjkJocyarnt4oa/ZmfkVkdEHYLSXi66wQyX8OMfwTEmVBRn/rAjwmK 1wi1JH8tjy+eRXm7dIT94tfoRENnO+3N2yAEX2fXotijgx0YeOtqiCa6u6WZYJfTtaCs LoEonvH5Sl6TetUvap22APKSesABxXiB6/XfOtOmK0Ff2SHCKRcHRkWE/WUifSZ2HX0f +8+pIyKIXYfuhJPSluHDQFLk83kNtc2oHkGJJvAVJP0DDC5TbIcRtw8ZHxGXxC127hzu Kd+3BLI8RceEJbWYR2QYr3kZNtIi56O0bIcxBAgg3JBaqW3TxwPJbd9rrEnDhCLRo330 8e1Q== X-Gm-Message-State: ALQs6tAV4JqGZa8mal8xLFRf3crHTvyYMJQvFxJfn0eZNiHGAo7yohm+ GBqsZvHTZom2eTzeQGQEhfg= X-Google-Smtp-Source: AIpwx4/jms/0iiH9face/HyRWF0aRPeGTLD9BVY8wRY0v6sUFN1PtuVPY1rr1magphQCLnWGXvc7Ug== X-Received: by 10.107.10.203 with SMTP id 72mr1391597iok.24.1523720158978; Sat, 14 Apr 2018 08:35:58 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id t4-v6sm1485307ita.3.2018.04.14.08.35.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Apr 2018 08:35:58 -0700 (PDT) From: Noam Postavsky To: Lars Ingebrigtsen Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> <83r2ni470z.fsf@gnu.org> <87lgdqj5kf.fsf@mouse.gnus.org> <83k1t9533h.fsf@gnu.org> <87r2nhj3lu.fsf@mouse.gnus.org> <83in8t4yuw.fsf@gnu.org> <87in8tkeak.fsf@gmail.com> <8736zxizjg.fsf@mouse.gnus.org> Date: Sat, 14 Apr 2018 11:35:57 -0400 In-Reply-To: <8736zxizjg.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sat, 14 Apr 2018 17:21:55 +0200") Message-ID: <87fu3xkdgi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27178 Cc: Eli Zaretskii , 27178@debbugs.gnu.org, eefacm@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > That's as a declaration in the defun? How would we do this for a > built-in C function, then? Hm... Oh, right, forgot the context. Should have put `(elisp) Obsolete Functions': In addition, you can mark a particular calling convention for a function as obsolete: -- Function: set-advertised-calling-convention function signature when This function specifies the argument list SIGNATURE as the correct way to call FUNCTION. (The declare form would just expand to a call to this.) From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 11:43:24 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 15:43:24 +0000 Received: from localhost ([127.0.0.1]:52525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7NKm-0001fv-Aw for submit@debbugs.gnu.org; Sat, 14 Apr 2018 11:43:24 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:54436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7NKk-0001fn-Rp for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 11:43:23 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f7NKh-00027P-N0; Sat, 14 Apr 2018 17:43:21 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f7NKb-0005Vl-V7; Sat, 14 Apr 2018 17:43:13 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> <83r2ni470z.fsf@gnu.org> <87lgdqj5kf.fsf@mouse.gnus.org> <83k1t9533h.fsf@gnu.org> <87r2nhj3lu.fsf@mouse.gnus.org> <83in8t4yuw.fsf@gnu.org> <87in8tkeak.fsf@gmail.com> <8736zxizjg.fsf@mouse.gnus.org> <83h8od4x96.fsf@gnu.org> Date: Sat, 14 Apr 2018 17:43:13 +0200 In-Reply-To: <83h8od4x96.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Apr 2018 18:35:01 +0300") Message-ID: <87r2nhhjzi.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27178 Cc: 27178@debbugs.gnu.org, npostavs@gmail.com, eefacm@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Doesn't set-advertised-calling-convention work on primitives? Thanks. I guess those should go in subr.el? Hm... Should I then remove the mention of DISCARD-COMMENTS from the doc strings? I mean, the functions still accept those... Perhaps the doc string should stay the same until the argument is really removed? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 12:25:08 2018 Received: (at 27178) by debbugs.gnu.org; 14 Apr 2018 16:25:08 +0000 Received: from localhost ([127.0.0.1]:52532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7Nz5-0002bs-MO for submit@debbugs.gnu.org; Sat, 14 Apr 2018 12:25:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7Nz1-0002bJ-2d for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 12:25:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7Nyr-0000FW-Tx for 27178@debbugs.gnu.org; Sat, 14 Apr 2018 12:24:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7Nyn-0000Da-CN; Sat, 14 Apr 2018 12:24:45 -0400 Received: from [176.228.60.248] (port=1731 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f7Nym-0005Al-Qc; Sat, 14 Apr 2018 12:24:45 -0400 Date: Sat, 14 Apr 2018 19:24:44 +0300 Message-Id: <83fu3x4uyb.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87r2nhhjzi.fsf@mouse.gnus.org> (message from Lars Ingebrigtsen on Sat, 14 Apr 2018 17:43:13 +0200) Subject: Re: bug#27178: 26.0.50; libxml-parse-*-region functions ignore discard-comments argument References: <877f0jx2oh.fsf@users.sourceforge.net> <87bmemn2em.fsf@mouse.gnus.org> <83r2ni470z.fsf@gnu.org> <87lgdqj5kf.fsf@mouse.gnus.org> <83k1t9533h.fsf@gnu.org> <87r2nhj3lu.fsf@mouse.gnus.org> <83in8t4yuw.fsf@gnu.org> <87in8tkeak.fsf@gmail.com> <8736zxizjg.fsf@mouse.gnus.org> <83h8od4x96.fsf@gnu.org> <87r2nhhjzi.fsf@mouse.gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27178 Cc: 27178@debbugs.gnu.org, npostavs@gmail.com, eefacm@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Lars Ingebrigtsen > Cc: npostavs@gmail.com, 27178@debbugs.gnu.org, eefacm@gmail.com > Date: Sat, 14 Apr 2018 17:43:13 +0200 > > Eli Zaretskii writes: > > > Doesn't set-advertised-calling-convention work on primitives? > > Thanks. I guess those should go in subr.el? Yes. Or simple.el. > Hm... Should I then remove the mention of DISCARD-COMMENTS from the doc > strings? Yes, because "C-h f" will not show the extra argument. From unknown Sat Sep 06 21:08:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 13 May 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator