GNU bug report logs - #27176
[PATCH] gnu: Add python-xsge.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27176 in the body.
You can then email your comments to 27176 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: [PATCH] gnu: Add python-xsge.
Date: Wed, 31 May 2017 17:57:44 -0400

* gnu/packages/game-development.scm (python-xsge, python2-xsge): New
variables.
---
 gnu/packages/game-development.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index b7bcdee94..80f56b245 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -249,6 +249,43 @@ levels.")
        `(("python2-pathlib" ,python2-pathlib)
          ,@(package-propagated-inputs python2-tmx))))))
 
+(define-public python-xsge
+  (package
+    (name "python-xsge")
+    (version "2017.04.10")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://savannah/xsge/xsge-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "04il5yx0py6kchxxw6ydbbx0wpiyjf9dgkwsdynirpkczlnid3am"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (zero?
+              (system* "python" "setup.py" "install"
+                       (string-append "--prefix=" (assoc-ref outputs "out"))
+                       "--root=/")))))
+       #:tests? #f))
+    (propagated-inputs
+     `(("python-sge-pygame" ,python-sge-pygame)
+       ("python-pygame" ,python-pygame)
+       ("python-six" ,python-six)
+       ("python-tmx" ,python-tmx)))
+    (home-page "http://xsge.nongnu.org")
+    (synopsis "Extensions for the SGE Game Engine")
+    (description
+     "xSGE is a collection of modules that make doing certain tasks with the SGE
+Game Engine easier.")
+    (license license:gpl3+)))
+
+(define-public python2-xsge
+  (package-with-python2 python-xsge))
+
 (define-public tiled
   (package
     (name "tiled")
-- 
2.13.0

Message #8 received at 27176 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 27176 <at> debbugs.gnu.org
Subject: Re: bug#27176: [PATCH] gnu: Add python-xsge.
Date: Thu, 1 Jun 2017 00:41:38 +0200

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (zero?
> +              (system* "python" "setup.py" "install"
> +                       (string-append "--prefix=" (assoc-ref outputs "out"))
> +                       "--root=/")))))

What's the difference to what the python-build-system does?

> +       #:tests? #f))

Why?

> +    (description
> +     "xSGE is a collection of modules that make doing certain tasks with the SGE
> +Game Engine easier.")

Like what? :)

Otherwise LGTM!

Message #13 received at 27176-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 27176-done <at> debbugs.gnu.org
Subject: Re: bug#27176: [PATCH] gnu: Add python-xsge.
Date: Wed, 31 May 2017 20:50:33 -0400

[Message part 1 (text/plain, inline)]

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

>> +         (replace 'install
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (zero?
>> +              (system* "python" "setup.py" "install"
>> +                       (string-append "--prefix=" (assoc-ref outputs "out"))
>> +                       "--root=/")))))
>
> What's the difference to what the python-build-system does?

The python-build-system also uses "--single-version-externally-managed"
which is unsupported by xSGE's setup.py script for some reason. I've
added a comment stating this.

>
>> +       #:tests? #f))
>
> Why?
>

I forgot the "no check target" comment, but I've since added it.

>> +    (description
>> +     "xSGE is a collection of modules that make doing certain tasks with the SGE
>> +Game Engine easier.")
>
> Like what? :)

I added details from the list on the xSGE about page.

>
> Otherwise LGTM!

Pushed to master as e99039b5da6dfbc49a2f8cf0fb523a8049fe5ef8!
Thanks for the review.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.