GNU bug report logs - #27161
COLOSSAL CAVE!

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27161 in the body.
You can then email your comments to 27161 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> pragmatique.xyz>
To: guix-patches <at> gnu.org
Subject: COLOSSAL CAVE!
Date: Wed, 31 May 2017 13:20:11 +0000

[Message part 1 (text/plain, inline)]

Have a piece of interactive fiction history:
This adds 'open-adventure', a port of Collosal Cave
just recently released under BSD-2 license.
-- 
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588

[0001-gnu-Add-open-adventure.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> pragmatique.xyz>
To: guix-patches <at> gnu.org
Subject: Re: bug#27161: COLOSSAL CAVE!
Date: Wed, 31 May 2017 18:59:05 +0000

ng0 transcribed 5.6K bytes:
> Have a piece of interactive fiction history:
> This adds 'open-adventure', a port of Collosal Cave
> just recently released under BSD-2 license.
> -- 
> ng0
> OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588

> From 603186e67720056adc778bc8a623d6f39e758326 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> no-reply.pragmatique.xyz>
> Date: Tue, 30 May 2017 13:56:26 +0000
> Subject: [PATCH] gnu: Add open-adventure.

I have just received feedback on the bug report, the parallel building
bug might be solved. I'm sending an updated patch soon.

> * gnu/packages/games.scm (open-adventure): New variable.
> ---
>  gnu/packages/games.scm | 62 +++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 61 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 60d885500..40c2a335a 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -17,7 +17,7 @@
>  ;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli <at> gmail.com>
>  ;;; Copyright © 2016, 2017 Rodger Fox <thylakoid <at> openmailbox.org>
>  ;;; Copyright © 2016 Manolis Fragkiskos Ragkousis <manolis837 <at> gmail.com>
> -;;; Copyright © 2016, 2017 ng0 <contact.ng0 <at> cryptolab.net>
> +;;; Copyright © 2016, 2017 ng0 <ng0 <at> no-reply.pragmatique.xyz>
>  ;;; Copyright © 2016 Albin Söderqvist <albin <at> fripost.org>
>  ;;; Copyright © 2016, 2017 Kei Kebreau <kei <at> openmailbox.org>
>  ;;; Copyright © 2016 Alex Griffin <a <at> ajgrf.com>
> @@ -66,6 +66,7 @@
>    #:use-module (gnu packages avahi)
>    #:use-module (gnu packages boost)
>    #:use-module (gnu packages documentation)
> +  #:use-module (gnu packages docbook)
>    #:use-module (gnu packages fltk)
>    #:use-module (gnu packages fribidi)
>    #:use-module (gnu packages game-development)
> @@ -4272,3 +4273,62 @@ at their peak of economic growth and military prowess.
>                     license:lgpl3
>                     license:mpl2.0
>                     license:zlib))))
> +
> +(define-public open-adventure
> +  (let* ((commit "edc11a1f04663df13baa8178af610f5c91878d8f")
> +         (revision "1"))
> +    (package
> +      (name "open-adventure")
> +      (version (string-append "2.5-" revision "." (string-take commit 7)))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://gitlab.com/esr/open-adventure")
> +               (commit commit)))
> +         (sha256
> +          (base32
> +           "1grh5cak2vg3pglmbdax78h03m3d6zczddp6k29acfijvwdcawjf"))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(;; https://gitlab.com/esr/open-adventure/issues/4
> +         #:parallel-build? #f ;Parallel builds fail.
> +         #:make-flags (list "CC=gcc")
> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure)
> +           (add-before 'build 'use-echo
> +             (lambda _
> +               (substitute* "tests/Makefile"
> +                 (("/bin/echo")
> +                  (which "echo")))))
> +           (add-after 'build 'build-manpage
> +             (lambda _
> +               (zero? (system* "a2x" "--doctype" "manpage" "--format"
> +                               "manpage" "advent.txt"))))
> +           (replace 'install
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               ;; There is no 'make install'.
> +               (let* ((out (assoc-ref outputs "out"))
> +                      (bin (string-append out "/bin"))
> +                      (man (string-append out "/share/man/man6")))
> +                 (install-file "advent" bin)
> +                 (install-file "advent.6" man))
> +               #t)))))
> +      (native-inputs
> +       `(("asciidoc" ,asciidoc)
> +         ("docbook-xsl" ,docbook-xsl)))
> +      (synopsis "Colossal Cave Adventure")
> +      (description
> +       "Forward-port of the Crowther/Woods Adventure 2.5 from 1995,
> +last version in the main line of Colossal Cave Adventure development
> +written by the original authors.  The authors have given permission
> +and encouragement for this release.
> +This project is called \"Open Adventure\" because it's not at all clear
> +how to number Adventure past 2.5 without misleading or causing
> +collisions or both.  See the history file for discussion.  The
> +original 6-character name on the PDP-10 has been reverted to for the
> +executable in order to avoid a collision with the BSD games port of
> +the ancestral 1977 version.")
> +      (home-page "https://gitlab.com/esr/open-adventure")
> +      (license license:bsd-2))))
> -- 
> 2.13.0
> 




-- 
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588

Message #11 received at 27161 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> pragmatique.xyz>
To: 27161 <at> debbugs.gnu.org
Subject: Re: bug#27161: COLOSSAL CAVE!
Date: Thu, 1 Jun 2017 10:54:26 +0000

[Message part 1 (text/plain, inline)]

ng0 transcribed 4.6K bytes:
> ng0 transcribed 5.6K bytes:
> > Have a piece of interactive fiction history:
> > This adds 'open-adventure', a port of Collosal Cave
> > just recently released under BSD-2 license.

> I have just received feedback on the bug report, the parallel building
> bug might be solved. I'm sending an updated patch soon.

This commit is more recent and includes the fix for bug #4.
-- 
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588

[0001-gnu-Add-open-adventure.patch (text/plain, attachment)]

Message #16 received at 27161-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: ng0 <ng0 <at> pragmatique.xyz>
Cc: 27161-done <at> debbugs.gnu.org
Subject: Re: bug#27161: COLOSSAL CAVE!
Date: Thu, 01 Jun 2017 23:30:08 +0200

Hi,

ng0 <ng0 <at> pragmatique.xyz> writes:

>> > Have a piece of interactive fiction history:
>> > This adds 'open-adventure', a port of Collosal Cave
>> > just recently released under BSD-2 license.
>
>> I have just received feedback on the bug report, the parallel building
>> bug might be solved. I'm sending an updated patch soon.
>
> This commit is more recent and includes the fix for bug #4.

This didn’t build for me:

--8<---------------cut here---------------start------------->8---
starting phase `build'
gcc     compile.c   -o compile
./compile
./compile
gcc -std=c99 -O  -c database.c
gcc -std=c99 -O  -c database.c
database.c:1465:3: error: expected expression at end of input
   18046, 17007, 17038, 17044, 19010, 19030, 19045, 150022029, 150022031, 150022034, 
   ^
make: *** [Makefile:38: database.h] Error 1
make: *** Waiting for unfinished jobs....
phase `build' failed after 0.9 seconds
--8<---------------cut here---------------end--------------->8---

I had to disable parallel builds.  I made a couple of changes and pushed
it with commit dec63df4f.

Thanks!

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #19 received at 27161-done <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> pragmatique.xyz>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 27161-done <at> debbugs.gnu.org, ng0 <ng0 <at> pragmatique.xyz>
Subject: Re: bug#27161: COLOSSAL CAVE!
Date: Thu, 1 Jun 2017 21:41:32 +0000

[Message part 1 (text/plain, inline)]

Ricardo Wurmus transcribed 1.1K bytes:
> 
> Hi,
> 
> ng0 <ng0 <at> pragmatique.xyz> writes:
> 
> >> > Have a piece of interactive fiction history:
> >> > This adds 'open-adventure', a port of Collosal Cave
> >> > just recently released under BSD-2 license.
> >
> >> I have just received feedback on the bug report, the parallel building
> >> bug might be solved. I'm sending an updated patch soon.
> >
> > This commit is more recent and includes the fix for bug #4.
> 
> This didn’t build for me:
> 
> --8<---------------cut here---------------start------------->8---
> starting phase `build'
> gcc     compile.c   -o compile
> ./compile
> ./compile
> gcc -std=c99 -O  -c database.c
> gcc -std=c99 -O  -c database.c
> database.c:1465:3: error: expected expression at end of input
>    18046, 17007, 17038, 17044, 19010, 19030, 19045, 150022029, 150022031, 150022034, 
>    ^
> make: *** [Makefile:38: database.h] Error 1
> make: *** Waiting for unfinished jobs....
> phase `build' failed after 0.9 seconds
> --8<---------------cut here---------------end--------------->8---
> 
> I had to disable parallel builds.  I made a couple of changes and pushed
> it with commit dec63df4f.

Strange... For me it worked. So maybe bug number 4 upstream isn't fixed yet.
Builds here happen with 8+ processes in parallel I think
and with 6 or more the bug was visible.

> Thanks!
> 
> -- 
> Ricardo
> 
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
> 
> 

-- 
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.