GNU bug report logs - #27158
25.2; Eliminating old usage of completing-read from built-in files

Previous Next

Full log

Message #68 received at 27158 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Ryan <rct <at> thompsonclan.org>
Cc: 27158 <at> debbugs.gnu.org
Subject: Re: bug#27158: 25.2; Eliminating old usage of completing-read from
 built-in files
Date: Mon, 24 Aug 2020 16:58:33 +0200

Ryan <rct <at> thompsonclan.org> writes:

> completing-read-default still supports a behavior that is, as far as I
> know, a legacy feature that is kept only for backward compatibility with
> code that was written before the default argument was added: if the
> input is empty and the user presses RET, it will return the empty
> string, even if require-match is non-nil and the empty string is not in
> the collection.

[...]

> While this behavior can
> probably not be changed without breaking backward compatibility, we can
> at least eliminate every use of the feature in the elisp files included
> with Emacs. The patch below does exactly that for all the cases that I
> am aware of.

[...]

> -    (completing-read "Keyword, C-h: " v1 nil t))
> +    (completing-read "Keyword, C-h: " v1 nil t nil nil ""))

If we're not going to change the behaviour, I don't really see any
advantage to changing the in-tree callers, so I'm closing this bug
report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.