GNU bug report logs - #27158
25.2; Eliminating old usage of completing-read from built-in files

Previous Next

Package: emacs;

Reported by: Ryan <rct <at> thompsonclan.org>

Date: Wed, 31 May 2017 04:43:02 UTC

Severity: minor

Tags: wontfix

Found in version 25.2

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #17 received at 27158 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>, Ryan <rct <at> thompsonclan.org>,
 27158 <at> debbugs.gnu.org
Subject: RE: bug#27158: 25.2; Eliminating old usage of completing-read from
 built-in files
Date: Wed, 31 May 2017 07:51:51 -0700 (PDT)
> > Would you make a default arg be mandatory instead of optional?
> > Is that it?  If not, what default default would you propose?
> 
> It's not necessary.

What's not necessary?  The argument is either optional or mandatory.
If optional, what default behavior do you want?

Or are you saying that the default arg should just be removed
from `completing-read', because "it's not necessary"?  Not
necessary for whom?  Why isn't it ever a useful thing to have?

Just because some callers might not need it does not mean that
it is not useful for other callers.

> > What should be returned if no explicit default is provided and
> > the user hits RET with no input?
> 
> Prohibit them from finishing completion, except through entering
> a valid value, or pressing C-g.

(while <no valid value> <get input with completion>)

Is that hard?

> > In any case, nothing stops someone from defining their own
> > `my-completing-read', which does not have this feature, er,
> > quirk.  I don't see the problem.
> 
> That doesn't help if we want to augment completing-read-function
> and all packages using it.

What happens when you set `completing-read-function' to your
`my-completing-read'?




This bug report was last modified 4 years and 331 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.