From unknown Tue Aug 19 02:53:09 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27133 <27133@debbugs.gnu.org> To: bug#27133 <27133@debbugs.gnu.org> Subject: Status: 26.0.50; Todo-mode multiline item highlighting is broken Reply-To: bug#27133 <27133@debbugs.gnu.org> Date: Tue, 19 Aug 2025 09:53:09 +0000 retitle 27133 26.0.50; Todo-mode multiline item highlighting is broken reassign 27133 emacs submitter 27133 Stephen Berman severity 27133 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon May 29 14:20:11 2017 Received: (at submit) by debbugs.gnu.org; 29 May 2017 18:20:11 +0000 Received: from localhost ([127.0.0.1]:43666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFPH1-0001z1-Au for submit@debbugs.gnu.org; Mon, 29 May 2017 14:20:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFPH0-0001yq-6j for submit@debbugs.gnu.org; Mon, 29 May 2017 14:20:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFPGu-0005DW-1x for submit@debbugs.gnu.org; Mon, 29 May 2017 14:20:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58415) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dFPGt-0005DS-Un for submit@debbugs.gnu.org; Mon, 29 May 2017 14:20:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFPGs-0001CZ-Ub for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 14:20:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFPGq-0005Ct-8U for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 14:20:02 -0400 Received: from mout.gmx.net ([212.227.17.21]:49506) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFPGp-0005Cl-TB for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 14:20:00 -0400 Received: from rosalinde ([83.135.17.20]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M5HZD-1e8DY11XI7-00zYZu for ; Mon, 29 May 2017 20:19:58 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Todo-mode multiline item highlighting is broken Date: Mon, 29 May 2017 20:19:57 +0200 Message-ID: <87poerplte.fsf@rosalinde> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:74/eZE2cnqz+3ufXXuA7M8e7BrYVkdn78FG1xB5nUqvIqC36OFp JbQbUrQTKoUBmqvPPbzR95lom2JT5kTdAQEFRzzt+s74lhof9jXGguK4VEb9WpfBUbwfxWU 0dDsnIHA3B7nqiByUQo+nnbFWs9ZJBP5JeQ6R+G4I5BdgAJovHCqs7Bht8tXkZo82X9G3+h JhrWaQquxz1qUfJe12IDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:sF2+9TEwAVo=:t/at5jDdKm3SsIqhENKsMz 9xZNB1a+fuHNGhppZnQuHRKFzUXNpJbJsDgOJmPhfT1MyrRZoqQMrRw+EA1o6Vnp4RWr60ROH AV7WfEny9UBC3Yj5CuH0uTvaYhY5nBWeRZnu0dB2Y9YTY/9RrE2CRaToEbFeWqcX8u+eREjKq +7mIBkHreKvtXsvtsh3YV+Bu9AG5/nVdbzldoumQ5u4UnlJ07rab2oZQejjYyl7Ppp5zLywJt vlvQaXaq+QQB+qiyyh8icC/0vlQrR6Wqo2wryztyfYPkNPKQAokcMQRgbiPjkyzYgrMlVpIVH 5pl5YJ2niV/GSWoPhTIeTjZUxy4Djn9lruh5dJwPREL7DxgiSDz0aqrCu1fcY09BSND8jYmfm lR5Fj8p+ZKt8dIzdxbQqLnEsyWbbokW6WcWd/xnzE9HGfNeRNJerNHMTVcfPRyVP7PBMK+/Qf ZRRIyPftn63rBxAJFGl8lxTfD4J2Me9IdmZaWdlP2yJZmG+IEB4psVCkeiyYNMsxbZZYNNeqM 9ZutHv/IJCQb0ksVQmOKtIaM4+LsUUUefG6V+nA3WW0nxFPeyfxNSKK2xOgzB8+XJf8mSLxyO gZhR4ohiiH39cw2XKf+qNNx6yU2UAClSplsfLiQ2sFe/jt8PU3UkkRJTU5d+YII97u2h8r0ZW Fpv2G6ewSIMyQnC1bnHHBSP4oLL6wk3OSJO3/Lncpk+MEsmvxVQXpUkfFbdawILN0matr9dNl xlh88UDciH0GHxaTMbWTtr1CZccRxbl4+aOfQ9kcDhk7+tMusRK9ccrJA10= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) --=-=-= Content-Type: text/plain If a todo-mode item contains more than one line (hard newline), then typing `H' (`todo-toggle-item-highlighting') only highlights the first line instead of the entire item. --=-=-= Content-Type: text/plain Content-Disposition: inline Content-Description: ChangeLog 2017-05-29 Stephen Berman Make `todo-toggle-item-highlighting' work on multiline items * lisp/calendar/todo-mode.el (todo-hl-line-range): New named function, replacing an anonymous function for the sake of `describe-variable'. (todo-modes-set-2): Use it as buffer-local value of hl-line-range-function and remove boundp test of this variable, so its value is available on invoking `todo-toggle-item-highlighting'. --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: todo-mode item highlighting patch diff --git a/lisp/calendar/todo-mode.el b/lisp/calendar/todo-mode.el index 8155a4241a..7b27e7049d 100644 --- a/lisp/calendar/todo-mode.el +++ b/lisp/calendar/todo-mode.el @@ -6583,17 +6583,19 @@ todo-modes-set-1 (visual-line-mode) (setq wrap-prefix (make-string todo-indent-to-here 32)))) +(defun todo-hl-line-range () + "Make `todo-toggle-item-highlighting' highlight entire item." + (save-excursion + (when (todo-item-end) + (cons (todo-item-start) + (todo-item-end))))) + (defun todo-modes-set-2 () "Make some settings that apply to multiple Todo modes." (add-to-invisibility-spec 'todo) (setq buffer-read-only t) (setq-local desktop-save-buffer 'todo-desktop-save-buffer) - (when (boundp 'hl-line-range-function) - (setq-local hl-line-range-function - (lambda() (save-excursion - (when (todo-item-end) - (cons (todo-item-start) - (todo-item-end)))))))) + (setq-local hl-line-range-function 'todo-hl-line-range)) (defun todo-modes-set-3 () "Make some settings that apply to multiple Todo modes." --=-=-= Content-Type: text/plain In GNU Emacs 26.0.50 (build 29, x86_64-pc-linux-gnu, GTK+ Version 3.22.8) of 2017-05-28 built on rosalinde Repository revision: 288b3ca2e519903653b9bc88d281ecd9f6b162a4 Windowing system distributor 'The X.Org Foundation', version 11.0.11901000 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 29 14:32:38 2017 Received: (at 27133-done) by debbugs.gnu.org; 29 May 2017 18:32:38 +0000 Received: from localhost ([127.0.0.1]:43677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFPT2-0002HK-PZ for submit@debbugs.gnu.org; Mon, 29 May 2017 14:32:38 -0400 Received: from mout.gmx.net ([212.227.17.22]:59669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFPT0-0002H5-1R for 27133-done@debbugs.gnu.org; Mon, 29 May 2017 14:32:34 -0400 Received: from rosalinde ([83.135.17.20]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LjLwB-1dmGdo14pj-00dULj for <27133-done@debbugs.gnu.org>; Mon, 29 May 2017 20:32:27 +0200 From: Stephen Berman To: 27133-done@debbugs.gnu.org Subject: Re: bug#27133: 26.0.50; Todo-mode multiline item highlighting is broken References: <87poerplte.fsf@rosalinde> Date: Mon, 29 May 2017 20:32:26 +0200 In-Reply-To: <87poerplte.fsf@rosalinde> (Stephen Berman's message of "Mon, 29 May 2017 20:19:57 +0200") Message-ID: <87lgpfpl8l.fsf@rosalinde> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:NKbgdbVDHS5uyL9pzp3LpHNjEiRl+bqQDO65Em5NVEZNujc+5nX Nt7HVNAPH1ybzkA0XpydHYUMkH0IQQRwonWQY9QyL1i25bap8LrfQ+jAQ/+QuQI20fQsXWy /fdLWdzQETPp71uutWMQVOKqCkXdmR6TZlIHNLuqbva9Mrkfule9v1/XjYVVACoH53PbsDY KKXsu/1SEa29WOjfyVxbQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:qK7NxXfCoCI=:Pl29KT+RSu8wzNevvOysVz l2iQ1V8zasQXFIWOBf+/FGcQCRGUVuML73RFL/JBege7MFcbMb3NLM+5GAbsafO1Hmj8Ce7rI Nf0/JpqgGuViFaRmOi53Ks6oDy1CO1cV27LRK9vA35fcUt9ld/6XvhADBue6W8g4ZgbU5aR99 vHKzoeKacKarnNNQymWHHEJ2RDYENfMvZT4g/s9DeEBU7VAlfuZgp1aOVPFRnQs/BkohiHB3G A9WWDp41Lr2Z3jreLZMbXNjeeW4Fm2pUkn8RwHF3m7+CLIHWy1CDZQTVuOO8iZnaWPk8Z+zbS CBW1b9OlBR4kz5QSzVE+oEfT1F53kV7H0+jy/GraAxsQDBKlIFnGAITPgt8r/5O7iE0Wce3v4 7KxfjdbagDIyxWA77+6B2jkE+yIzzVmDme9k1YkKpzVHL0KhXdZOytWpXDxr0fY4gjCJf8XDn pN2A0zXjCtVT7CBIEtqpje/3AGwVZezr6HgJ2OOQz+P0563hUentvfbQ5dr5imIu9UMtQnmE8 68t7a+pETjsMSjgj0R4WfRoz/d5rdAGpxc/Dh+QWrOHXGD44+hP8/TVcQpq9QmB/+YWjOd8Nw zYAM8Lh29Kks5sX8qXPu1CXkByj1i9RIKhxC1DH6m9Hn+A5HGc/y3bYuL41l8JK14yyGkADhQ OEv8s8TwfR5FhBlWLUcQtbbAyxSG6kE5wjl2dPzHDTFQpu7SadjiFSrbrSWnq0bbYR0Mw9+jI blqJPd5boAVRyEGfogqiExn+kt/8j8t9aMpJWKA8BDWG991iNQqcMX6Z0bI32YOheBIGMFoGZ ah5DPCp X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 27133-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) On Mon, 29 May 2017 20:19:57 +0200 Stephen Berman wrote: > If a todo-mode item contains more than one line (hard newline), then > typing `H' (`todo-toggle-item-highlighting') only highlights the first > line instead of the entire item. Fixed in commit ed222c502b. From unknown Tue Aug 19 02:53:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 27 Jun 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator