GNU bug report logs - #27071
[PATCH 0/3] Add flask-script, flask-migrate, flasgger.

Previous Next

Full log

View this message in rfc822 format

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 27071 <at> debbugs.gnu.org
Subject: bug#27071: [PATCH 3/3] gnu: Add python-flasgger.
Date: Sat, 27 May 2017 15:54:46 +0200

Hi Marius,

thanks for the review.

On Thu, 25 May 2017 21:02:13 +0200
Marius Bakke <mbakke <at> fastmail.com> wrote:

> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
> 
> > * gnu/packages/python.scm (python-flasgger,
> > python2-flasgger): New variables.  
> 
> [...]
> 
> > +    (build-system python-build-system)
> > +    (arguments
> > +     `(#:tests? #f))  
> 
> Please add a comment about why tests are disabled. 

Because they don't work.  I've reported it upstream at <https://github.com/rochacbruno/flasgger/issues/105>.

> Especially since
> pytest is a native-input. Should it be?

I guess not with tests disabled.

I'll keep trying to get it to work including the tests, but so far that requires the following new packages we didn't have:
- python-jsonpointer
- python-rfc3987
- python-validate-email
- python-flex

It also requires new native-inputs, finally ending up with:

(define-public python-flasgger
  (package
    (name "python-flasgger")
    (version "0.6.3")
    (source
      (origin
        (method url-fetch)
        (uri (string-append "https://github.com/rochacbruno/flasgger/archive/"
                            version ".tar.gz"))
        (file-name (string-append name "-" version ".tar.gz"))
        (sha256
          (base32
            "1gqzlm0rb55fdpsy5ipkganlx9cnpi454fqyycr03jm22zql14ay"))))
    (build-system python-build-system)
    (arguments
     `(#:phases
       (modify-phases %standard-phases
         (replace 'check
           (lambda* (#:key inputs outputs #:allow-other-keys)
             (substitute* "Makefile"
               (("flake8 flasgger --ignore=F403")
                "flake8 flasgger --ignore=E731,F403"))
             (setenv "PYTHONPATH" (string-append (getcwd)
                                                 ":"
                                                 (getenv "PYTHONPATH")))
             ;(zero? (system* "py.test"))
             (zero? (system* "make" "test"))
             ;#t
)))))
    (propagated-inputs
     `(("python-flask" ,python-flask)
       ("python-pyyaml" ,python-pyyaml)
       ("python-jsonschema" ,python-jsonschema)
       ("python-mistune" ,python-mistune)
       ("python-six" ,python-six)))
    (native-inputs
     `(("python-decorator" ,python-decorator)
       ("python-flake8" ,python-flake8)
       ("python-flask-restful" ,python-flask-restful)
       ("python-flex" ,python-flex)
       ("python-pytest-3.0" ,python-pytest-3.0)
       ("python-pytest-cov" ,python-pytest-cov)))
    (home-page "https://github.com/rochacbruno/flasgger/")
    (synopsis "Extract Swagger specs from your Flask project")
    (description "This package allows extracting Swagger specs from your Flask
project.  It is a fork of Flask-Swagger.")
    (license license:expat)))

And then the tests finally run and fail.

Let's wait for a few days whether there's an easy fix from upstream.  If not, we can still commit it with the tests disabled (ugh).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.