From unknown Wed Jun 18 23:05:33 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27057 <27057@debbugs.gnu.org> To: bug#27057 <27057@debbugs.gnu.org> Subject: Status: 26.0.50; Equal defstruct objects not recognized in puthash Reply-To: bug#27057 <27057@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:05:33 +0000 retitle 27057 26.0.50; Equal defstruct objects not recognized in puthash reassign 27057 emacs submitter 27057 Stefan Monnier severity 27057 normal tag 27057 confirmed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed May 24 11:40:13 2017 Received: (at submit) by debbugs.gnu.org; 24 May 2017 15:40:13 +0000 Received: from localhost ([127.0.0.1]:36383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYOT-0003Wv-2R for submit@debbugs.gnu.org; Wed, 24 May 2017 11:40:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYOR-0003Wg-Jo for submit@debbugs.gnu.org; Wed, 24 May 2017 11:40:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDYOI-0008Iq-N0 for submit@debbugs.gnu.org; Wed, 24 May 2017 11:40:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43436) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dDYOI-0008Ia-Kc for submit@debbugs.gnu.org; Wed, 24 May 2017 11:40:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDYOH-0003mc-Jn for bug-gnu-emacs@gnu.org; Wed, 24 May 2017 11:40:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDYOE-0008G2-FH for bug-gnu-emacs@gnu.org; Wed, 24 May 2017 11:40:01 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:64333) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dDYOE-0008F9-A7 for bug-gnu-emacs@gnu.org; Wed, 24 May 2017 11:39:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BAFAAPqCVZ/7vmSC1cHgYMg1VCW4Nyi1mREQGCO4oSiH6CDxyGAgSCcUEXAQIBAQEBAQEBayhCAQQJAYUkXxMhARwNil2ce5Ixi3GRCYUmBZ4jlRaJDYZ8lE4hATWBCi8gCC+EbQELQx2BfySBWYRxgw8BAQE X-IPAS-Result: A0BAFAAPqCVZ/7vmSC1cHgYMg1VCW4Nyi1mREQGCO4oSiH6CDxyGAgSCcUEXAQIBAQEBAQEBayhCAQQJAYUkXxMhARwNil2ce5Ixi3GRCYUmBZ4jlRaJDYZ8lE4hATWBCi8gCC+EbQELQx2BfySBWYRxgw8BAQE X-IronPort-AV: E=Sophos;i="5.38,386,1491278400"; d="scan'208";a="313484259" Received: from 45-72-230-187.cpe.teksavvy.com (HELO pastel.home) ([45.72.230.187]) by smtp.teksavvy.com with ESMTP; 24 May 2017 11:39:56 -0400 Received: by pastel.home (Postfix, from userid 20848) id 5AFA562DA8; Wed, 24 May 2017 11:39:56 -0400 (EDT) From: Stefan Monnier To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Equal defstruct objects not recognized in puthash X-Debbug-Cc: Michael.Albinus@gmx.de (Michael Albinus), Lars Brinkhoff , Stefan Monnier Date: Wed, 24 May 2017 11:39:56 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Package: Emacs Version: 26.0.50 It looks like the new records-based code introduced a bug in the way records are handled as keys in hash-tables when the test is `equal`: (progn (cl-defstruct sm-foo a b) (setq sm-hash (make-hash-table :test 'equal)) (puthash (make-sm-foo :a 4 :b 6) "test1" sm-hash) (puthash (make-sm-foo :a 4 :b 6) "test2" sm-hash) (hash-table-count sm-hash)) this code return 2 here instead of 1. Lars, could you take a look at it? Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed May 24 11:47:36 2017 Received: (at control) by debbugs.gnu.org; 24 May 2017 15:47:36 +0000 Received: from localhost ([127.0.0.1]:36394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYVc-0003iG-3U for submit@debbugs.gnu.org; Wed, 24 May 2017 11:47:36 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:33273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYVa-0003i3-AI for control@debbugs.gnu.org; Wed, 24 May 2017 11:47:34 -0400 Received: by mail-oi0-f43.google.com with SMTP id w10so247384022oif.0 for ; Wed, 24 May 2017 08:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=TR/5Gt9buQ4XWvC8qLhbjs5aKGooMTRk7W1+0TzgZB4=; b=pQfuINB2FTBruvIRQodSaqXMcH6HpYhblaPOFgdXUFiF+akQkuKh/uph5fBkboE7FV Ko0xjuhZI2W1fCjMFxoPl4ZvUYiNwzvxRQo3vxfs+Rt3Zb6Uun2YfDmGFmDhemvAPmts irmlNo5sQxUoiBTj62GO/qdfrUQRyAgnIEz7CcrJci0WjMUJ5y9yqDcWdry0HN7NpYUB H7zaML46XEExlbgPJfP10ev7BWdmVaTH+Srhf0XoQHUojBToUrMIpm/wVeeYmY8LzMbz uVp9NnAVSgWFItJVN+i8bWW1mXHJU5xLVcozGVt07xsHnTLf1DFwC64tPJTbv5JyAmoc YEGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=TR/5Gt9buQ4XWvC8qLhbjs5aKGooMTRk7W1+0TzgZB4=; b=Nae0Vf59tu3ISj+ToujAspIIjaUZ1h3QAkFmPOWoiL2EjEOj29qzWjpYSN8lB0KPEb rbwZBpzmEF3KRyhDk0Hyxj+JkiEr7mgSc3iZuv01SemguP495g9foAoU1FMWU0zSdBYM TBIpIBtv6pdtD6A0yw7tahNueM+mAOuGbAQn4WMaZwF5GWk6zUi+Nff43FhufHzxFgoN dJwkUlUJLLTZ/RdzXPEvJJYF1bQ/Rb1Y7tSQ4wx9Vh9ziYaTOroUkPmMeIz3Cgfa1XCG 1cHi03ZimcVvYBy1Mo02uJbT0d8ivqLVoZOlozOGllQ8kcLKY78zZ20nF31bMTWdb3xi VaRQ== X-Gm-Message-State: AODbwcDjeghhfPNgcbBNw2Ch3wG5mz8ghbRV7rS9vprLtHOaajF9Jd49 zLVrC3pStSyc+nqP2oi1Hq062YoGdVlL X-Received: by 10.157.29.235 with SMTP id w40mr5215495otw.128.1495640848275; Wed, 24 May 2017 08:47:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.139.83 with HTTP; Wed, 24 May 2017 08:47:27 -0700 (PDT) In-Reply-To: References: From: Noam Postavsky Date: Wed, 24 May 2017 11:47:27 -0400 X-Google-Sender-Auth: zzvseyb65EFTHM1FiiYz9Skyjrc Message-ID: Subject: Re: bug#27057: 26.0.50; Equal defstruct objects not recognized in puthash To: GNU bug tracker automated control server Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) merge 27057 26639 quit From debbugs-submit-bounces@debbugs.gnu.org Wed May 24 11:56:34 2017 Received: (at 27057-done) by debbugs.gnu.org; 24 May 2017 15:56:34 +0000 Received: from localhost ([127.0.0.1]:36408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYeI-0003vl-Au for submit@debbugs.gnu.org; Wed, 24 May 2017 11:56:34 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:13773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYeF-0003vM-R2; Wed, 24 May 2017 11:56:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DPBgCzrCVZ/7vmSC1cGwEBAQMBAQEJAQEBg1VChE2FWoV/kRMBl1ochgIEAgKCbUMVAQIBAQEBAQEBayiFGQZWIxALNBIUGA0lijivLYtAAQEBAQEBBAEBAQEki1mKVgEEniOVFgGJDIZ8lE41IoEKLyAIL4U8HYF/JIlZAQEB X-IPAS-Result: A0DPBgCzrCVZ/7vmSC1cGwEBAQMBAQEJAQEBg1VChE2FWoV/kRMBl1ochgIEAgKCbUMVAQIBAQEBAQEBayiFGQZWIxALNBIUGA0lijivLYtAAQEBAQEBBAEBAQEki1mKVgEEniOVFgGJDIZ8lE41IoEKLyAIL4U8HYF/JIlZAQEB X-IronPort-AV: E=Sophos;i="5.38,386,1491278400"; d="scan'208";a="313485316" Received: from 45-72-230-187.cpe.teksavvy.com (HELO pastel.home) ([45.72.230.187]) by smtp.teksavvy.com with ESMTP; 24 May 2017 11:56:25 -0400 Received: by pastel.home (Postfix, from userid 20848) id 86F6662DA8; Wed, 24 May 2017 11:56:25 -0400 (EDT) From: Stefan Monnier To: 27057-done@debbugs.gnu.org, 26639-done@debbugs.gnu.org Subject: Re: bug#27057: 26.0.50; Equal defstruct objects not recognized in puthash Message-ID: References: Date: Wed, 24 May 2017 11:56:25 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 24 May 2017 11:39:56 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 27057-done Cc: Lars Brinkhoff , Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > (progn > (cl-defstruct sm-foo a b) > (setq sm-hash (make-hash-table :test 'equal)) > (puthash (make-sm-foo :a 4 :b 6) "test1" sm-hash) > (puthash (make-sm-foo :a 4 :b 6) "test2" sm-hash) > (hash-table-count sm-hash)) > > this code return 2 here instead of 1. This should be fixed now, Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed May 24 12:02:13 2017 Received: (at 27057-done) by debbugs.gnu.org; 24 May 2017 16:02:13 +0000 Received: from localhost ([127.0.0.1]:36426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYjl-0005on-CX for submit@debbugs.gnu.org; Wed, 24 May 2017 12:02:13 -0400 Received: from mout.gmx.net ([212.227.17.21]:52456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYjk-0005js-8H; Wed, 24 May 2017 12:02:12 -0400 Received: from detlef.gmx.de ([212.86.45.192]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MSMr9-1dOrFA16p1-00TXLg; Wed, 24 May 2017 18:02:03 +0200 From: Michael Albinus To: Stefan Monnier Subject: Re: bug#27057: 26.0.50; Equal defstruct objects not recognized in puthash References: Date: Wed, 24 May 2017 18:02:01 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 24 May 2017 11:56:25 -0400") Message-ID: <874lwa9rba.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:D6d1xTHgF1vT1pnGflJd31nkL/avCX5sBQBsYpOV93wBMWrPnVP xpFKlldG0B83WTI5I5AdyRBfhZreSdTRGZWB/itAi1l738DUEdQFoWn/3gdppb6RnfjlqhK yIeFlbNP4ZRa3o5fXKjzGb4VedOa7lye/pvJ68CzQH8ws/QWWWli7Y1qelCSHC5D7zBCKcZ ibk2NQjEJf2GeU6tYpV3w== X-UI-Out-Filterresults: notjunk:1;V01:K0:7Qfnk+peNj0=:YgHbdlZbm7SPnnfswEvxpv xtBkTpkn7GR7abpmQkLOQ7mru48L6XLKjOBD5G3WopEy51GYrn+i7IpSQbGLHArhD39DFV2X1 II3+ZzJchHCUWBd3Q4v7uDyGwUqmOTGEvCJOTMbWQruFjbjDXx2leqdMvXpJENBNbX7K1wDKN iLV1BG3dsntsBFNc6FznN/lfR0+MZ17OIyYC1BTgBakmCVsWFHiq0K+jfDizQOPHVJtEo+Lat EaaYJj8CUVZxZQyZrvOoayEOa3mj75/zh1x4CXqxAWPIePtp+6fPV7AB8pyw16z7MxSxbMTkg L6kri28Ia0KCG1Qzppc2ueYGLVNzqCkm/LZH0r24tOJsmz4u4fXafpoyp1R9KeTxo+e1qXPC6 FCkRyML/acxxktPa5BGhWWzr4D0TLlQV48i8Sv6QfpyzvkwnZAy6SPYO/xIZiV3+E+GBnQ8CX q6fCW8PFj0gHkpmCrKf0dubZ48L5DljyH3P3Vx1wJCSrEgMantzK1xzpPN+yYW2VkS7QXTA7P TLVRCn5U7JKZjnLjv5j0zgdMQcWOjRDjcctQJcljr/t6euAuIemyTuhO8qjmhodGzp8nSsXig YXpBqqy0VQahhWnD1K/ElHL4DAapU5jKWwbRsq1cTnpTVoYQvCg1auptc3l3zU6q39eJpYDTZ 8nFvA44sitVHDpaYioXtpSu4LsPTcpn84OUp8PqRIZo+i9bLCAQ0bwPK4YqU2GCVLqsRGDMh9 i6dS2YWCGYHHuwcTCAO194RH9HA3nJMB3dnrg2SLy3W2k7T68l8VqVIy8+jxG8z2wdLf4xEkV vVtlRKi X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 27057-done Cc: Lars Brinkhoff , 27057-done@debbugs.gnu.org, 26639-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) Stefan Monnier writes: Hi Stefan >> this code return 2 here instead of 1. > > This should be fixed now, Thanks. But for Tramp, I'll keep the list type, due to backward compatibility. > Stefan Best regards, Michael. From unknown Wed Jun 18 23:05:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 22 Jun 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator