From unknown Mon Jun 23 13:15:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27047: 26.0.50; Scroll bar menu UI glitches [patch] Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 May 2017 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27047 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 27047@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.149557370416198 (code B ref -1); Tue, 23 May 2017 21:09:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 May 2017 21:08:24 +0000 Received: from localhost ([127.0.0.1]:35163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDH2V-0004DA-F7 for submit@debbugs.gnu.org; Tue, 23 May 2017 17:08:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDH2S-0004Cw-SK for submit@debbugs.gnu.org; Tue, 23 May 2017 17:08:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDH2M-00042y-3U for submit@debbugs.gnu.org; Tue, 23 May 2017 17:08:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47892) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dDH2L-00042s-VD for submit@debbugs.gnu.org; Tue, 23 May 2017 17:08:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDH2K-00019F-18 for bug-gnu-emacs@gnu.org; Tue, 23 May 2017 17:08:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDH2E-000408-RX for bug-gnu-emacs@gnu.org; Tue, 23 May 2017 17:08:11 -0400 Received: from mout.gmx.net ([212.227.15.19]:64889) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDH2E-0003zq-Fv for bug-gnu-emacs@gnu.org; Tue, 23 May 2017 17:08:06 -0400 Received: from rosalinde ([83.135.14.80]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M8NWM-1e8yDh2Sd0-00vxvX for ; Tue, 23 May 2017 23:08:04 +0200 From: Stephen Berman Date: Tue, 23 May 2017 23:08:03 +0200 Message-ID: <87d1azffik.fsf@rosalinde> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:irfe3CjHldbQ8VXjlXLsCEK6wg0tu7JHJLFXNovd+6lsSwCN6xr 3SDPKQty6eIgxYgAeBMFXemHzVYGCWE0agcyWrY6tSPMKDpoQg5S6MWLYgDMf8lliISvBn0 huHCF7JDSXsw3ZY0W8jBXJAM1Nz7lVcet6x2zbIFhxxag39KG3EW7Pe7ttoED3M47GJkFjV tWaJZf/ML7pTr4aHYUQvg== X-UI-Out-Filterresults: notjunk:1;V01:K0:QgpLAm8lUdo=:cUbOBDSE56nka/GCEwT+ds jqo2SNL3YI6VPIVoADBBZOLNl93HfOSJh8RLdCkYs6BSv6sDy9T4UlmUqDzWMZ59+LNcCgkWq 6/cC4fhAWor+aG4gNXYTWc2VC44embvZ0+dBEVKv9jbniL3D/FZk74LTo2tlDwSCd//DRpB7a G2my5iAoikaNqyqJAqgASz6hlHwznAL10CVIiqaJCeZFyPpbmkJcZWmxJgQ9gAarTS51hjEbE 6PiopvvFre5JB0whF2ee/43MGnMIQsqZ6FdQgMDUsIO7bJv0PoFTXZ/LpxS6RRsuyfsOVNIPU ujRHduYz9ZOPkYegBHnZXoDAugZFAhE98pe99Tzly8UCyIHgUffYw1dQALppPjwQIUhZtO+L+ /yJ71xaUM+znO2RQqa+5vtcuTHNjud7ZRgCgMMo86jZi+4Ky9TyYybCtLOnMBYFVV+D0kdHLd vwbLePOLKSNSrPmZol8GA1zS3fBHSRdwzsfc2LGWt5kPeDc3K0anGdKgtQjN6PPtVOcB+9BhJ UJ/3dwhgJB8Vz88T7xO3O3F99bjamZce3xyP9jrH/o5B3eSCVMxswinakWynfKAkKh2s8KdAl bBwvQWdv3dC0GJ9kD8BhUH8ZyihZqsqBJsadrzG3JtK/0A+zL1zkUDXtvnXjqYMGQaz4evTAS T1UPcokRLLf/Flv2Ja86xV/FWpIn6m+WZ4dnDBKsv40DdFalk2m6/e39Wmid7/sWC2wY4OV3B wAtg1qJNOLhA6Qto2GD6EYhgkq5KmX4tnAHzyxnsRXAG3jTNLvMxka+P7Vs= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=-=-= Content-Type: text/plain The Options->Show/Hide->Scroll-bar menu functions correctly -- when you press any of the five radio buttons, the result is what it should be -- but the UI is broken. With -Q the vertical scroll bar is on the right, there is no horizontal scroll bar and the menu shows the radio button "None-horizontal" [sic] pressed. If you press any of the other buttons in that menu, the scroll bars change accordingly, but the menu continues to show the same "None-horizontal" button pressed. The attached patch fixes this UI glitch. In addition, I find the current scroll bar menu somewhat incoherent and the patch offers an improvement (IMO): the radio buttons are confined to the vertical scroll bar, and the two buttons for the horizontal scroll bar are replaced by a single check box toggle, and a separator is added to visually emphasize that two UI components are involved. While I was looking at the Show/Hide menu, I noticed that the spelling there is not consistent with the convention of the Emacs manual, which uses "scroll bar", "tool bar" and "menu bar" without hyphenation. So the patch changes the spelling of these in the menu and tooltips too. In GNU Emacs 26.0.50 (build 19, x86_64-pc-linux-gnu, GTK+ Version 3.22.8) of 2017-05-22 built on rosalinde Repository revision: bc78276e81956b3caa8a5eb7ef26959fa4c84b7b Windowing system distributor 'The X.Org Foundation', version 11.0.11901000 --=-=-= Content-Type: text/plain Content-Disposition: inline Content-Description: ChangeLog entry 2017-05-23 Stephen Berman Fix and improve UI of scroll bar menu In addition, since the Emacs manual writes "scroll bar", "tool bar" and "menu bar", use this convention in the Show/Hide menues and tooltips as well. * lisp/menu-bar.el (menu-bar-showhide-scroll-bar-menu): Make pressing a radio button in the menu actually show that it was pressed. Replace the two radio buttons to turn the horizontal scroll bar on and off with a single check-box toggle and add a separator between this and the vertical scroll bar radio buttons. (menu-bar-showhide-tool-bar-menu): (menu-bar-showhide-menu): (menu-bar-mode): Use conventional spelling. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: Show/Hide menu patch diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 6befa6d234..c8eb565942 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -981,43 +981,39 @@ menu-bar-no-horizontal-scroll-bar (customize-set-variable 'horizontal-scroll-bar-mode nil)) (defvar menu-bar-showhide-scroll-bar-menu - (let ((menu (make-sparse-keymap "Scroll-bar")) - (vsb (frame-parameter nil 'vertical-scroll-bars)) - (hsb (frame-parameter nil 'horizontal-scroll-bars))) + (let ((menu (make-sparse-keymap "Scroll Bar"))) + (bindings--define-key menu [horizontal] - `(menu-item "Horizontal" - menu-bar-horizontal-scroll-bar - :help "Horizontal scroll bar" - :visible (horizontal-scroll-bars-available-p) - :button (:radio . ,hsb))) - - (bindings--define-key menu [none-horizontal] - `(menu-item "None-horizontal" - menu-bar-no-horizontal-scroll-bar - :help "Turn off horizontal scroll bars" - :visible (horizontal-scroll-bars-available-p) - :button (:radio . (not ,hsb)))) + (menu-bar-make-mm-toggle horizontal-scroll-bar-mode + "Horizontal" + "Horizontal scroll bar")) + + (bindings--define-key menu [scrollbar-separator] + menu-bar-separator) (bindings--define-key menu [right] - `(menu-item "On the Right" - menu-bar-right-scroll-bar - :help "Scroll-bar on the right side" + '(menu-item "On the Right" menu-bar-right-scroll-bar + :help "Scroll bar on the right side" :visible (display-graphic-p) - :button (:radio . (eq ,vsb 'right)))) + :button (:radio . (and scroll-bar-mode + (eq (frame-parameter + nil 'vertical-scroll-bars) + 'right))))) (bindings--define-key menu [left] - `(menu-item "On the Left" - menu-bar-left-scroll-bar - :help "Scroll-bar on the left side" + '(menu-item "On the Left" menu-bar-left-scroll-bar + :help "Scroll bar on the left side" :visible (display-graphic-p) - :button (:radio . (eq ,vsb 'left)))) + :button (:radio . (and scroll-bar-mode + (eq (frame-parameter + nil 'vertical-scroll-bars) + 'left))))) (bindings--define-key menu [none] - `(menu-item "None" - menu-bar-no-scroll-bar - :help "Turn off scroll-bar" + '(menu-item "No Vertical Scroll Bar" menu-bar-no-scroll-bar + :help "Turn off vertical scroll bar" :visible (display-graphic-p) - :button (:radio . (not ,vsb)))) + :button (:radio . (eq scroll-bar-mode nil)))) menu)) (defun menu-bar-frame-for-menubar () @@ -1057,24 +1053,24 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom (when (featurep 'move-toolbar) (defvar menu-bar-showhide-tool-bar-menu - (let ((menu (make-sparse-keymap "Tool-bar"))) + (let ((menu (make-sparse-keymap "Tool Bar"))) (bindings--define-key menu [showhide-tool-bar-left] '(menu-item "On the Left" menu-bar-showhide-tool-bar-menu-customize-enable-left - :help "Tool-bar at the left side" + :help "Tool bar at the left side" :visible (display-graphic-p) :button (:radio . (and tool-bar-mode - (eq (frame-parameter + (frame-parameter (menu-bar-frame-for-menubar) 'tool-bar-position) - 'left))))) + 'left)))) (bindings--define-key menu [showhide-tool-bar-right] '(menu-item "On the Right" menu-bar-showhide-tool-bar-menu-customize-enable-right - :help "Tool-bar at the right side" + :help "Tool bar at the right side" :visible (display-graphic-p) :button (:radio . (and tool-bar-mode @@ -1086,7 +1082,7 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom (bindings--define-key menu [showhide-tool-bar-bottom] '(menu-item "On the Bottom" menu-bar-showhide-tool-bar-menu-customize-enable-bottom - :help "Tool-bar at the bottom" + :help "Tool bar at the bottom" :visible (display-graphic-p) :button (:radio . (and tool-bar-mode @@ -1098,7 +1094,7 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom (bindings--define-key menu [showhide-tool-bar-top] '(menu-item "On the Top" menu-bar-showhide-tool-bar-menu-customize-enable-top - :help "Tool-bar at the top" + :help "Tool bar at the top" :visible (display-graphic-p) :button (:radio . (and tool-bar-mode @@ -1110,7 +1106,7 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom (bindings--define-key menu [showhide-tool-bar-none] '(menu-item "None" menu-bar-showhide-tool-bar-menu-customize-disable - :help "Turn tool-bar off" + :help "Turn tool bar off" :visible (display-graphic-p) :button (:radio . (eq tool-bar-mode nil)))) menu))) @@ -1168,7 +1164,7 @@ menu-bar-showhide-menu :visible (display-graphic-p))) (bindings--define-key menu [showhide-scroll-bar] - `(menu-item "Scroll-bar" ,menu-bar-showhide-scroll-bar-menu + `(menu-item "Scroll Bar" ,menu-bar-showhide-scroll-bar-menu :visible (display-graphic-p))) (bindings--define-key menu [showhide-tooltip-mode] @@ -1178,8 +1174,8 @@ menu-bar-showhide-menu :button (:toggle . tooltip-mode))) (bindings--define-key menu [menu-bar-mode] - '(menu-item "Menu-bar" toggle-menu-bar-mode-from-frame - :help "Turn menu-bar on/off" + '(menu-item "Menu Bar" toggle-menu-bar-mode-from-frame + :help "Turn menu bar on/off" :button (:toggle . (menu-bar-positive-p (frame-parameter (menu-bar-frame-for-menubar) @@ -1188,12 +1184,12 @@ menu-bar-showhide-menu (if (and (boundp 'menu-bar-showhide-tool-bar-menu) (keymapp menu-bar-showhide-tool-bar-menu)) (bindings--define-key menu [showhide-tool-bar] - `(menu-item "Tool-bar" ,menu-bar-showhide-tool-bar-menu + `(menu-item "Tool Bar" ,menu-bar-showhide-tool-bar-menu :visible (display-graphic-p))) ;; else not tool bar that can move. (bindings--define-key menu [showhide-tool-bar] - '(menu-item "Tool-bar" toggle-tool-bar-mode-from-frame - :help "Turn tool-bar on/off" + '(menu-item "Tool Bar" toggle-tool-bar-mode-from-frame + :help "Turn tool bar on/off" :visible (display-graphic-p) :button (:toggle . (menu-bar-positive-p @@ -2268,11 +2264,11 @@ menu-bar-mode (assq-delete-all 'menu-bar-lines default-frame-alist))))) ;; Make the message appear when Emacs is idle. We can not call message - ;; directly. The minor-mode message "Menu-bar mode disabled" comes + ;; directly. The minor-mode message "Menu Bar mode disabled" comes ;; after this function returns, overwriting any message we do here. (when (and (called-interactively-p 'interactive) (not menu-bar-mode)) (run-with-idle-timer 0 nil 'message - "Menu-bar mode disabled. Use M-x menu-bar-mode to make the menu bar appear."))) + "Menu Bar mode disabled. Use M-x menu-bar-mode to make the menu bar appear."))) ;;;###autoload ;; (This does not work right unless it comes after the above definition.) --=-=-=-- From unknown Mon Jun 23 13:15:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27047: 26.0.50; Scroll bar menu UI glitches [patch] Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 May 2017 06:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27047 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stephen Berman , 27047@debbugs.gnu.org Received: via spool by 27047-submit@debbugs.gnu.org id=B27047.149560652921212 (code B ref 27047); Wed, 24 May 2017 06:16:02 +0000 Received: (at 27047) by debbugs.gnu.org; 24 May 2017 06:15:29 +0000 Received: from localhost ([127.0.0.1]:35414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDPZx-0005W4-Dv for submit@debbugs.gnu.org; Wed, 24 May 2017 02:15:29 -0400 Received: from mout.gmx.net ([212.227.17.21]:61041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDPZv-0005Vq-UI for 27047@debbugs.gnu.org; Wed, 24 May 2017 02:15:28 -0400 Received: from [192.168.1.100] ([46.125.250.33]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lo3IS-1dtN5t0YKu-00fwny; Wed, 24 May 2017 08:15:21 +0200 Message-ID: <592524EF.2040805@gmx.at> Date: Wed, 24 May 2017 08:15:11 +0200 From: martin rudalics MIME-Version: 1.0 References: <87d1azffik.fsf@rosalinde> In-Reply-To: <87d1azffik.fsf@rosalinde> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:QzyOo4lCbY6qvNDQylYz2Hv4rDTJikwdGSaTOk1NCv1zbfkBMPW MfYTlBk0gJ6H4oQvdHZd0efxcqfT51hkEAmwJxQueET52XyhGYs1LoADLlTRV+mnhGqW0z9 uKf30UN8fiIZvsWpW31l+tn+wV1KSAhzjSlHzK1+IzLXJxs0LpMSgoCGTF5o1Ul+rY5iiL/ 8dEdp6cpkRsPyIFw9AiKQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:j7ZUnCA+9AY=:gpeQTJoL/ZccnqLCX3Jipq 9YlHtaouW9QhmWCY8TmBm0xMmxQJG4+MjOpR7/G9pAjxgTMc7JrewtT4g2UYN+/i3h9BCqy1B YgymPWyNAXYtPqyPaRUFi+dPih7Mvoc3+snY+LWxkjgYiahugzM089duX1/4kiVv304WW0UsS Y4KU2UQZTTDRkBRgfIJV6eAgRsUKVnnct4Za7jzOQke2KZiIOKGGlhqtBZPGKHeDoSCsudre5 S6cu00iZkPdqLPYH2/w/Qc9SyshNGEnXkq9NYu3WsQW69MdMfG6Z1W0lJ9KpjOWKD3D7TiRS0 iWC6GQ5BR0PyeObrU8So+BzyvcpZ/CxkVrA+jj6t7LTD3lj/djh2sO2FN7I3U0oP+3A7dGc1v bRQisrICd2FHJqnzZzbeGv73RVz2P5njodsKIpTPKeI/aAh1Nq7mQY/Wq/kWbD7Wdjqldi/UT 7HqV9OG4/+k4xLkrrSggMYVAYCFy6ma+UIPSRVZxp1QLK0dPvhqvilPVsC92SFjnHgdrKnC6D huDZOI2YqtBwBqB3QlqRXnGzEzoIrAVdh4BvMDhDZdWJMVSs0/7u+jtbc5CKuPHuKluuLk4Sr taExP5ZYu7k/7HZ+O/gGxW//HZQRLr7O3+da+e5kWSK5J4vlTEIRHlJRzEyAFhnePBmWZWaOM WJz+MgW7/1J31oPHdBUWCcRf6kJZHUqJ0MYfr/d4dEAOk/X4CCoUeBFlsM10jDbqpspqQ8Q8y q4rf/GuRg6MhcMSvg+LL0bB/2Agb+Q8bNWA1uLhyc8DJUUevMHvLiQnlDc3nDfmXZtEkmQtmu kQXwhXV X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) > The Options->Show/Hide->Scroll-bar menu functions correctly -- when you > press any of the five radio buttons, the result is what it should be -- > but the UI is broken. With -Q the vertical scroll bar is on the right, > there is no horizontal scroll bar and the menu shows the radio button > "None-horizontal" [sic] pressed. If you press any of the other buttons > in that menu, the scroll bars change accordingly, but the menu continues > to show the same "None-horizontal" button pressed. The attached patch > fixes this UI glitch. Thanks. > In addition, I find the current scroll bar menu > somewhat incoherent and the patch offers an improvement (IMO): the radio > buttons are confined to the vertical scroll bar, and the two buttons for > the horizontal scroll bar are replaced by a single check box toggle, and > a separator is added to visually emphasize that two UI components are > involved. I once planned to implement horizontal scroll bars on the top of a frame too but lack of knowledge of the internals of the display engine impeded me to do so properly (I failed to detect all uses of "0" indicating the start of the text area, so display usually got mangled). Also, I doubted that anyone would ever need scoll bars on top, so I eventually gave up on that idea. The "None-horizontal" entry was the last remnant of that failed attempt. > While I was looking at the Show/Hide menu, I noticed that the spelling > there is not consistent with the convention of the Emacs manual, which > uses "scroll bar", "tool bar" and "menu bar" without hyphenation. So > the patch changes the spelling of these in the menu and tooltips too. Fine. Please install. martin From unknown Mon Jun 23 13:15:22 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stephen Berman Subject: bug#27047: closed (Re: bug#27047: 26.0.50; Scroll bar menu UI glitches [patch]) Message-ID: References: <87wp96qyaz.fsf@rosalinde> <87d1azffik.fsf@rosalinde> X-Gnu-PR-Message: they-closed 27047 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 27047@debbugs.gnu.org Date: Wed, 24 May 2017 11:40:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1495626002-23902-1" This is a multi-part message in MIME format... ------------=_1495626002-23902-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #27047: 26.0.50; Scroll bar menu UI glitches [patch] which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 27047@debbugs.gnu.org. --=20 27047: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27047 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1495626002-23902-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 27047-done) by debbugs.gnu.org; 24 May 2017 11:39:10 +0000 Received: from localhost ([127.0.0.1]:35581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDUdC-0006CU-Kf for submit@debbugs.gnu.org; Wed, 24 May 2017 07:39:10 -0400 Received: from mout.gmx.net ([212.227.15.19]:60609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDUdA-0006CG-4I for 27047-done@debbugs.gnu.org; Wed, 24 May 2017 07:39:09 -0400 Received: from rosalinde ([83.135.21.156]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MhAAr-1dZ8D62ZBh-00MOU7; Wed, 24 May 2017 13:39:01 +0200 From: Stephen Berman To: martin rudalics Subject: Re: bug#27047: 26.0.50; Scroll bar menu UI glitches [patch] References: <87d1azffik.fsf@rosalinde> <592524EF.2040805@gmx.at> Date: Wed, 24 May 2017 13:39:00 +0200 In-Reply-To: <592524EF.2040805@gmx.at> (martin rudalics's message of "Wed, 24 May 2017 08:15:11 +0200") Message-ID: <87wp96qyaz.fsf@rosalinde> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:ObzIN592nAm9pXqHx/YSPzZztzE15kLhs2vBcSED1E0NWciOUiN 7EMQJkDAsvQrnfd/ChKOWBjd4aIJBipouuPTn0KZt4Dd8KRsbGzrSQx2a1wZXq+lJUsQWoB 3aZ7l5BPHcX1lSM/BUO4OCHEMgUa30PCcPbSgg6AOcYFg9SA2e86h2RjLYZMX8UOTG8ZPwD XgL4p/ZG1iGOLqh8L/Yxg== X-UI-Out-Filterresults: notjunk:1;V01:K0:DupVL8D5+Ds=:jmsp3u+7lkpGrWQxMfupye Xs3vMamRuGPeRVcJjusSaWKdSCc7XD0D4SWGXdBJD/4G/lH8AV285R7MFcdX9MlxHo3cY7Ko5 YznhLmyAlO4K3MMkd9ux5qD8Hf3/XO0PGBZd6oGqH39cy8VO/A+WAIVnYGZDVZvyDj66NBLHd Fdr/PzKHw8gXeOIAZyFaw0Th3a9wFMUoM1xSw9N1MftXd2oyIX+lYXj+RiYVd24e9lzTs9Twh IB019kepTZ/yg1LA6lPm7tB1ns2uVqfU8QeJMlEsDcaVY+GY/H1NSNcDcAWbsJya1bGAm3/+S grbaJN3wMW5W7t+LavUYrnrJ93ZR1CYNsvT+x+WtzTEb2VTJpK2tAHIONrXawmjvHAKpY0EUz MmfseRp+UXPfj2GPNdrbMmjWcuaGn5hqpUuFj/1b2txfGGOeHcrtQC93zeQk65+L538/DAn+y BHYwaN1Qtuc1Q4I07WC1pTqizRkGpZa3CJIKNMKCF5TN4472jE1MJeH/ISklO9X18lvO6eDR5 lPLew+faAvfGbetaG/ey+cJV3lN5nsBkX8dylZ2yD8n+vIsLG/S7ChU2/u9oA/CFawCi7j0SO 9JiArTsRneNChKU6ZJw8Yq73F5bWCX45BcdpLj+U0GZZjVV3JyFe2CTLc9VsjLGDHNYhWQv2y dHsETvnzlLjanqVRPd3Yhee+vgtBDkvAr6hNOroqvbtUPNdwCEQPd1YOfv5K1qwm7dMcq1l0s 6GHb4tEVWvchmD5rd9pHsPT2LsHfhMTRzHEKZMcfMMKmuoDvDvWR+QPKDmvyJ6KX+wiCfHiX+ jUjO+8g X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 27047-done Cc: 27047-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) On Wed, 24 May 2017 08:15:11 +0200 martin rudalics wrote: > Fine. Please install. Done, as commit 08f00c01d6 and closing the bug. (The commit also removed the two functions that were no longer used as a result of the change, which the patch I posted had overlooked.) Steve Berman ------------=_1495626002-23902-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 May 2017 21:08:24 +0000 Received: from localhost ([127.0.0.1]:35163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDH2V-0004DA-F7 for submit@debbugs.gnu.org; Tue, 23 May 2017 17:08:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDH2S-0004Cw-SK for submit@debbugs.gnu.org; Tue, 23 May 2017 17:08:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDH2M-00042y-3U for submit@debbugs.gnu.org; Tue, 23 May 2017 17:08:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47892) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dDH2L-00042s-VD for submit@debbugs.gnu.org; Tue, 23 May 2017 17:08:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDH2K-00019F-18 for bug-gnu-emacs@gnu.org; Tue, 23 May 2017 17:08:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDH2E-000408-RX for bug-gnu-emacs@gnu.org; Tue, 23 May 2017 17:08:11 -0400 Received: from mout.gmx.net ([212.227.15.19]:64889) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dDH2E-0003zq-Fv for bug-gnu-emacs@gnu.org; Tue, 23 May 2017 17:08:06 -0400 Received: from rosalinde ([83.135.14.80]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M8NWM-1e8yDh2Sd0-00vxvX for ; Tue, 23 May 2017 23:08:04 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Scroll bar menu UI glitches [patch] Date: Tue, 23 May 2017 23:08:03 +0200 Message-ID: <87d1azffik.fsf@rosalinde> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:irfe3CjHldbQ8VXjlXLsCEK6wg0tu7JHJLFXNovd+6lsSwCN6xr 3SDPKQty6eIgxYgAeBMFXemHzVYGCWE0agcyWrY6tSPMKDpoQg5S6MWLYgDMf8lliISvBn0 huHCF7JDSXsw3ZY0W8jBXJAM1Nz7lVcet6x2zbIFhxxag39KG3EW7Pe7ttoED3M47GJkFjV tWaJZf/ML7pTr4aHYUQvg== X-UI-Out-Filterresults: notjunk:1;V01:K0:QgpLAm8lUdo=:cUbOBDSE56nka/GCEwT+ds jqo2SNL3YI6VPIVoADBBZOLNl93HfOSJh8RLdCkYs6BSv6sDy9T4UlmUqDzWMZ59+LNcCgkWq 6/cC4fhAWor+aG4gNXYTWc2VC44embvZ0+dBEVKv9jbniL3D/FZk74LTo2tlDwSCd//DRpB7a G2my5iAoikaNqyqJAqgASz6hlHwznAL10CVIiqaJCeZFyPpbmkJcZWmxJgQ9gAarTS51hjEbE 6PiopvvFre5JB0whF2ee/43MGnMIQsqZ6FdQgMDUsIO7bJv0PoFTXZ/LpxS6RRsuyfsOVNIPU ujRHduYz9ZOPkYegBHnZXoDAugZFAhE98pe99Tzly8UCyIHgUffYw1dQALppPjwQIUhZtO+L+ /yJ71xaUM+znO2RQqa+5vtcuTHNjud7ZRgCgMMo86jZi+4Ky9TyYybCtLOnMBYFVV+D0kdHLd vwbLePOLKSNSrPmZol8GA1zS3fBHSRdwzsfc2LGWt5kPeDc3K0anGdKgtQjN6PPtVOcB+9BhJ UJ/3dwhgJB8Vz88T7xO3O3F99bjamZce3xyP9jrH/o5B3eSCVMxswinakWynfKAkKh2s8KdAl bBwvQWdv3dC0GJ9kD8BhUH8ZyihZqsqBJsadrzG3JtK/0A+zL1zkUDXtvnXjqYMGQaz4evTAS T1UPcokRLLf/Flv2Ja86xV/FWpIn6m+WZ4dnDBKsv40DdFalk2m6/e39Wmid7/sWC2wY4OV3B wAtg1qJNOLhA6Qto2GD6EYhgkq5KmX4tnAHzyxnsRXAG3jTNLvMxka+P7Vs= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=-=-= Content-Type: text/plain The Options->Show/Hide->Scroll-bar menu functions correctly -- when you press any of the five radio buttons, the result is what it should be -- but the UI is broken. With -Q the vertical scroll bar is on the right, there is no horizontal scroll bar and the menu shows the radio button "None-horizontal" [sic] pressed. If you press any of the other buttons in that menu, the scroll bars change accordingly, but the menu continues to show the same "None-horizontal" button pressed. The attached patch fixes this UI glitch. In addition, I find the current scroll bar menu somewhat incoherent and the patch offers an improvement (IMO): the radio buttons are confined to the vertical scroll bar, and the two buttons for the horizontal scroll bar are replaced by a single check box toggle, and a separator is added to visually emphasize that two UI components are involved. While I was looking at the Show/Hide menu, I noticed that the spelling there is not consistent with the convention of the Emacs manual, which uses "scroll bar", "tool bar" and "menu bar" without hyphenation. So the patch changes the spelling of these in the menu and tooltips too. In GNU Emacs 26.0.50 (build 19, x86_64-pc-linux-gnu, GTK+ Version 3.22.8) of 2017-05-22 built on rosalinde Repository revision: bc78276e81956b3caa8a5eb7ef26959fa4c84b7b Windowing system distributor 'The X.Org Foundation', version 11.0.11901000 --=-=-= Content-Type: text/plain Content-Disposition: inline Content-Description: ChangeLog entry 2017-05-23 Stephen Berman Fix and improve UI of scroll bar menu In addition, since the Emacs manual writes "scroll bar", "tool bar" and "menu bar", use this convention in the Show/Hide menues and tooltips as well. * lisp/menu-bar.el (menu-bar-showhide-scroll-bar-menu): Make pressing a radio button in the menu actually show that it was pressed. Replace the two radio buttons to turn the horizontal scroll bar on and off with a single check-box toggle and add a separator between this and the vertical scroll bar radio buttons. (menu-bar-showhide-tool-bar-menu): (menu-bar-showhide-menu): (menu-bar-mode): Use conventional spelling. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: Show/Hide menu patch diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 6befa6d234..c8eb565942 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -981,43 +981,39 @@ menu-bar-no-horizontal-scroll-bar (customize-set-variable 'horizontal-scroll-bar-mode nil)) (defvar menu-bar-showhide-scroll-bar-menu - (let ((menu (make-sparse-keymap "Scroll-bar")) - (vsb (frame-parameter nil 'vertical-scroll-bars)) - (hsb (frame-parameter nil 'horizontal-scroll-bars))) + (let ((menu (make-sparse-keymap "Scroll Bar"))) + (bindings--define-key menu [horizontal] - `(menu-item "Horizontal" - menu-bar-horizontal-scroll-bar - :help "Horizontal scroll bar" - :visible (horizontal-scroll-bars-available-p) - :button (:radio . ,hsb))) - - (bindings--define-key menu [none-horizontal] - `(menu-item "None-horizontal" - menu-bar-no-horizontal-scroll-bar - :help "Turn off horizontal scroll bars" - :visible (horizontal-scroll-bars-available-p) - :button (:radio . (not ,hsb)))) + (menu-bar-make-mm-toggle horizontal-scroll-bar-mode + "Horizontal" + "Horizontal scroll bar")) + + (bindings--define-key menu [scrollbar-separator] + menu-bar-separator) (bindings--define-key menu [right] - `(menu-item "On the Right" - menu-bar-right-scroll-bar - :help "Scroll-bar on the right side" + '(menu-item "On the Right" menu-bar-right-scroll-bar + :help "Scroll bar on the right side" :visible (display-graphic-p) - :button (:radio . (eq ,vsb 'right)))) + :button (:radio . (and scroll-bar-mode + (eq (frame-parameter + nil 'vertical-scroll-bars) + 'right))))) (bindings--define-key menu [left] - `(menu-item "On the Left" - menu-bar-left-scroll-bar - :help "Scroll-bar on the left side" + '(menu-item "On the Left" menu-bar-left-scroll-bar + :help "Scroll bar on the left side" :visible (display-graphic-p) - :button (:radio . (eq ,vsb 'left)))) + :button (:radio . (and scroll-bar-mode + (eq (frame-parameter + nil 'vertical-scroll-bars) + 'left))))) (bindings--define-key menu [none] - `(menu-item "None" - menu-bar-no-scroll-bar - :help "Turn off scroll-bar" + '(menu-item "No Vertical Scroll Bar" menu-bar-no-scroll-bar + :help "Turn off vertical scroll bar" :visible (display-graphic-p) - :button (:radio . (not ,vsb)))) + :button (:radio . (eq scroll-bar-mode nil)))) menu)) (defun menu-bar-frame-for-menubar () @@ -1057,24 +1053,24 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom (when (featurep 'move-toolbar) (defvar menu-bar-showhide-tool-bar-menu - (let ((menu (make-sparse-keymap "Tool-bar"))) + (let ((menu (make-sparse-keymap "Tool Bar"))) (bindings--define-key menu [showhide-tool-bar-left] '(menu-item "On the Left" menu-bar-showhide-tool-bar-menu-customize-enable-left - :help "Tool-bar at the left side" + :help "Tool bar at the left side" :visible (display-graphic-p) :button (:radio . (and tool-bar-mode - (eq (frame-parameter + (frame-parameter (menu-bar-frame-for-menubar) 'tool-bar-position) - 'left))))) + 'left)))) (bindings--define-key menu [showhide-tool-bar-right] '(menu-item "On the Right" menu-bar-showhide-tool-bar-menu-customize-enable-right - :help "Tool-bar at the right side" + :help "Tool bar at the right side" :visible (display-graphic-p) :button (:radio . (and tool-bar-mode @@ -1086,7 +1082,7 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom (bindings--define-key menu [showhide-tool-bar-bottom] '(menu-item "On the Bottom" menu-bar-showhide-tool-bar-menu-customize-enable-bottom - :help "Tool-bar at the bottom" + :help "Tool bar at the bottom" :visible (display-graphic-p) :button (:radio . (and tool-bar-mode @@ -1098,7 +1094,7 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom (bindings--define-key menu [showhide-tool-bar-top] '(menu-item "On the Top" menu-bar-showhide-tool-bar-menu-customize-enable-top - :help "Tool-bar at the top" + :help "Tool bar at the top" :visible (display-graphic-p) :button (:radio . (and tool-bar-mode @@ -1110,7 +1106,7 @@ menu-bar-showhide-tool-bar-menu-customize-enable-bottom (bindings--define-key menu [showhide-tool-bar-none] '(menu-item "None" menu-bar-showhide-tool-bar-menu-customize-disable - :help "Turn tool-bar off" + :help "Turn tool bar off" :visible (display-graphic-p) :button (:radio . (eq tool-bar-mode nil)))) menu))) @@ -1168,7 +1164,7 @@ menu-bar-showhide-menu :visible (display-graphic-p))) (bindings--define-key menu [showhide-scroll-bar] - `(menu-item "Scroll-bar" ,menu-bar-showhide-scroll-bar-menu + `(menu-item "Scroll Bar" ,menu-bar-showhide-scroll-bar-menu :visible (display-graphic-p))) (bindings--define-key menu [showhide-tooltip-mode] @@ -1178,8 +1174,8 @@ menu-bar-showhide-menu :button (:toggle . tooltip-mode))) (bindings--define-key menu [menu-bar-mode] - '(menu-item "Menu-bar" toggle-menu-bar-mode-from-frame - :help "Turn menu-bar on/off" + '(menu-item "Menu Bar" toggle-menu-bar-mode-from-frame + :help "Turn menu bar on/off" :button (:toggle . (menu-bar-positive-p (frame-parameter (menu-bar-frame-for-menubar) @@ -1188,12 +1184,12 @@ menu-bar-showhide-menu (if (and (boundp 'menu-bar-showhide-tool-bar-menu) (keymapp menu-bar-showhide-tool-bar-menu)) (bindings--define-key menu [showhide-tool-bar] - `(menu-item "Tool-bar" ,menu-bar-showhide-tool-bar-menu + `(menu-item "Tool Bar" ,menu-bar-showhide-tool-bar-menu :visible (display-graphic-p))) ;; else not tool bar that can move. (bindings--define-key menu [showhide-tool-bar] - '(menu-item "Tool-bar" toggle-tool-bar-mode-from-frame - :help "Turn tool-bar on/off" + '(menu-item "Tool Bar" toggle-tool-bar-mode-from-frame + :help "Turn tool bar on/off" :visible (display-graphic-p) :button (:toggle . (menu-bar-positive-p @@ -2268,11 +2264,11 @@ menu-bar-mode (assq-delete-all 'menu-bar-lines default-frame-alist))))) ;; Make the message appear when Emacs is idle. We can not call message - ;; directly. The minor-mode message "Menu-bar mode disabled" comes + ;; directly. The minor-mode message "Menu Bar mode disabled" comes ;; after this function returns, overwriting any message we do here. (when (and (called-interactively-p 'interactive) (not menu-bar-mode)) (run-with-idle-timer 0 nil 'message - "Menu-bar mode disabled. Use M-x menu-bar-mode to make the menu bar appear."))) + "Menu Bar mode disabled. Use M-x menu-bar-mode to make the menu bar appear."))) ;;;###autoload ;; (This does not work right unless it comes after the above definition.) --=-=-=-- ------------=_1495626002-23902-1-- From unknown Mon Jun 23 13:15:22 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27047: 26.0.50; Scroll bar menu UI glitches [patch] Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 May 2017 12:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27047 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stephen Berman Cc: 27047-done@debbugs.gnu.org Received: via spool by 27047-done@debbugs.gnu.org id=D27047.149562883928284 (code D ref 27047); Wed, 24 May 2017 12:28:02 +0000 Received: (at 27047-done) by debbugs.gnu.org; 24 May 2017 12:27:19 +0000 Received: from localhost ([127.0.0.1]:35635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDVNn-0007M8-11 for submit@debbugs.gnu.org; Wed, 24 May 2017 08:27:19 -0400 Received: from mout.gmx.net ([212.227.15.19]:49598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDVNk-0007Lt-Ud for 27047-done@debbugs.gnu.org; Wed, 24 May 2017 08:27:17 -0400 Received: from [192.168.1.100] ([46.125.250.98]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MBnSJ-1d3qTi1y59-00Ajye; Wed, 24 May 2017 14:27:09 +0200 Message-ID: <59257C14.1050409@gmx.at> Date: Wed, 24 May 2017 14:27:00 +0200 From: martin rudalics MIME-Version: 1.0 References: <87d1azffik.fsf@rosalinde> <592524EF.2040805@gmx.at> <87wp96qyaz.fsf@rosalinde> In-Reply-To: <87wp96qyaz.fsf@rosalinde> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:N/s1LE+VFVc0RjipPg9N7+zQyGeHaRILM0RiinqWMm3th+/ad6v 8qn8P8y9CWfW2WS8sUGdO1M3ji2VduMcL3ubidwc4VoPG3fby9Lt2t1OArWnDmz/L+/vn5S j9iwHgkGJbvtYVzmAgmHCckDMQlAWy7rIevX/fqS4t4K05nQGkIt0YLuyO4Db192V4Vs4TK g+Ki1ETfihU6sMEbKt8Rg== X-UI-Out-Filterresults: notjunk:1;V01:K0:LoIM2Em51uo=:+upp6MO8cURb0+tjgB4++X D/Yh9/AkMy65Sj6VitovHOV2MReSq4mr+stUtFFjsbWuhSMsijI5kv3qmAkWxPfGA8Yzed8FQ 3w1YT0wB2v75jOM3tOHZVmyTrbz1iCUuxWrixpKOtKGnP70FDp/nJwcidRpk4Ivzz7aVWvu1J L66WRLZ67foRCME6d5mmwTuBZ7NwLE3ehNeNKB9QnDh0GXxLwW1fBvWgzrr8q/8EOCGdQ0nCl hpVldBHCEr2+gSLi172NWSDxWmKun5x38PibQysnnw2//PBNFw96xDim+rABNc12Q5DRSHheQ w7KwEgnvuJAlS9ZNXlu9BnpVFSs9ZDoQijlqXbaMF3/GS4qldIDRAUD+5oAPJpuH1/XAUMRaw 0HBiV5QOUgRMitN9TZsZ/1abfX+MvwsHJVZ3i+gX1BicMHDSbCloKYvvUeS9QjUkHV8v7tGZu YickbMbViK0AStxJOiOB/gNkCcoR40FG8O7rajS5eHo88xYMTA05FUH4hdG1Xa7PDek1rYNCV nGZnpBaYWmy54AZiA8TdFC79AqHqWcafWQz8qxG0A7PuMZ08B4ikQolwbTtvs/ArqRcwi68hF q+ycQkNPl1JQb/AYYiXJxsm2aRN7aqGcrsseA2RjLkMDZ9oR1TdMYuHsd/iboamZ7P274IIe8 2rRxgOiW3pF4+pqHY/pTx3bNHhshaDf3ZpkE31j1sUg3TbQzkDBtxKMi/aCePDIRH5tcD+D4f lG5mk76Q4SZ5EjIl/yg8wrZDroThaxLRXgT+CdgwHjFpVbPqd1RlizQWYpzsvtAXuNtvCe2fH VC4SCsx35C0W4QCE1G+oNAJ6yZ1gw== X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) > Done, as commit 08f00c01d6 and closing the bug. (The commit also > removed the two functions that were no longer used as a result of the > change, which the patch I posted had overlooked.) Thanks again, martin